{quote} are you sure?nevermind, then i deleted my post because not usefull .. it's your rule
{image} {image} {image}
I want to test this one please ganztrade
I will code your EAs and Indicators for no charge
- #41,763
- Nov 24, 2020 12:48am Nov 24, 2020 12:48am
- Joined Nov 2015 | Status: Trader | 2,525 Posts
Practice makes a person perfect
{quote} I want to test this one please ganztrade
Hi ganztrade,
This is what I was meaning yesterday with where I want my fib levels on the screen, on the right hand side.
See attached indicator where it prints its levels as an example.
This indicator works off ADR , I dont want that, want pure Fib levels of a price level , and I want to anchor and leave it where I want it.
If you can get this one to do that, also fine.
If you have a way to make the BoxBcBox levels also print only on right side...will be awesome !
But fibs...PLEASE
Anyone here on the forum maybe have a quarters line indicator ( 00, 25, 50, 100) , with change able line features?
Searching my ass off, cant find something so simple...lol
( maybe im just blind...lol)
Kind Regards
- #41,766
- Nov 24, 2020 4:50am Nov 24, 2020 4:50am
- Joined Nov 2018 | Status: Trader | 1,051 Posts
{quote} Hi ganztrade, This is what I was meaning yesterday with where I want my fib levels on the screen, on the right hand side. See attached indicator where it prints its levels as an example. This indicator works off ADR , I dont want that, want pure Fib levels of a price level , and I want to anchor and leave it where I want it. If you can get this one to do that, also fine. If you have a way to make the BoxBcBox levels also print only on right side...will be awesome ! But fibs...PLEASE Anyone here on the forum maybe have a quarters line indicator...
Everybody is trying to get something around this indicator
- #41,767
- Nov 24, 2020 7:43am Nov 24, 2020 7:43am
- Joined Oct 2010 | Status: Trader | 21,478 Posts
Intraday only.
- #41,769
- Nov 24, 2020 8:40am Nov 24, 2020 8:40am
- Joined Oct 2010 | Status: Trader | 21,478 Posts
Intraday only.
- #41,771
- Nov 24, 2020 8:54am Nov 24, 2020 8:54am
- Joined Jun 2012 | Status: Trader , Analyst and Mentor | 5,884 Posts
Say something meaningful or Silence!!
Hello all, I am trying to combine RSI and Bollinger Bands within an EA but I seem to be running into a weird problem. When I combine the default RSI with Bollinger Bands using Previous Indicator's Data or within an indicator (see attached) , I obtain the correct values.
However, when I copy the RSI values into a static array with 100 elements, I get totally different results for the Bollinger Bands.
So for instance when I try to access the RSI/BB values of the previous candle, the output is way off.
Evidently apart from the RSI, all other values are completely wrong. I am hoping someone can help me figure out what the problem is. I have tried adjusting the size of the arrays but that does not seem to work although the values do vary slightly. I also tried ArraySetAsSeries() but ran into a wall probably because I am not entirely sure whether it is applicable here. I find this to be a rather peculiar problem working with arrays. Is anyone in a position to offer some needed guidance?
However, when I copy the RSI values into a static array with 100 elements, I get totally different results for the Bollinger Bands.
Inserted Code
double rsi[100];
double rsi_bb_main[100];
double rsi_bb_upper[100];
double rsi_bb_lower[100];
//+------------------------------------------------------------------+
void Rsi_bb()
//+------------------------------------------------------------------+
{
int counted_bars=IndicatorCounted();
if(counted_bars<0) return;
if(counted_bars>0) counted_bars--;
int limit=MathMin(100-counted_bars,100-1);
for(int i=limit; i>=0; i--) rsi[i]=iRSI(NULL,0,14,PRICE_CLOSE,i);
for(int i=limit; i>=0; i--)
{
rsi_bb_main[i] = iBandsOnArray(rsi,0,14,2,0,MODE_MAIN,i);
rsi_bb_upper[i] = iBandsOnArray(rsi,0,14,2,0,MODE_UPPER,i);
rsi_bb_lower[i] = iBandsOnArray(rsi,0,14,2,0,MODE_LOWER,i);
}
return;
} So for instance when I try to access the RSI/BB values of the previous candle, the output is way off.
Inserted Code
Rsi_bb(); //<---- function call Comment( "RSI: "+DoubleToStr(rsi[1],4)+"\n"+ "UPPER: "+DoubleToStr(rsi_bb_upper[1],4)+"\n"+ "LOWER: "+DoubleToStr(rsi_bb_lower[1],4)+"\n"+ "MAIN: "+DoubleToStr(rsi_bb_main[1],4)+"\n" );
Evidently apart from the RSI, all other values are completely wrong. I am hoping someone can help me figure out what the problem is. I have tried adjusting the size of the arrays but that does not seem to work although the values do vary slightly. I also tried ArraySetAsSeries() but ran into a wall probably because I am not entirely sure whether it is applicable here. I find this to be a rather peculiar problem working with arrays. Is anyone in a position to offer some needed guidance?
- #41,773
- Nov 24, 2020 10:24am Nov 24, 2020 10:24am
- Joined Jun 2012 | Status: Trader , Analyst and Mentor | 5,884 Posts
Say something meaningful or Silence!!
- #41,775
- Nov 24, 2020 12:14pm Nov 24, 2020 12:14pm
Alright, so quick update to the question I had posted earlier.
For anyone who'd taken an interest, it turns out that ArraySetAsSeries() is actually quite important for obtaining the correct values. MQL4 documentation is not quite clear on this and does not provide a replicable example when dealing with series/non-series arrays. In order to obtain the correct values, the RSI array has to be set as series before populating it with data. The correct code for the RSI/BB should therefore be:
So when you call the function, you now get the correct values.
I got this solution from the Orchard Forex YouTube channel which along with the JimDandy1958 channel I highly recommend especially for beginner and intermediate coders.
For anyone who'd taken an interest, it turns out that ArraySetAsSeries() is actually quite important for obtaining the correct values. MQL4 documentation is not quite clear on this and does not provide a replicable example when dealing with series/non-series arrays. In order to obtain the correct values, the RSI array has to be set as series before populating it with data. The correct code for the RSI/BB should therefore be:
Inserted Code
double rsi[100];
double rsi_bb_main[100];
double rsi_bb_upper[100];
double rsi_bb_lower[100];
//+------------------------------------------------------------------+
void Rsi_bb()
//+------------------------------------------------------------------+
{
ArraySetAsSeries(rsi,true);
int counted_bars=IndicatorCounted();
if(counted_bars<0) return;
if(counted_bars>0) counted_bars--;
int limit=MathMin(100-counted_bars,100-1);
for(int i=limit; i>=0; i--) rsi[i]=iRSI(NULL,0,14,PRICE_CLOSE,i);
for(int i=limit; i>=0; i--)
{
rsi_bb_main[i] = iBandsOnArray(rsi,0,14,2,0,MODE_MAIN,i);
rsi_bb_upper[i] = iBandsOnArray(rsi,0,14,2,0,MODE_UPPER,i);
rsi_bb_lower[i] = iBandsOnArray(rsi,0,14,2,0,MODE_LOWER,i);
}
return;
} So when you call the function, you now get the correct values.
I got this solution from the Orchard Forex YouTube channel which along with the JimDandy1958 channel I highly recommend especially for beginner and intermediate coders.
- #41,776
- Nov 24, 2020 12:17pm Nov 24, 2020 12:17pm
{quote} Trading is basically a psychology thing. Profitable trading has not much to do with applying a strategy or technique. I gather statistics to study patterns and devise in my own personal way methods that could help me fight fear and greed. Nothing to do with generation of signals or devising a profitable strategy. Trading will be conducted by a semi-automated EA. I am trying to devise an EA based on price action. by forward testing based on knowledge acquired by statistical indicators coded by Blue Rain and do visual backtesting by using...
Every trader has to find own way and tools in a journey that mostly requires struggling with with own self all the time, rather than try to find a holy grail.
Good Luck, Green Pips to you
Kind Regards,
Moti
- #41,777
- Nov 24, 2020 1:31pm Nov 24, 2020 1:31pm
- Joined Mar 2013 | Status: Trader | 2,466 Posts
Hello all, I am trying to combine RSI and Bollinger Bands within an EA but I seem to be running into a weird problem. When I combine the default RSI with Bollinger Bands using Previous Indicator's Data or within an indicator (see attached) , I obtain the correct values. {file}However, when I copy the RSI values into a static array with 100 elements, I get totally different results for the Bollinger Bands. double rsi[100]; double rsi_bb_main[100]; double rsi_bb_upper[100]; double rsi_bb_lower[100]; //+------------------------------------------------------------------+...
Dont know still you needs some well coded RSI BB,here is Mladen's and Mrtools tweaked toy
some usual 4 basic averaging methods for bb
20 prices for rsi
full alerting package
full arrowing package
line or dots for rsi option (bar to bar dots)
- #41,778
- Nov 24, 2020 1:41pm Nov 24, 2020 1:41pm
- Joined Sep 2019 | Status: Trader | 1,207 Posts
{quote} Dear BlueRain (and Lucky1359) Would it be complicated to put the label of the day of the week left to the date ? In any case thanks for that interesting indi. Best
Anyway, I added option so it is just avail if needed.
input bool ShowTimeColume = false; //Show Timeformat for Candle Index
input bool Prefix_Weekdays_to_Time = false;
if first is true, it will show time, if 2nd is also true, it will show Weekdays.
- #41,780
- Nov 24, 2020 2:35pm Nov 24, 2020 2:35pm
{quote} I want to test this one please ganztrade
I've been busy, my big account maybe Blow next days 
Busy on hedging 
Margin Call again and again...