Close Only Unprofitable positions

int total_nb_orders = OrdersTotal();

for(int b=OrdersTotal();b>-1;b--)

for(int b=total_nb_orders;b>-1;b--)

if (DayOfWeek() == 5 && Hour() == 23 && Minute() < 2 && OrdersTotal() > 0 && OrderType() == OP_BUY)

OrderSelect(0,SELECT_BY_POS,MODE_TRADES);

[font=fixedsys]// buy orders
for(int b=OrdersTotal();b>-1;b--)
{
   if(OrderSelect(b,SELECT_BY_POS,MODE_TRADES)==true)
      if(OrderMagicNumber()==MagicNumber                               // Condition of Magic Number[/font]
[font=fixedsys]      && OrderProfit()<0                                                                 // Condition of profit (negative only)[/font]
[font=fixedsys]      && OrderSymbol()==Symbol()                                              // Condition of Symbol (only the one of the chart)
      && DayOfWeek() == 5 && Hour() == 23 && Minute() < 2 // Condition of the time of the closure[/font]
[font=fixedsys]      && OrderType() == OP_BUY)                                               // Condition of Symbol (only the Buys)
      {
          OrderClose(OrderTicket(),OrderLots( ),Bid,5,Green);[/font]
[font=fixedsys]      }
}[/font]

void CloseFridayCheck(int close_attempts,
                      uint close_delay,
                      int magic,
                      int slippage,
                      bool refresh_required,
                      bool &ea_trading_busy){
//Master Check
if(IsConnected()&&IsTradeAllowed()&&!IsTradeContextBusy()&&!ea_trading_busy)
{
//make our custom context busy its near certain a tick will strike before we complete our operations
ea_trading_busy=true;
//Loop to orders if the close time has been breached 
if(DayOfWeek()==5&&Hour()==23&&Minute()<2)
{
//Loop to orders 
  int ords=OrdersTotal()-1; 
  for(int o=ords;o>=0;o--)
  {
  bool selected=OrderSelect(o,SELECT_BY_POS,MODE_TRADES);
  if(selected)
    {
    if(OrderMagicNumber()==magic&&OrderProfit()<0&&OrderSymbol()==Symbol())
      {
      //temp stuff 
      double lots=OrderLots();int type=OrderType();int ticket=OrderTicket();int atts=0;bool closed=false;double price=0;bool rates=true;color clr=clrAliceBlue;
      //close attempts
        while(!closed&&atts<close_attempts)
        {
        //increase attempts count
          atts++;
        //try again
          //refresh rates 
            if(refresh_required){rates=RefreshRates();}
            if(rates)
              {
              price=Bid;
              clr=clrDarkBlue;
              if(type==OP_SELL){price=Ask;clr=clrDarkRed;}
              closed=OrderClose(ticket,lots,price,slippage,clr);
              }
        //if it closed and theres more trades down the line ,delay 
          if(closed&&o>0){Sleep(close_delay);}
        //if it failed and we have more attempts left ,delay
          if(!closed&&atts<=close_attempts){Sleep(close_delay);}
        }
      //close attempts ends here 
      }
    }
  }
//Loop to orders ends here 
}
//Loop to orders if the close time has been breached ends here 
//release our custom context 
ea_trading_busy=false;
}
//master check ends here 
}

Quoting FXponential

Disliked

Ah sorry, I didn't grasp the fact that you were bothered by profitable ones. I thought you had issues because I read that you didn't have all your unprofitable trades closed. In this case, I wonder whether your second following line is the cause of your issues : OrderSelect(0,SELECT_BY_POS,MODE_TRADES);. You should use the same variable as in your for loop (b for the Buys and s for the Sells)... The strange stuff is if your Anyway, to make it shorter, I would write your code like this : // buy orders for(int b=OrdersTotal();b>-1;b--) { if(OrderSelect(b,SELECT_BY_POS,MODE_TRADES)==true)...

Ignored

Quoting LoRio

Disliked

Try this : void CloseFridayCheck(int close_attempts, uint close_delay, int magic, int slippage, bool refresh_required, bool &ea_trading_busy){ //Master Check if(IsConnected()&&IsTradeAllowed()&&!IsTradeContextBusy()&&!ea_trading_busy) { //make our custom context busy its near certain a tick will strike before we complete our operations ea_trading_busy=true; //Loop to orders if the close time has been breached if(DayOfWeek()==5&&Hour()==23&&Minute()<2) { //Loop to orders int ords=OrdersTotal()-1; for(int o=ords;o>=0;o--) { bool selected=OrderSelect(o,SELECT_BY_POS,MODE_TRADES);...

Ignored