I will code your EAs and Indicators for no charge

Hi everyone,
I spent 3 weeks to create a custom indicator but clearly Im not good enough, hoping someone can help.
The prupose of this simply indicator is to group RS like we draw RS in chart manaully base on multiple top or bottom. Im hoping to use this indicator to display most recent RS for my scapling EA later on. Most fractal RS indicator only display 2 RS level for each time frame. Mine is to display all combined level(most importantly in M15 where my EA will run).
My indicator take 3 extern: "Timeframe", "number of display level on chart" and "min distance between each level".
All i need to code is to group, remove fractal point within min distance and then display the remaining fractal point level.
The first version(MainRS_AddOn2.mq4) i created do exactly what i want, however i use stupid method by drawing object and keep modify object, the indicator run extremely slow.
The second version(17_8_2020_RS_Indicator.mq4) store all level in buffer which run a lot faster, but i got issues which im not able fix.
----i believe i have logical error in storing new fractal level, which some display level didnt met the min distance requirement and got more duplicate level when run in tester.
https://c.mql5.com/3/329/4418339092467__1.png
left side is 17_8_2020_RS_Indicator.mq4, which have duplicated level.
https://c.mql5.com/3/329/3446411664519__1.png
Above is duplicate level inside tester.
//--------------------------------------------------------------------------------------------
if(modify == false)// store new level when display level limit have no more room
{
if(RSMode[limit]==1)
{
int index = ArrayMinimum(Display_level,WHOLE_ARRAY,0);
Display_Mode[index]=RSMode[limit] ;
Display_level[index]=RSBuffer1[limit];
}
if(RSMode[limit]==2)
{
int index = ArrayMaximum(Display_level,WHOLE_ARRAY,0);
Display_Mode[index]=RSMode[limit] ;
Display_level[index]=RSBuffer1[limit];
}

modify =true;

}
//---------------------------------------------------------------------------------------------------------------------


Im thinking the above code may cause the logical error. But nobody can tell unless they willing to spend time to look into whole file.
Hoping anyone can help/teach or improve.
Greatly appreciated. Below is the complete code, you are welcome to copy and paste or download the attached file.
Many thanks.

//+------------------------------------------------------------------+
//| 17_8_2020_RS_Indicator.mq4 |
//| Copyright 2020, MetaQuotes Software Corp. |
//| https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2020, MetaQuotes Software Corp."
#property link "https://www.mql5.com"
#property version "1.00"
#property description "Indicator to show Grouped Fractal Support and Resisitance Level"
#property strict
#property indicator_chart_window
#property indicator_buffers 2
#define Confirm_Level 3
#define Up_Fractal 1
#define Down_Fractal 2
#define Combined_Up 4
#define Combined_Down 5

enum timeframe_display_option
{
Current = 0,
PeriodM5 =5,
PeriodM15 =15,
PeriodM30 =30,
PeriodH1 =60,
PeriodH4 =240,
PeriodD1 =1440,
PeriodW1 =10080,
};
double RSBuffer1[];//hold new form fractal
double RSMode[];//hold new form fractal status
double Display_level[];// hold fractal display level
double Display_Mode[];// hold fractal display level status
extern int Show_Level_Limit =15; //Max Level to be display on chart
extern timeframe_display_option Level_of_TimeFrame=Current; //Option to display which timeframe level on chart
extern double sensitvity = 15; // Min distance between each RS level,input in pips values
int DisplayIndex = 0;

//++++ These are adjusted for 5 digit brokers.
int pips2points; // slippage 3 pips 3=points 30=points
double pips2dbl; // Stoploss 15 pips 0.0015 0.00150
int Digitspips; // DoubleToStr(dbl/pips2dbl, Digits.pips)
string indId ="SR_"; // string to name object on chart for delete and create object
double fractal; // to store fractal point value
bool modify = false; // to indicate a existing level on chart being modify or not
double status;// status of display level, use to reduce and combine level within min distance
color mark = clrRed;
//--------------------------------------------------
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int OnInit()
{

if (Digits % 2 == 1)
{ // DE30=1/JPY=3/EURUSD=5 forum.mql4.com/43064#515262
pips2dbl = Point*10;
pips2points = 10;
Digitspips = 1;
}
else
{ pips2dbl = Point;
pips2points = 1;
Digitspips = 0;
}
SetIndexBuffer(0, RSBuffer1);
SetIndexStyle(0,DRAW_ARROW);
SetIndexArrow(0,251); //buffer 0 draw line not symbol
SetIndexEmptyValue(0,0.0);
SetIndexBuffer(1, RSMode);
SetIndexStyle(1,DRAW_NONE);
SetIndexArrow(1,251); //buffer 0 draw line not symbol
SetIndexEmptyValue(1,0.0);
sensitvity = sensitvity * pips2dbl;// min distance of each display level/fractal point
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
DeleteAllObjects();
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
int counted_bars=IndicatorCounted();
if(counted_bars > 0) //---- the last calculated bar will be recalculated
counted_bars--;
int limit = Bars - counted_bars-1;
//-------------------------------------------------------------------------------------------------
//---- store fractal point to array
//-------------------------------------------------------------------------------------------------
while(limit>0)
{
fractal = iFractals(NULL, Level_of_TimeFrame, MODE_UPPER, limit);
if(fractal != 0)
{
RSBuffer1[limit]= fractal;
RSMode[limit]= Up_Fractal;
}
fractal = iFractals(NULL, Level_of_TimeFrame, MODE_LOWER, limit);
if(fractal != 0)
{
RSBuffer1[limit]= fractal;
RSMode[limit]= Down_Fractal;
}
//-----------------------------------------------------------------------------------------------------------------------------------------------
//below status for fractal point reduction
//Confirm_Level 3
//Up_Fractal 1
//Down_Fractal 2
//Combined_Up 4
//Combined_Down 5
//upper fractal point with another upper fractal point == combined up
//lower fractal point with another lower fractal point == combine down
//opposite fractal merge == confirm level (up & down || up & combine down || up && confirm || down & up || down & combine up ||down && confirm)
//--------------------------------------------------------------------------------------------------------------------------------------------------
ArrayResize(Display_level,Show_Level_Limit+1);
ArrayResize(Display_Mode,Show_Level_Limit+1);
if( RSBuffer1[limit]!=0)
{
for (int i=Show_Level_Limit-1; i>=0; i--)
{
double diff = MathAbs(RSBuffer1[limit]-Display_level[i]);// calculate min distance between level
modify = false;
if(diff<=sensitvity )//new fractal, check against Displaylevel
{
if(Display_Mode[i]==1&& RSMode[limit] == 1)//
{
Display_Mode[i]= 4;// mode up & up = combine up
if(RSBuffer1[limit]<Display_level[i])
Display_level[i]=Display_level[i];

Comment( " Up & Up== " + Display_level[i]+ "Display_Mode = " +Display_Mode[i]);
}
if(Display_Mode[i]==4 && RSMode[limit] == 1)
{
Display_Mode[i]= 4;// mode combine up & up = combine up
if(RSBuffer1[limit]<Display_level[i])
Display_level[i]=Display_level[i];
Comment( " Up & combine Up== "+ Display_level[i]+ "Display_Mode = " +Display_Mode[i]);
}
if(Display_Mode[i]==2 && RSMode[limit] == 2)
{
Display_Mode[i]= 5;// mode down & down = combine down
if(RSBuffer1[limit]>Display_level[i])
Display_level[i]=Display_level[i];
Comment( "down & down== "+ Display_level[i]+ "Display_Mode = " +Display_Mode[i]);
}
if(Display_Mode[i]==5 && RSMode[limit] == 2)
{
Display_Mode[i]= 5;// mode down & combine down = combine down
if(RSBuffer1[limit]>Display_level[i])
Display_level[i]=Display_level[i];
Comment( " Down & combine down== "+ Display_level[i]+ "Display_Mode = " +Display_Mode[i]);
}

}
if(diff<=sensitvity)
{

if((Display_Mode[i]==2 && RSMode[limit] == 1 )||(Display_Mode[i]==1 && RSMode[limit] == 2 ))
{
Display_Mode[i]= 3;// mode up & down & combine down = confirm
Display_level[i]=Display_level[i];
Comment( "Up & down or combine down == "+ Display_level[i]+ "Display_Mode = " +Display_Mode[i]);
modify = true;
break;
}
if( (Display_Mode[i]==3 || Display_Mode[i]==5))
{
Display_Mode[i]= 3;// mode up & confirm level = confirm
Display_level[i]=Display_level[i];
Comment( "Up & confirm level== "+ Display_level[i]+ "Display_Mode = " +Display_Mode[i]);
modify = true;
break;
}

if( Display_Mode[i]==3 || Display_Mode[i]==4)
{
Display_Mode[i]= 3;// mode down & confirm level = confirm
Display_level[i]=Display_level[i];
Comment( "Down & confirm level== "+ Display_level[i]+ "Display_Mode = " +Display_Mode[i]);
modify = true;
break;
}

}

}//end of modify existing level for loop

if(modify == false)// store disply level untill reacah show level limit
{
for (int a=0; a<Show_Level_Limit-1; a++)
{
if (Display_Mode[a]==0)
{
Display_Mode[a]=RSMode[limit];
Display_level[a] = RSBuffer1[limit];

modify =true;
break;
}
a++;
}

if(modify == false)// store new level when display level limit have no more room
{
if(RSMode[limit]==1)
{
int index = ArrayMinimum(Display_level,WHOLE_ARRAY,0);
Display_Mode[index]=RSMode[limit] ;
Display_level[index]=RSBuffer1[limit];
}
if(RSMode[limit]==2)
{
int index = ArrayMaximum(Display_level,WHOLE_ARRAY,0);
Display_Mode[index]=RSMode[limit] ;
Display_level[index]=RSBuffer1[limit];
}

modify =true;

}
}
}
limit--;

}
DeleteAllObjects();

int uplevel=1;
int downlevel=1;
ArraySort(Display_level,WHOLE_ARRAY,0,MODE_ASCEND);
DisplayIndex = 0;
for(int a=0;a<ArraySize(Display_level)-1; a++)
{
if (Display_level[a]<Bid && Display_level[a+1]>Bid)
DisplayIndex =a+1;
}
for (int c =DisplayIndex ; c<=Show_Level_Limit; c++)
{
HLine("SR_RES"+uplevel+ " # " + c, Display_level[c],mark);
uplevel++;
}
for (int c =DisplayIndex-1 ; c>0; c--)
{
HLine("SR_SUP"+downlevel+ " # " + c, Display_level[c],mark);
downlevel++;
}



return(0);
}
void HLine(string name, double P0, color clr)
{
#define WINDOW_MAIN 0
/**/ if (ObjectMove( name, 0, Time[0], P0 )){}
else if(!ObjectCreate( name, OBJ_HLINE, WINDOW_MAIN, Time[0], P0 ))
Alert("ObjectCreate(",name,",HLINE) failed: ", GetLastError() );
if (!ObjectSet(name, OBJPROP_COLOR, clr )) // Allow color change
Alert("ObjectSet(", name, ",Color) [1] failed: ", GetLastError() );
if (!ObjectSetText(name, PriceToStr(P0), 10))
Alert("ObjectSetText(",name,") [1] failed: ", GetLastError());
}
void DeleteAllObjects()
{
// Delete all objects created by the indicator
for (int i = ObjectsTotal() - 1; i >= 0; i--)
{
string name = ObjectName(i);

if (StringSubstr(name, 0, StringLen(indId)) == indId)
ObjectDelete(name);
}
}

string PriceToStr(double p)
{
string pFrc = DoubleToStr(p, Digits);
if(Digitspips==0)
return(pFrc);
string pPip = DoubleToStr(p, Digits-1);
if (pPip+"0" == pFrc)
return(pPip);
return(pFrc);
}
//---------------------------------------------------------------------------------------------
double Price(double Old, double New, int result)//1 return larger value, 2 return smaller value
{
double value=0;
if(result==1)
value=MathMax(Old,New);
if(result==2)
value=MathMin(Old,New);
return(value);
}
//---------------------------------------------------------------------------------------------

jeanlouie ....
I really like the ### Auto Pivot2button 1.03 AW1 indicator, but there are some additional features that I need, namely:

a. Levels R and S only up to 3 levels, what I want is 4 Levels.
b. There is no Middle Level on this indicator.

Is jeanlouie willing to help me add those two things to my indicator?
Before that, I thank you very much

ServerMoney

Additional:
I also attach other Pivot indicators for your reference.

[quote = jeanlouie; 13119682] {quote} Amplie n tire uma foto dos valores em torno da mudança do oscilador. Também presumindo que seja a primeira subjanela. {arquivo} [/ citação]
Hello friends! If possible, how would you transform this ON NEW BAR Indicator into an INTRABAR Indicator?

Hi, indicators are not able to place trades. What you are after is a script. Have a search for "pending script" or a mix of these terms: Pending, mt4, script, buy, sell, multiple, grid, etc. You will find it using these search terms

Shoot, I used the indicator for something else and didn't change it all back. This is for tradeonix, do the same thing and get a pic of this, try to get 2 signals in 1 pic too, you can make the font bigger and easier to read from a pic if it still fits.

Personally I don't do ea's, but good luck.

Bro I hope Understand your purpose given i do not know English well, Do i must to check the indicator signal? I mean I must to use it now in chart for test or just you want see the numbers?

Anyone here can help with a dashboard?

show for all timeframes m1 m5 m15 m30 H1 H4 d1 wk monthly

if above 5ema and 10ema show green box
if below both ema show red
If in between orange

Symbols to Use this for can be customised

thanks

Good Day,

1...On the smQuarter Lines Indicator, is it possible to add an option so it is possible to input own colour options ?( that blue and pink clashes with everything).

2...On same indie, the entry field SUBLEVELS, that is standard 25, will it be possible to make it so i can enter the half of 25, ( 12,5) ? at this stage I can only enter 12 or 13, 12,5 would be PERFECT.

3...General Questions:
a...In a situation where you might have two indies and their colours overlay, is there a way that the colours do not mix, for example indie last installed has the 'power to override" all other colours?

b...On MT4, grid, any chance one can get rid of the vertical gridlines and only keep tha horisontal lines ?

Thanx in advance for the brainiacs that wana get onto this !!!!

hi mate would you like to consider another request ,it will be great if draw red -green support-resistance based on nsnd bar i mean just below and above candle/bar because most of the time price test that level . on the other hand for valid support-resistance(horizontal line respect .thanks in advance

Good Day,

On the attached Quarter Theory Indicator , will it be possible to :

1...The lime green line does not want to change colour, can that be fixed?

2...Will it be possible to add extra " half way lines" ?...for example 1.32500 and the next quarter point is 1.32750, I you could add the midpoint, 1.32625 ?

I notice the Dealers / MMs like to be sneaky and have certain times the price just turn around there...

Thank you in advance for the brainiacs here

Yeah I need to see the numbers to see what the indicator is doing because I can't load it. Pic was good. This will use completed candles.

controversial man...
great mathematician and even better saleman for sure.... his COG is totally useless... it repaint everything.
try it you'll see. i'm not here to talk about the man but only of is indicator.
here in this thread we talk only about, coding,EA and indicator. thank you

My remark leans more to ironie
I knew problem regarding his indicators or Belkhayate's system, and wonder too how he has come that far

Hi Here2there

If you read a second time my comment, I said I took the simplest description
ND is an up bar with volume lower than the prior two bars
NS is an down bar with volume lower than the prior two bars

For the explanation it calculates on the last and current bar which means the start of the period all the bars have a lower volume than the 2 previous bars so logically during all the candles are subject to change the status.
NSND arrows will display all the candle candles matching the 2 conditions above
NSND arrows 50 % close will display only the candle the are closing between 25 & 75 % of the candle

Added the corresponding dashboard -

Please check if it works correctly - thank you

PS I would be grateful if any other coder have a look at my requests posted recently.

Hi zeroegotrader,

As you do not give more specific rules , the following dashboard gives the signals for for the current candle for each TF , it also means that when price is touching the ema's the status will change accordingly, it doesn't mean it repaint after the fact.

As always please check if it actually perform you as you expect.

Cheers

I don't think it is useful as the level would remain visible for the length of the selected TF, I mean if a ND is detected on H1 the dashboard would only display the signal for the following hour and then the status change so the levels would disappear.
It would also be to complex for me to add-up a section to auto-detect the loaded pair and TF

Here is a small script that allows you to drop on the chart a line starting at the point you want. Same function as the trend line button in the draw menu, but you can create several script with different line style etc.. to fit your needs.

Hello friends! If possible, how would you transform this ON NEW BAR Indicator into an INTRABAR Indicator? help me friend

Thank you, will check it out