Wick high average

Quoting hibra68

Disliked

Hi all, due to coronavirus I'm staying home like everyone else. So I decided to learn a bit of Mt4 coding. For my first script I decided to create a function that gets the average value of the last 14 bars. I was able to get the function working. However it doesn't round the numbers. I tried using Mathround command but than it returns 0.00. Can someone help fix this? Now to sum up the codes figures out first if its a bearish or bullish closing candle than figures out the high wick of that candle accordingly. Than it sums up all the highwicks than...

Ignored

#property copyright "halil"
#property strict
#define lookback 14
void OnStart(){
   Alert("");
   double sumHi=0,sumLo=0;
   for(int i=lookback+1;i>0;i--){
      if(Open[i]>Close[i]){
         sumHi+=High[i]-Open[i];
         sumLo+=Close[i]-Low[i];
         }
      if(Open[i]<Close[i]){
         sumHi+=High[i]-Close[i];
         sumLo+=Open[i]-Low[i];
         }
      }
   sumHi/=lookback;
   sumLo/=lookback;
   Alert("Upper Wick Avg:"+DoubleToStr(sumHi,2)+" | Lower Wick Avg: "+DoubleToStr(sumLo,2));
   }

Quoting Beerrun

Disliked

{quote} Mathround is used for integers, it will return the rounding closest to a whole number. So round(0.4) -> 0.0, round(1.6) -> 2, etc. If you want to use round to trim your decimals then you have to multiply your variable by 10^x, x being the decimals you want to keep, then round and then multiply by 10^-x. It looks like this: foo=round(foo*100)*0.01 #property copyright "halil" #property strict #define lookback 14 void OnStart(){ Alert(""); double sumHi=0,sumLo=0; for(int i=lookback+1;i>0;i--){ if(Open>Close){ sumHi+=High-Open; sumLo+=Close-Low;...

Ignored

Quoting Beerrun

Disliked

{quote} Mathround is used for integers, it will return the rounding closest to a whole number. So round(0.4) -> 0.0, round(1.6) -> 2, etc. If you want to use round to trim your decimals then you have to multiply your variable by 10^x, x being the decimals you want to keep, then round and then multiply by 10^-x. It looks like this: foo=round(foo*100)*0.01 #property copyright "halil" #property strict #define lookback 14 void OnStart(){ Alert(""); double sumHi=0,sumLo=0; for(int i=lookback+1;i>0;i--){ if(Open>Close){ sumHi+=High-Open; sumLo+=Close-Low;...

Ignored

Quoting hibra68

Disliked

{quote} Hi Beerrun, Tnx for your help. Your code looks a lot cleaner than mine. But when I pasted your code and ran the script I got 0.00 and 0.00 for both sumhi and sumlo. I changed my own script to the below, where I used "NormalizeDouble" function and it worked. //+------------------------------------------------------------------+ //| test.mq4 | //| halil | //| https://www.mql5.com | //+------------------------------------------------------------------+ #property copyright "halil" #property link "https://www.mql5.com" #property version...

Ignored

Quoting hibra68

Disliked

For some reason it figures out how many digits the chart has

Ignored

Quoting Beerrun

Disliked

{quote} The original works on all pairs; it is not showing you what you intend. Perhaps read the documentation on DoubleToStr and other mql4 code so you understand what is happening with the code you are writing/using.

Ignored

Quoting hibra68

Disliked

{quote} My intention is to get for example: Eurusd and like pairs>>> eg.( .0030), (.0100)etc. Yen pairs >>>>>eg. (.03), (.10) etc. But when I ran your code I got the following. Eurusd >>>>(0.00) yen pairs>>>(0.05) so basically it gives me what I want for yen pairs but on other pairs I get only 2 decimals instead of 4 That's why I just changed the number to 4 and it worked for both pairs. But I still didn't get how it computes whether the forex pair is 5 digits or something else. Like you said I will look into the meaning of doubletostr function....

Ignored

Quoting hibra68

Disliked

Ok below are 2 codes for comparing the last closed bar's high wick with the last 14 bars(14 bars not counting the current bar and last closed bar) high wicks and prints the wick value. I did not go forward and compare it with the last closed bar and so forth until I figure out how to do this with loops. The first code I did it manually to see the logic so I only checked 3 bars not 14 bars. And I was able to get the highest wick from the 3 bars and print its value. The second code I used ArrayFill function to use loop to fill in the array. There...

Ignored

#property strict
#define lookback 14
void OnStart(){
   double sumHi=,largestWick=0;
   for(int i=lookback+1;i>0;i--){
      double wickHi=Open[i]>=Close[i]?High[i]-Open[i]:High[i]-Close[i];
      if(wickHi>largestWick)largestWick=wickHi;
      sumHi+=wickHi;
      }
   sumHi/=lookback;
   Alert("Upper Wick Avg: "+DoubleToStr(sumHi,_Digits)+" / Largest Wick: "+DoubleToStr(largestWick,_Digits));
   }

Quoting Beerrun

Disliked

{quote} Why are you placing individual values into an array if you are just going to fill the entire array with one value? (x14) Also calling it highestwick is a misnomer since it is not the highest but the largest. #property strict #define lookback 14 void OnStart(){ double sumHi=,largestWick=0; for(int i=lookback+1;i>0;i--){ double wickHi=Open>=Close?High-Open:High-Close; if(wickHi>largestWick)largestWick=wickHi; sumHi+=wickHi; } sumHi/=lookback; Alert("Upper Wick Avg: "+DoubleToStr(sumHi,_Digits)+" / Largest Wick: "+DoubleToStr(largestWick,_Digits));...

Ignored

Quoting hibra68

Disliked

{quote} Ok tnx for the input, I'm trying to get the highest/largest wick size(you are right it should be largest) between bar 2-14. And compare the largest wick in this array with bar 1(the last closed candle). And print out alert if bar 1's high wick is larger than any of the high wicks of the other bars. I ran your code , it prints out I think the average of the 14 bars and the largest of them. I did something on my own before I saw your code. It works , I think? +------------------------------------------ #property copyright "halil" #property...

Ignored

#property strict
void OnStart(){
   double largestHiWick=0;
   int largestIndex=0;
   for(int i=14;i>1;i--){
      double wickHi=Open[i]>=Close[i]?High[i]-Open[i]:High[i]-Close[i];
      if(wickHi>largestHiWick){
         largestHiWick=wickHi;
         largestIndex=i;
         }
      }
   Alert("Largest Hi Wick: "+DoubleToStr(largestHiWick,_Digits)+" / Candle Index: "+(string)largestIndex);
   double prevWickHi=Open[1]>=Close[1]?High[1]-Open[1]:High[1]-Close[1];
   if(prevWickHi>largestHiWick)Alert("Sell Signal");
   }

Quoting Beerrun

Disliked

{quote} Yes my apologies, I was under the premise the new code was in addition to the average code. You don't need to use ArrayResize after declaring the array, just declare it with a specific size: double wicks_array[14]; You can also remove the double variable highwicks and place values directly into the array: wicks_array=High-MathMax(Open,Close); Also in your for loop you start at 1, so your array is including the most recently closed candle, which might give you issue, and does not include candle 14. You said between 2-14, but do...

Ignored

Quoting hibra68

Disliked

{quote} Tnx, Im just processing both of your codes, I will chime in tomorrow. I learned about "?" operator. It eliminates the for loop. Great how it gives Boolean value . I'll learn to be more concise with my coding hopefully.

Ignored

Quoting Beerrun

Disliked

{quote} The ternary operator does not replace a for loop. It replaces if else statements when assigning a value to a variable. foo=this?bar:that?foobar:0; Is the same as if(this)foo=bar; else if(that)foo=foobar; else foo=0;

Ignored

Quoting hibra68

Disliked

{quote} I know this is not highwick script but I wanted to see what you think about this script. It determines whether the second bar is a valid pinbar or not. If the range is at least twice the body size condition 1 is true; If the body is located either on top third or bottom third of the range 2nd condition is true; If both conditions are true it alerts the pinbarvalid is true. I will ofcourse add other conditions later. +----------------------------------------------------------------------------------------------- //+------------------------------------------------------------------+...

Ignored

Quoting Beerrun

Disliked

{quote} It looks good. However one thing I notice is the “Open[2]&&“ in the 2nd condition. As it is now it is saying “if open[2] is true”. Testing shows that an if statement with any value besides 0 will still be accepted as true: if(-1), if(0.1), if(2) all pass as true if(0) is not passing So no reason to have it, but I think you intended something else, like “if open[2] and close[2] are greater than high[2]-range3rd”. In that case you would have to specify the open and close conditions separately: open[2]>high[2]-range3rd&&close[2]>high[2]-range3rd...

Ignored

Quoting hibra68

Disliked

{quote} Hi, Yes I intended to get the value of “if open[2] and close[2] are greater than high[2]-range3rd”. This is to check to see if the body is in the top 3rd. So if I write it as "Open[2]&&Close[2]>High[2]-range3rd" the program adds the open and close values than checks if its >high-range3rd? Because I thought when I used && it would check separately to see if both Open and Close are greater than the value High - 1/3 of the total range. Basically condition2 is true if either the body is in the top 3rd OR the bottom 3rd +-------------------------------------------------------------------------...

Ignored

Quoting Beerrun

Disliked

{quote} The && (AND) and || (OR) separate conditions. The conditions inside have to evaluate to true based on whatever you put in there. So saying open&&close does not add them together, it is two separate conditions.

Ignored