#include <WinUser32.mqh>
#include <stdlib.mqh>
#define NL "\n"
#define up "Up"
#define down "Down"
#define ranging "Ranging"
#define none "None"
#define both "Both"
#define buy "Buy"
#define sell "Sell"
#define AllTrades 10 // Tells CloseAllTrades() to close/delete everything
#define million 1000000;
// *** Semafor status
#define nosemafor " No signal found on previous candle"
#define highsemafor " High signal found on previous candle"
#define lowsemafor " Low signal found on previous candle"
#define highsemafornow " High signal emerging on current candle"
#define lowsemafornow " Low signal emerging on current candle"
// *** Currency status
#define upaccelerating "Up, and accelerating"
#define updecelerating "Up, but slowing"
#define downaccelerating "Down, and accelerating"
#define downdecelerating "Down, but slowing"
// *** Pending trade price line
#define pendingpriceline "Pending price line"
// *** Hidden sl and tp lines. If used, the bot will close trades on a touch/break of these lines.
// *** Each line is named with its appropriate prefix and the ticket number of the relevant trade
#define TpPrefix "Tp"
#define SlPrefix "Sl"
// *** RSI TMA Slope constants
#define pinhigh "Pin high"
#define pinlow "Pin low"
#define pinnone "No pin"
// *** Slope constants
#define buyonly " Buy Only. "
#define sellonly " Sell Only. "
#define buyhold " Buy and hold. "
#define sellhold " Sell and hold. "
#define rising ": Angle is rising. "
#define falling ": Angle is falling. "
#define unchanged ": Angle is unchanged. "
// *** Error reporting
#define slm " stop loss modification failed with error "
#define tpm " take profit modification failed with error "
#define ocm " order close failed with error "
#define odm " order delete failed with error "
#define pcm " part close failed with error "
#define spm " shirt-protection close failed with error "
#define slim " stop loss insertion failed with error "
#define tpim " take profit insertion failed with error "
#define tpsl " take profit or stop loss insertion failed with error "
#define oop " pending order price modification failed with error "
//#################################################################################
enum enPrices
{
pr_close, // Close
pr_open, // Open
pr_high, // High
pr_low, // Low
pr_median, // Median
pr_typical, // Typical
pr_weighted // Weighted
};
/*
HOW TO USE THIS CODE
This code allows us to create auto-trading robots quickly and easily. Use it freely for your own trading. Distribute trading ea's that you create using it freely at in my forum or at FF. Do not use it in commercial ea's that you claim as your own work; I retain the copyright of this material.
The first thing you do is save the Generic ea using the name of your new EA. Don't forget to do this, or you will find yourself taking hours to find out where you downloaded the generic code.
Calls to other indicators go in void ReadIndicatorValues(). This function calls the sub-functions that contain the code that calls the indi's.
void CountOpenTrades() ascertains whether there is already
an open trade/trades and leaves the variable TicketNo set to the final trade in a sequence of trades.
start() contains calls to all the functions that manage open trades, check trading times etc.
void LookForTradingOpportunities() is the final function in start() before the feedback display.
void LookForTradingOpportunities() contains the trade-trigger code; simply adapt it to suit the trigger
you are using. IsTradingAllowed() is called from LookForTradingOpportunities(); it contains a variety of filters that might cancel trading - swap, balance etc.
The code that adapts the bot to x digit criminals is in void PFactor() and sets the global variable 'factor'. Usage is, for example, double stop = OrderOpenPrice() - (StopLoss / factor).
Stealth: In the Aurora thread at FF, we developed what I jokingly call Stealth Technology to hide some of our activities from the crims. Hidden take profit and stop loss are automatic features:
- sends a 'hard' sl/tp if required, then draws lines that represent the hidden stops. The lines have names
consisting of the SlPrefix/TpPrefix plus the trade ticket number.
- Breakeven, trailing jumping & candlestick trailing stops are operated by reference to the hidden sl line
The user turns off Stealth with a HiddenPips = 0 value in the input. The ea will close the trade when the Bid touches/passes either of the lines. At the time of
writing this - 5th October 2011 - Stealth has worked successfully but is still recent, so the odd bug may still crawl out of the woodwork.
Matt Kennel has provided the code for bool O_R_CheckForHistory(int ticket). Cheers Matt, You are a star.
Code for adding debugging Sleep
Alert("G");
int x = 0;
while (x == 0) Sleep(100);
Standard order loop code
for (int cc = OrdersTotal() - 1; cc >= 0; cc--)
{
if (!OrderSelect(cc, SELECT_BY_POS) ) continue;
if (OrderSymbol() != Symbol() ) continue;
if (OrderMagicNumber() != MagicNumber) continue;
}//for (int cc = OrdersTotal() - 1; cc >= 0; cc--)
Code from George, to detect the shift of an order open time
int shift = iBarShift(NULL,Period(),OrderOpenTime(), false);
To calculate what percentage a small number is of a larger one:
(Given amount Divided by Total amount) x100 = %
as in UpperWickPercentage = (UpperWick / CandleSize) * 100; where CandleSize is the size of the the candle and UpperWick the size of the top of the body to the High.
Example of iHighest and iLowest
double lastHigh = iHigh( symbolNames[i], PERIOD_H1, iHighest( symbolNames[i], PERIOD_H1, MODE_HIGH, 24, 1 ) );
double lastLow = iLow( symbolNames[i], PERIOD_H1, iLowest( symbolNames[i], PERIOD_H1, MODE_LOW, 24, 1 ) );
Full snippet to force closure of all open trades. Use whichever part is most appropriate.
if (ForceTradeClosure)
{
CloseAllTrades();
if (ForceTradeClosure)
{
CloseAllTrades();
if (ForceTradeClosure)
{
return;
}//if (ForceTradeClosure)
}//if (ForceTradeClosure)
}//if (ForceTradeClosure)
*/
extern string gen="----General inputs----";
/*
Note to coders about TradingTimeFrame. Be consistent in your calls to indicators etc and always use TradingTimeFrame i.e.
double v = iCustom(Symbol(), TradingTimeFrame, ....................)
This allows the user to change time frames without disturbing the ea. There is a line of code in OnInit(), just above the call
to DisplayUserFeedback() that forces the EA to wait until the open of a new TradingTimeFrame candle; you might want to comment
this out during your EA development.
*/
extern ENUM_TIMEFRAMES TradingTimeFrame = PERIOD_CURRENT; // Defaults to current chart
extern bool EveryTickMode = false;
extern double Lot = 0.01;
extern double RiskPercent = 0; // Set to zero to disable and use Lot
extern double LotsPerDollopOfCash = 0.01; // Over rides Lot. Zero input to cancel.
extern double SizeOfDollop = 1000;
extern bool UseBalance = false;
extern bool UseEquity = true;
extern int MaxTradesAllowed = 1; // For multi-trade EA's
extern bool StopTrading = false;
extern bool TradeLong = true;
extern bool TradeShort = true;
extern int TakeProfitPips = 100;
extern int StopLossPips = 100;
extern int MagicNumber = 0;
extern string TradeComment = "G";
extern bool IsGlobalPrimeOrECNCriminal = false;
extern double MaxSlippagePips = 5;
// *** We need more safety to combat the cretins at Crapperquotes managing to break Matt's OR code occasionally.
// *** EA will make no further attempt to trade for PostTradeAttemptWaitMinutes minutes, whether OR detects a receipt return or not.
extern int PostTradeAttemptWaitSeconds = 600; // Defaults to 10 minutes
datetime TimeToStartTrading = 0; // Re-start calling LookForTradingOpportunities() at this time.
double TakeProfit, StopLoss;
datetime OldBarsTime;
double dPriceFloor = 0, dPriceCeiling = 0; // Next x0 numbers
double PriceCeiling100 = 0, PriceFloor100 = 0; // Next 'big' numbers
string GvName="Under management flag"; // The name of the GV that tells the EA not to send trades whilst the manager is closing them.
string TradingTimeFrameDisplay="";
// *** For FIFO
int FifoTicket[]; // Array to store trade ticket numbers in FIFO mode, to cater for
// US citizens and to make iterating through the trade closure loop
// quicker.
// *** Variables for building a picture of the open position
// *** Market Buy trades
bool BuyOpen=false;
int MarketBuysCount=0;
double LatestBuyPrice=0, EarliestBuyPrice=0, HighestBuyPrice=0, LowestBuyPrice=0;
int BuyTicketNo=-1, HighestBuyTicketNo=-1, LowestBuyTicketNo=-1, LatestBuyTicketNo=-1, EarliestBuyTicketNo=-1;
double BuyPipsUpl=0;
double BuyCashUpl=0;
datetime LatestBuyTradeTime=0;
datetime EarliestBuyTradeTime=0;
// *** Market Sell trades
bool SellOpen=false;
int MarketSellsCount=0;
double LatestSellPrice=0, EarliestSellPrice=0, HighestSellPrice=0, LowestSellPrice=0;
int SellTicketNo=-1, HighestSellTicketNo=-1, LowestSellTicketNo=-1, LatestSellTicketNo=-1, EarliestSellTicketNo=-1;;
double SellPipsUpl=0;
double SellCashUpl=0;
datetime LatestSellTradeTime=0;
datetime EarliestSellTradeTime=0;
// *** BuyStop trades
bool BuyStopOpen=false;
int BuyStopsCount=0;
double LatestBuyStopPrice=0, EarliestBuyStopPrice=0, HighestBuyStopPrice=0, LowestBuyStopPrice=0;
int BuyStopTicketNo=-1, HighestBuyStopTicketNo=-1, LowestBuyStopTicketNo=-1, LatestBuyStopTicketNo=-1, EarliestBuyStopTicketNo=-1;;
datetime LatestBuyStopTradeTime=0;
datetime EarliestBuyStopTradeTime=0;
// *** BuyLimit trades
bool BuyLimitOpen=false;
int BuyLimitsCount=0;
double LatestBuyLimitPrice=0, EarliestBuyLimitPrice=0, HighestBuyLimitPrice=0, LowestBuyLimitPrice=0;
int BuyLimitTicketNo=-1, HighestBuyLimitTicketNo=-1, LowestBuyLimitTicketNo=-1, LatestBuyLimitTicketNo=-1, EarliestBuyLimitTicketNo=-1;;
datetime LatestBuyLimitTradeTime=0;
datetime EarliestBuyLimitTradeTime=0;
// *** SellStop trades
bool SellStopOpen=false;
int SellStopsCount=0;
double LatestSellStopPrice=0, EarliestSellStopPrice=0, HighestSellStopPrice=0, LowestSellStopPrice=0;
int SellStopTicketNo=-1, HighestSellStopTicketNo=-1, LowestSellStopTicketNo=-1, LatestSellStopTicketNo=-1, EarliestSellStopTicketNo=-1;;
datetime LatestSellStopTradeTime=0;
datetime EarliestSellStopTradeTime=0;
// *** SellLimit trades
bool SellLimitOpen=false;
int SellLimitsCount=0;
double LatestSellLimitPrice=0, EarliestSellLimitPrice=0, HighestSellLimitPrice=0, LowestSellLimitPrice=0;
int SellLimitTicketNo=-1, HighestSellLimitTicketNo=-1, LowestSellLimitTicketNo=-1, LatestSellLimitTicketNo=-1, EarliestSellLimitTicketNo=-1;;
datetime LatestSellLimitTradeTime=0;
datetime EarliestSellLimitTradeTime=0;
// *** Not related to specific order types
int TicketNo=-1,OpenTrades,OldOpenTrades;
// *** Variables to tell the ea that it has a trading signal
bool BuySignal=false, SellSignal=false;
// *** Variables to tell the ea that it has a trading closure signal
bool BuyCloseSignal=false, SellCloseSignal=false;
// *** Variables for storing market trade ticket numbers
datetime LatestTradeTime=0, EarliestTradeTime = 0; // More specific times are in each individual section
double PipsUpl; // For keeping track of the pips PipsUpl of multi-trade/hedged positions
double CashUpl; // For keeping track of the cash PipsUpl of multi-trade/hedged positions
// *** Variable for the hedging code to tell if there are tp's and sl's set
bool TpSet=false, SlSet=false;
//#########################################################################################################
// *** Hedging and the grid are linked. If using hedging and using the grid, then the ea
// *** will send grids in both directions when an initial trade trigger arises. If only using
// *** the grid, then only the grid in the direction of the initial trade will be sent.
extern string sep1 ="================================================================";
extern string hed ="---- Hedging ----";
extern bool UseHedgingWithGrid = true;
extern int HedgeProfitPips = 30; // Pips profit target at which to close a hedged position.
// Zero value to disable
extern int HedgeProfitCash = 30; // Cash profit target at which to close a hedged position.
//Zero value to disable
double HedgeProfit = 0;
//###################################################################################################
extern string sep1b="================================================================";
extern string gri="---- Grid inputs ----";
extern bool UseGrid = true;
extern int GridSize = 5; // x orders above market and x below.
extern int DistanceBetweenTradesPips = 0;
extern bool CloseOnOppositeSignal = true;
double DistanceBetweenTrades = 0;
int GridTradesTotal = 0; // Total of market, stop and limit trades
int PendingTradesTotal = 0; // Total of stop and limit trades
int MarketTradesTotal = 0; // Total of open market trades
bool GridSent = false; // true if CountOpenTrades finds a trade
bool Hedged = true; // Set to true if there are both market buys and sells open,
// to prevent closure on an opposite direction signal. Initialised
// as true to avoid closure first time around CountOpenTrades
//##############################################################################################################
extern string sep1c ="================================================================";
extern string atri ="---- ATR for grid trading inputs ----";
extern string grz ="-- Grid size --";
extern bool UseAtrForGrid = true;
extern ENUM_TIMEFRAMES GridAtrTimeFrame = PERIOD_H1;
extern int GridAtrPeriod = 20;
extern double GridAtrMultiplier = 1;
double GridAtrVal=0;
//#################################################################################################################
extern string sem ="---- 3 Semafor Inputs ----";
extern bool CloseTradesOnRelevantSemafor = true;
extern bool CloseImmediatelySemaforAppears = true;
extern bool ReplaceWinnersGrid = true; // Open a new grid in case the market resumes its move
extern bool DeleteAndReplaceLosersGrid = true; // Losing hedged trades will be a long way away, so delete
// and outstanding stop orders and replace them closer to the market.
double Period1 = 5;
double Period2 = 13;
extern double Period3 = 34;
string Dev_Step_1 = "1,3";
string Dev_Step_2 = "8,5";
string Dev_Step_3 = "13,8";
string SemStatus = "";
//##########################################################################################################
extern string sep1a ="================================================================";
extern string sfs ="----SafetyFeature----";
// *** Safety feature. Sometimes an unexpected concatenation of inputs choice and logic error can cause rapid opening-closing of trades. Use the next input
// *** in combination with TooClose() to abort the trade if the previous one closed within the time limit.
extern int MinMinutesBetweenTradeOpenClose = 1; //For spotting possible rogue trades
extern int MinMinutesBetweenTrades = 1; // Minimum time to pass after a trade closes, until the ea can open another.
bool SafetyViolation; // For chart display
bool RobotSuspended = false;
//##########################################################################################################
extern string sep2="================================================================";
// *** Hidden tp/sl inputs.
extern string hts="----Stealth stop loss and take profit inputs----";
extern int PipsHiddenFromCriminal = 0; // Added to the 'hard' sl and tp and used for closure calculations
double HiddenStopLoss, HiddenTakeProfit;
double HiddenPips = 0; // Added to the 'hard' sl and tp and used for closure calculations
//##########################################################################################################
extern string sep3="================================================================";
// *** Bob's H4 240 trend filter. Market above the ma = buy only; below ma = sell only
extern string mai="---- Moving average ----";
extern ENUM_TIMEFRAMES MaTF = PERIOD_CURRENT; // Defaults to current chart
extern int MaShift = 0;
extern int MaPeriod = 21; // Zero value to disable
extern ENUM_MA_METHOD MaMethod = MODE_EMA;
extern ENUM_APPLIED_PRICE MaAppliedPrice = PRICE_CLOSE;
double MaVal;
string MaTrend; ///up, down or none constants
//#########################################################################################################
extern string sep4 ="================================================================";
extern string slo ="----Slope inputs----";
extern int HtfTimeFrame = 0; //Zero to disable
extern double HtfBuyOnlyLevel = 0.4;
extern double HtfBuyHoldLevel = 0.8;
extern double HtfBuyCloseLevel = 0.3;
extern double HtfSellOnlyLevel = -0.4;
extern double HtfSellHoldLevel = -0.8;
extern double HtfSellCloseLevel = -0.3;
extern int LtfTimeFrame = 0; //Zero to disable
extern double LtfBuyOnlyLevel = 0.4;
extern double LtfBuyHoldLevel = 0.8;
extern double LtfBuyCloseLevel = 0.3;
extern double LtfSellOnlyLevel = -0.4;
extern double LtfSellHoldLevel = -0.8;
extern double LtfSellCloseLevel = -0.3;
double HtfSlopeVal, LtfSlopeVal, PrevHtfSlopeVal, PrevLtfSlopeVal;
string HtfSlopeTrend, LtfSlopeTrend, HtfSlopeAngle, LtfSlopeAngle;
//#####################################################################################################
extern string sep5 ="================================================================";
extern string CSS_Input ="----CCS inputs----";
extern bool UseCSS = false;
extern int maxBars = 100;
extern int CssTf = 0; // Defaults to current time frame
// extern bool ignoreFuture = true;
string CurrNames[8] = { "USD", "EUR", "GBP", "CHF", "JPY", "AUD", "CAD", "NZD" };
string Curr1, Curr2; // First and second currency in the pair
int CurrIndex1, CurrIndex2; // Index of the currencies that form the pair to point to the correct one in currencyNames
double CurrVal1[3], CurrVal2[3]; // Hold the values of the two currencies, alloing me to look back in time to see if the currency is rising or falling.
string CurrDirection1, CurrDirection2; // One of the Currency ststus constants
//######################################################################################################
extern string sep6 ="================================================================";
extern string rst ="----RSI-TMA Slope indi inputs----";
extern bool UseTmaRsi2 = false;
extern int TmaRsi2TF = 0; // Defaults to current tf
extern int PinHighLevel = 90; // Sell after a pin high
extern int PinLowLevel = 10; // Buy after a pin low
double RsiTmaVal[4];
string RsiPinStatus; // Will be one of the pin constants pinhigh, pinlow or pinnone
//######################################################################################################
extern string sep7="================================================================";
// *** CheckTradingTimes. Baluda has provided all the code for this. Mny thanks Paul; you are a star.
extern string trh = "----Trading hours----";
extern string tr1 = "tradingHours is a comma delimited list";
extern string tr1a = "of start and stop times.";
extern string tr2 = "Prefix start with '+', stop with '-'";
extern string tr2a = "Use 24H format, local time.";
extern string tr3 = "Example: '+07.00,-10.30,+14.15,-16.00'";
extern string tr3a = "Do not leave spaces";
extern string tr4 = "Blank input means 24 hour trading.";
extern string tradingHours = "";
double TradeTimeOn[];
double TradeTimeOff[];
// *** trading hours variables
int tradeHours[];
string tradingHoursDisplay; // tradingHours is reduced to "" on initTradingHours, so this variable saves it for screen display.
bool TradeTimeOk;
//#####################################################################################################################
extern string sep8 ="================================================================";
extern string bf ="----Trading balance filters----";
extern bool UseZeljko = false;
extern bool OnlyTradeCurrencyTwice = false;
bool CanTradeThisPair;
//#####################################################################################################
extern string sep9 ="================================================================";
extern string pts ="----Swap filter----";
extern bool CadPairsPositiveOnly = false;
extern bool AudPairsPositiveOnly = false;
extern bool NzdPairsPositiveOnly = false;
extern bool OnlyTradePositiveSwap = false;
double LongSwap, ShortSwap;
//#####################################################################################################
extern string sep10 ="================================================================";
extern string amc ="----Available Margin checks----";
extern string sco = "Scoobs";
extern bool UseScoobsMarginCheck = false;
extern string fk="ForexKiwi";
extern bool UseForexKiwi = false;
extern int FkMinimumMarginPercent = 1500;
bool EnoughMargin;
string MarginMessage;
//#####################################################################################################
extern string sep11 ="================================================================";
extern string asi ="----Average spread inputs----";
extern bool RunInSpreadDetectionMode = false;
extern int TicksToCount = 5; // The ticks to count whilst canculating the av spread
extern double MultiplierToDetectStopHunt = 10;
double AverageSpread = 0;
string SpreadGvName; // A GV will hold the calculated average spread
int CountedTicks = 0; // For status display whilst calculating the spread
double BiggestSpread = 0; // Holds a record of the widest spread since the EA was loaded
//######################################################################################################
extern string sep11a ="================================================================";
extern string ccs ="---- Chart snapshots ----";
extern bool TakeSnapshots = true; // Tells ea to take snaps when it opens and closes a trade
extern int PictureWidth = 800;
extern int PictureHeight = 600;
//######################################################################################################
extern string sep12 ="================================================================";
extern string ems ="----Email thingies----";
extern bool EmailTradeNotification = false;
extern bool SendAlertNotTrade = false;
extern bool AlertPush = false; // Enable to send push notification on alert
bool AlertSent; // To alert to a trade trigger without actually sending the trade
//#####################################################################################################
extern string sep13 ="================================================================";
extern string tmm ="----Trade management module----";
// *** Breakeven has to be enabled for JS and TS to work.
extern string BE = "Break even settings";
extern bool BreakEven = false;
extern int BreakEvenTargetPips = 10;
extern int BreakEvenTargetProfit = 5;
extern bool PartCloseEnabled = false;
extern double PartClosePercent = 50; // Percentage of the trade lots to close
double BreakEvenPips, BreakEvenProfit;
bool TradeHasPartClosed = false;
//##################################################################################################
extern string sep14 ="================================================================";
extern string JSL ="Jumping stop loss settings";
extern bool JumpingStop = false;
extern int JumpingStopTargetPips = 10;
extern bool AddBEP = true;
double JumpingStopPips;
//##################################################################################################
extern string sep15 ="================================================================";
extern string cts ="----Candlestick jumping stop----";
extern bool UseCandlestickTrailingStop = false;
extern int CstTimeFrame = 0; // Defaults to current chart
extern int CstTrailCandles = 1; // Defaults to previous candle
extern bool TrailMustLockInProfit = true;
int OldCstBars; // For candlestick ts
//##################################################################################################
extern string sep16 ="================================================================";
extern string TSL ="Trailing stop loss settings";
extern bool TrailingStop = false;
extern int TrailingStopTargetPips = 20;
double TrailingStopPips;
//###################################################################################################
extern string sep17 ="Indicator Settings================================================================";
extern int NMAPeriod = 40;
extern enPrices NMAPrice = pr_close;
extern int TEMAPeriod = 15;
extern int SmoothPeriod = 8;
extern bool SmoothUsingSSM = true;
extern bool Interpolate = true;
//############################################################################################################
// *** Enhanced screen feedback display code provided by Paul Batchelor (lifesys). Thanks Paul; this is fantastic.
extern string se52 ="================================================================";
extern string oad ="----Odds and ends----";
extern int ChartRefreshDelaySeconds = 3;
extern int DisplayGapSize = 30; // if using Comments
// *** added to make screen Text more readable
extern bool DisplayAsText = true; // replaces Comment() with OBJ_LABEL text
extern bool KeepTextOnTop = true; // Disable the chart in foreground CrapTx setting so the candles do not obscure the text
extern int DisplayX = 100;
extern int DisplayY = 0;
extern int fontSise = 10;
extern string fontName = "Arial";
extern color colour = Yellow;
extern double spacingtweek = 0.6; // adjustment to reform lines for different font size
int DisplayCount;
string Gap,ScreenMessage;
//##################################################################################################################################################################################### 
