Need help with 'array out of range'

int ThisBarTrade           =  0;
 
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- indicator buffers mapping
 
   //Each time the indi is reloaded (ie. switch between TFs, new apply, etc ...),
   //the current bar isn't checked for conditions.
   ThisBarTrade    = Time[0];
//---
   return(INIT_SUCCEEDED);
  }
  
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
{
   
return(0);
}
  
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
//---
      string pairs[];
      int length = getAvailableCurrencyPairs(pairs);
 
      if (Bars != ThisBarTrade ) 
      {
         ThisBarTrade = Bars;  // ensure only one trade opportunity per bar   
 
         //Loop through symbols
         for(int i=0; i < length; i++)
         {
            //Alert("Pair #", i+1, ": ", pairs[i]);
   
           // Get index         
           int current_bar_index       = iHighest(pairs[i], PERIOD_M5, MODE_HIGH, 1, 0);
           int previous_bar_index      = iHighest(pairs[i], PERIOD_M5, MODE_HIGH, 1, 1);
           int current_bar_index_low   = iLowest(pairs[i], PERIOD_M5, MODE_LOW, 1, 0);
           int previous_bar_index_low  = iLowest(pairs[i], PERIOD_M5, MODE_LOW, 1, 1);
         
           //Get prices
           double current_high   = High[current_bar_index];
           double previous_high  = High[previous_bar_index];
           double current_low    = Low[current_bar_index_low];
           double previous_low   = Low[previous_bar_index_low];
           
           // Logic - Start
           if (( previous_low + 1.0 * Point ) > current_low || ( previous_high  - 1.0 * Point ) < current_high )
              {
                 Alert("Pair #", i+1, ": ", pairs[i] , "has a higher high or lower low"); 
              }
           // Logic - End
              
         } // for length
      } // if Bars
   
//--- return value of prev_calculated for next call
   return(rates_total);
  }
//+------------------------------------------------------------------+
 
//+------------------------------------------------------------------+
int getAvailableCurrencyPairs(string& availableCurrencyPairs[])
{
//---   
   bool selected = false;
   const int symbolsCount = SymbolsTotal(selected);
   int currencypairsCount;
   ArrayResize(availableCurrencyPairs, symbolsCount);
   int idxCurrencyPair = 0;
   for(int idxSymbol = 0; idxSymbol < symbolsCount; idxSymbol++)
     {      
         string symbol = SymbolName(idxSymbol, selected);
         string firstChar = StringSubstr(symbol, 0, 1);
         if(firstChar != "#" && StringLen(symbol) == 6)
           {        
               availableCurrencyPairs[idxCurrencyPair++] = symbol; 
           } 
     }
     currencypairsCount = idxCurrencyPair;
     ArrayResize(availableCurrencyPairs, currencypairsCount);
     return currencypairsCount;
}
//+------------------------------------------------------------------+
class CFix { } ExtFix; // Force expressions evaluation while debugging

Quoting Georgebaker

Disliked

Hey guys, My eyes are bleeding

Ignored

Quoting Georgebaker

Disliked

It seems it's only the last one there's -1 {image}

Ignored

Quoting BlueRain

Disliked

{quote} Classic missed by 1 - which is out of array. More likely, your loop is counting too many and went over by 1. Check if there is actually pairs[i] - more likely, you counted too many.

Ignored

int ThisBarTrade           =  0;
 
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- indicator buffers mapping
 
   //Each time the indi is reloaded (ie. switch between TFs, new apply, etc ...),
   //the current bar isn't checked for conditions.
   ThisBarTrade    = Time[0];
//---
   return(INIT_SUCCEEDED);
  }
  
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
{
   
return(0);
}
  
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
//---
      string pairs[];
      int length = getAvailableCurrencyPairs(pairs);
 
      if (Bars != ThisBarTrade ) 
      {
         ThisBarTrade = Bars;  // ensure only one trade opportunity per bar   
 
         //Loop through symbols
         for(int i=0; i < length; i++)
         {
            //Alert("Pair #", i+1, ": ", pairs[i]);
   
           // Get index         
           int current_bar_index       = iHighest(pairs[i], PERIOD_M5, MODE_HIGH, 1, 0);
           int previous_bar_index      = iHighest(pairs[i], PERIOD_M5, MODE_HIGH, 1, 1);
           int current_bar_index_low   = iLowest(pairs[i], PERIOD_M5, MODE_LOW, 1, 0);
           int previous_bar_index_low  = iLowest(pairs[i], PERIOD_M5, MODE_LOW, 1, 1);
           
           Print("pairs : " + pairs[i]);
         
           //Get prices
           double current_high   = High[current_bar_index];
           double previous_high  = High[previous_bar_index];
           double current_low    = Low[current_bar_index_low];
           double previous_low   = Low[previous_bar_index_low];
           
           // Logic - Start
           if (( previous_low + 1.0 * Point ) > current_low || ( previous_high  - 1.0 * Point ) < current_high )
              {
                 //Alert("Pair #", i+1, ": ", pairs[i] , "has a higher high or lower low"); 
              }
           // Logic - End
              
         } // for length
      } // if Bars
   
//--- return value of prev_calculated for next call
   return(rates_total);
  }
//+------------------------------------------------------------------+
 
//+------------------------------------------------------------------+
int getAvailableCurrencyPairs(string& availableCurrencyPairs[])
{
//---   
   bool selected = false;
   const int symbolsCount = SymbolsTotal(selected);
   int currencypairsCount;
   ArrayResize(availableCurrencyPairs, symbolsCount);
   int idxCurrencyPair = 0;
   for(int idxSymbol = 0; idxSymbol < symbolsCount; idxSymbol++)
     {      
         string symbol = SymbolName(idxSymbol, selected);
         string firstChar = StringSubstr(symbol, 0, 1);
         if(firstChar != "#" && StringLen(symbol) == 6)
           {        
               availableCurrencyPairs[idxCurrencyPair++] = symbol; 
           } 
     }
     currencypairsCount = idxCurrencyPair;
     ArrayResize(availableCurrencyPairs, currencypairsCount);
     return currencypairsCount;
}
//+------------------------------------------------------------------+
class CFix { } ExtFix; // Force expressions evaluation while debugging

Quoting Beerrun

Disliked

Why are you using iHighest/iLowest for a single bar? (...,1,0) Just use the cohl arrays directly. I don’t know if it’s intended or not but you are taking the highest/lowest of a different pair and then use that bar index on only aud/usd arrays. Should be using iHigh, iLow, etc, if you are checking other symbols.

Ignored

Quoting Georgebaker

Disliked

{quote} Jeah u r right, too much overthinking i guess when i had these problems Let me try change it

Ignored

      string pairs[];
      int length = getAvailableCurrencyPairs(pairs);
      if (Bars != ThisBarTrade ) 
      {
         ThisBarTrade = Bars;  // ensure only one trade opportunity per bar   
         //Loop through symbols
         for(int i=0; i < length; i++)
         {
            //Alert("Pair #", i+1, ": ", pairs[i]);
   
           // Get index         
           int current_bar_index       = iHigh(pairs[i], PERIOD_M5, 0);
           int previous_bar_index      = iHigh(pairs[i], PERIOD_M5, 1);
           int current_bar_index_low   = iLow(pairs[i], PERIOD_M5, 0);
           int previous_bar_index_low  = iLow(pairs[i], PERIOD_M5, 1);
           
           //Print("pairs : " + pairs[i]);
         
           //Get prices
           double current_high   = High[current_bar_index];
           double previous_high  = High[previous_bar_index];
           double current_low    = Low[current_bar_index_low];
           double previous_low   = Low[previous_bar_index_low];
           
           // Logic - Start
           if (( previous_low + 1.0 * Point ) > current_low || ( previous_high  - 1.0 * Point ) < current_high )
              {
                 //Alert("Pair #", i+1, ": ", pairs[i] , "has a higher high or lower low"); 
              }
           // Logic - End
              
         } // for length
      } // if Bars

Quoting Georgebaker

Disliked

{quote} Like this right? string pairs[]; int length = getAvailableCurrencyPairs(pairs); if (Bars != ThisBarTrade ) { ThisBarTrade = Bars; // ensure only one trade opportunity per bar //Loop through symbols for(int i=0; i < length; i++) { //Alert("Pair #", i+1, ": ", pairs); // Get index int current_bar_index = iHigh(pairs, PERIOD_M5, 0); int previous_bar_index = iHigh(pairs, PERIOD_M5, 1); int current_bar_index_low = iLow(pairs, PERIOD_M5, 0); int previous_bar_index_low = iLow(pairs, PERIOD_M5, 1); //Print("pairs : " + pairs);...

Ignored

Quoting Beerrun

Disliked

{quote} iHigh etc returns the actual double price not an int index. The section under //Get Prices, is using the prices of the chart: High[], Low[], etc are the prices for the current chart. So every index you get above is only being used with A/U prices. Should just be 4 lines total not 8. current_high=iHigh(symbol,tf,index); etc

Ignored

      string pairs[];
      int length = getAvailableCurrencyPairs(pairs);
      if (Bars != ThisBarTrade ) 
      {
         ThisBarTrade = Bars;  // ensure only one trade opportunity per bar   
         //Loop through symbols
         for(int i=0; i < length; i++)
         {
         
           //Get prices
           double current_high   = iHigh(pairs[i], PERIOD_M5, 0);
           double previous_high  = iHigh(pairs[i], PERIOD_M5, 1);
           double current_low    = iLow(pairs[i], PERIOD_M5, 0);
           double previous_low   = iLow(pairs[i], PERIOD_M5, 1);
           
           // Logic - Start
           if (( previous_low + 1.0 * Point ) > current_low || ( previous_high  - 1.0 * Point ) < current_high )
              {
                 //Alert("Pair #", i+1, ": ", pairs[i] , "has a higher high or lower low"); 
              }
           // Logic - End
              
         } // for length
      } // if Bars

Quoting BlueRain

Disliked

{quote} Classic missed by 1 - which is out of array. More likely, your loop is counting too many and went over by 1. Check if there is actually pairs[i] - more likely, you counted too many. Print out what is Pair[i] and make sure actually there is value.

Ignored

Quoting Georgebaker

Disliked

{quote} Thank you Beerun!! So now it also scans other pairs as well right? string pairs[]; int length = getAvailableCurrencyPairs(pairs); if (Bars != ThisBarTrade ) { ThisBarTrade = Bars; // ensure only one trade opportunity per bar //Loop through symbols for(int i=0; i < length; i++) { //Get prices double current_high = iHigh(pairs, PERIOD_M5, 0); double previous_high = iHigh(pairs, PERIOD_M5, 1); double current_low = iLow(pairs, PERIOD_M5, 0); double previous_low = iLow(pairs, PERIOD_M5, 1); // Logic - Start if (( previous_low + 1.0...

Ignored

Quoting Beerrun

Disliked

{quote} Assuming the rest of the code works as intended then yes. Also this: ThisBarTrade = Time[0]; if (Bars != ThisBarTrade ) is comparing two different data types. Bars is the count of bars on the chart and Time[0] is a date time. Granted it can be cast into an int and looks like it works fine after the first tick. Do you mean to use a newbar? If so you can use the prev_calculated and rates_total in OnCalculate. Something like this: if(rates_total-prev_calculated>0)

Ignored

Quoting Georgebaker

Disliked

{quote} Yes i only want to get an alert for each new bar

Ignored

Quoting Beerrun

Disliked

{quote} Assuming the rest of the code works as intended then yes. Also this: ThisBarTrade = Time[0]; if (Bars != ThisBarTrade ) is comparing two different data types. Bars is the count of bars on the chart and Time[0] is a date time. Granted it can be cast into an int and looks like it works fine after the first tick. Do you mean to use a newbar? If so you can use the prev_calculated and rates_total in OnCalculate. Something like this: if(rates_total-prev_calculated>0)

Ignored

      string pairs[];
      int length = getAvailableCurrencyPairs(pairs);
 
      if(rates_total-prev_calculated>0)
      {
         //Loop through symbols
         for(int i=0; i < length; i++)
         {
        
           //Get prices
           double current_high   = iHigh(pairs[i], PERIOD_M5, 0);
           double previous_high  = iHigh(pairs[i], PERIOD_M5, 1);
           double current_low    = iLow(pairs[i], PERIOD_M5, 0);
           double previous_low   = iLow(pairs[i], PERIOD_M5, 1);
          
           // Logic - Start
           if (( previous_low + 1.0 * Point ) > current_low || ( previous_high  - 1.0 * Point ) < current_high )
              {
                 Alert("Pair #", i+1, ": ", pairs[i] , "has a higher high or lower low");
              }
           // Logic - End
              
         } // for length
      } // if rates
  
//--- return value of prev_calculated for next call
   return(rates_total);
  }

Quoting Georgebaker

Disliked

{quote} So u want it to look like this instead? Is it possible to avoid the alert to come up when the indi is attached the first time? string pairs[]; int length = getAvailableCurrencyPairs(pairs); if(rates_total-prev_calculated>0) { //Loop through symbols for(int i=0; i < length; i++) { //Get prices double current_high = iHigh(pairs, PERIOD_M5, 0); double previous_high = iHigh(pairs, PERIOD_M5, 1); double current_low = iLow(pairs, PERIOD_M5, 0); double previous_low = iLow(pairs, PERIOD_M5, 1); // Logic - Start if (( previous_low + 1.0...

Ignored

Quoting Beerrun

Disliked

{quote} To avoid the first time alert on attaching, then put "&&prev_calculated!=0" into the if statement.

Ignored

Quoting Georgebaker

Disliked

{quote} Works perfect. Thank u! Jeah make sense prev_calculated diff from 0

Ignored