Can someone tell me what's wrong with my code?

I have an EA coded and it works but when I change a "=" sign with a "<" or ">" it gives me the following error messages when I compile it.

'>' - comma or semicolon expectedC:\Program Files\MetaTrader - North Finance\experts\sample12.mq4 (73, 26)
'<' - comma or semicolon expectedC:\Program Files\MetaTrader - North Finance\experts\sample12.mq4 (75, 27)
'CloseBuy1_2' - variable not definedC:\Program Files\MetaTrader - North Finance\experts\sample12.mq4 (95, 34)
'CloseSell1_2' - variable not definedC:\Program Files\MetaTrader - North Finance\experts\sample12.mq4 (125, 35)

Here is the Code:

property copyright "Expert Advisor Builder"
#property link "http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/"

extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lots = 1.0;
extern int Slippage = 3;
extern bool StopLossMode = False;
extern int StopLoss = 30;
extern bool TakeProfitMode = False;
extern int TakeProfit = 60;
extern bool TrailingStopMode = False;
extern int TrailingStop = 30;

#define SIGNAL_NONE 0
#define SIGNAL_BUY 1
#define SIGNAL_SELL 2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4

int BarCount;
int Current;
bool TickCheck = False;
//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init() {
BarCount = Bars;

if (EachTickMode) Current = 0; else Current = 1;

return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit() {
return(0);
}
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start() {
int Order = SIGNAL_NONE;
int Total, Ticket;
double StopLossLevel, TakeProfitLevel;



if (EachTickMode && Bars != BarCount) TickCheck = False;
Total = OrdersTotal();
Order = SIGNAL_NONE;

//+------------------------------------------------------------------+
//| Variable Begin |
//+------------------------------------------------------------------+

double Buy1_1 = iStochastic(NULL, 0, 5, 3, 3, MODE_SMA, 1, MODE_MAIN, Current + 0);
double Buy1_2 = 0;
double Sell1_1 = iStochastic(NULL, 0, 5, 3, 3, MODE_SMA, 1, MODE_MAIN, Current + 0);
double Sell1_2 = 100;
double CloseBuy1_1 = iStochastic(NULL, 0, 5, 3, 3, MODE_SMA, 1, MODE_MAIN, Current + 0);
double CloseBuy1_2 > 95;
double CloseSell1_1 = iStochastic(NULL, 0, 5, 3, 3, MODE_SMA, 1, MODE_MAIN, Current + 0);
double CloseSell1_2 < 5;

//+------------------------------------------------------------------+
//| Variable End |
//+------------------------------------------------------------------+

//Check position
bool IsTrade = False;

for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;
if(OrderType() == OP_BUY) {
//Close

//+------------------------------------------------------------------+
//| Signal Begin(Exit Buy) |
//+------------------------------------------------------------------+

if (CloseBuy1_1 > CloseBuy1_2) Order = SIGNAL_CLOSEBUY;

//+------------------------------------------------------------------+
//| Signal End(Exit Buy) |
//+------------------------------------------------------------------+

if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(TrailingStopMode && TrailingStop > 0) {
if(Bid - OrderOpenPrice() > Point * TrailingStop) {
if(OrderStopLoss() < Bid - Point * TrailingStop) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
} else {
//Close

//+------------------------------------------------------------------+
//| Signal Begin(Exit Sell) |
//+------------------------------------------------------------------+

if (CloseSell1_1 < CloseSell1_2) Order = SIGNAL_CLOSESELL;

//+------------------------------------------------------------------+
//| Signal End(Exit Sell) |
//+------------------------------------------------------------------+

if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(TrailingStopMode && TrailingStop > 0) {
if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
}
}

//+------------------------------------------------------------------+
//| Signal Begin(Entry) |
//+------------------------------------------------------------------+

if (Buy1_1 == Buy1_2) Order = SIGNAL_BUY;
if (Sell1_1 == Sell1_2) Order = SIGNAL_SELL;

//+------------------------------------------------------------------+
//| Signal End |
//+------------------------------------------------------------------+

//Buy
if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (StopLossMode) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
if (TakeProfitMode) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("BUY order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
} else {
Print("Error opening BUY order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

//Sell
if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (StopLossMode) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
if (TakeProfitMode) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("SELL order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
} else {
Print("Error opening SELL order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

if (!EachTickMode) BarCount = Bars;

return(0);
}
//+------------------------------------------------------------------+

Lines like "double CloseBuy1_2 > 95;" aren't allowed. What do you want with this line?

If you write "double CloseBuy1_2 = 95;", you define a variable and give it an initial value. That is correct. But changing = to < or > is wrong.

Hi

I am trying to get it to close an open buy order when scholastic indicator value is greater then 95 and close a sell order when scholastic indicator is less than 5.

Kevin

These are the 2 main lines that control closing. In your case you should Close_Buy1_2 give the value 95 and Close_Sell1_2 the value 5. Then those 2 lines say:

This means that:

double CloseBuy1_2 > 95; should be double CloseBuy1_2 = 95;

double CloseSell1_2 < 5; should be double CloseSell1_2 = 5;

Boy....what I wouldn't give to be able to read code...LOL! Wish I were a progammer.

You only need time. Learn, practice, learn, practice, etc etc
There are a lot of sources on internet. MT4 is almost like C so look here: http://www.eskimo.com/~scs/cclass/cclass.html

Here the place you can learn about MQL

http://www.forex-tsd.com/lessons/?pp=20&daysprune=-1

Happy New Year all!!!

Hello,

Someone plz help me. I have a code and i want to make a alert. when candle close after i get an alert. or some kind of dashboard scanner with it. alert should come after closing the candle. not middle of the candle. plz help me. i will be very grateful to you. sorry for my English. by the way code is giving the alerts properly.


#property indicator_chart_window
#property indicator_buffers 6
#property indicator_color1 Green
#property indicator_color2 Gray
#property indicator_color3 Green
#property indicator_color4 Gray
#property indicator_color5 Green
#property indicator_color6 Gray

int g_period_76 = 20;
int gi_80 = 1;
double gd_84 = 1.0;
int gi_92 = 1;
int gi_96 = 1;
extern int Nbars = 1000;
extern bool eMailAlerts_On = FALSE;
double g_ibuf_108[];
double g_ibuf_112[];
double g_ibuf_116[];
double g_ibuf_120[];
double g_ibuf_124[];
double g_ibuf_128[];
extern bool SoundON = TRUE;
bool gi_136 = FALSE;
bool gi_140 = FALSE;
int init() {
SetIndexBuffer(0, g_ibuf_108);
SetIndexBuffer(1, g_ibuf_112);
SetIndexBuffer(2, g_ibuf_116);
SetIndexBuffer(3, g_ibuf_120);
SetIndexBuffer(4, g_ibuf_124);
SetIndexBuffer(5, g_ibuf_128);
SetIndexStyle(0, DRAW_ARROW, STYLE_SOLID, 2);
SetIndexStyle(1, DRAW_ARROW, STYLE_SOLID, 2);
SetIndexStyle(2, DRAW_ARROW, STYLE_SOLID, 5);
SetIndexStyle(3, DRAW_ARROW, STYLE_SOLID, 5);
SetIndexStyle(4, DRAW_LINE);
SetIndexStyle(5, DRAW_LINE);
SetIndexArrow(0, 159);
SetIndexArrow(1, 159);
SetIndexArrow(2, 233);
SetIndexArrow(3, 234);
IndicatorDigits(MarketInfo(Symbol(), MODE_DIGITS));
string ls_0 = "ProFX01(" + g_period_76 + "," + gi_80 + ")";
IndicatorShortName(ls_0);
SetIndexLabel(0, "UpTrend Stop");
SetIndexLabel(1, "DownTrend Stop");
SetIndexLabel(2, "UpTrend Signal");
SetIndexLabel(3, "DownTrend Signal");
SetIndexLabel(4, "UpTrend Line");
SetIndexLabel(5, "DownTrend Line");
SetIndexDrawBegin(0, g_period_76);
SetIndexDrawBegin(1, g_period_76);
SetIndexDrawBegin(2, g_period_76);
SetIndexDrawBegin(3, g_period_76);
SetIndexDrawBegin(4, g_period_76);
SetIndexDrawBegin(5, g_period_76);
return (0);
}
string GetPeriodStr(int ai_0) {
string ls_ret_4;
if (ai_0 == 1) ls_ret_4 = "M1";
if (ai_0 == 5) ls_ret_4 = "M5";
if (ai_0 == 15) ls_ret_4 = "M15";
if (ai_0 == 30) ls_ret_4 = "M30";
if (ai_0 == 60) ls_ret_4 = "H1";
if (ai_0 == 240) ls_ret_4 = "H4";
if (ai_0 == 1440) ls_ret_4 = "D1";
if (ai_0 == 10080) ls_ret_4 = "W1";
if (ai_0 == 43200) ls_ret_4 = "MN1";
return (ls_ret_4);
}
int start() {
Comment("Www.ForexWinners.Net");
int li_12;
double lda_16[25000];
double lda_20[25000];
double lda_24[25000];
double lda_28[25000];
ObjectCreate("IndName", OBJ_LABEL, 0, 0, 0);
ObjectSet("IndName", OBJPROP_CORNER, 2);
ObjectSet("IndName", OBJPROP_XDISTANCE, 3);
ObjectSet("IndName", OBJPROP_YDISTANCE, 3);
ObjectSet("IndName", OBJPROP_BACK, TRUE);
ObjectSetText("IndName", "", 9, "Times New Roman", White);
for (int l_shift_8 = Nbars; l_shift_8 >= 0; l_shift_8--) {
g_ibuf_108[l_shift_8] = 0;
g_ibuf_112[l_shift_8] = 0;
g_ibuf_116[l_shift_8] = 0;
g_ibuf_120[l_shift_8] = 0;
g_ibuf_124[l_shift_8] = EMPTY_VALUE;
g_ibuf_128[l_shift_8] = EMPTY_VALUE;
}
for (l_shift_8 = Nbars - g_period_76 - 1; l_shift_8 >= 0; l_shift_8--) {
lda_16[l_shift_8] = iBands(NULL, 0, g_period_76, gi_80, 0, PRICE_CLOSE, MODE_UPPER, l_shift_8);
lda_20[l_shift_8] = iBands(NULL, 0, g_period_76, gi_80, 0, PRICE_CLOSE, MODE_LOWER, l_shift_8);
if (Close[l_shift_8] > lda_16[l_shift_8 + 1]) li_12 = 1;
if (Close[l_shift_8] < lda_20[l_shift_8 + 1]) li_12 = -1;
if (li_12 > 0 && lda_20[l_shift_8] < lda_20[l_shift_8 + 1]) lda_20[l_shift_8] = lda_20[l_shift_8 + 1];
if (li_12 < 0 && lda_16[l_shift_8] > lda_16[l_shift_8 + 1]) lda_16[l_shift_8] = lda_16[l_shift_8 + 1];
lda_24[l_shift_8] = lda_16[l_shift_8] + (gd_84 - 1.0) / 2.0 * (lda_16[l_shift_8] - lda_20[l_shift_8]);
lda_28[l_shift_8] = lda_20[l_shift_8] - (gd_84 - 1.0) / 2.0 * (lda_16[l_shift_8] - lda_20[l_shift_8]);
if (li_12 > 0 && lda_28[l_shift_8] < lda_28[l_shift_8 + 1]) lda_28[l_shift_8] = lda_28[l_shift_8 + 1];
if (li_12 < 0 && lda_24[l_shift_8] > lda_24[l_shift_8 + 1]) lda_24[l_shift_8] = lda_24[l_shift_8 + 1];
if (li_12 > 0) {
if (gi_92 > 0 && g_ibuf_108[l_shift_8 + 1] == -1.0) {
g_ibuf_116[l_shift_8] = lda_28[l_shift_8];
g_ibuf_108[l_shift_8] = lda_28[l_shift_8];
if (gi_96 > 0) g_ibuf_124[l_shift_8] = lda_28[l_shift_8];
if (SoundON == TRUE && l_shift_8 == 0 && !gi_136) {
Alert("MATE SYSTEM UP->", Symbol(), "-", Period());
if (eMailAlerts_On) SendMail("MATE SYSTEM", "MATE SYSTEM UP - " + Symbol() + " - " + GetPeriodStr(Period()));
gi_136 = TRUE;
gi_140 = FALSE;
}
} else {
g_ibuf_108[l_shift_8] = lda_28[l_shift_8];
if (gi_96 > 0) g_ibuf_124[l_shift_8] = lda_28[l_shift_8];
g_ibuf_116[l_shift_8] = -1;
}
if (gi_92 == 2) g_ibuf_108[l_shift_8] = 0;
g_ibuf_120[l_shift_8] = -1;
g_ibuf_112[l_shift_8] = -1.0;
g_ibuf_128[l_shift_8] = EMPTY_VALUE;
}
if (li_12 < 0) {
if (gi_92 > 0 && g_ibuf_112[l_shift_8 + 1] == -1.0) {
g_ibuf_120[l_shift_8] = lda_24[l_shift_8];
g_ibuf_112[l_shift_8] = lda_24[l_shift_8];
if (gi_96 > 0) g_ibuf_128[l_shift_8] = lda_24[l_shift_8];
if (SoundON == TRUE && l_shift_8 == 0 && !gi_140) {
Alert("MATE SYSTEM DOWN=>", Symbol(), "-", Period());
if (eMailAlerts_On) SendMail("MATE SYSTEM", "MATE SYSTEM DOWN - " + Symbol() + " - " + GetPeriodStr(Period()));
gi_140 = TRUE;
gi_136 = FALSE;
}
} else {
g_ibuf_112[l_shift_8] = lda_24[l_shift_8];
if (gi_96 > 0) g_ibuf_128[l_shift_8] = lda_24[l_shift_8];
g_ibuf_120[l_shift_8] = -1;
}
if (gi_92 == 2) g_ibuf_112[l_shift_8] = 0;
g_ibuf_116[l_shift_8] = -1;
g_ibuf_108[l_shift_8] = -1.0;
g_ibuf_124[l_shift_8] = EMPTY_VALUE;
}
}
return (0);
}
int deinit() {
ObjectDelete("IndName");
return (0);
}