mql - Need help with some code again | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

I need some MQL help 3 replies

Started to program MQL, need help waiting for second condition 1 reply

MQL Coding - Let’s talk about how to code mql 0 replies

Need help with 10M chart - got it already but need some help! 1 reply

Need to code indicator from MQL to ProRealTime 1 reply

Attachments: mql - Need help with some code again
Exit Attachments

mql - Need help with some code again

  • #1
  • First Post: Edited 7:43pm Apr 11, 2020 7:29pm | Edited 7:43pm
I like to make a line x bar back(to the left) from the monthly separator in the code below

Inserted Code
int start()
{
   int j=TimeMonth(Time[Bars-1]);
   string name;
   datetime d;
   string ObjName = "LineFromMonthlySeparator";
  
   for (int i=Bars-1;i>0;i--)
   {
      d = Time[i];
      if (TimeMonth(d) !=j)
      {  
         j=TimeMonth(d);
         Comment(i);
         Sleep(100);
         name="vline"+IntegerToString(i);
         ObjectDelete(name);
         ObjectCreate(name,OBJ_VLINE,0,d,0);
        
         //This is the part that create the line to the left of the monthly separator
         ObjectCreate(ObjName,OBJ_RECTANGLE,0,Time[j],0.99430,Time[j+16],0.99480);
         ObjectSet(ObjName,OBJPROP_COLOR,Tomato);
         ChartRedraw();
      }
   }
} // Start

When i run the code it show that line too many bars to the right like in the picture below.
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 101 KB


I want it to show at the beginning of the monthly separator like below.
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot2.png Size: 96 KB


How do i automate it so it starts at the right point and make that line for every monthly separator?

It works if i use Time[j+6], but need it to be automatic

Thank u for ur reply in advance!
Blindly following others will make you blind!
  • #2
  • Apr 12, 2020 2:22am Apr 12, 2020 2:22am
Why do i have to add 6 to J when J is the one that creates the red vertical monthly separator line?
Blindly following others will make you blind!
  • #3
  • Edited 3:20am Apr 12, 2020 3:03am | Edited 3:20am
Quoting Georgebaker
Why do i have to add 6 to J when J is the one that creates the red vertical monthly separator line?
First, you shouldn't use OBJ_RECTANGLE - you should use OBJ_TREND.
OBJ_RECTANGLE will draw Rectanglar.

If you just want line, do simiar like this.
Below will draw a line from Time[i] to latest bar at price high point of current price. ( a single line )


ObjectCreate(name,OBJ_TREND,0,Time[i],0,Time[0],0); //default you set X and X1 point.
ObjectSet(name,OBJPROP_COLOR,clrBlack);
ObjectSet(name,OBJPROP_WIDTH,2);
ObjectSet(name,OBJPROP_RAY,false);

ObjectSet(name,OBJPROP_PRICE1,High[i]); //you set Y level here
ObjectSet(name,OBJPROP_PRICE2,High[i]); //you set Y1 level here

Basically, to draw a line or rectangular, you will need two points.
(x,y) -> (x1,y1)
Here, X is your time[1] and X1 is your Time[2]
Y and Y1 you should provide point.

Since your X is Time[j] and your X1 is Time[j+6], it will draw from Time[j] to Time[j+6]

In mql, index is moving right to left ( most recent one is index 0).
So, if you provide Time[j+6], your X1 point will be 6 bars to the left.


To detect if this is newMonth, you will use like below:

TimeDay(Time[index]) will return what day of month.
So, you just need to check if this is first day of month.


you will need to fix this:
if (TimeMonth(d) !=j)
{


to
if (TimeMonth(I) == 1)
{

draw line from Time[ I] to Time[I + 6] index.

}


I hope this helps.
  • #4
  • Apr 12, 2020 6:34am Apr 12, 2020 6:34am
Ok thank you BlueRian

I have changed the code so it use a trendline instead of a rectangle, so now it looks like this.

Inserted Code
#property copyright ""
#property link      ""
#property indicator_chart_window
 
extern bool ShowText = true;
extern bool ShowTip = true;
 
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
{
return(0);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
{
   ObjectsDeleteAll();
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{
   int j=TimeMonth(Time[Bars-1]);
   string name;
   datetime d;
   string ObjName = "LineFromMonthlySeparator";
 
  
   for (int i=Bars-1;i>0;i--)
   {
      d = Time[i];
 
      if (TimeMonth(i) == 1)
      {  
         j=TimeMonth(d);
         name="vline"+IntegerToString(i);
         ObjectDelete(name);
         ObjectCreate(name,OBJ_VLINE,0,d,0);
                  
        
         ObjectCreate(name,OBJ_TREND,0,Time[i],0,Time[0],0); //default you set X and X1 point.
         ObjectSet(name,OBJPROP_COLOR,clrRed);
         ObjectSet(name,OBJPROP_WIDTH,2);
         ObjectSet(name,OBJPROP_RAY,false);
        
         ObjectSet(name,OBJPROP_PRICE1,High[i]); //you set Y level here
         ObjectSet(name,OBJPROP_PRICE2,High[i]); //you set Y1 level here
        
        
         //ObjectCreate(ObjName,OBJ_RECTANGLE,0,Time[j+6],0.99430,Time[j+16],0.99480);
         //ObjectSet(ObjName,OBJPROP_COLOR,Tomato);
         //ChartRedraw();
 
      }
   }
} // Start

When i change the code from if(TimeMonth(d) != j) to if(TimeMonth(i) == 1) then i get a vertical line for every day candle instead of one for each month.

What have i missed here?
Blindly following others will make you blind!
  • #5
  • Apr 12, 2020 9:34am Apr 12, 2020 9:34am
Quoting Georgebaker
Ok thank you BlueRian I have changed the code so it use a trendline instead of a rectangle, so now it looks like this. #property copyright "" #property link "" #property indicator_chart_window extern bool ShowText = true; extern bool ShowTip = true; //+------------------------------------------------------------------+ //| Custom indicator initialization function | //+------------------------------------------------------------------+ int init() { return(0); } //+------------------------------------------------------------------+ //| Custor indicator...

name="vline"+IntegerToString(i);
ObjectDelete(name);
ObjectCreate(name,OBJ_VLINE,0,d,0);

You are creating an object with same name.
If you want VLine, you need to create with different name.

Each object should have an unique name.


if you don't want vline, delete a few lines.
below are not needed at all.

d = Time[i];

j=TimeMonth(d);
name="vline"+IntegerToString(i);
ObjectDelete(name);
ObjectCreate(name,OBJ_VLINE,0,d,0);


and add this line so each will have unique names.

name="line"+IntegerToString(i);
  • #6
  • Apr 12, 2020 10:00am Apr 12, 2020 10:00am
Ahh jeah always forget that thanks!

So now the code looks like this but now it's really a mess.

Inserted Code
#property copyright ""
#property link      ""
#property indicator_chart_window
 
extern bool ShowText = true;
extern bool ShowTip = true;
 
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
{
return(0);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
{
   ObjectsDeleteAll();
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{
   int j=TimeMonth(Time[Bars-1]);
   string name, line;
   datetime d;
   string ObjName = "LineFromMonthlySeparator";
 
  
   for (int i=Bars-1;i>0;i--)
   {
      d = Time[i];
 
      if (TimeMonth(i) == 1)
      {  
         j=TimeMonth(d);
         name="vline"+IntegerToString(i);
         ObjectDelete(name);
         ObjectCreate(name,OBJ_VLINE,0,d,0);
                  
         line ="line"+IntegerToString(i);
         ObjectDelete(line);
         ObjectCreate(line,OBJ_TREND,0,Time[i],0,Time[0],0); //default you set X and X1 point.
         ObjectSet(line,OBJPROP_COLOR,clrRed);
         ObjectSet(line,OBJPROP_WIDTH,2);
         ObjectSet(line,OBJPROP_RAY,false);
        
         ObjectSet(line,OBJPROP_PRICE1,High[i]); //you set Y level here
         ObjectSet(line,OBJPROP_PRICE2,High[i]); //you set Y1 level here
        
         //ObjectCreate(ObjName,OBJ_RECTANGLE,0,Time[j+6],0.99430,Time[j+16],0.99480);
         //ObjectSet(ObjName,OBJPROP_COLOR,Tomato);
         //ChartRedraw();
 
      }
   }
} // Start

Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 87 KB
Blindly following others will make you blind!
  • #7
  • Apr 12, 2020 10:03am Apr 12, 2020 10:03am
Quoting BlueRain
{quote} name="vline"+IntegerToString(i); ObjectDelete(name); ObjectCreate(name,OBJ_VLINE,0,d,0); You are creating an object with same name. If you want VLine, you need to create with different name. Each object should have an unique name. if you don't want vline, delete a few lines. below are not needed at all. d = Time[i]; j=TimeMonth(d); name="vline"+IntegerToString(i); ObjectDelete(name); ObjectCreate(name,OBJ_VLINE,0,d,0); and add this line so each will have unique names. name="line"+IntegerToString(i);
Please remember i need both vlines and the orther lines, vlines for monthly separator and the other line for like 10 bars back horizontal

Like this:
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 96 KB
Blindly following others will make you blind!
  • #8
  • Apr 12, 2020 10:39am Apr 12, 2020 10:39am
Quoting Georgebaker
{quote} Please remember i need both vlines and the orther lines, vlines for monthly separator and the other line for like 10 bars back horizontal Like this: {image}
if you need vline,

change this -
d should be I as it will be date of month.
.

ObjectCreate(name,OBJ_VLINE,0,j,0);
  • #9
  • Apr 12, 2020 11:28am Apr 12, 2020 11:28am
Quoting BlueRain
{quote} if you need vline, change this - d should be I as it will be date of month. . ObjectCreate(name,OBJ_VLINE,0,j,0);
U say change d to I, but u write J so which one is correct?

Have tried to change it to I and J and same result
Blindly following others will make you blind!
  • #10
  • Apr 12, 2020 11:51am Apr 12, 2020 11:51am
Quoting Georgebaker
{quote} U say change d to I, but u write J so which one is correct? Have tried to change it to I and J and same result
Maybe, providing whole code would be easier to understand.
When I gave sample, it was for reference so you can use as template but in need of change few things.

This would be code for you.

#property copyright ""
#property link ""
#property indicator_chart_window

extern bool ShowText = true;
extern bool ShowTip = true;

//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
return(0);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
ObjectsDeleteAll();

return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
//initial bar count
int counted_bars=IndicatorCounted();

//sets nobs
if(Bars<=100) return(0);
//---- check for possible errors
if(counted_bars<0) return(-1);
//---- the last counted bar will be recounted
if(counted_bars>0) counted_bars--;

string name,name2;
int limit=MathMin(Bars-counted_bars,Bars-1);


for (int i=limit;i>=0;i--)
{


//first of month?
if (TimeDay(Time[i]) == 1)
{


//draw V line
name="vline"+IntegerToString(i);
ObjectDelete(name);
ObjectCreate(name,OBJ_VLINE,0,Time[i],0);
ObjectSet(name,OBJPROP_COLOR,clrRed);
ObjectSet(name,OBJPROP_WIDTH,2);



name2="tline"+IntegerToString(i);


ObjectCreate(name2,OBJ_TREND,0,Time[i],0,Time[i+6],0); //default you set X and X1 point.
ObjectSet(name2,OBJPROP_COLOR,clrRed);
ObjectSet(name2,OBJPROP_WIDTH,2);
ObjectSet(name2,OBJPROP_RAY,false);

ObjectSet(name2,OBJPROP_PRICE1,High[i]); //you set Y level here
ObjectSet(name2,OBJPROP_PRICE2,High[i]); //you set Y1 level here


//ObjectCreate(ObjName,OBJ_RECTANGLE,0,Time[j+6],0.99430,Time[j+16],0.99480);
//ObjectSet(ObjName,OBJPROP_COLOR,Tomato);
//ChartRedraw();

}
}
} // Start
Attached Image (click to enlarge)
Click to Enlarge Name: vlinemonthly.JPG Size: 210 KB
  • #11
  • Apr 12, 2020 12:00pm Apr 12, 2020 12:00pm
Ha ha jeah saved a lot of time, looks promising, but i can see u r missing the line for 01.02.2020

And im missing even more lines

Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 98 KB
Blindly following others will make you blind!
  • #12
  • Apr 12, 2020 12:21pm Apr 12, 2020 12:21pm
Quoting Georgebaker
Ha ha jeah saved a lot of time, looks promising, but i can see u r missing the line for 01.02.2020 And im missing even more lines {image}
More likely, those are from missing bar as there was no trading data.
time[i] returns time of that bar.

Maybe, you can add some condition so it can draw this to next day or first trading day.


I just checked internet and there is some topic
https://www.mql5.com/en/forum/141099
  • #13
  • Apr 12, 2020 12:42pm Apr 12, 2020 12:42pm
But my first post of the sourcecode didn't have that problem.

There's no missing bars, this is when the first trading day is then second or the third instead of the first.
Blindly following others will make you blind!
  • #14
  • Edited 1:16pm Apr 12, 2020 12:52pm | Edited 1:16pm
Quoting Georgebaker
But my first post of the sourcecode didn't have that problem. There's no missing bars, this is when the first trading day is then second or the third instead of the first.
Let me rephrase.. missing data, not bar.

By default, MT4 displays only available data on the chart.
so, even if you have missing time/data.. you won't notice.. you will feel there is no missing hole.
There was no trading on 1/1 so it won't have data.


But, if you do this as programmatically, there is no data on 1 of month ( example : 1/1 ) as there is no trade.
so, it won't find any bar with this condition.

if (TimeDay(Time[i]) == 1)

so, it won't be able to draw vline on that bar..


I think this would be better handling

if (TimeMonth(Time[i])!= TimeMonth(Time[i+1]))
{

this will handle any time frame and draw vline on the first trade day of month.
Attached Image (click to enlarge)
Click to Enlarge Name: vlinemonthly.JPG Size: 48 KB
  • #15
  • Apr 12, 2020 1:51pm Apr 12, 2020 1:51pm
Changing the code to if (TimeMonth(Time[i])!= TimeMonth(Time[i+1])) made the difference.

It works perfect now.

Thank your for ur help

Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 123 KB
Blindly following others will make you blind!
  • #16
  • Apr 12, 2020 1:54pm Apr 12, 2020 1:54pm
Just came to my mind, now that u say Time[i+6] it works when there are 6 candles to the first monthly separator, will it work tomorrow when we have 7 candles to the separator?
Blindly following others will make you blind!
  • #17
  • Apr 12, 2020 2:36pm Apr 12, 2020 2:36pm
Quoting Georgebaker
Just came to my mind, now that u say Time[i+6] it works when there are 6 candles to the first monthly separator, will it work tomorrow when we have 7 candles to the separator?
Yes. It just mean 6 bars to the left.
  • #18
  • Last Post: Apr 12, 2020 2:54pm Apr 12, 2020 2:54pm
Ok cool
Blindly following others will make you blind!
0 traders viewing now