improve my programming skill

I have learn mql4 programming for several months now . Pretty much i get idea how the basic stuff work but thing where never enough for me .


Today i want to share my work and and i name it EA20.1 . This ea work base on martingale system and mainly purpose this ea where made is for educational and learning .

EA 20.1 work fine during the backtesting ( no errors ) but time consuming (its take an hour or 2 finish a year data backtesting ) .

If u guys wonder why i put function inside OnTick and not outside , cause i found out ea work better if the func. where inside ( just my findings , if there is issues pls light me).
i did some investigate myself and found out , not using "dailyprofittarget" but using conventional TP/SL take time less backtesting .

I still try to work around with my problem to make this ea less take time backtesting without changing it original concept .

I wonder if there is tips i can improve my code ?

well i just found my answer which is inefficient code .

Dear CosmasMoses, I hope you are safe and doing well.

I saw You on the "I will code your EAs and Indicators for no charge" thread and decided I give it a shot here.

Is there any chance You could please look into my post with a small request here: https://www.forexfactory.com/showthr...2#post12832372 , in case You have some free time soon? That would be really appreciated. I hope I did not interrupt You.
Best wishes,
12i2121

Hi CosmasMoss,

You want to improve your programming skills. I like your approach of giving time to pick up programming skills. I also realise you are not a guy who is looking for quick and "effortless success" . Obviously you have the rare quality of being patient. That's why I am sharing this knowledge with you and I am willing to share my experience of trading as long as you don't ask for signals or recommendations.

I am a 35 year experienced trader and I am teaching retirees free of cost.
The senior learners easily get confused with the forex trading because there are two symbols involved and not one.
Their comprehension levels are low. So they don't want to learn about Technical Analysis.

They told me they want to trade for income generation because banks are not giving any interest on deposit.
Some of them who are wealthy told me that is not the main reason for them trading. Before retirement, some of them were into activities related to money.
So they think trading will interest them because of their past background and at the same time help them avoid early onset of memory-related diseases.
They will trade with small account. It is like a brain exercise for them.

In general, all of them want to become self-directed traders and willing to learn about manual trading on MT4 and get trading signals from their own brains rather than from the indicators.

I am 71 and understood what they want .

First thing, I told them to keep away from forex because single symbol CFD index trading is possible on MT4. That will make their life easy.

I advised them to go for MT4 brokers who derive CFD value from Futures and not from their own made up derivative toy. Any Mt4 broker acting as a market maker will offer a derivative index made up by themselves to increase spread or change value of price suddenly and killing the accounts.

I showed them an instance of how this is done. Stock market has regular trading hours, lunch break as well as pre-trading and post-trading hours.
During lunch break three brokers increased the spread of ask bid from 10 to 60 . They were shocked. Similar tactics are employed by these market makers who don't pass any orders to any liquidity providers but have technology kill 80% to 95% of retail accounts.

It is quite a job to source CFD brokers who are linking price movements to exchange-regulated Futures. Darwinex is one of the brokers using a sumbol that matches the movement of Futures.

The learners want to do day trading so that they will not be affected by pre and after hours tantrums. Profit or Loss they have to quit at the end of the trading day.

They asked me which instrument to choose. I taught them technique of finding out volatility statistics available on the Internet to decide which one they liked based on their psychology of money and risk behaviour.

One of them selected German DAX. I told him it's a good choice for aggressive trader. GBPJPY delivers average of 150 pips in a day while DAX was delivering 350 pips ADR. More opportunities for very aggressive trading learners.

Next, they wanted an easy user-friendly tool on the MT4 platform to execute trades instantly. I showed them a few samples of Button Interfaces. They liked two and both of them are available on FF.

It is a mixed crowd of beginners and experienced person.

The beginners just want to learn how to buy, sell, control risks, find direction, and whether the Button Interface will keep their learning curve to be a modest one.
The experienced ones want to learn how to trade without using any of the indicator or technical analysis. Using the same button interface.

Indeed it is a tall order. But luckily, I got buttons that can satisfy both the beginner and the advanced trading learner.

I have found two Button interfaces .
1. One is ONLY for momentum day trading. Excellent for elderly learners both beginners and experienced ones.
It has Big buttons for Market Price Buy and Sell and small buttons for Pending orders of Buy and Sell. It is a marvellous piece of classy interface design.
https://www.forexfactory.com/showthread.php?t=954503

What is lacks for buttons for Hedging: Hedge Now, Hedge Later,

2, The above button trader is specifically for Patient traders or learners who want to see the power of momentum trading, It uses up all equity and even winnings like a martingale trader. Even if you use it ONE TIME in one month with your timing correct you will make more money that a person daytrading for whole month. It is such powerful. It also needs powerful skills of judging momentum speed. I told the learners I will also teach them how to detect momentum and play with very small money to make big money. Trigger-happy or impulsive traders should keep away from such an EA.

3, I have found the button on the link. It is equally good. You will find my comments on that site explaining what to be done. But the coder is busy but has kindly given me mql which he has not shared on this site.

https://www.forexfactory.com/showthread.php?t=480763

3. If you want to develop a new EA taking ideas from both, then let me know. I will give you ideas as a trader what is needed to be done. I don't even know Excel or any programming language. I can't be of any help to you there.

please do an EA with the following
SYMBOL ADR RSI PRICE XB XE

Entries :
if ADR is clicked and modoki has currency to be on at top two