Array out of range when running indicator | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Array out of range? Help? 11 replies

Please help: Getting "Array Out of Range" in EA 7 replies

Help with " array out of range in" - Error 6 replies

Two Dimensional Array vs One Dimensional Array 13 replies

Calculate Stochastic Formula on a array (non indicator buffer array) 2 replies

Attachments: Array out of range when running indicator
Exit Attachments

Array out of range when running indicator

  • #1
  • First Post: Mar 15, 2020 6:13pm Mar 15, 2020 6:13pm
Hello,

I have an indicator that show me 3 bar fractals. I'm drawing lines on OHLC of a candle and that's where it gives me some problems.

It works fine as long a i keep the number below i+4 in the line below - if i change it to i+5 i get the error "array out of range xxxx.mq4 (253,53)

Inserted Code
ObjectCreate(strObjectNameLow, OBJ_TREND, 0, Time[i-5], value, Time[i+5], value);

Here is the code i'm working on
Inserted Code
#property indicator_chart_window #property indicator_buffers 2 #include <WinUser32.mqh> extern int     Fractal_Timeframe                = 0; extern int     Maxbar                           = 2000; extern color   Up_Fractal_Color                 = Red; extern int     Up_Fractal_Symbol                = 108; extern color   Down_Fractal_Color               = Blue; extern int     Down_Fractal_Symbol              = 108; extern bool    Extend_Line                      = false; extern bool    Extend_Line_to_Background        = true; extern bool    Show_Validation_Candle           = true; extern color   Up_Fractal_Extend_Line_Color     = Red; extern int     Up_Fractal_Extend_Width          = 0; extern int     Up_Fractal_Extend_Style          = 2; extern color   Down_Fractal_Extend_Line_Color   = Blue; extern int     Down_Fractal_Extend_Width        = 0; extern int     Down_Fractal_Extend_Style        = 2; extern double  DistanceFromCandle               = 25; double UpBuffer[], DoBuffer[], refchk, tempref, level, level_1, level_2; int barc; //+------------------------------------------------------------------+ //|                                                             INIT | //+------------------------------------------------------------------+ int init()   {    SetIndexBuffer(0,UpBuffer);    SetIndexStyle(0,DRAW_ARROW, DRAW_ARROW, 0, Up_Fractal_Color);    SetIndexArrow(0,Up_Fractal_Symbol);    SetIndexBuffer(1,DoBuffer);    SetIndexStyle(1,DRAW_ARROW, DRAW_ARROW, 0, Down_Fractal_Color);    SetIndexArrow(1,Down_Fractal_Symbol);    return(0);   } //+------------------------------------------------------------------+ //|                                                           DEINIT | //+------------------------------------------------------------------+ int deinit()   {    for(int i = ObjectsTotal(); i >= 0; i--)      {       if(StringSubstr(ObjectName(i),0,12) == "MTF_Fractal_")         {          ObjectDelete(ObjectName(i));         }      }       for(int i = ObjectsTotal(); i >= 0; i--)      {       if(StringSubstr(ObjectName(i),0,12) == "Example line")         {          ObjectDelete(ObjectName(i));         }      }         Comment("");    return(0);   }    //+------------------------------------------------------------------+ //|                                                            START | //+------------------------------------------------------------------+ int start()   {    // Check if correctly timeframe is selected. Only show dots on D1    if((Period() == 1440))    {         int c, dif;       int i;              tempref =   iHigh(Symbol(), Fractal_Timeframe, 1) +                   iHigh(Symbol(), Fractal_Timeframe, 51) +                   iHigh(Symbol(), Fractal_Timeframe, 101);       if(barc != Bars || IndicatorCounted() < 0 || tempref != refchk)         {          barc = Bars;          refchk = tempref;         }       else          return(0);       deinit();       if(Fractal_Timeframe <= Period())          Fractal_Timeframe = Period();       dif = Fractal_Timeframe/Period();       if(Maxbar > Bars)          Maxbar = Bars-10;                int CountHigh = 1;       int CountLow = 1;                     for(i = 0; i < Maxbar; i++)       {            if(iBarShift(NULL,Fractal_Timeframe,Time[i]) < 3)          {             UpBuffer[i] = 0;             DoBuffer[i] = 0;             continue;          }                   // Add a dot above the candle that is the high fractal          UpBuffer[i] = iFractals(NULL,Fractal_Timeframe,1,iBarShift(NULL,Fractal_Timeframe,Time[i]));                   if(CountHigh<2)          {             if(UpBuffer[i] > 0)             {                DrawFractalOHLCHigh(i, "M", High[i]);                DrawFractalOHLCHigh(i, "N", Low[i]);                DrawFractalOHLCHigh(i, "O", Open[i]);                DrawFractalOHLCHigh(i, "P", Close[i]);                CountHigh = CountHigh + 1;             }          }          //level_1 = iFractals(NULL,Fractal_Timeframe,1,iBarShift(NULL,Fractal_Timeframe,Time[i]));          //UpBuffer[i] = level_1+DistanceFromCandle*10*Point;                   // Add a dot below the candle that is the low fractal          DoBuffer[i] = iFractals(NULL,Fractal_Timeframe,2,iBarShift(NULL,Fractal_Timeframe,Time[i]));                  if(CountLow<2)          {             if(DoBuffer[i] > 0)             {                DrawFractalOHLCLow(i, "Q", High[i]);                DrawFractalOHLCLow(i, "R", Low[i]);                DrawFractalOHLCLow(i, "S", Open[i]);                DrawFractalOHLCLow(i, "T", Close[i]);                CountLow = CountLow + 1;             }          }          //level_2 = DoBuffer[i] = iFractals(NULL,Fractal_Timeframe,2,iBarShift(NULL,Fractal_Timeframe,Time[i]));          //DoBuffer[i] = level_2-DistanceFromCandle*10*Point;       }                              //if(Extend_Line)       if(Show_Validation_Candle)       {          for(i = 0; i < 30; i++)          {             if(UpBuffer[i] > 0)             {                level = UpBuffer[i];                for(c = i; c > 0; c--)                {                    if((Open[c] < level && Close[c] > level) || (Open[c] > level && Close[c] < level))                       break;                    if(Open[c] <= level && Close[c] <= level && Open[c-1] >= level && Close[c-1] >= level)                       break;                    if(Open[c] >= level && Close[c] >= level && Open[c-1] <= level && Close[c-1] <= level)                       break;                }                               if(Extend_Line)                {                                 DrawLine ("H", i, c, level, Extend_Line_to_Background, Up_Fractal_Extend_Line_Color, Up_Fractal_Extend_Width, Up_Fractal_Extend_Style);                }                //if(Show_Validation_Candle)                UpBuffer[i-2*dif] = level;                i += dif;             }          }       }          if(Show_Validation_Candle)       {          for(i = 0; i < 30; i++)          {             if(DoBuffer[i] > 0)             {                level = DoBuffer[i];                for(c = i; c > 0; c--)                {                   if((Open[c] < level && Close[c] > level) || (Open[c] > level && Close[c] < level))                      break;                   if(Open[c] <= level && Close[c] <= level && Open[c-1] >= level && Close[c-1] >= level)                      break;                   if(Open[c] >= level && Close[c] >= level && Open[c-1] <= level && Close[c-1] <= level)                      break;                }                               if(Extend_Line)                {                   DrawLine ("L", i, c, level, Extend_Line_to_Background, Down_Fractal_Extend_Line_Color, Down_Fractal_Extend_Width, Down_Fractal_Extend_Style);                }                //if(Show_Validation_Candle)                DoBuffer[i-2*dif] = level;                i += dif;             }          }       }    }       else    {       Comment("Invalid timeframe selected. Change timeframe to D1.");    }    return(0);   } //+------------------------------------------------------------------+ //|                                                        DRAW LINE | //+------------------------------------------------------------------+ void DrawLine (string dir, int i, int c, double lev, bool back, color col, int width, int style) {    ObjectCreate("MTF_Fractal_"+dir+i,OBJ_TREND,0,0,0,0,0);    ObjectSet("MTF_Fractal_"+dir+i,OBJPROP_TIME1,iTime(Symbol(),Period(),i));    ObjectSet("MTF_Fractal_"+dir+i,OBJPROP_PRICE1,lev);    ObjectSet("MTF_Fractal_"+dir+i,OBJPROP_TIME2,iTime(Symbol(),Period(),c));    ObjectSet("MTF_Fractal_"+dir+i,OBJPROP_PRICE2,lev);    ObjectSet("MTF_Fractal_"+dir+i,OBJPROP_RAY,0);    ObjectSet("MTF_Fractal_"+dir+i,OBJPROP_BACK,back);    ObjectSet("MTF_Fractal_"+dir+i,OBJPROP_COLOR,col);    ObjectSet("MTF_Fractal_"+dir+i,OBJPROP_WIDTH,width);    ObjectSet("MTF_Fractal_"+dir+i,OBJPROP_STYLE,style); } void DrawFractalOHLCHigh(int i, string dir, double value) {    string strObjectNameHigh = "Example line"+dir+i;    ObjectCreate(strObjectNameHigh, OBJ_TREND, 0, Time[i-10], value, Time[i+10], value);    ObjectSet(strObjectNameHigh, OBJPROP_RAY, false); } void DrawFractalOHLCLow(int i, string dir, double value) {    string strObjectNameLow = "Example line"+dir+i;    [highlight=#FFDD00]ObjectCreate(strObjectNameLow, OBJ_TREND, 0, Time[i-5], value, Time[i+5], value);[/highlight]    ObjectSet(strObjectNameLow, OBJPROP_RAY, false); }

I know i have to use ArrayResize, but i cannot find out to put it in the code correctly so it removes the array out of range error.

This is how it looks like when the number is i+4
Attached Image (click to enlarge)
Click to Enlarge Name: FractalIndi.png Size: 22 KB


And when the number is changed to i+5 it looks like this
Attached Image (click to enlarge)
Click to Enlarge Name: FractalIndi1.png Size: 20 KB
Blindly following others will make you blind!
  • #2
  • Edited 7:07pm Mar 15, 2020 6:28pm | Edited 7:07pm
Why can i not edit the post above

The editor destroys the code so it's only in one line

The code
Attached File(s)
File Type: mq4 ICT_Fractals_v1.0ff.mq4   17 KB | 245 downloads


The problem is in line 246 - Time[i-5]

Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 7 KB
Blindly following others will make you blind!
  • #3
  • Edited 7:36pm Mar 15, 2020 7:24pm | Edited 7:36pm
Quoting Georgebaker
Why can i not edit the post above The editor destroys the code so it's only in one line The code {file} The problem is in line 246 - Time[i-5] {image}
did look at code but looking at snippet, it might be Time[i-5]

Time[0] is current bar.
So, if you subtract , it is future which might not exist and will give out of range error.

Check your code if some loop check current position.
you shouldn't give this base bar position no more than 5. this Time[I-5] shouldn't have value < 0.

you might fix this issue like

Draw(xxx)
{
int position = 0;
if ( I - 5 < 0) { position = 0 } else { position = i-5;}

then use this positon variable to Time[position]

}
  • #4
  • Mar 15, 2020 7:30pm Mar 15, 2020 7:30pm
Hmm... not sure what u actually say, but i though i could give Time[i] whatever number i like cause u can always count back and i only use it to draw the line.

It is Time[i-5] that makes the problem though
Blindly following others will make you blind!
  • #5
  • Mar 15, 2020 7:33pm Mar 15, 2020 7:33pm
But it's not a problem in the code above that also draw a line, there i can go as far back as i want? Like -15
Blindly following others will make you blind!
  • #6
  • Mar 15, 2020 7:39pm Mar 15, 2020 7:39pm
I know what the problem is and maybe that was also what u tried to say

When i uploaded the code i could max give the number 4, now after midnight i can give is 5 cause now we have one more candle.

This problem is because i cannot give it a higher number than i have candle to the right
Blindly following others will make you blind!
  • #7
  • Mar 15, 2020 7:40pm Mar 15, 2020 7:40pm
Tomorrow i can give it number 6 (On a daily chart)
Blindly following others will make you blind!
  • #8
  • Mar 15, 2020 7:46pm Mar 15, 2020 7:46pm
So i cannot get the line out in the future with this method is guess.

If u know another way to do that i like to know.
Blindly following others will make you blind!
  • #9
  • Edited 9:42pm Mar 15, 2020 7:57pm | Edited 9:42pm
Quoting Georgebaker
Tomorrow i can give it number 6 (On a daily chart)
You are missing the point.
if your time is future, reset to 0 so that it doesn't give error.
You can't print something to out of chart like Time[futureindex]


You can test out this like below:

for(i = 0; i < Maxbar; i++)
{
Print("Var i", i);
Print("Time is ", Time[i-5]);

you will get error -
2020.03.15 17:53:42.276 ICT_Fractals_v1.0ff EURUSD,Daily: array out of range in 'ICT_Fractals_v1.0ff.mq4' (113,32)


this Time[xxx] should be kept as index<=0.

One way is to check and reset to zero in your code so that it doesn't give out of range error.

this should reset index to zero.
At least, it will draw upto today which is latest possible in anyday.


void DrawFractalOHLCHigh(int i, string dir, double value)
{
int index = 0;
if ( i - 10 < 0) {index = 0;}
else index = i - 10;

string strObjectNameHigh = "Example line"+dir+i;
ObjectCreate(strObjectNameHigh, OBJ_TREND, 0, Time[index], value, Time[i+10], value);
ObjectSet(strObjectNameHigh, OBJPROP_RAY, false);
}
void DrawFractalOHLCLow(int i, string dir, double value)
{
int index = 0;
if ( i - 8 < 0) {index = 0;}
else index = i - 8;

string strObjectNameLow = "Example line"+dir+i;
ObjectCreate(strObjectNameLow, OBJ_TREND, 0, Time[index], value, Time[i+8], value);
ObjectSet(strObjectNameLow, OBJPROP_RAY, false);
}


below is after fix this:
Attached Image (click to enlarge)
Click to Enlarge Name: fractal.JPG Size: 96 KB
Attached File(s)
File Type: mq4 ICT_Fractals_v1.0ff.mq4   18 KB | 307 downloads
  • #10
  • Mar 16, 2020 4:03am Mar 16, 2020 4:03am
Quoting Georgebaker
But it's not a problem in the code above that also draw a line, there i can go as far back as i want? Like -15
Hi George,

You cannot pass a negative index to an array, like Time[i-5] when i < 5. It will always give an out of range error. If you really want to plot a line into the future, you need to do something like the code below, where offset is the + and - value passed to the DrawFractalOHLCHigh function.

void DrawFractalOHLCHigh(int i, int offset, string dir, double value)
{
DateTime start_time;
DateTime end_time = Time[i+offset]; //assuming offset is always positive

int start_index = i - offset;
if (start_index < 0)
{
start_time = iTime(NULL,0, 0) + (Period()*60)*(-start_index); //this will generate the proper time shifted value to pass to the ObjectCreate function
}
else
start_time = Time[start_index];

string strObjectNameLow = "Example line"+dir+DoubleToString(start_time,0);
ObjectCreate(strObjectNameLow, OBJ_TREND, 0, start_time, value, end_time, value);
ObjectSet(strObjectNameLow, OBJPROP_RAY, false);
}

Something like this, though I have not tested this specific snippet. I use the same method in my drawing utility functions. Also note that it is better to use the time as unique reference in the object name, since the current bar will always be index[0] and you will have name conflict going into the future when using the index.

Hope this helps. Good luck.
  • #11
  • Last Post: Mar 16, 2020 5:20am Mar 16, 2020 5:20am
Thank u guys for the explanation and the snippets
Blindly following others will make you blind!
0 traders viewing now