Need Help with Simple Coding

input bool Exit_Only = 0;
 
int OnInit(){
return(INIT_SUCCEEDED);
}
 
void OnTick(){
 
int testFunction(){
if(Exit_Only==1)
   return(1);
   return(0);//else expecting 0
}
 
int resExitOnly=testFunction();
if(resExitOnly==1){
   Comment("Exit Only");
   Comment("both Entry & Exit");//else output
}
}

input bool Exit_Only = 0;
 
int OnInit(){
   return(INIT_SUCCEEDED);
}
 
int testFunction() {
   if(Exit_Only==1)
      return(1);
   else
      return(0);//else expecting 0
}
 
void OnTick(){
 
   int resExitOnly=testFunction();
 
   if(resExitOnly==1){
      Comment("Exit Only");
   }
   else {
      Comment("both Entry & Exit");//else output
   }
}

Quoting chimoong

Disliked

I'm testing on simple "return(x) or return(y)" for an EA, but with an error message "testFunction - function declarations are allowed namespace or class scope only", can someone advise me where am I go wrong ? Thanks I learn to code by following https://www.mql5.com/en/forum/120791 ... input bool Exit_Only = 0; int OnInit(){ return(INIT_SUCCEEDED); } void OnTick(){ int testFunction(){ if(Exit_Only==1) return(1); return(0);//else expecting 0 } int resExitOnly=testFunction(); if(resExitOnly==1){ Comment("Exit Only"); Comment("both Entry & Exit");//else...

Ignored

input bool Exit_Only = 0;
int OnInit()
{
   return(INIT_SUCCEEDED);
}
void OnTick(){
  string text = "both Entry & Exit";
 
  int resExitOnly=testFunction();
  if(resExitOnly){ text = "Exit Only"};
 
  Comment(text);//else output
}
 
int testFunction(){
ExitOnly == 1 ? return 1 : return 0
}

Quoting Quants

Disliked

{quote} You need to declare your functions out of OnTick Function and call them in OnTick as TestFunction(); input bool Exit_Only = 0; int OnInit() { return(INIT_SUCCEEDED); } void OnTick(){ string text = "both Entry & Exit"; int resExitOnly=testFunction(); if(resExitOnly){ text = "Exit Only"}; Comment(text);//else output } int testFunction(){ ExitOnly == 1 ? return 1 : return 0 }

Ignored

Quoting Mic_FX

Disliked

input bool Exit_Only = 0; int OnInit(){ return(INIT_SUCCEEDED); } int testFunction() { if(Exit_Only==1) return(1); else return(0);//else expecting 0 } void OnTick(){ int resExitOnly=testFunction(); if(resExitOnly==1){ Comment("Exit Only"); } else { Comment("both Entry & Exit");//else output } }

Ignored

Quoting chimoong

Disliked

{quote} Thanks Quants, but your solution is not what I want because string text is not my direction but I want to learn how the return(0) and return(1) work for the function. Thanks anyway.

Ignored

int magicNum = 1;
 
void OnStart(){
 
int cntBuyOrders=0;
int cntSellOrders=0;
for(int cnt=0;cnt<OrdersTotal();cnt++){
   OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
   if (OrderType()==OP_BUY && OrderSymbol()==Symbol() && OrderMagicNumber()==magicNum){
      cntBuyOrders++;
   }
   if (OrderType()==OP_SELL && OrderSymbol()==Symbol() && OrderMagicNumber()==magicNum){
      cntSellOrders++;
   }
}
 
MessageBox(
"Info Total BUY Open Orders : "+IntegerToString(cntBuyOrders)+"\n"
"Info Total SELL Open Orders : "+IntegerToString(cntSellOrders)+"\n"
);
}

Quoting chimoong

Disliked

Dear coders, I've another question on a script. This script is to count the number of open BUY trades and open SELL trades, but it has a warning "return value of 'OrderSelect' should be checked", kindly advise, thank you. int magicNum = 1; void OnStart(){ int cntBuyOrders=0; int cntSellOrders=0; for(int cnt=0;cnt<OrdersTotal();cnt++){ OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES); if (OrderType()==OP_BUY && OrderSymbol()==Symbol() && OrderMagicNumber()==magicNum){ cntBuyOrders++; } if (OrderType()==OP_SELL && OrderSymbol()==Symbol() && OrderMagicNumber()==magicNum){...

Ignored

bool x = OrderSelect() or if(OrderSelect())

Quoting Quants

Disliked

{quote} Function returns 1 and 0 and it edits the text based on condition. Instead of calling Comment multiple times you can just edit Text variable that you want to print with Result of function. Glad your problem is resolved

Ignored

Quoting Quants

Disliked

{quote} OrderSelect returns boolean you need to see if OrderSelect returns true or false bool x = OrderSelect() or if(OrderSelect())

Ignored

Quoting chimoong

Disliked

{quote} Honestly Quants, I don't know what to do with your suggested answer, LOL. In fact, my above script is a full script, it is working as there is no error per attched picture, but MetaEditor shows a warning message of "return value of 'OrderSelect' should be checked", means there is a "defect", but I do not know how to troubleshoot it. Hope you do not mind rectify the full script accordingly so that it will not show warning message at all. Thank you. {image}

Ignored

for(int cnt=0;cnt<OrdersTotal();cnt++){
bool isSelected = OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);

Quoting Quants

Disliked

{quote} Just replace that line with this for(int cnt=0;cnt<OrdersTotal();cnt++){ bool isSelected = OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);

Ignored

Quoting Quants

Disliked

{quote} Function returns 1 and 0 and it edits the text based on condition. Instead of calling Comment multiple times you can just edit Text variable that you want to print with Result of function. Glad your problem is resolved

Ignored

Quoting chimoong

Disliked

{quote} From my understanding, declaration will be situated in non-OnTick section and the function operation will be situated in OnTick section (Comment). Your statement "calling Comment multiple times" is confusing me. From my logic understanding, the Comment section is just an output of the whole operation and it shall "call from" the declaration non-OnTick section rather than the Comment section being called. In other words, who is calling who ? Kindly advise / correct my understanding, thanks.

Ignored

if(a)
Comment("x");
else
Comment("y");

string text = "y"
 
if(a)
text = "x"
 
Comment(text);

Quoting Quants

Disliked

{quote} Comment(); is a Function. OnTick() is another function. whenever new tick comes to the market OnTick() block executed. Whatever you have inside there will be executed next. So if(a) Comment("x"); else Comment("y"); will be equal to string text = "y" if(a) text = "x" Comment(text); But there you just typed less words.

Ignored

Quoting chimoong

Disliked

{quote} Thanks Quants. I will gradually pick up the coding knowledge soon.

Ignored

Quoting ionone

Disliked

{quote} yes! you're on the right path anyway learning programming is not very easy but it can be helpful

Ignored

Quoting Quants

Disliked

{quote} Comment(); is a Function. OnTick() is another function. whenever new tick comes to the market OnTick() block executed. Whatever you have inside there will be executed next. So if(a) Comment("x"); else Comment("y"); will be equal to string text = "y" if(a) text = "x" Comment(text); But there you just typed less words.

Ignored

Quoting chimoong

Disliked

{quote} Hi Quants, I have a question to seek your advice. As per above, there are two portions of the coding (1) non-OnTick block and (2) OnTick block codes. int testFunction() { if(Exit_Only==1) return(1); (I'll have complicated formulas and calculations in this area) else return(0); void OnTick() ... blablabla (to call return value from the above) Since the complicated formulas and calculations are not falling into the OnTick block, will the EA progressively act fast overally such as per tick basis ? How about if I add :- if(Exit_Only==1) return(1);RefreshRates();...

Ignored

Quoting Quants

Disliked

{quote} I hardly suggest you to read documentation of mql4 This link can help you to understand how OnTick , OnTimer functions. https://docs.mql4.com/basis/function/events and to get better understanding about functions ...

Ignored

// C++ Language
 
#include<iostream>
 
using namespace std;
 
int power(int baseNum, int powNum){
   int result = 1;
   for(int aaa = 0; aaa < powNum; aaa++){
      result = baseNum * result;
   }
   return result;
}
 
int main(){
   cout << power(2, 4) << endl;
   return 0;
}

void OnTick() {
bla bla bla ...
}
void OnTimer() {
OnTick();
}