BreakEven code keep calling OrderModify() | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

OrderModify - Error code 1 9 replies

Need help with OrderModify code 4 replies

looping ordermodify code 4 replies

Hidden SL Breakeven/Jump code not working 0 replies

OrderModify() problem (NOT error code 1) 3 replies

BreakEven code keep calling OrderModify()

  • #1
  • First Post: Nov 17, 2019 11:40am Nov 17, 2019 11:40am
Can someone help me with this? My BE code keep calling OrderModify() even though criteria wasn't met. I keep getting error 130. If criteria is met, it modifies the SL and the error 130 stops.

void TrailStops()
{
int total=OrdersTotal();
for (int cnt=0;cnt<total;cnt++)
{
OrderSelect(cnt, SELECT_BY_POS);
int mode=OrderType();
if ( OrderSymbol()==Symbol() )
{
if ( mode==OP_BUY )
{

if ( Bid-OrderOpenPrice()>Point*BreakEven && (OrderStopLoss() < OrderOpenPrice())) //if Bid price had moved above the BreakEven value
{
double newBuyStop = NormalizeDouble(OrderOpenPrice()+Point*10,digit); //Set new stoploss at 1pip above orderopenprice
OrderModify(OrderTicket(),OrderOpenPrice(),newBuyStop,OrderTakeProfit(),0,LightGreen);
}
}
if ( mode==OP_SELL )
{

if ( OrderOpenPrice()-Ask>Point*BreakEven && (OrderStopLoss() > OrderOpenPrice())) //if Ask price had moved belove the BreakEven value
{
double newSellStop = NormalizeDouble(OrderOpenPrice()-Point*10,digit); //Set new stoploss at 1pip below orderopenprice
OrderModify(OrderTicket(),OrderOpenPrice(),newSellStop,OrderTakeProfit(),0,Yellow);
}
}
}
}
}
  • #2
  • Nov 17, 2019 1:14pm Nov 17, 2019 1:14pm
Not sure but see how i use the normalization over pairs. I see you have made simply *Point
Below code will trail each 1 pip profitable move after trigger. So its not breakeven one but simply trailing stoploss.

My normalization goes with *Pip instead of *Point.

That might be the issue. Is that happening on all pairs or just JPY ?

Inserted Code
double Pip;
int PipsToPoints;
 
if (Digits % 2 == 1) { Pip = Point * 10;}
else { Pip = Point;}
  
PipsToPoints = int(Pip / _Point);
 
void TrailingPositions(int trailingStop)
  {
    for(int i = 0; i< OrdersTotal(); ++i)
    {
      if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
      {
        if(OrderType()==OP_BUY && OrderMagicNumber() == EAMagicNumber)
        {  
          if(MathAbs(Bid-OrderOpenPrice()) >= TrailingStopTrigger*Pip)
          {
            int factor = int ( (Bid-OrderOpenPrice()) / (trailingStop*Pip));
            double originalStopLoss = OrderOpenPrice()-SLpoints*Pip;
            double newStopLoss = originalStopLoss + factor * trailingStop * Pip;
            if(OrderStopLoss()<newStopLoss || OrderStopLoss()==0.0)
            {
              bool IsGood = OrderModify(OrderTicket(), OrderOpenPrice(), newStopLoss, OrderTakeProfit(),0,clrNONE);
            }  
          }  
        }
        else if(OrderType()==OP_SELL && OrderMagicNumber() == EAMagicNumber)
        {
          if(MathAbs(Ask-OrderOpenPrice()) >= TrailingStopTrigger*Pip)
          {
            int factor = int ( (OrderOpenPrice() - Ask) / (trailingStop*Pip));
            double originalStopLoss = OrderOpenPrice()+SLpoints*Pip;
            double newStopLoss = originalStopLoss - factor * trailingStop * Pip;
            if(OrderStopLoss()>newStopLoss || OrderStopLoss()==0.0)
            {
              bool IsGood = OrderModify(OrderTicket(), OrderOpenPrice(), newStopLoss, OrderTakeProfit(),0,clrNONE);
            }
          }    
        }
      }  
    }
  }
Take it easy.
  • #3
  • Nov 17, 2019 1:57pm Nov 17, 2019 1:57pm
Yes, I am moving it 1pip profitable after trigger, but it could be BE. My question is why would it continue to the OrderModify() function if the criteria wasn't met?

if ( Bid-OrderOpenPrice()>Point*BreakEven && (OrderStopLoss() < OrderOpenPrice())) //if Bid price had moved above the BreakEven value

I'm checking if price had moved a certain number of pips, AND comparing SL with Openprice. The code modifies the the SL fine if conditions are met.
  • #4
  • Last Post: Edited 4:47pm Nov 17, 2019 4:07pm | Edited 4:47pm
Quoting xiqat
Yes, I am moving it 1pip profitable after trigger, but it could be BE. My question is why would it continue to the OrderModify() function if the criteria wasn't met? if ( Bid-OrderOpenPrice()>Point*BreakEven && (OrderStopLoss() < OrderOpenPrice())) //if Bid price had moved above the BreakEven value I'm checking if price had moved a certain number of pips, AND comparing SL with Openprice. The code modifies the the SL fine if conditions are met.
You cannot compare two doubles using ">" or "<". The result will always cause errors as doubles internally are not stored as exact numbers but only as an approximation. For comparing doubles you must use helper functions which normalize values and thus account for the mentioned approximation issue.

Copy yourself the following 6 functions for comparing doubles into your code and use only them. No manual comparisons more.

https://github.com/rosasurfer/mt4-mq...ions.mqh#L1222

There is no principle difference in comparing doubles for equality or non-equality. So what is valid for "<" and ">" is also valid for "<=", ">=", "==" and "!=". There is one exception to the rule "never manually compare doubles". Using a Microsoft compiler (most Windows programs) and a i386-i686 compatible CPU you can rely on the fact that doubles containing integer values are stored with exact precision. Means you can compare doubles manually only if they have been assigned a plain integer.

"double a = 3" internally stores the exact value of "3".

"double b = 3.1" internally may store anything from around "3.0000000000000009" to "3.10000000000001". That's why your comparisons fail.

So in MQL the following code will never fail:
Inserted Code
double varA = 3, varB = 3;    // plain non-fractional integers
if (varA == varB) {
   // do something
}

With regular fractional values (e.g. prices or Point) the above case may or may not fail, depending on the internally stored representation - which you can never know.
It takes blood, sweat and enough tears to wash away the blood.
0 traders viewing now