(binned per thread starter’s request) Position size calc code | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Fibo Calc indicator 74 replies

Que's MM Calc and Log 87 replies

Replace Moving Average Calc in EA with Calc of MA Indie 2 replies

Lot size, contract size, max position ? 1 reply

Help: Need code to increase lot size per $1000 increase in account 4 replies

Attachments: (binned per thread starter’s request) Position size calc code
Exit Attachments

(binned per thread starter’s request) Position size calc code

  • #1
  • First Post: Jul 19, 2019 9:02pm Jul 19, 2019 9:02pm
Can anyone help to make minor changes to this code please?
I would like the SL range from 5 pips to 20 pips.
If anyone can help I'll need new code as a .mq4 file

Regards
Rob


Attached Image (click to enlarge)
Click to Enlarge Name: PSC.png Size: 32 KB





#property copyright ""
#property link ""
#property strict

#property indicator_separate_window

extern int FontSize=8;
extern color FontColor=DeepSkyBlue;
extern int XDistance=10;// X location
extern int YDistance=10;// Y location
extern double Risk=2;// Risk (%)

//--------------------------------------------------------------------
int init()
{
IndicatorShortName("");
return(0);
}

int deinit()
{
Comment("");

ObjectsDeleteAll();
return(0);
}
//--------------------------------------------------------------------

int BarsCount = 0;

int totalprofit = 0;
int totalloss = 0;
int countbuy = 0;
int countsell = 0;

int start()
{
double bal = AccountEquity();
string s = "SL (pips)|";
string s2 = "Lot Size |";
make_label("sl",s,XDistance,YDistance);
make_label("lots",s2,XDistance,YDistance+(FontSize*2));

for(int i = 0; i <= 20; i++)
{
double lot = (bal*(Risk/100.0)) / ((10+i)*10* MarketInfo(Symbol(), MODE_TICKVALUE));

if(0.01 == MarketInfo(0,MODE_MINLOT))
{
lot = NormalizeDouble(lot,2);

if(lot < 0.01){lot = 0.01;}
else{}
}
else if(0.1 == MarketInfo(0,MODE_MINLOT))
{
lot = NormalizeDouble(lot,1);

if(lot < 0.1){lot = 0.1;}
else{}
}
else if(1.0 == MarketInfo(0,MODE_MINLOT))
{
lot = NormalizeDouble(lot,0);

if(lot < 1.0){lot = 1.0;}
else{}
}
else{}

s = (10+i)+" |";
s2 = DoubleToStr(lot,2)+" |";

make_label("sl"+i,s,XDistance+(0+(FontSize*8))+((10+(FontSize*4))*i),YDistance);
make_label("lots"+i,s2,XDistance+(0+(FontSize*8))+((10+(FontSize*4))*i),YDistance+(FontSize*2));
}

return(0);
}

void DrawPriceHHLine(datetime x1, datetime x2, double y1,
double y2, color lineColor, double style)
{
string label = "HHLine.0# " + DoubleToStr(x2, 0) + lineColor;
ObjectDelete(label);
ObjectCreate(label, OBJ_TREND, 0, x1, y1, x2, y2, 0, 0);
ObjectSet(label, OBJPROP_RAY, 0);
ObjectSet(label, OBJPROP_COLOR, lineColor);
ObjectSet(label, OBJPROP_STYLE, style);
ObjectSet(label, OBJPROP_WIDTH, 1);

}

void make_label(string sl,string l,int x,int y)
{
ObjectCreate("l"+sl, OBJ_LABEL, WindowsTotal()-1, 0, 0);
ObjectSetText("l"+sl, l , FontSize, "Verdana", FontColor);
ObjectSet("l"+sl, OBJPROP_CORNER, 0);
ObjectSet("l"+sl, OBJPROP_XDISTANCE, x);
ObjectSet("l"+sl, OBJPROP_YDISTANCE, y);
}
Your trade order needs to be in the right place at the right time.
  • #2
  • Jul 21, 2019 3:17pm Jul 21, 2019 3:17pm
Bumping this thread. It's a great indicator. easily the fastest way to position size I've seen.

I hope someone technical will come in and help as should be an easy fix.

If not, $30 on M5QL dot com freelance will get you a swift outcome.
  • #3
  • Jul 21, 2019 6:25pm Jul 21, 2019 6:25pm
Hi C-12,
I'm glad you like it, I find it invaluable.
I originally paid for the indicator to be written on M5QL of which the coder did a great job.
I have posted the code on FF because I know there are some great coders here that could modify / improve it.
Hopefully others will see the value of the indicator and help out.

Regards
Rob
Your trade order needs to be in the right place at the right time.
  • #4
  • Jul 22, 2019 3:00am Jul 22, 2019 3:00am
Quoting Islandfx911
Hi C-12, I'm glad you like it, I find it invaluable. I originally paid for the indicator to be written on M5QL of which the coder did a great job. I have posted the code on FF because I know there are some great coders here that could modify / improve it. Hopefully others will see the value of the indicator and help out. Regards Rob
I'm lining up work for one of my devs over the next couple of weeks. I'll see if I can tag this onto the order and will send it over.

If any dev on here fancies updating it then feel free to jump in.
  • #5
  • Jul 22, 2019 3:09am Jul 22, 2019 3:09am
That's very good of you.
Your trade order needs to be in the right place at the right time.
  • #6
  • Jul 25, 2019 2:59am Jul 25, 2019 2:59am
Just thought I bump this thread to see if anyone can have a go at amending the code. It should only be a minor code change.

The original request was different, (5-20 pip scale)
I would like the SL scale to range from 3 pips to 15 pips.

Anyone???

Regards
Rob
Your trade order needs to be in the right place at the right time.
  • #7
  • Edited 9:59pm Jul 25, 2019 5:57am | Edited 9:59pm
A one-off quick hack job by me, the .mq4 file is attached if a programmer wants to modify it further.
Use a non-proportional font if you want the lines to align correctly.

.mq4 will compile with a zillion errors unless you do this (https://www.forexfactory.com/showthread.php?p=10041710#post10041710) first, otherwise download .ex4 only.

Quoting C-12
Any possibility of adding the ability to save / load input settings? How about option for 10, 20, 30, 40, 50 pips SL?
I knew I should have stayed away!
Try the attached:
Attached Image (click to enlarge)
Click to Enlarge Name: PPI 213.png Size: 33 KB
Attached File(s)
File Type: ex4 size calc.ex4   318 KB | 364 downloads
File Type: mq4 size calc.mq4   5 KB | 325 downloads
  • #8
  • Jul 25, 2019 2:51pm Jul 25, 2019 2:51pm
Quoting hanover
A one-off quick hack job by me, mq4 is attached if programmer wants to modify further. Use a non-proportional font if you want lines to align correctly. .mq4 will compile with a zillion errors unless you do this (https://www.forexfactory.com/showthread.php?p=10041710#post10041710) first, otherwise download .ex4 only. {file} {file}
Excellent work hanover.

This works better, has more options and lines up better.

Any possibility of adding the ability to save / load input settings? How about option for 10, 20, 30, 40, 50 pips SL? Maybe for some people 1 pip increment is quite granular.

If that is extra hassle don't worry. It works great.
  • #9
  • Jul 26, 2019 1:17am Jul 26, 2019 1:17am
Quoting hanover
I knew I should have stayed away!
Hah, cheers for the extra tweaks! Even better now.
  • #10
  • Jul 26, 2019 2:09am Jul 26, 2019 2:09am
Thank you Hanover.
I appreciate your time and effort.
Indi looks great

Regards
Rob
Your trade order needs to be in the right place at the right time.
  • #11
  • Jul 27, 2019 5:56am Jul 27, 2019 5:56am
Hi Hanover,
Hate to be a pain but any chance you could delete the indi name (size calc) in the indi window as its overlapping text.
Regards
Rob
Your trade order needs to be in the right place at the right time.
  • #12
  • Jul 27, 2019 6:05am Jul 27, 2019 6:05am
Quoting Islandfx911
Hi Hanover, Hate to be a pain but any chance you could delete the indi name (size calc) in the indi window as its overlapping text. Regards Rob
I don't think it is possible. You can either rename indi to a single letter to minimise it.

Alternatively you can shift the text right and then up to get something like in this image.
Attached Image
  • #13
  • Jul 27, 2019 6:19pm Jul 27, 2019 6:19pm
Thanks C-12,
All sorted
Your trade order needs to be in the right place at the right time.
  • #14
  • Aug 10, 2019 6:08am Aug 10, 2019 6:08am
Anyone know why this doesn't calculate for some CHF pairs like CADCHF or AUDCHF? It's very odd as it works for USDCHF.
  • #15
  • Aug 21, 2019 8:43pm Aug 21, 2019 8:43pm
This is a great indi but I would like to see another option in terms of risk. currently it only calculates % .

Can it be modified to calculate lot size for a fixed dollar amount?
  • #16
  • Edited 2:23pm Aug 22, 2019 6:35am | Edited 2:23pm
Quoting C-12
Anyone know why this doesn't calculate for some CHF pairs like CADCHF or AUDCHF? It's very odd as it works for USDCHF.
Unable to reproduce error. Seems to work OK on AxiTrader MT4 build 1170. See screenshot.
Attached Image (click to enlarge)
Click to Enlarge Name: PPI 165.png Size: 73 KB


Quoting shrips
This is a great indi but I would like to see another option in terms of risk. currently it only calculates % . Can it be modified to calculate lot size for a fixed dollar amount?
Attached version allows Risk to be entered as either x% or $x
Attached File(s)
File Type: ex4 size calc.ex4   323 KB | 405 downloads
Attached File(s)
File Type: mq4 size calc.mq4   7 KB | 367 downloads


Quoting shrips
However I think the fixed dollar risk is in USD?
Not necessarily. It's whatever currency your account is denominated in, e.g. if the amounts that show in your Terminal (P/L, account equity, etc) are AUD, then the indicator assumes that the amount you enter into Risk is likewise AUD. I don't understand why anybody would want it to be anything else: if you want to place an amount at risk, surely you'd be talking in terms of your account equity, and whatever its currency is.

Forgot to mention: you can enter 2%E for 2% of account equity, 1.5%B for 1.5% of account balance, 3%F for 3% of free margin, etc. If there is no alpha character, it defaults to a percent of your account balance.
  • #17
  • Aug 22, 2019 9:21am Aug 22, 2019 9:21am
Quoting hanover
{quote} Unable to reproduce error. Seems to work OK on AxiTrader MT4 build 1170. See screenshot.{image} {quote} Attached version allows Risk to be entered as either x% or $x{file}{file}

Thanks hanover for the update. However I think the fixed dollar risk is in USD? Can it be for other currencies eg AUD or EUR?
  • #18
  • Aug 24, 2019 9:05pm Aug 24, 2019 9:05pm
Quoting hanover
{quote} Unable to reproduce error. Seems to work OK on AxiTrader MT4 build 1170. See screenshot.{image} {quote} Attached version allows Risk to be entered as either x% or $x{file}{file} {quote} Not necessarily. It's whatever currency your account is denominated in, e.g. if the amounts that show in your Terminal (P/L, account equity, etc) are AUD, then the indicator assumes that the amount you enter into Risk is likewise AUD. I don't understand why anybody would want it to be anything else: if you want to place an amount at risk, surely you'd be...

From what I can gather and please correct me if I am wrong but the fixed amount risk is working on the basis of 1 pip SL is 10 dollars (so thats why I assumed it was in USD). My account is in AUD and therefore it doesn't calculate that 1 pip (if trading a USD pair) to be approx 14 AUD.

It seems to work fine with the % risk
  • #19
  • Aug 25, 2019 6:28am Aug 25, 2019 6:28am
Quoting shrips
From what I can gather and please correct me if I am wrong......
Try the attached. I made a small change and ran it on a AUD-denominated demo account. I checked the result and I'm fairly sure that it's correct.

The formula is:
number_of_lots = amount_at_risk / SLpips / tickvalue, rounded down to the nearest 0.01 lots

where
tickvalue = 10 / AUDYYY_exchange_rate, for all XXXYYY pairs.

e.g. for GBPUSD, current AUDUSD_exchange_rate is 0.67509
hence tickvalue = 10 / 0.67509 = 14.8128
thus for amount_at_risk = $200, and SLpips = 15,
number_of_lots = 200 / 15 / 14.8128 = 0.9001, rounded down to 0.90 (see screenshot)
Attached Image (click to enlarge)
Click to Enlarge Name: PPI 172.png Size: 3 KB
Attached File(s)
File Type: ex4 size calc.ex4   324 KB | 435 downloads
Attached File(s)
File Type: mq4 size calc.mq4   7 KB | 469 downloads
My last post in this thread. I've done all that I can with this.
  • #20
  • Aug 26, 2019 7:43am Aug 26, 2019 7:43am
Quoting hanover
{quote} Try the attached. I made a small change and ran it on a AUD-denominated demo account. I checked the result and I'm fairly sure that it's correct. The formula is: number_of_lots = amount_at_risk / SLpips / tickvalue, rounded down to the nearest 0.01 lots where tickvalue = 10 / AUDYYY_exchange_rate, for all XXXYYY pairs. e.g. for GBPUSD, current AUDUSD_exchange_rate is 0.67509 hence tickvalue = 10 / 0.67509 = 14.8128 thus for amount_at_risk = $200, and SLpips = 15, number_of_lots = 200 / 15 / 14.8128 = 0.9001, rounded down to 0.90 (see screenshot){image}{file}{file}My...

thanks Hanover, works great now
0 traders viewing now