How to calculate maximum value of 10 or more variables | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Quick way to calculate PIP value in USD 2 replies

How to calculate the MTM value today of a 1-w forward contract sold 2 days ago? 0 replies

How to calculate the pip value for EUR/USD? 6 replies

calculate pip value, margin required 8 replies

Help me calculate the pip value for this 2 replies

How to calculate maximum value of 10 or more variables

  • #1
  • First Post: Jul 17, 2019 10:17am Jul 17, 2019 10:17am
Can someone help with adding array function or any other idea to check for highest value in last n candles for tales indicator?
I am using variables to store the value of each shift candle and calculating mathmax etc. But I want to pass a value in EA so that it will look for max/min value of n candles instead of writing mathmax for all the variable I save.

double SI(int buff,int shift){ return(iCustom(NULL,PERIOD_H4,"tales",buff,shift));} //indicator
double TalesU1=NormalizeDouble(SI(0,1),4);
double TalesU2=NormalizeDouble(SI(0,2),4);
double TalesU3=NormalizeDouble(SI(0,3),4);
double TalesU4=NormalizeDouble(SI(0,4),4);
double TalesU5=NormalizeDouble(SI(0,5),4);
double TalesU6=NormalizeDouble(SI(0,6),4);
double MaxU=NormalizeDouble((MathMax(TalesU2,TalesU3)),4);
double MaxU1=NormalizeDouble((MathMax(MaxU,TalesU4)),4);
Believe in your thesis and stick to the plan, don't get scared with moves
  • #2
  • Jul 17, 2019 11:03am Jul 17, 2019 11:03am
Inserted Code
#define max 6
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
double t[];
ArrayResize(t,max);
for(int i=0;i<max;i++) t[i]=NormalizeDouble(SI(0,i+1),4);
int  index = ArrayMaximum(t);
double maximum = t[index];
   return(rates_total);
  }
  • #3
  • Jul 17, 2019 11:31am Jul 17, 2019 11:31am
Quoting paulselvan
...
No need to copy values between arrays. ArrayMaximum() has parameters to specify begin and amount of values to inspect for the maximum.
It takes blood, sweat and enough tears to wash away the blood.
  • #4
  • Jul 17, 2019 12:10pm Jul 17, 2019 12:10pm
Quoting paulselvan
#define max 6 //+------------------------------------------------------------------+ //| Custom indicator iteration function | //+------------------------------------------------------------------+ int OnCalculate(const int rates_total, const int prev_calculated, const datetime &time[], const double &open[], const double &high[], const double &low[], const double &close[], const long &tick_volume[], const long &volume[], const int &spread[]) { double t[]; ArrayResize(t,max); for(int i=0;i<max;i++) t=NormalizeDouble(SI(0,i+1),4); int index = ArrayMaximum(t);...
I placed this code above void OnTick()

When I use the array t[1] in IF condition, it says undeclared identifier. Did I place the code in wrong place? How do I use the array to enter a trade?
Believe in your thesis and stick to the plan, don't get scared with moves
  • #5
  • Jul 17, 2019 12:15pm Jul 17, 2019 12:15pm
never mind, instead of OnCalculate,

I just used the rest of the code and it works. You are awesome brother.
Believe in your thesis and stick to the plan, don't get scared with moves
  • #6
  • Jul 17, 2019 1:45pm Jul 17, 2019 1:45pm
Do you know why the below code does not work and enter any trade? When I print, it prints the values correct for every candle.

double t[];
ArrayResize(t,Tmax);
for(int i=0;i<Tmax;i++) t[i]=NormalizeDouble(SI(0,i+1),4);
int index = ArrayMaximum(t);
double maximum = t[index];

if(t[0] > 2*maximum)
{
OrderSend(Symbol(),OP_SELL,1,price,3,stoploss,takeprofit,"My order",16384,0,clrGreen)
}
Believe in your thesis and stick to the plan, don't get scared with moves
  • #7
  • Jul 17, 2019 1:57pm Jul 17, 2019 1:57pm
Quoting akash14
double maximum = t[index];
if(t[0] > 2*maximum)
you know each element of t[] couldn't be greater than maximum
so how can t[0] > 2*maximum
  • #8
  • Last Post: Jul 17, 2019 2:36pm Jul 17, 2019 2:36pm
Quoting paulselvan
{quote} you know each element of t[] couldn't be greater than maximum so how can t[0] > 2*maximum
aaah my bad. I wanted to calculate t[0] > 2*max(t[1,2,.....10])
Believe in your thesis and stick to the plan, don't get scared with moves
0 traders viewing now