Newbie needs help with a logic idea

Quoting will.cyan259

Disliked

I want to close the last 2 trade of 0.32 and 0.16 when the sum of profit = $0

Ignored

Quoting Beerrun

Disliked

{quote} The sum of just those two orders or the sum of all the orders?

Ignored

Quoting will.cyan259

Disliked

{quote} sum only the last 2 biggest orders. Thanks beerrun again

Ignored

void LotSizes(){
  double biggest=0,second=0,sumB=0,sumS=0;
  int tktB=0,tktS=0,slip=1;
  for(int ord=OrdersTotal()-1;ord>=0;ord--){
   if(OrderSelect(ord,SELECT_BY_POS,MODE_TRADES))
    if(OrderSymbol()==Symbol()){
     if(OrderLots()>biggest){
      biggest=OrderLots();
      sumB=OrderProfit();
      tktB=OrderTicket();
      continue;}
     if(OrderLots()>second){
      second=OrderLots();
      sumS=OrderProfit();
      tktS=OrderTicket();}}}
  Print("Biggest Order Size "+DoubleToString(biggest,2));
  Print("Second Order Size "+DoubleToString(second,2));
  if(round((sumB+sumS)*100)*0.01==0)
   for(int clo=1,ticket=tktB;clo>=0;clo--,ticket=tktS){
    RefreshRates();
    if(OrderSelect(ticket,SELECT_BY_TICKET)){
     double price=(OrderType())?Ask:Bid;
     if(OrderClose(ticket,OrderLots(),price,slip)){
      Print("OrderClose #"+IntegerToString(ticket)+" Successful! Lotsize "+DoubleToString(OrderLots(),2));
      continue;}
     Print("OrderClose #"+IntegerToString(ticket)+" Unsuccessful! Error #"+IntegerToString(GetLastError()));
     continue;}
    Print("OrderSelect Failed! Ticket# "+IntegerToString(ticket));}}

Quoting Beerrun

Disliked

{quote} I didn't realize it was you when I responded lol Try this, added to the function from the other thread. For market orders only. void LotSizes(){ double biggest=0,second=0,sumB=0,sumS=0; int tktB=0,tktS=0,slip=1; for(int ord=OrdersTotal()-1;ord>=0;ord--){ if(OrderSelect(ord,SELECT_BY_POS,MODE_TRADES)) if(OrderSymbol()==Symbol()){ if(OrderLots()>biggest){ biggest=OrderLots(); sumB=OrderProfit(); tktB=OrderTicket(); continue;} if(OrderLots()>second){ second=OrderLots(); sumS=OrderProfit(); tktS=OrderTicket();}}} Print("Biggest Order Size "+DoubleToString(biggest,2));...

Ignored

Quoting will.cyan259

Disliked

{quote} Wow, thanks for that sharing. I will study your code carefully. Actually, I have done the code, it works pretty well but sometimes it closes only 1 order and left the other order run with error 130, I cannot find out the reason that why I think my logic is failed. So I come here to ask for the logic ^^. Firstly, I will study this code and give you feedback soon. Cheers, Will

Ignored

Quoting Beerrun

Disliked

{quote} This might be helpful https://book.mql4.com/appendix/errors .Error 130 means you are trying to place a stop that is an invalid price and that error is not applicable to OrderClose(). The best way to error check that is place a Print() statement right before your OrderSend() or OrderModify(): Print("Stoploss "+DoubleToString(SLvariable,Digits+2)+"/ Takeprofit "+DoubleToString(TPvariable,Digits+2)); -Perhaps the stop you are trying to place is in pips/points (ex 0.0004/0.00004), or an integer value (ex 40/4) -Or the value needs...

Ignored

if(round((sumB+sumS)*100)*0.01==0)

double price=(OrderType())?Ask:Bid

Quoting will.cyan259

Disliked

{quote} Hi Beerrun, I have study your code. It works pretty well so far. Hence, my EA has only 1 error which I cannot identify. It keeps placing the pending order and delete immediately after it places an order, and keep repeat it infinity. Do you know which possible error that make it like this? In my opinion, we could use Sleep() function that might help but I dont know where to put it correctly.

Ignored

Quote

Disliked

double price=(OrderType())?Ask:Bid
I understand that EA will select Bid or Ask price base on OP_BUY or OP_SELL but I dont understand how you write it

Quote

Disliked

In your code, I do not understand if(round((sumB+sumS)*100)*0.01==0) why you *100 and then *0.01, - To normalize value, I use NormalizeDouble() function, is that correct way? or I have to use Stoploss=round(Stoploss*_Point)/_Point; Sorry for my stupid question if it is. Thank you and have a nice weekend. {image}

Quoting DojiSan

Disliked

{quote} this happened to me just two days ago when I installed a new mt4.. it happened when my broker time on the platform was at 0. After that it went away..maybe also the fact that I increased the stop loss range helped.

Ignored

Quoting Beerrun

Disliked

{quote} Without seeing your code I cannot say exactly why, but it is not in the code I gave you; it is related to your OrderDelete() function. Adding in Sleep() is not fixing the problem; there is some logic in your code that is allowing it to delete the orders on the same tick. Perhaps you need to add in a return() after your order sending code. {quote} This is a ternary operator and it is like an if/else statement during a variable assignment. I should mention: this code will only work properly for market orders and should not be used if there...

Ignored

Quoting Beerrun

Disliked

{quote} Without seeing your code I cannot say exactly why, but it is not in the code I gave you; it is related to your OrderDelete() function. Adding in Sleep() is not fixing the problem; there is some logic in your code that is allowing it to delete the orders on the same tick. Perhaps you need to add in a return() after your order sending code. {quote} This is a ternary operator and it is like an if/else statement during a variable assignment. I should mention: this code will only work properly for market orders and should not be used if there...

Ignored

void CLOSEALL()
{
   for(int i=0;i<OrdersTotal();i++)
   {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
      if(OrderSymbol() == Symbol())
      if(OrderType() == OP_BUY || OrderType() == OP_SELL)
      {
         RefreshRates();
         OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),100,Red);
      }
      if( OrderType() == OP_BUYLIMIT ||
         OrderType() == OP_SELLLIMIT|| 
         OrderType() == OP_BUYSTOP  ||
         OrderType() == OP_SELLSTOP )
      {
         RefreshRates();
         OrderDelete(OrderTicket(),clrNONE);
      }
   }
}

Quoting will.cyan259

Disliked

for(int i=0;i<OrdersTotal();i++)

Ignored

Quote

Disliked

if(OrderSymbol() == Symbol()) if(OrderType() == OP_BUY || OrderType() == OP_SELL) {...} if( OrderType() == OP_BUYLIMIT || OrderType() == OP_SELLLIMIT|| OrderType() == OP_BUYSTOP || OrderType() == OP_SELLSTOP )

Quote

Disliked

OrderDelete(OrderTicket(),clrNONE); } } } It worked, but it shows the warning, the return value of OrderClose and OrderDelete should be checked

void CLOSEALL(){
   for(int i=OrdersTotal()-1;i>=0;i--)
    if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
     if(OrderSymbol()==Symbol()){
      RefreshRates();
      if(OrderType()==OP_BUY||OrderType()==OP_SELL)
       if(!OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),100,clrRed))
        Print("OrderClose Failed! Error# "+IntegerToString(GetLastError()));
      if(OrderType()>1&&OrderType()<6)
       if(!OrderDelete(OrderTicket()))
        Print("OrderDelete Failed! Error# "+IntegerToString(GetLastError()));}}

Quoting Beerrun

Disliked

{quote} Always count down your orders, otherwise you run the risk of skipping orders. There is a good explanation of it here https://www.mql5.com/en/forum/139654. And when counting down, don't forget to convert the order count to order positions by adding "-1" to OrdersTotal(). {quote} You need to wrap brackets {} around everything after your symbol check. When you don't use brackets then the if statement only controls the first line that comes after it; in this case the symbol check only applies to the first order type check (Buy/Sell),...

Ignored

Quoting Beerrun

Disliked

{quote} Always count down your orders, otherwise you run the risk of skipping orders. There is a good explanation of it here https://www.mql5.com/en/forum/139654. And when counting down, don't forget to convert the order count to order positions by adding "-1" to OrdersTotal(). {quote} You need to wrap brackets {} around everything after your symbol check. When you don't use brackets then the if statement only controls the first line that comes after it; in this case the symbol check only applies to the first order type check (Buy/Sell),...

Ignored

if(!OrderClose)(),
if(!OrderDelete)()

Quoting will.cyan259

Disliked

{quote} Hi Beerrun, I have 1 stupid question about your code. Why we use if(!OrderClose)(), if(!OrderDelete)() As my understanding, it means "if NOT OrderClose()". I dont understand how "!" put here can close & delete order.

Ignored

Quoting Beerrun

Disliked

{quote} Its not a stupid question buddy. The "!" means if the expression is not true. OrderClose and OrderDelete are bool type functions, they return either true or false. When written like this the OrderClose function is still called, but if it returns true it will not go to the next line. So here we are saying if OrderClose returns not true then print the fail message. The opposite of this is how OrderSelect is written, if OrderSelect returns true then go to the next line.

Ignored

Quoting will.cyan259

Disliked

{quote} And if OrderClose return true, it will execute the OrderClose with price, lots, and ticket in the bracket. Everything is clear now. I will rewrite my EA for a clean code. Thank you a lot.

Ignored

Quoting Beerrun

Disliked

{quote} Not quite; whether OrderClose actually succeeded or failed is what is returned true or false. The OrderClose is executed inside of the if statement. So if(!OrderClose(ticket,lots,price,slippage,colour)) will attempt to close the order, if it fails it will return false, then it will go to the next line.

Ignored

//+------------------------------------------------------------------+
//|                                                  My Test EA .mq4 |
//|                                     MQL4 tutorial on quivofx.com |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright ""
#property link      ""
#property version   "4.00"
#property strict
 
//--- input parameters
extern bool          Auto_trade     = false;
input int            TakeProfit=20;
input int            StopLoss=10;
input double         FirstLot=0.1;
input double         Lot_Multiplier = 2;
input int            Slippage=3;
input int            MagicNumber=5555;
input double         Profit_target= 20;
 
//--- global variables
double MyPoint;
int    MySlippage;
 
 
//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit()
  {
//---
   MyPoint = MyPoint();
   MySlippage = MySlippage();
  
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
//---
  
  }
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
  {
//---
       Comment(StringFormat("Show info\nnext_lot = %G\nprofit_Am = %G",
       NormalizeDouble(next_lot,2),
       NormalizeDouble(profit_bracket,2)));
      
   if(TotalOpenOrders() == 0 && IsNewBar() == true)
   {
 
  
      // Check Buy Entry
      if(BuySignal() == true && Auto_trade == true)
         {
            OpenBuy();
         }
      
      // Check Sell Entry
      else if(SellSignal() == true && Auto_trade == true)
         {
            OpenSell();
         }  
   }
   ProfitEachOrder();
   if(TotalPendingOrders()>0)
   {
      delete_pending();
   }
  }
 
//+------------------------------------------------------------------+
//| Custom functions                                                 |
//+------------------------------------------------------------------+
 
 
// Initialize Indicators
 
// Buy Logic
bool BuySignal()
{
   if(Open[2] > Close[2] &&
      Open[1] < Close[1] &&              
      High[2] < High[1]  &&            // Buy and sell logic base on Engulfing strategy
      Low[2]  > Low[1]   &&
      Close[1]> Open[2])
   {
      return(true);
   }
   else
   {
      return(false);
   }
}
 
 
// Sell Logic
bool SellSignal()
{
   if(Open[2] < Close[2] &&
      Open[1] > Close[1] &&
      High[2] < High[1]  &&
      Low[2]  > Low[1]   &&
      Close[1]< Open[2])
   {
      return(true);
   }
   else
   {
      return(false);
   }
}
 
 
// Open Buy Order
void OpenBuy()
{
   // Open Buy Order
   int ticket = OrderSend(_Symbol,OP_BUY,FirstLot,Ask,MySlippage,0,0,"BUY",MagicNumber);
      
      if(ticket<0)
      {
         Print("OrderSend failed with error #",GetLastError());
      }
      else
      {
         Print("OrderSend placed successfully");
      }
                
   // Modify Buy Order
   bool res = OrderModify(ticket,OrderOpenPrice(),Ask-StopLoss*MyPoint,Ask+TakeProfit*MyPoint,0);
      
      if(!res)
      {
         Print("Error in OrderModify. Error code=",GetLastError());
      }
      else
      {
         Print("Order modified successfully.");
      }
}
 
 
// Open Sell Order
void OpenSell()
{
   //Open Sell Order
   int ticket = OrderSend(_Symbol,OP_SELL,FirstLot,Bid,MySlippage,0,0,"SELL",MagicNumber);
      
      if(ticket<0)
      {
         Print("OrderSend failed with error #",GetLastError());
      }
      else
      {
         Print("OrderSend placed successfully");
      }
                
   // Modify Sell Order
   bool res = OrderModify(ticket,OrderOpenPrice(),Bid+StopLoss*MyPoint,Bid-TakeProfit*MyPoint,0);
      
      if(!res)
      {
         Print("Error in OrderModify. Error code=",GetLastError());
      }
      else
      {
         Print("Order modified successfully.");
      }    
}
 
  
// Get My Points   for 3 digits broker or 5 digits broker.
double MyPoint()
{
   double CalcPoint = 0;
  
   if(_Digits == 2 || _Digits == 3) CalcPoint = 0.01;
   else if(_Digits == 4 || _Digits == 5) CalcPoint = 0.0001;
  
   return(CalcPoint);
}
 
 
// Get My Slippage
int MySlippage()
{
   int CalcSlippage = 0;
  
   if(_Digits == 2 || _Digits == 4) CalcSlippage = Slippage;
   else if(_Digits == 3 || _Digits == 5) CalcSlippage = Slippage * 10;
  
   return(CalcSlippage);
}
 
  
// Check if there is a new bar
bool IsNewBar()  
{        
   static datetime RegBarTime=0;
   datetime ThisBarTime = Time[0];
      
   if (ThisBarTime == RegBarTime)
   {
      return(false);
   }
   else
   {
      RegBarTime = ThisBarTime;
      return(true);
   }
}  
 
  
// Returns the number of total open orders for this Symbol and MagicNumber
int TotalOpenOrders()
{
   int total_orders = 0;
  
   for(int order = 0; order < OrdersTotal(); order++)
   {
      if(OrderSelect(order,SELECT_BY_POS,MODE_TRADES)==false) break;
      
      if(OrderSymbol() == _Symbol)
         {
            total_orders++;
         }
   }
  
   return(total_orders);
}
 
//----Martingale----//
 
   double next_lot = 0.0;
   double profit_bracket=0;
   int PendingTicket=0;
void ProfitEachOrder(){
   double profit_total=0;
   for(int i=OrdersHistoryTotal()-1; i >= 0; i--)
  {
      if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)){   //check history
      string ordSym=OrderSymbol();                    
      int ordType=OrderType();
      datetime ordTime=OrderOpenTime();
      double ordLot=OrderLots();
      double ordOp=OrderOpenPrice();
      int ordMag=OrderMagicNumber();
      int ordTicket=OrderTicket();
      double ordProfit=OrderProfit();
 
         if(ordSym==Symbol() && ordProfit <0){
            profit_total+=OrderProfit();}             // find all sum of order profit <0
              
         Print("profit history total "+DoubleToString(profit_total,2)); // PERFECT DISPLAY
      }
     }
  
  /* // calculate next lot
   double spread =  MarketInfo(_Symbol,MODE_SPREAD);
   double tickvalue  = MarketInfo(_Symbol,MODE_TICKVALUE);                        //--Dont need to care about this section
   double ticksize = MarketInfo(_Symbol,MODE_TICKSIZE);
   RefreshRates();
   next_lot = (Profit_target + MathAbs(profit_total))*tickvalue/(TakeProfit);
   next_lot = NormalizeDouble(next_lot,2); */
  
   //--PLACE HEDGE ORDER--/
   double lastSL =0.0, lastProfit=0.0, lastLot=0.0;
   int    lastType=0;
   datetime lastTime =0;
   int PendingType =0;
   double PendingPrice =0.0;
   double PendingLot = 0.0;
 
   for(int i=OrdersTotal()-1; i >= 0; i--)
  {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)){
      string ordSym=OrderSymbol();
      int ordType=OrderType();
      datetime ordTime=OrderOpenTime();
      double ordLot=OrderLots();
      double ordOp=OrderOpenPrice();
      int ordMag=OrderMagicNumber();
      int ordTicket=OrderTicket();
      double ordProfit=OrderProfit();
      double ordTp=OrderTakeProfit();
      double ordSL=OrderStopLoss();
         if(ordSym==Symbol() && ordTime>lastTime && OrderType()<=1)   //get last order SL, Type, Lot
         {
            lastTime=ordTime;
            lastSL = ordSL;
            lastType = ordType;
            lastLot = ordLot;
         }
   //----Get pending ticket ----//
         if(ordSym==Symbol() && OrderType()>=4){         // get pending order SL, Type, Lot, Ticket
            PendingType=ordType;
            PendingPrice=ordOp;
            PendingLot=ordLot;
            PendingTicket=ordTicket;
            }
  Print("PendingPrice "+DoubleToString(PendingPrice,Digits));
  Print("PendingLot "+DoubleToString(PendingLot,2));
  Print("PendingType "+IntegerToString(PendingType,0));
  Print("PendingTicket "+IntegerToString(PendingTicket,0));  
   //Calculate martingale lot
   next_lot = lastLot * Lot_Multiplier;               // Calculate Lotsize for next order.
   next_lot = NormalizeDouble(next_lot,2);
      
   RefreshRates();
   if(lastType == OP_BUY && TotalPendingOrders()==0)  // place Sell stop order at SL of previous order,
   {
      if(!OrderSend(_Symbol,OP_SELLSTOP,next_lot,ordSL,Slippage,ordSL+StopLoss*MyPoint,ordSL-TakeProfit*MyPoint,"SELLSTOP",0))        
      Print("Order SELLSTOP Failed! Error# "+IntegerToString(GetLastError()));
   }
   if(lastType == OP_SELL && TotalPendingOrders()==0) // place Buy stop order at SL of previous order,
   {
      if(!OrderSend(_Symbol,OP_BUYSTOP,next_lot,ordSL,Slippage,ordSL-StopLoss*MyPoint,ordSL+TakeProfit*MyPoint,"BUYSTOP",0))        
      Print("Order BUYSTOP Failed! Error# "+IntegerToString(GetLastError()));
   }
}
}
}  
 
//Get total Pending order
int TotalPendingOrders(){
   int total=0;
   for(int i=OrdersTotal()-1; i >= 0; i--)
  {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)){
      
      string ordsymB  = OrderSymbol();
      int ordtypeB    =OrderType();      
         if(ordsymB==Symbol() && ordtypeB>=4){
            total++;
            }
         }
  }
return (total);
}
  //---Delete the pending order if TP hit.---//
void delete_pending()
{
   datetime CurrTime =TimeCurrent();  
      for(int h=OrdersHistoryTotal()-1; h >= 0; h--)
        {
            if(OrderSelect(h,SELECT_BY_POS,MODE_HISTORY)){     // H stand for History.
            string HSym=OrderSymbol();
            int HType=OrderType();
            datetime HTime=OrderCloseTime();
            double HLot=OrderLots();
            double HOp=OrderOpenPrice();
            int HMag=OrderMagicNumber();
            int HTicket=OrderTicket();
            double HProfit=OrderProfit();        
         if(HProfit > 0 && HTime==CurrTime )
         {
            RefreshRates();
            if(!OrderDelete(PendingTicket))
            Print("OrderDelete Pending Failed! Error# "+IntegerToString(GetLastError()));
            break;}
         }  
    }
}
 
/* Place hedge order ok
delete order ok
calculate volume !OK */