Open: Button, Close: MA Cross | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Open/close cross 282 replies

5min open/close ma cross 39 replies

Alert for Ema Open-Close Cross 0 replies

Close all trades with a push of a button? 1 reply

Confessions of a compulsive close-button clicker 10 replies

Attachments: Open: Button, Close: MA Cross
Exit Attachments

Open: Button, Close: MA Cross

  • #1
  • First Post: Mar 23, 2019 12:06pm Mar 23, 2019 12:06pm
Hey guys,
I have this simple EA that successfully opens a trade when the onchartevent buy/sell button is clicked on. That's all great and it's nice to have a big green/red button for that quick scalp with a set SL/TP.

I've dug around and can find lots of EA's that open and close on a MA cross, but when I hack out the close code into this buttontrader, it just never seems to work. I feel like I'm missing something minor but can't figure it out!

So I'm trying to get a trade to close when two MA's cross. Any ideas?
Attached File(s)
File Type: mq4 buttontrader.mq4   4 KB | 405 downloads
  • #2
  • Mar 23, 2019 1:07pm Mar 23, 2019 1:07pm
Quoting Rgb-dj
Hey guys, I have this simple EA that successfully opens a trade when the onchartevent buy/sell button is clicked on. That's all great and it's nice to have a big green/red button for that quick scalp with a set SL/TP. I've dug around and can find lots of EA's that open and close on a MA cross, but when I hack out the close code into this buttontrader, it just never seems to work. I feel like I'm missing something minor but can't figure it out! So I'm trying to get a trade to close when two MA's cross. Any ideas? {file}
Could you be more specific about what doesn’t work?
  • #3
  • Mar 23, 2019 2:00pm Mar 23, 2019 2:00pm
The buttons work perfectly, now I'm trying to get the order to close on a MA cross.

I hacked some closing code (see the attached) but it just doesn't close on a cross.
Attached File(s)
File Type: mq4 buttontrader-v2.mq4   6 KB | 377 downloads
  • #4
  • Mar 23, 2019 5:50pm Mar 23, 2019 5:50pm
Quoting Rgb-dj
The buttons work perfectly, now I'm trying to get the order to close on a MA cross. I hacked some closing code (see the attached) but it just doesn't close on a cross. {file}
I dont know why you have the checktoclose function as well as the switch in your start. But I cleaned it up as best I can. Count loops down starting from the total and finishing at 0.
Attached File(s)
File Type: mq4 buttontrader-v2.mq4   5 KB | 482 downloads
  • #5
  • Mar 23, 2019 10:52pm Mar 23, 2019 10:52pm
Quoting Beerrun
{quote} I dont know why you have the checktoclose function as well as the switch in your start. But I cleaned it up as best I can. Count loops down starting from the total and finishing at 0. {file}
Thanks Beerrun! The code looks soooo clean and organized now, it’s a beautiful thing. Going to test it out Sunday evening and let you know how it runs.

I picked up the checktoclose from a different post on the forum, so I copied and pasted and altered as best as I could. I hit a limit with my coding abilities though, so I’m going to compare my version and yours and educate myself on the difference. Every bit helps!
  • #6
  • Mar 23, 2019 11:58pm Mar 23, 2019 11:58pm
Thanks for sharing. Regards
  • #7
  • Mar 25, 2019 9:41am Mar 25, 2019 9:41am
Just an update: script runs and works perfect! Thanks Beerrun!
  • #8
  • Mar 25, 2019 10:05am Mar 25, 2019 10:05am
Quoting Rgb-dj
Just an update: script runs and works perfect! Thanks Beerrun!
No problem buddy but I just cleaned it up, didn’t do much fixing, so I worry you might run into issues eventually.
  • #9
  • Apr 16, 2019 1:39am Apr 16, 2019 1:39am
Quoting Beerrun
{quote} I dont know why you have the checktoclose function as well as the switch in your start. But I cleaned it up as best I can. Count loops down starting from the total and finishing at 0. {file}
sorry to say, needs more work, using 20 TP or SL is only 2 pips on Yen pairs, any programmer would know about decimal situation

thanks
It takes a lot for me to IGNORE you, but you can try.
  • #10
  • Apr 16, 2019 1:55am Apr 16, 2019 1:55am
Quoting Beerrun
{quote} No problem buddy but I just cleaned it up, didn’t do much fixing, so I worry you might run into issues eventually.
may as well remove, it's useless the way it is

it get the SL and TP wrong way around for selling, how hard can that be....

warning to future readers, move along, don't bother
It takes a lot for me to IGNORE you, but you can try.
  • #11
  • Apr 16, 2019 2:07am Apr 16, 2019 2:07am
Quoting Erebus
{quote} may as well remove, it's useless the way it is it get the SL and TP wrong way around for selling, how hard can that be.... warning to future readers, move along, don't bother
Erebus are u a coder?
  • #12
  • Apr 16, 2019 5:19am Apr 16, 2019 5:19am
Quoting Erebus
{quote} may as well remove, it's useless the way it is it get the SL and TP wrong way around for selling, how hard can that be.... warning to future readers, move along, don't bother
You can read right?? I am not the author of that mq4 file, I literally just removed empty spaces from the code and changed the direction of one loop. Stop quoting me saying it’s bad, it’s not my program... it’s not that hard...
  • #13
  • Apr 16, 2019 5:43am Apr 16, 2019 5:43am
Quoting Erebus
{quote} sorry to say, needs more work, using 20 TP or SL is only 2 pips on Yen pairs, any programmer would know about decimal situation thanks
This thread is for Rgb-dj to learn some coding. And you come in here and apparently don’t read any post before downloading and then criticizing his program by way of me. If you are a coder then help him learn. If you aren’t and cannot offer anything helpful, then silence is your better option.
  • #14
  • Apr 16, 2019 11:53pm Apr 16, 2019 11:53pm
Quoting Beerrun
{quote} This thread is for Rgb-dj to learn some coding. And you come in here and apparently don’t read any post before downloading and then criticizing his program by way of me. If you are a coder then help him learn. If you aren’t and cannot offer anything helpful, then silence is your better option.
very good, thanks

actually, it's fine for 1 to 1 trades
It takes a lot for me to IGNORE you, but you can try.
  • #15
  • Last Post: Apr 17, 2019 12:26am Apr 17, 2019 12:26am
Quoting Rgb-dj
Just an update: script runs and works perfect! Thanks Beerrun!
Dear Rgb-dj,

To get around the decimal points situation as mentioned by Erebus, just replace the ".0001" with "Point". Beerrun, thank you for helping Rgb-dj with the code
Note: This should fix the JPY issue, but for gold it is still likely that to get 20 pips you will need to *10 (200 on gold = 20 pips ).

"Point
Returns the point size of the current symbol in the quote currency.
double Point(); " MQL4 reference

Kind Regards,
Tzamo
"Work hard, put in the effort, and follow your dreams..." -Me
0 traders viewing now