Help needed to fix 'Divide by zero' error | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need help to solve "zero divide error" 7 replies

Divide by zero error? 2 replies

Zero Divide Error 4 replies

Zero Divide error? Where do I need to look to fix it? 28 replies

Zero Divide Error 5 replies

Attachments: Help needed to fix 'Divide by zero' error
Exit Attachments

Help needed to fix 'Divide by zero' error

  • #1
  • First Post: Edited 11:42am Jan 12, 2019 10:56am | Edited 11:42am
Trying to create an indicator that will make some candle in another color, but nothing happens when i put it on the chart.

Can see i get a divide by zero error in line 74 in the code, but not sure how to fix it.

Want to mark up candles where the body of the candle is less than 50% of the whole (high to low) candle

Inserted Code
//+------------------------------------------------------------------+
//|                                                      eCandle.mq4 |
//|                        Copyright 2019, MetaQuotes Software Corp. |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2019, MetaQuotes Software Corp."
#property link      "https://www.mql5.com"
#property version   "1.00"
#property strict
#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 clrOrange
#property indicator_color2 clrOrange
#property indicator_width1 5
#property indicator_width2 5
double BodyHigh[],BodyLow[];
      double BodyRange = 0;
 
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- indicator buffers mapping
   SetIndexBuffer(0,BodyHigh);
   SetIndexBuffer(1,BodyLow);
   SetIndexStyle(0,DRAW_HISTOGRAM);
   SetIndexStyle(1,DRAW_HISTOGRAM);
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
//---
   for(int i = MathMax(Bars-2-IndicatorCounted(),1); i>=0;i--)
   {
      double hi=high[i], lo=low[i], prevhi=high[i+1], prevlo=low[i+1];
      double bodyhigh=MathMax(close[i], open[i]);
      double bodylow=MathMin(close[i], open[i]);
      
      // Markup candles where the body of the candle is less than 50% of the whole (high to low) candle  
      double CandleRange = hi - lo;    
      double pCandle = (BodyRange / CandleRange)*100;
      if (pCandle < 50)
      //if(hi>prevhi&&lo<prevlo)
      {
         BodyHigh[i]=bodyhigh;
         BodyLow[i]=bodylow;
      }
      
      //This code work if i want to mark up outside candles
      //double hi=high[i], lo=low[i], prevhi=high[i+1], prevlo=low[i+1];
      //double bodyhigh=MathMax(close[i], open[i]);
      //double bodylow=MathMin(close[i], open[i]);
      //if(hi>prevhi&&lo<prevlo)
      //{
      //   BodyHigh[i]=bodyhigh;
      //   BodyLow[i]=bodylow;
      //}      
      
   }
//--- return value of prev_calculated for next call
   return(rates_total);
  }
//+------------------------------------------------------------------+
Blindly following others will make you blind!
  • #2
  • Jan 12, 2019 12:32pm Jan 12, 2019 12:32pm
Check the values of BodyRange and CandleRange.. can they be zero at any time?

Nothing can be divided by zero so i assume thats the error. you can make a condition like this to avoid this ... just an idea :

Inserted Code
if (BodyRange > 0 && CandleRange > 0)
      pCandle = BodyRange / CandleRange*100;
      else{
      pCandle = 0;
      }
@fauzaanu on Telegram
  • #3
  • Jan 12, 2019 12:42pm Jan 12, 2019 12:42pm
That helped on the divide by zero, but still something wrong, cause it paints on all candles

Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 32 KB


Inserted Code
//+------------------------------------------------------------------+
//|                                                      eCandle.mq4 |
//|                        Copyright 2019, MetaQuotes Software Corp. |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2019, MetaQuotes Software Corp."
#property link      "https://www.mql5.com"
#property version   "1.00"
#property strict
#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 clrOrange 
#property indicator_color2 clrOrange

double BodyHigh[],BodyLow[];
      double BodyRange = 0;
      double CandleRange = 0;
      double pCandle = 0;
      int width=18;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- indicator buffers mapping
   //SetIndexBuffer(0,BodyHigh);
   //SetIndexBuffer(1,BodyLow);
   //SetIndexStyle(0,DRAW_HISTOGRAM);
   //SetIndexStyle(1,DRAW_HISTOGRAM);
   
   width = (int) ChartGetInteger(0,CHART_SCALE);
   SetIndexBuffer(0,BodyHigh);
   SetIndexStyle(0, DRAW_HISTOGRAM, EMPTY, width);  
   SetIndexBuffer(1,BodyLow);
   SetIndexStyle(1, DRAW_HISTOGRAM, EMPTY, width);
   
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
  if(ChartGetInteger(0,CHART_SCALE) != width)  OnInit();
//---
   for(int i = MathMax(Bars-2-IndicatorCounted(),1); i>=0;i--)
   {
      double hi=high[i], lo=low[i], prevhi=high[i+1], prevlo=low[i+1];
      double bodyhigh=MathMax(close[i], open[i]);
      double bodylow=MathMin(close[i], open[i]);
      if (BodyRange > 0 && CandleRange > 0)
      pCandle = (BodyRange/CandleRange)*100;
      else{
      pCandle = 0;
      }
      
      if (pCandle < 10)
      {
       BodyHigh[i]=bodyhigh;
       BodyLow[i]=bodylow;
      }   
      
   }
//--- return value of prev_calculated for next call
   return(rates_total);
  }
//+------------------------------------------------------------------+
Blindly following others will make you blind!
  • #4
  • Jan 12, 2019 2:18pm Jan 12, 2019 2:18pm
Sigh. At least you're trying to code rather than asking someone else to do it for free. For that, you get my (limited) help today...

Regarding divide-by-zero: Once you know the line number, look only at the denominator, and see why it is zero. (The denominator is the divisor, a.k.a the bottom of the fraction). In your case, it's "CandleRange".

Use an "if/else" statement: If CandleRange != 0.0, do the division. Else bypass the division and *substitute* in whatever value you want it to assume.

But look at your code? What value is "CandleRange"? For that matter, what is the value of "BodyRange"?

You initialized them as "0" but never set them again!

Obviously you need two basic lines to calculate CandleRange and BodyRange.

If you were to run this code on a live chart, it may well meet the criteria to flag the candle body, but then later on, the body might grow larger and no longer meet the criteria. Your code only *sets* the buffers to hi/lo values. Nowhere to you set them back to "EMPTY_VALUE", but I added code to do so.


Beyond that, throughout your code, for everywhere that you are calculating/setting/compare double values, *always* include the decimal for *every* double number! Therefore, for a double, use "0.0" not "0". Use "*100.0", and not "*100". Integer math can cause surprising (wrong) results which are not always obvious. Avoid doing integer math by specifying numbers as doubles, then it will keep the precision as you would expect your code to do.


I coded your "10.0" threshold as a external variable, as well as the body color, to make it easy to use on charts with various colors.

Inserted Code
//+------------------------------------------------------------------+
//|                                                      eCandle.mq4 |
//|                        Copyright 2019, Georgebaker               |
//+------------------------------------------------------------------+
#property copyright "Copyright 2019, Georgebaker of ForexFactory.com"
#property link      "https://www.forexfactory.com/Georgebaker"
#property version   "1.01"
#property strict
#property indicator_chart_window
#property indicator_buffers 2
//#property indicator_color1 clrOrange // This color is set further below!
//#property indicator_color2 clrOrange
extern string INFO__v1_01  = "";
extern double Flag_Body_To_Range_Below_percent = 10.0;
extern color  UseColor = clrOrange;
double BodyHigh[],BodyLow[];
      double BodyRange = 0.0; // For all values/calculations/expressions that involve 'double' vars, *always* include the decimal
      double CandleRange = 0.0;
      d ouble pCandle = 0.0;
      int width=18;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- indicator buffers mapping
   //SetIndexBuffer(0,BodyHigh);
   //SetIndexBuffer(1,BodyLow);
   //SetIndexStyle(0,DRAW_HISTOGRAM);
   //SetIndexStyle(1,DRAW_HISTOGRAM);
  
   // A possible disadvantage to calculate 'width' this way is it does it one time only, based on the CHART_SCALE only upon initialization.  Perhaps think of a better way, or hardcode the value.
   width = (int) ChartGetInteger(0,CHART_SCALE);
  
   SetIndexBuffer(0,BodyHigh);
   SetIndexStyle(0, DRAW_HISTOGRAM, EMPTY, width, UseColor);  
   SetIndexBuffer(1,BodyLow);
   SetIndexStyle(1, DRAW_HISTOGRAM, EMPTY, width, UseColor);
   SetIndexLabel(0,WindowExpertName()+" BodyHi");
   SetIndexLabel(1,WindowExpertName()+" BodyLo");
   IndicatorDigits(Digits);
  
  
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
  if(ChartGetInteger(0,CHART_SCALE) != width)  OnInit();
//---
   int limit = MathMax(Bars-2-IndicatorCounted(),1);
   for(int i=limit; i>=0;i--)
   {
      double hi=high[i], lo=low[i], prevhi=high[i+1], prevlo=low[i+1];
      double bodyhigh=MathMax(close[i], open[i]);
      double bodylow=MathMin(close[i], open[i]);
      // Unlike previous version, the 'BodyRange' and 'CandleRange' are now actually calculated.
      BodyRange = bodyhigh - bodylow;
      CandleRange = hi - lo;
      if (CandleRange != 0.0) pCandle = (BodyRange/CandleRange)*100.0;
      else
      {
         pCandle = 0.0; // Use this if you want to flag O=H=L=C candles. HOWEVER, the body will be zero width, and possibly invisible. (But buffers will be set).
         //pCandle = 100.0; // Use this if you DO NOT want to flag O=H=L=C candles
      }
      if (pCandle <= Flag_Body_To_Range_Below_percent)
      {
       BodyHigh[i]=bodyhigh;
       BodyLow[i]=bodylow;
      }  
      else
      {
       // If candle is not marked, set the buffers back to EMPTY_VALUE
       BodyHigh[i]=EMPTY_VALUE;
       BodyLow[i]=EMPTY_VALUE;
      }
      
   }
//--- return value of prev_calculated for next call
   return(rates_total);
  }
//+------------------------------------------------------------------+

Any further features are up to you...

Pips4life
Attached File(s)
File Type: mq4 eCandle.mq4   4 KB | 436 downloads
  • #5
  • Edited 5:02pm Jan 12, 2019 4:52pm | Edited 5:02pm
Thank you pips4life for all the explanation inside and outside the code
Blindly following others will make you blind!
  • #6
  • Last Post: Jan 13, 2019 5:20am Jan 13, 2019 5:20am
Arghh i give up. Cannot get it to work correctly
Blindly following others will make you blind!
0 traders viewing now