iHighest - 2nd highest candle in the last X candles | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

MQL4 code: iHighest 11 replies

iHighest iLowest Clarification 4 replies

iHighest code problem 6 replies

Help with using iHighest in an indicator 9 replies

Exiting Trades on iLowest and iHighest 7 replies

iHighest - 2nd highest candle in the last X candles

  • #1
  • First Post: Dec 29, 2018 12:33pm Dec 29, 2018 12:33pm
Hi friends, Happy Holidays! I wrote a function to find the 2nd highest value in the last X bars like this:

void secondHighestValue()
{

for(int n=0;n<=maxBars;n++)
{
if((High[iHighest(NULL,0,MODE_HIGH,maxBars,n)] < highestValue) && (High[iHighest(NULL,0,MODE_HIGH,maxBars,n)] > thirdHighest))
{
secondHighest = High[iHighest(NULL,0,MODE_HIGH,maxBars,n)];
}

}
}

Is there an easier or more efficient way to do this? i.e. find the 2nd or 3rd etc highest candle value.

Thanks guys!
  • #2
  • Dec 29, 2018 9:21pm Dec 29, 2018 9:21pm
Quoting bientos
...Is there an easier or more efficient way to do this?...
Sure. You shouldn't use a loop for it.
Inserted Code
/**
 * Resolve the price of the second highest high over a number of bars.
 *
 * @param  int - number of bars to inspect
 *
 * @return double - price of the second highest high
 */
double secondHighestHigh(int bars) {
   if (bars < 2) return(0);
   int iFirstHigh = iHighest(NULL, NULL, MODE_HIGH, bars, 0);
   double olderHigh = 0, youngerHigh = 0;
   if (iFirstHigh < bars-1) olderHigh   = High[iHighest(NULL, NULL, MODE_HIGH, bars-iFirstHigh-1, iFirstHigh+1)];
   if (iFirstHigh >      0) youngerHigh = High[iHighest(NULL, NULL, MODE_HIGH, iFirstHigh,        0           )];
   return(MathMax(olderHigh, youngerHigh));
}
It takes blood, sweat and enough tears to wash away the blood.
  • #3
  • Last Post: Dec 29, 2018 11:18pm Dec 29, 2018 11:18pm
Quoting emmzett
{quote} Sure. You shouldn't use a loop for it. /** * Resolve the price of the second highest high over a number of bars. * * @param int - number of bars to inspect * * @return double - price of the second highest high */ double secondHighestHigh(int bars) { if (bars < 2) return(0); int iFirstHigh = iHighest(NULL, NULL, MODE_HIGH, bars, 0); double olderHigh = 0, youngerHigh = 0; if (iFirstHigh < bars-1) olderHigh = High[iHighest(NULL, NULL, MODE_HIGH, bars-iFirstHigh-1, iFirstHigh+1)]; if (iFirstHigh > 0) youngerHigh = High[iHighest(NULL, NULL, MODE_HIGH,...
Wow, thanks Emmzett! Your solution is clean and elegant. Much appreciated and wish you best!
0 traders viewing now