return value of 'OrderSelect' should be checked - Help Please | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Help with 'return value of 'OrderSend' should be checked' 3 replies

orderselect problem 1 reply

OrderSelect by comment 5 replies

Can't get OrderSelect() to find order automatically 2 replies

OrderSelect() Index Problem 3 replies

return value of 'OrderSelect' should be checked - Help Please

  • #1
  • First Post: Nov 23, 2018 1:23pm Nov 23, 2018 1:23pm
Hello, I have a couple of Warnings" return value of 'OrderSelect' should be checked "

I have tried various code changes yet without success, all help appreciated

1st -----------------------

if((BuyTicket > 0) && ((Current_TP > 0) || (Current_SL > 0)))
{
OrderSelect(BuyTicket,SELECT_BY_TICKET);

double OpenPrice = OrderOpenPrice();

2nd -----------------------

int TotalOrderCount(string argSymbol, int argMagicNumber)
{
int OrderCount;
for(int Counter = 0; Counter <= OrdersTotal()-1; Counter++)
{
OrderSelect(Counter,SELECT_BY_POS);
if(OrderMagicNumber() == argMagicNumber && OrderSymbol() == argSymbol)
{
OrderCount++;
}
}
return(OrderCount);
}

-----------------------
  • #2
  • Nov 23, 2018 2:57pm Nov 23, 2018 2:57pm
1st -----------------------
if((BuyTicket > 0) && ((Current_TP > 0) || (Current_SL > 0))){
int check = OrderSelect(BuyTicket,SELECT_BY_TICKET);

if (check == true) double OpenPrice = OrderOpenPrice();
else Print("OrderSelect returned the error of ",GetLastError());
}

2nd -----------------------

int TotalOrderCount(string argSymbol, int argMagicNumber)
{
int OrderCount;
for(int Counter = 0; Counter <= OrdersTotal()-1; Counter++)
if (OrderSelect(Counter,SELECT_BY_POS) == true) {if(OrderMagicNumber() == argMagicNumber && OrderSymbol() == argSymbol) OrderCount++;}
else Print("OrderSelect returned the error of ",GetLastError());


return(OrderCount);
}
  • #3
  • Nov 23, 2018 5:22pm Nov 23, 2018 5:22pm
Thank you Paul, that helped greatly, many Warnings corrected, yet not sure how to correct this warning " return value of 'OrderSelect' should be checked "

int LastOrderTime(string argSymbol,int argMagicNumber)
{
datetime LastOrder; //
for(int Counter=0; Counter<=OrdersTotal()-1; Counter++)
{
OrderSelect(Counter,SELECT_BY_POS);
if(OrderMagicNumber()==argMagicNumber && OrderSymbol()==argSymbol)
{
LastOrder=OrderOpenTime();
}
}
return(LastOrder);
}
  • #4
  • Nov 23, 2018 6:06pm Nov 23, 2018 6:06pm
Quoting Burton
Thank you Paul, that helped greatly, many Warnings corrected, yet not sure how to correct this warning " return value of 'OrderSelect' should be checked " int LastOrderTime(string argSymbol,int argMagicNumber) { datetime LastOrder; // for(int Counter=0; Counter<=OrdersTotal()-1; Counter++) { OrderSelect(Counter,SELECT_BY_POS); if(OrderMagicNumber()==argMagicNumber && OrderSymbol()==argSymbol) { LastOrder=OrderOpenTime(); } } return(LastOrder); }
try this?

int LastOrderTime(string argSymbol,int argMagicNumber){
datetime LastOrder;
for(int Counter=OrdersTotal()-1; Counter>=0; Counter--){
if(OrderSelect(Counter,SELECT_BY_POS)){
if(OrderMagicNumber()==argMagicNumber && OrderSymbol()==argSymbol){
LastOrder=OrderOpenTime();}}
else Print(" OrderSelect Error: ",GetLastError());
return(LastOrder);}}
  • #5
  • Edited 7:03pm Nov 23, 2018 6:23pm | Edited 7:03pm
Quoting Beerrun
{quote} try this? int LastOrderTime(string argSymbol,int argMagicNumber){ datetime LastOrder; for(int Counter=OrdersTotal()-1; Counter>=0; Counter--){ if(OrderSelect(Counter,SELECT_BY_POS)){ if(OrderMagicNumber()==argMagicNumber && OrderSymbol()==argSymbol){ LastOrder=OrderOpenTime();}} else Print(" OrderSelect Error: ",GetLastError()); return(LastOrder);}}
maybe this would be better lol?

datetime LastOrderTime(string argSymbol,int argMagicNumber){
datetime LastOrder=0;
for(int Counter=OrdersTotal()-1;Counter>=0;Counter--){
if(OrderSelect(Counter,SELECT_BY_POS)){
if(OrderMagicNumber()==argMagicNumber&&OrderSymbol()==argSymbol) LastOrder=OrderOpenTime();}
else Print(" OrderSelect Error: ",GetLastError());
return(LastOrder);}return(LastOrder);}
  • #6
  • Nov 23, 2018 6:51pm Nov 23, 2018 6:51pm
Quoting Beerrun
{quote} maybe this would be better lol? datetime LastOrderTime(string argSymbol,int argMagicNumber){ datetime LastOrder=0; for(int Counter=OrdersTotal()-1;Counter>=0;Counter--){ if(OrderSelect(Counter,SELECT_BY_POS)){ if(OrderMagicNumber()==argMagicNumber&&OrderSymbol()==argSymbol){ LastOrder=OrderOpenTime();}} else Print(" OrderSelect Error: ",GetLastError()); return(LastOrder);}return(LastOrder);}
Thank you Beerun that helped reduce my Warnings even more...much appreciated
  • #7
  • Nov 23, 2018 6:55pm Nov 23, 2018 6:55pm
Quoting Burton
{quote} Thank you Beerun that helped reduce my Warnings even more...much appreciated
Im glad it helped
Remember to always count down orders, and the function type needed to be the same as the returned value type.
  • #8
  • Last Post: Nov 3, 2019 1:21am Nov 3, 2019 1:21am
Hello Guys I have the same issue with my code. Can anyone help me please.

for (int cnt = OrdersTotal() - 1; cnt >= 0; cnt--)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if (OrderSymbol() != Symbol() || OrderMagicNumber() != MagicNumber) continue;
if (OrderSymbol() == Symbol() && OrderMagicNumber() == MagicNumber && OrderType() == OP_BUY) {
oldticketnumber = OrderTicket();
if (oldticketnumber > ticketnumber) {
oldorderopenprice = OrderOpenPrice();
unused = oldorderopenprice;
ticketnumber = oldticketnumber;
}
}
}
return (oldorderopenprice);
0 traders viewing now