Help with basic coding problem

STOCH CROSS INDI HELP
Can somebody please assist me as I'm trying to understand how to correct the following.
I'm learning MQL4 and have the following 2 issues I don't understand.
#1:
In the attached example I want to put the indicator on an M5 chart, and it draws arrows when the M5 Stochs cross, BUT...the H1 Stochs must also be moving upwards. What I'm getting is the arrows but only ON the hour, while there has been many times within the hour that it didn't create an arrow. I want it to draw an arrow if M5 Stochs cross and even tho the H1 Stochs might not have closed yet take that into consideration for that moment and use the data on the H1 "0 bar".
#2:
Then another thing I picked up was that when changed the previous H1 Stochs from "i-1" to "i-2", it gives an arrow and then directly afterwards another arrow. It's not an Array-out-of-range issue but why is it doing this?

Appreciate the help.

I need some help to understand how the iBarShift works as per the above request.

Thanx

Would You not have two index variables for the different time frames? For there are i.e. twelve M5 bars in H1..

The attached file shows that I'm looking at M5 with an H1 Stoch attached. I know it's a bad example but what I want is to be able to see where the Current H1 Stoch at 0750 is even if it has not closed yet, in relation to it's already closed bar on the hour at 0700 on a M5 chart.

I'm sure it's iBarShift to use but just not yet sure how?

I think you are using iBarShift correctly, except that you have to pay attention to the direction of indexing of the arrays. The Time[] array is indexed right-to-left, while the other arrays may by default index left-to-right. Perhaps use time[] insted of Time[] and set ArraySetAsSeries(time,false). Also not sure if built-in indicators will return intermediary values when called in such a way.

Thanx, but I think I need the array to go from right-to-left.

Think I got the issue, looks like my i=1 and changed it to i=0 in the "for" loop. Now I get the current and also can look at the hours x-bars back on the hour.

Will test a little bit.

thanx for the help

Okay, no-go.

I think it need the FOR loop on the HTF to use i=0 and then a FOR loop on the CurrentTF to be i=1.

But how do you then run the conditionals?

EDIT: Attached I've done how I think it should be, but won't compile and I'm a bit stuck.

Please help!

Made it compile for you.
Not tested to see if it does what you want.

M.

Thanx a bunch. Will try it out.

Thanx FutureSpec, I see my rookie mistake with the declarations.

Though it still only needs to draw an arrow once the Current TF candle has closed, so Stochs on the CTF has to be on the i=1, and then the Higher TF will still be in progress and that needs to be on the i=0. Or am I wrong in this assumption?

Hope you understand what I mean?

I'd highly suggest you use the standard library indicator classes instead of the low level api functions. Your code will be much more readable and your development time cut in half. Here is an example

, and here I was thinking that I was getting the hang of writing my own code. WOW and thanx!!

You have really peaked my interest now with this. How can I learn more because all I can see on the web is relating to mql5 or is there not much of a line anymore.

Nicholishen: I've tried reading up on the Standard Library, but there is not much out there and almost no examples to work from if you don't have some C background I suspect.

Can you please just show me using FOO.mq4 how to add a custom indicator, for instance using TDI, or must you re-write the whole thing as an indicator class?

You need to use CiCustom or inherit CIndicator to make your own. There are articles on MQL5.com that can help.

Hi Nicholishen,

I have tried using your previous example that I have tweaked a little to draw arrows but just can't get them to appear.

Please can you have a look at the code and see where I'm going wrong.

Thanx

Hi Futurespec,
I am a newbie in forex, and need your help in EA. Please help me out!!!

Hi,
Not really doing any more coding I'm afraid.

If you care to PM me I will take a look if it is a 5 minute job.

M.