Need Best Support and Resistance Indicator | Page 16 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Best Reliable Sources for Daily Support and Resistance points. 2 replies

Need help: edit support resistance indicator 2 replies

The best support and resistance levels 55 replies

What are the Best Support and Resistance Systems? 1 reply

Need help with Support, Resistance and Fib 14 replies

Attachments: Need Best Support and Resistance Indicator
Exit Attachments

Need Best Support and Resistance Indicator

  • #301
  • May 9, 2018 12:19pm May 9, 2018 12:19pm
Quoting gio.gee
Ebeckers {quote} 1. I've not used your code its MT5 a complete different language yes it is based of your Idea but that's it 2. This is not for commercial use (what i choose to do with it is up to me as i paid to have it made from scratch) 3. I no longer use MT4 and so do not use your indicator 4. this was email to you:17th April and i got no reply from you................. Hi Erwin, What can I say amazing work on the MT4 support and Resistance indicator, I’m going to pay to have a version made on MT5 I just wanted to know as I’m not a programmer...
Look buddy, for me its pretty simple :

1) "I've not used your code, its MT5 a complete different language, yes it is based of your Idea, but that's it"
Doesn't matter. You took my open source code, improved/changed/refactored it for MT 5 whatever.
In the end...
- You took my opensource code
- You used it to create a closed-source product from it
- and you didn't gave back the changes to the open source community

2) "But this is not for commercial use"
I don't care. Doesn't change the facts I mentioned in #1

3) "But I don't use MT4?
I don't care. Doesn't change the facts I mentioned in #1

4) "But I send you an email ?"
Doesn't change the facts I mentioned in #1.
Sending an e-mail and not getting a response doesn't give you the rights to steal something, does it ?

Erwin
  • #302
  • May 9, 2018 12:33pm May 9, 2018 12:33pm
Quoting ebeckers
{quote} Look buddy, for me its pretty simple : 1) "I've not used your code, its MT5 a complete different language, yes it is based of your Idea, but that's it" Doesn't matter. You took my open source code, improved/changed/refactored it for MT 5 whatever. In the end... - You took my opensource code - You used it to create a closed-source product from it - and you didn't gave back the changes to the open source community 2) "But this is not for commercial use" I don't care. Doesn't change the facts I mentioned in #1 3) "But I don't use MT4? I don't...
I wouldn't be too concerned with "Commercial use" regarding MT4/5 code... It's likely the "entrepreneur" will never recoup his freelance cost. In cases like this I would really suggest that you include an appropriate licence in the root of your github project and also in the file itself (if you are sharing as attachments in the forums) that way you can enforce a cease and desist if your code pops up on the MQL marketplace.

Quote
I would be more than happy to share it with you.
You are missing the point. This is a scummy way to use someone else's open-source.
  • #303
  • May 9, 2018 8:13pm May 9, 2018 8:13pm
Quoting ebeckers
For those using it, here's the latest version of my S&R indicator: What's new: - you can specify your own colors - indicator now supports following key shortcuts: press following keys to: 'h' to turn on/off H4 S&R lines 'd' to turn on/off daily S&R lines 'w' to turn on/off weekly S&R lines '1'-'5' to switch between minimum-maximum detail 'r' for reset back to default values {image} {image} {file}

Hey man this s&r looks awesome, i have a few questions about it it.

1. do the arrows repaint?

2. is it good to use on the 1hr?

3. Does Alert you when the price touches the zones or when and arrow appears?
  • #304
  • May 10, 2018 11:46am May 10, 2018 11:46am
First, I completely agree with the "open source" concept explained by ebeckers.

Secondly, please ebeckers and friday13 check what I'm going to say below.
As told, I'm not a big programmer but I was able to "read" and (I hope) find out some issues that, if real, maybe could be bring to a revised version.
Using the mtf version of friday13 I had problems with refreshing lines in smaller timeframes, exept after the OnInit(), eg. changing timeframe.
In fact the Refresh (that is -> forceRefresh=true) seems to be called at the OnInit(), and this is OK, and automatically only when a new Day is found/calculated:

Line 552 in mtf_CSsupportResistance.mqh -> if (day != _previousDay || forceRefresh)

This had a sense as the original indicator was made for working h4/d1/w1.
But the mtf version needs a more frequent refresh/recalculation of data according to the smaller timefrime used.

So now I've introduced into OnCalculate() the following mod, so that at every new bar (of the active timeframe) all the re-calculations are made and then the lines are re-drawn accordingly:

OnCalculate(etc et..)
{
if (Bars>bar_calculated)
{
CalculateSR(true);
}
return(rates_total);
}

What I'm saying has some sense?
If I'm correct (I'm not sure 100% because I could have bad interpreted the code) maybe friday13 could review and re-publish his mod?
Friday13, maybe there are are some other places in the code to be checked/reviewed for this refresh issue?

Hope I was useful, thanks, bye
  • #305
  • Edited 7:03pm May 15, 2018 5:51pm | Edited 7:03pm
Quoting ebeckers
you can find all code and the ex4 here https://github.com/erwin-beckers/SupportResistance
thank you so much ebeckers .... you are the best one .... I pray will you long life
The Average Discount Everything
  • #306
  • Jun 9, 2018 7:42am Jun 9, 2018 7:42am
Quoting ebeckers
For those using it, here's the latest version of my S&R indicator: What's new: - you can specify your own colors - indicator now supports following key shortcuts: press following keys to: 'h' to turn on/off H4 S&R lines 'd' to turn on/off daily S&R lines 'w' to turn on/off weekly S&R lines '1'-'5' to switch between minimum-maximum detail 'r' for reset back to default values {image} {image} {file}

hello thank for your work with this awesome indicator!!

can i know wich cross arrow indicator do you use in this picture?

thankss
  • #307
  • Jun 9, 2018 11:47am Jun 9, 2018 11:47am
someone have any version for mt5? it will be nice m thankss
  • #308
  • Jun 14, 2018 5:42am Jun 14, 2018 5:42am
Quoting ramzam
this is one is fibo and fractalsmod indicator... {image} {file} {file}
Hi, can we have simple lines instead of those dotted lines in this indicator please? thank you
The loss was not bad luck. It was bad Analysis - D.Einhorn
  • #309
  • Jun 14, 2018 5:51am Jun 14, 2018 5:51am
Quoting Vcv13
{quote} Hi, can we have simple lines instead of those dotted lines in this indicator please? thank you

Hello, yes, we can.
  • #310
  • Jun 14, 2018 6:13am Jun 14, 2018 6:13am
I tried changing the style but I couldn't.

now it looks like this
Attached Image (click to enlarge)
Click to Enlarge Name: b.jpg Size: 131 KB


I want it to look like this
Attached Image (click to enlarge)
Click to Enlarge Name: a.jpg Size: 122 KB
The loss was not bad luck. It was bad Analysis - D.Einhorn
  • #311
  • Jun 14, 2018 7:34am Jun 14, 2018 7:34am
Quoting friday13
{quote} It is not possible to add Yearly-S/R-lines in an easy way, as MT4 does not have this timeframe. {quote} I allowed myself to add lower timeframes to the code, so I attach it here since I don't know how to add changes on GitHub. {file}

Hi,

Can you please add alerts to this awesome indicator?

Thank you!
  • #312
  • Jun 14, 2018 2:18pm Jun 14, 2018 2:18pm
Here is one that I found elsewhere.
Same levels on MTF and descriptive as well.

Attached File(s)
File Type: ex4 Important_SR_Levels.ex4   61 KB | 3,337 downloads
Ask and you look stupid for 5 minutes. Don't ask and stay stupid forever.
  • #313
  • Jun 14, 2018 3:54pm Jun 14, 2018 3:54pm
Quoting EeZeeTrader
Here is one that I found elsewhere. Same levels on MTF and descriptive as well. {file}
I tried this indicator... Who does that?!!
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot (861).png Size: 36 KB
  • #314
  • Jun 14, 2018 11:31pm Jun 14, 2018 11:31pm
Quoting Vcv13
I tried changing the style but I couldn't. now it looks like this {image} I want it to look like this {image}
search in the code STYLE_DOT ... you change this dot to SOLID and compile
Success is a Journey Not a Destination....... kind regards ramzam
  • #315
  • Jun 15, 2018 4:45am Jun 15, 2018 4:45am
Quoting ramzam
{quote} search in the code STYLE_DOT ... you change this dot to SOLID and compile

friend, here's the code, I don't see any STYLE_DOT

//+------------------------------------------------------------------+
//| FractalsMod.mq4 |
//| Manel Sanchon |
//+------------------------------------------------------------------+
#property copyright "Manel Sanchon"
#property link ""
#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 Red
#property indicator_width1 0
#property indicator_color2 Blue
#property indicator_width2 0
//---- input parameters
extern int leftbars = 12;
extern int rightbars = 12;
extern int shift = 0;
//---- buffers
double ExtUpperBuffer[];
double ExtLowerBuffer[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicator buffers mapping
SetIndexBuffer(0,ExtUpperBuffer);
SetIndexBuffer(1,ExtLowerBuffer);
//---- drawing settings
SetIndexStyle(0,DRAW_ARROW);
SetIndexArrow(0,167);
SetIndexStyle(1,DRAW_ARROW);
SetIndexArrow(1,167);
//----
SetIndexEmptyValue(0,0.0);
SetIndexEmptyValue(1,0.0);
//---- name for DataWindow
SetIndexLabel(0,"Fractal Up");
SetIndexLabel(1,"Fractal Down");
//---- initialization done
return(0);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
ObjectDelete(0,"Fractal Up");
ObjectDelete(1,"Fractal Down");
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
double Higher,Lower;
int countup=0;
int countdown=0;
int counted_bars=IndicatorCounted();
if(counted_bars < 0) return(-1);
if(counted_bars>0) counted_bars--;
int CalculateBars=Bars-counted_bars;
if(counted_bars==0) CalculateBars-=1+leftbars;
for(int Count=CalculateBars; Count>=0; Count--)
{
for(int j=1;j<=leftbars;j++)
{
if(Count+j<CalculateBars)
{
if(High[Count]>High[Count+j]) countup=countup+1;
if(Low[Count]<Low[Count+j]) countdown=countdown+1;
}
}
for(j=1;j<=rightbars;j++)
{
if(Count-j>=0)
{
if(High[Count]>High[Count-j]) countup=countup+1;
if(Low[Count]<Low[Count-j]) countdown=countdown+1;
}
}
if(countup==leftbars+rightbars) Higher=High[Count];
else Higher = ExtUpperBuffer[Count-shift+1];
if(countdown==leftbars+rightbars) Lower = Low[Count];
else Lower=ExtLowerBuffer[Count-shift+1];
ExtUpperBuffer[Count-shift] = Higher;
ExtLowerBuffer[Count-shift] = Lower;
countup=0;
countdown=0;
//if(shift==0)
// {
// Comment("FractalMod("+leftbars+","+rightbars+";"+shift+")","\n Up="+Higher+";Down="+Lower);
// }
}
//----
return(0);
}
//+------------------------------------------------------------------+
The loss was not bad luck. It was bad Analysis - D.Einhorn
  • #316
  • Jun 15, 2018 4:58am Jun 15, 2018 4:58am
you need to change the number 167 (in lines SetIndexArrow(1,167)...) to something different....

See your possibilities for example here http://www2.nefec.org/UPM/swingd.htm

(solid lines with this SetIndexArrow technique are not possible)
  • #317
  • Jun 15, 2018 5:06am Jun 15, 2018 5:06am
Vcv13, as far as I understood about mql4, you cannot transform the small "square" into a line, unless you modify the logic of the code.

The command implied is this:
SetIndexStyle(0,DRAW_ARROW);
SetIndexArrow(0,167);

"167" is the code for the small square in Wingdings Font, which is put over/under every candle.
For example if you try with "40" you will get a small fixed telephone icon!
Or "81" for a small plane!

If you want a "real" line, I guess you should modify the code in order to draw an object "line", which is different.
Hope I was of help.
  • #318
  • Jun 15, 2018 6:38am Jun 15, 2018 6:38am
Quoting friday13
{quote} It is not possible to add Yearly-S/R-lines in an easy way, as MT4 does not have this timeframe. {quote} I allowed myself to add lower timeframes to the code, so I attach it here since I don't know how to add changes on GitHub. {file}
Hi friday13!

Can you pls add alert when price is near a line and another if line was crossed? Near line at 30 pips and after crossing line?

Thank you! Hope you will add this!
  • #319
  • Jun 17, 2018 9:30pm Jun 17, 2018 9:30pm
Quoting Vcv13
{quote} friend, here's the code, I don't see any STYLE_DOT //+------------------------------------------------------------------+ //| FractalsMod.mq4 | //| Manel Sanchon | //+------------------------------------------------------------------+ #property copyright "Manel Sanchon" #property link "" #property indicator_chart_window #property indicator_buffers 2 #property indicator_color1 Red #property indicator_width1 0 #property indicator_color2 Blue #property indicator_width2 0 //---- input parameters extern int leftbars = 12; extern int rightbars...
https://docs.mql4.com/constants/obje...ants/wingdings here desire number you can input instead of 167
Attached Image
Success is a Journey Not a Destination....... kind regards ramzam
  • #320
  • Jun 17, 2018 9:40pm Jun 17, 2018 9:40pm
try this one.
Attached File(s)
File Type: mq4 Support and Resistance (Barry) with alerts.mq4   7 KB | 3,253 downloads
0 traders viewing now