Help with a very small part of code please | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need help with this part of code mql4 2 replies

Need help with a small piece of code 0 replies

Small help with the code to count up-bars and down-bars 12 replies

Could someone please write the following very small EA for me... 13 replies

Very easy basic code to be written, please help 0 replies

Help with a very small part of code please

  • #1
  • First Post: Apr 12, 2018 10:40am Apr 12, 2018 10:40am
Please can anyone point out what is wrong in this part of code below, it is showing "array out of range" and pointing that the error is on this line:
datetime time = Time[0];

Inserted Code
datetime getLastTradeTime(int type)
{
    datetime time = Time[0];
    for(int cnt = OrdersTotal()-1 ;cnt>=0;cnt--)
    {
      if(!OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES))continue;
      if(OrderMagicNumber() == MagicNumber && (OrderType() == type || type == -1)) 
      {
         if(time<OrderOpenTime())time = OrderOpenTime();
      }
    }
    
    for(int cnt = OrdersHistoryTotal()-1 ;cnt>=0;cnt--)
    {
      if(!OrderSelect(cnt, SELECT_BY_POS, MODE_HISTORY))continue;
      if(OrderMagicNumber() == MagicNumber && (OrderType() == type || type == -1)) 
      {
         if(time < OrderCloseTime())time = OrderCloseTime();
      }
    } 
   return(time);
}
  • #2
  • Apr 12, 2018 10:22pm Apr 12, 2018 10:22pm
Quoting nickz
Please can anyone point out what is wrong in this part of code below, it is showing "array out of range" and pointing that the error is on this line: datetime time = Time[0]; datetime getLastTradeTime(int type) { datetime time = Time[0]; for(int cnt = OrdersTotal()-1 ;cnt>=0;cnt--) { if(!OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES))continue; if(OrderMagicNumber() == MagicNumber && (OrderType() == type || type == -1)) { if(time<OrderOpenTime())time = OrderOpenTime(); } } for(int cnt = OrdersHistoryTotal()-1...
I would assume that you're calling this from OnInit, and if you are then you should know that the built-in variables are not ready to call until after OnInit returns INIT_SUCCEEDED, thus the Time array would not have any elements and you're calling for a non-existent index.
  • #3
  • Apr 12, 2018 10:47pm Apr 12, 2018 10:47pm
Quoting Nicholishen
{quote} I would assume that you're calling this from OnInit, and if you are then you should know that the built-in variables are not ready to call until after OnInit returns INIT_SUCCEEDED, thus the Time array would not have any elements and you're calling for a non-existent index.
Hi Nicholishen,
No not from OnInit, it is under void OnTick() .
  • #4
  • Apr 13, 2018 7:34pm Apr 13, 2018 7:34pm
Quoting nickz
{quote} Hi Nicholishen, No not from OnInit, it is under void OnTick() .
Not sure why the platform is failing to fill that array, but you need to error proof it and check its size before calling upon its elements.
  • #5
  • Apr 13, 2018 11:10pm Apr 13, 2018 11:10pm
i think "datetime time = Time[0];" is some old code, solution:
https://www.mql5.com/en/forum/235955
  • #6
  • Last Post: Apr 14, 2018 10:17am Apr 14, 2018 10:17am
Quoting nickz
i think "datetime time = Time[0];" is some old code, solution: https://www.mql5.com/en/forum/235955
iTime is better because it wont throw a fatal error, however, it will still throw 4066/4073 errors that you won't even know about unless you explicitly develop your program to look for them. What this all means; if for some reason the built-in arrays aren't ready then iTime won't be either, and the difference is Time[] will have a size ==0 and iTime will throw a silent 4066 error and return -1. If you're not error checking either then your algo is broken by default. So either way you decide to go, you have more work to do
0 traders viewing now