Menu
Sister Sites

Options

Bookmark Thread

First Page First Unread Last Page Last Post

Print Thread

Similar Threads

auto lot size based on risk% 8 replies

Which would you prefer: increasing lot size or TP size? 21 replies

At what lot size/account size do you have scale issues? 35 replies

calculating lot size based on money to risk, not % 4 replies

Lot size, contract size, max position ? 1 reply

Attachments: Code to work out lot size based on risk
Exit Attachments

Code to work out lot size based on risk

i must be really tripping, that script gives me correct result, but in my EA im getting that totally incorrect calculation, and i lifted the script and pasted into the EA :nuts:
Restart your mt4 instance.
wish it were that easy but no

pretty funny , this shows the output of the exact same code, one called in EA, other is the script:
Inserted Code
04:12:46 Assistant USDCZK,M15: Alt calculation; Capital=48939
Risk=1.0%
Stoploss=27
Lots=30.66
04:12:46 Assistant USDCZK,M15: Lot size calculated using 1.00000000% and stop: 27.00000000 = 30.65963366
04:12:46 Assistant USDCZK,M15: Using lot size of 30.65963366
04:12:46 Assistant USDCZK,M15: Checking param: M5 price: 1.07280000 sl: 1.07550000
04:12:46 Assistant USDCZK,M15: Here we go...
04:12:47 Assistant USDCZK,M15: Here we go...
04:13:09 Assistant USDCZK,M15: OrderSend failed with error #134

04:15:07 PosizionSize AUDUSD,M15: loaded successfully
04:15:07 PosizionSize AUDUSD,M15 inputs: risk=1; stoploss=36; 
04:15:07 PosizionSize AUDUSD,M15: Alert: Capital=48939\nRisk=1.0% Stoploss=36 Lots=1.36
04:15:07 PosizionSize AUDUSD,M15: Capital=48939
Risk=1.0%
Stoploss=36
Lots=1.36

code again, copy-paste from working script:
Inserted Code
double CalcLotSize(int iSL) {
   
  int iPipMult[]={1,10,1,10,1,10,100};       
  double dRiskCapital=MaxRisk/100*AccountBalance(); 
  double tmpLot =  dRiskCapital/(iSL*MarketInfo(Symbol(),MODE_TICKVALUE)*iPipMult[Digits]); 
  
  Print("Alt calculation; Capital=",DoubleToStr(AccountBalance(),0),"\nRisk=",DoubleToStr(MaxRisk,1)+"%",
            "\nStoploss=",DoubleToStr(iSL,0),"\nLots=",DoubleToStr(tmpLot,2));
            
  return(tmpLot);
}
im gonna go have a few beers, maybe it'll come to me then ...
You are comparing the position size calculated for AUDUSD against USDCZK . . . they WILL be different . . .

Run your EA on AUDUSD or run the script on USDCZK
20 pips a day isn't too much to ask . . .
"OrderSend failed with error #134" is because you don't have enough margin for the trade you are trying to place . . do you check for the margin requirement before you try to place the trade ?
20 pips a day isn't too much to ask . . .
nah raptor the EA is running on that chart but not executing on that pair - its still AU.
And the margin issue is after the calculation is incorrect.

xaphod i almost wish u could remote login to my PC so u can see im not on drugs ..
Quoting pipmyride
nah raptor the EA is running on that chart but not executing on that pair - its still AU.
Not if you are using a chart-specific function like "Symbol()" and a chart-specific property like "Digits" in your lot calculation.
Quoting pipmyride
nah raptor the EA is running on that chart but not executing on that pair - its still AU.
And the margin issue is after the calculation is incorrect.

xaphod i almost wish u could remote login to my PC so u can see im not on drugs ..
It is difficult to debug code one has no access to and knows nothing about. Break down the calculation to it's smallest individual steps and print out the data from each step and verify it is correct.

As zznbrm points out symbol() refers to the symbol of the chart the EA is running on. So you are using the tick value for USDCZK. RaptorUK pointed out that red flag too. The code works as it should. Your input data is incorrect.

Note: The code was written for the major pairs. I have not verified its functionality with the more exotic pairs like USDCZK etc.
Quoting zznbrm
Not if you are using a chart-specific function like "Symbol()" and a chart-specific property like "Digits" in your lot calculation.
hahahah u legend !!
see thats wot a 2nd pair of eyes does !

Indeed, thats exactly it, thx very much all for helping !
Quoting pipmyride
{quote} hahahah u legend !! see thats wot a 2nd pair of eyes does ! Indeed, thats exactly it, thx very much all for helping !
Hello Pipmyride,

Can you please post your end result compiled code for the lotsize calculator?

I have been looking for a correct way to calculate my lotsizes. I saw all the codes shared here but unfortunately for me, I do not have any knowledge about doing anything with codes.

Thank you.
Patience, Persistence and discipline = Holy Grail.
  • Post #31
  • Quote
  • Last Post: Apr 22, 2020 10:42pm Apr 22, 2020 10:42pm
Quoting CodersGuru
I usually use this function: double CalcLots(double Risk) { double tmpLot = 0, MinLot = 0, MaxLot = 0; MinLot = MarketInfo(Symbol(),MODE_MINLOT); MaxLot = MarketInfo(Symbol(),MODE_MAXLOT); tmpLot = NormalizeDouble(AccountBalance()*Risk/1000,2); if(tmpLot < MinLot) { Print("LotSize is Smaller than the broker allow minimum Lot!"); return(MinLot); } if(tmpLot > MaxLot) { Print ("LotSize is Greater than the broker allow minimum Lot!"); return(MaxLot); } return(tmpLot); }
Hi, CodersGuru, may I know why you divide risked balance by "1000"? thank you.
0 traders viewing now