Array out of range? Help?

//+------------------------------------------------------------------+
//|                                             FractalsExercise.mq4 |
//|                                                           AntiVi |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "AntiVi"
#property link      "https://www.mql5.com"
#property version   "1.00"
#property strict
#property indicator_chart_window
double Highs[];
double Lows[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- drawing style  
  SetIndexStyle(0, DRAW_ARROW, EMPTY, 1, clrGreen);
  SetIndexArrow(0, 234);
 
  SetIndexStyle(1, DRAW_ARROW, EMPTY, 1, clrRed);
  SetIndexArrow(1, 233);
 
//--- indicator buffers
   SetIndexBuffer(0, Highs);
   SetIndexBuffer(1, Lows);
  
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
//---
  
int i = 1;
int ii = 1;
int Limit = Bars - 1;
   while(i < Limit)
      {  
         if(High[i] > High[i + 1])
            {
               if(High[i] > High[i - 1])
                  {
                     Highs[i] = High[i];
                  }
            }
         i++;
      }    
    while(ii < Limit)
      {  
         if(Low[ii] < Low[ii + 1])
            {
               if(Low[ii] < Low[ii - 1])
                  {
                     Lows[ii] = Low[ii];
                  }
            }
         ii++;  
      }
  
  
  
  
  
  
//--- return value of prev_calculated for next call
   return(rates_total);
  }
//+------------------------------------------------------------------+

Quoting AntiVi

Disliked

Hey guys, So I've been trying to draw some stuff however it's giving me the error "Array out of range". It draws the green arrows perfectly however the red arrows just won't work. If someone could tell me what I'm doing wrong it would be great. It's not because I'm trying to access candles that aren't there yet or at all as far as I know. I get that some people might say that it's going past available bars but I have tested even with a limit of 1000 which I'm sure my chart has and it still gives me out of range. This is the code: //+------------------------------------------------------------------+...

Ignored

if(i >= Bars-1) break;

if(ii >= Bars-1) break;

Quoting FerruFx

Disliked

{quote} In each loop, try to break it with something like the example below to avoid to go past the Bars available: if(i >= Bars-1) break; if(ii >= Bars-1) break;

Ignored

Quoting AntiVi

Disliked

{quote} From what I can see that is what my "Limit" does already however I still inserted it into the code just to test and even tried it in several positions however the error persists. I'm honestly baffled as to why it's giving me the error. This is a picture of the result so far. It should do the same for the Lows with red arrows pointing up. You can also see the error just to give people an idea. {image}

Ignored

Quoting FerruFx

Disliked

{quote} Which line is 71 ?

Ignored

//+------------------------------------------------------------------+
//|                                             FractalsExercise.mq4 |
//|                                                           AntiVi |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "AntiVi"
#property link      "https://www.mql5.com"
#property version   "1.00"
#property strict
#property indicator_chart_window
 
// START ADDED JvW
#property indicator_buffers 2
// END ADDED JvW
 
double Highs[];
double Lows[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- drawing style  
  
  SetIndexStyle(0, DRAW_ARROW, EMPTY, 1, clrGreen);
  SetIndexArrow(0, 234);
 
  SetIndexStyle(1, DRAW_ARROW, EMPTY, 1, clrRed);
  SetIndexArrow(1, 233);
 
//--- indicator buffers
   SetIndexBuffer(0, Highs);
   SetIndexBuffer(1, Lows);
  
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
//---
  
int i = 1;
int ii = 1;
int Limit = Bars - 1;
   while(i < Limit)
      {  
         if(High[i] > High[i + 1])
            {
               if(High[i] > High[i - 1])
                  {
                     Highs[i] = High[i];
                  }
            }
         i++;
      }    
    while(ii < Limit)
      {  
         if(Low[ii] < Low[ii + 1])
            {
               if(Low[ii] < Low[ii - 1])
                  {
                     Lows[ii] = Low[ii];
                  }
            }
         ii++;  
      }
  
  
  
  
  
  
//--- return value of prev_calculated for next call
   return(rates_total);
  }
//+------------------------------------------------------------------+

Quoting johnvanwijk

Disliked

Hi AntiVi, you should indicate how many buffers are required.... the following change at the start in your code (after #property indicator_chart_window) makes it work nicely..... #property indicator_buffers 2 Cheers & Enjoy! John //+------------------------------------------------------------------+ //| FractalsExercise.mq4 | //| AntiVi | //| https://www.mql5.com | //+------------------------------------------------------------------+ #property copyright "AntiVi" #property link "https://www.mql5.com" #property version "1.00" #property strict #property...

Ignored

Quoting AntiVi

Disliked

{quote} You sir are a genius. I can't believe the fix was so simple. I'm going to blame this on my inexperience and do it yourself learning. I spent a good 5 hours trying to figure it out and all I found were workarounds that didn't fix anything. I'll edit the first post to include the fix so people can get the easy answer if they bother looking for it! Thanks a lot!

Ignored

#property strict
#property indicator_chart_window
// START ADDED JvW
#property indicator_buffers 2
// END ADDED JvW
double Highs[];
double Lows[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
{
//--- drawing style  
   SetIndexStyle(0,DRAW_ARROW,EMPTY,1,clrGreen);
   SetIndexArrow(0,234);
   SetIndexStyle(1,DRAW_ARROW,EMPTY,1,clrRed);
   SetIndexArrow(1,233);
//--- indicator buffers
   SetIndexBuffer(0,Highs);
   SetIndexBuffer(1,Lows);
   return(INIT_SUCCEEDED);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
//---
   int limit = rates_total - prev_calculated - 2;
   limit = limit < 1 ? 1 : limit;
   for(int i = limit; i > 0; i--)
   {
      if(high[i] > high[i+1] && high[i] > high[i-1])
         Highs[i] = high[i];
      if(low[i] < low[i+1] && low[i] < low[i-1])
         Lows[i] = low[i];  
   }
//--- return value of prev_calculated for next call
   return(rates_total);
}

Quoting Nicholishen

Disliked

{quote} Hi AntiVi, In addition to what john has shared, you also want to get in the habit of using the data passed as args into the OnCalculate function instead of relying on data from the built in vars. Also, you want to make sure you are doing your look-backs correctly. You don't need to process the entire loop (all chart data) on every tick. You only need to process the portion of the indicator data that needs updating. Here is an example of how to make better use of the OnCalculate function. #property strict #property indicator_chart_window...

Ignored

//+------------------------------------------------------------------+
//|                                             FractalsExercise.mq4 |
//|                                                           AntiVi |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "AntiVi"
#property link      "https://www.mql5.com"
#property version   "1.00"
#property strict
#property indicator_chart_window
#property indicator_buffers 2
double Highs[];
double Lows[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- drawing style  
  SetIndexStyle(0, DRAW_ARROW, EMPTY, 1, clrGreen);
  SetIndexArrow(0, 226);
 
  SetIndexStyle(1, DRAW_ARROW, EMPTY, 1, clrRed);
  SetIndexArrow(1, 225);
 
//--- indicator buffers
   SetIndexBuffer(0, Highs);
   SetIndexBuffer(1, Lows);
   
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
//---
int limit = rates_total - prev_calculated - 2;
limit = limit < 1 ? 2 : limit;

for(int i = limit; i > 1; i--)
   {  
   if(rates_total > prev_calculated)
      {
         Print("=== NEW CANDLE ===");
      
         if(High[i] > High[i + 1] && High[i] > High[i - 1])
            {
               Highs[i] = High[i] + 0.0001;
               Print("NEW HIGH DETECTED ", i);
            }
         if(Low[i] < Low[i + 1] && Low[i] < Low[i - 1])
            {
               Lows[i] = Low[i] - 0.0001;
               Print("NEW LOW DETECTED ", i);
            }
      }
}
   
   
//--- return value of prev_calculated for next call
   return(rates_total);
  }
//+------------------------------------------------------------------+