YES-TM EA Version 1.1 Beta released. It seems to work fine on my testing. But due to the time constrain, I may miss some bugs. So, do report them if you find any.
When in doubt, wait it out.
Just from inspection...
Personally I think you should limit the EA to the chart it is on. (check OrderSymbol() = Symbol() )
Why?
1) because people may want to have different levels of pips for different instruments (as they behave differently).
By making the one EA do all instruments with the same settings, it actually becomes less flexible.
2) as you've realized, because it will only run on ticks received by the main chart, so other charts only get updated with the main chart ticks and not when they get ticks.
Simpler all around to just have it stick to it's own chart IMO.
You are also still not continuing to the next order after calling OrderClose(). To close the order I would just set a boolean rather than duplicating the OrderClose code. ie
You are storing lots of values that you do not use again (OrderCommision etc)
I have some trailing stop functionality in my own EA, and key requirements (for me) were
1. sends wider trailing stops to the broker for safety, (using 10 pip boundaries to reduce OrderModify traffic)
2. managed terminal restarts ok,
3. adapts to market conditions somehow rather than using fixed values (this was being discussed in one of the threads you posted to
)
Personally I think you should limit the EA to the chart it is on. (check OrderSymbol() = Symbol() )
Why?
1) because people may want to have different levels of pips for different instruments (as they behave differently).
By making the one EA do all instruments with the same settings, it actually becomes less flexible.
2) as you've realized, because it will only run on ticks received by the main chart, so other charts only get updated with the main chart ticks and not when they get ticks.
Simpler all around to just have it stick to it's own chart IMO.
You are also still not continuing to the next order after calling OrderClose(). To close the order I would just set a boolean rather than duplicating the OrderClose code. ie
Inserted Code
loop {
bool closeTheOrder = false;
if (type = OP_BUY) {
if ( blah ) {
closeTheOrder = true;
}
if (blah blah) {
closeTheOrder = true;
}
} else if (type = OP_SELL) {
if ( blah ) {
closeTheOrder = true;
}
if (blah blah) {
closeTheOrder = true;
}
}
...
if (closeTheOrder) {
//close the order here with retry code.
} You are storing lots of values that you do not use again (OrderCommision etc)
I have some trailing stop functionality in my own EA, and key requirements (for me) were
1. sends wider trailing stops to the broker for safety, (using 10 pip boundaries to reduce OrderModify traffic)
2. managed terminal restarts ok,
3. adapts to market conditions somehow rather than using fixed values (this was being discussed in one of the threads you posted to
)
Personally I think you should limit the EA to the chart it is on
2) as you've realized, because it will only run on ticks received by the main chart, so other charts only get updated with the main chart ticks and not when they get ticks.
You are also still not continuing to the next order after calling OrderClose(). To close the order I would just set a boolean rather than duplicating the OrderClose code.
I have some trailing stop functionality in my own EA, and key requirements (for me) were
1. sends wider trailing stops to the broker for safety, (using 10 pip boundaries to reduce OrderModify traffic)
2. managed terminal restarts ok,
3. adapts to market conditions somehow rather than using fixed values (this was being discussed in one of the threads you posted to
A2: Yes, I agree with you. It will be something nice to have in the upcoming update.
A3: Adaptive market condition? Something worth serious exploring. Wonder if you have any guidance on market speed, trend, retracement & reversal.
When in doubt, wait it out.
