Need weekly time frame added to indicator

I need the attached indicator modified to give an option to select the Weekly time frame.
I'll appreciate it- I'll dance at your wedding

Too late Bill, I'm already married!

I've modified the indicator to use a variable timeframe. Hope that is what's required. Simply set Timeframe to W1 to get weekly (the indicator previously operated using daily).

I've also changed the display routine, because I noticed that if the values were equal the currency names plotted over top of each other. So now if two values are equal, to break the tie, the tied currencies display in alphabetical order.

I will leave you to test it more thoroughly when the markets reopen this coming week.

Happy New Year, my friend. May 2018 bring you good health, many pips, and much happiness.

David

NOTE: Code has been compiled using MQL4 Editor/compiler build 509. If you want the .mq4 source to continue to compile/run without errors, you'll need to do this first. Otherwise, download only the .ex4 file.

USD is not strong, I think, but on W1 it shows it as strong...in some point my interpretation might be wrong.

Thanks a million, Mr Hanover. I really appreciate it.

I didn't check to see how Bill's indicator calculates strength, but here are some other indications that US dollar (black line in the third screenshot, white line in the fourth) has indeed been weak, relative to the other majors, over the last few days:

I'll have to wait until the market opens to check it out. It won't activate without traffic.
I downloaded a tick generator but it doesn't make any difference. I used those things years ago and they used to work.
I'm sure the indicator is just what I needed.
Thanks again.

Mine works. I didn't wait long enough.
Here is how I was told to use it.

On W1, set the oneminma to 8.
That gives you, in order of strength:

NZD
AUD
EUR
CHF
CAD
GBP
JPY
USD

FWIW, as far as I can tell, this is how the calculation works:

The indicator originally calculated a simple MA with a period of oneminma on a daily chart, for every one of 27 currency pairs (excluding EURCHF, which is more complex). I've changed the Timeframe to be variable instead of daily. So if oneminma = 8, and Timeframe = W1, it calculates the SMA of the last 8 weekly candles (instead of the last 8 daily candles).

Each currency (EUR, USD, JPY, etc) starts with a score of 7.
If the current price of (for example) EURUSD is greater than its calculated SMA, then EUR's (the first named currency in the pair) score is decreased by 1, otherwise USD's (the second named currency in the pair) score is decreased by 1.
This process is repeated for the other 26 pairs. EURCHF works differently, but either EUR's or CHF's score is nonetheless decreased by 1.

If the final score for a currency is 5 or greater, it is printed in blue typeface; 3 or 4 is printed in white; 2 or less in red.
The currency with the lowest score prints at the top of the list, down to the currency with the highest score at the bottom.
All that is assuming that I've understood the code correctly. It's not always easy to get inside another programmer's head.

I'm not sure which currency is supposed to be the strongest, and which is the weakest. But, at a guess, if a pair's current price is above its SMA, then it is deemed to be rising and hence the first named currency is assumed to be strong; since that currency's score is decreased by 1, then I assume the currency with the lowest score (red, at the top of the list) is the strongest. (Which kinda makes sense )

I'm also not sure why it was programmed to work the way it does, but it is what it is.

I also fixed the indicator so that the text objects it creates disappear when the indicator is removed from the chart.
______________________________

[EDIT] BTW, in case anybody wants to know how the screenshots in post #5 were generated:
You can see the URLs in the first three.
Screenshot #4 uses the Recent Strength and CSM indicators.
Screenshot #5 uses the PSA.

Hi Bill,

I needed an example to test out a new multi-symbol/multi-timeframe framework I've been experimenting with - so here's my attempt to turn this into an MTF/MS oscillator.

A couple notes on the original code:

1. The symbols are hard coded so it will never work on an any broker with appended symbols (eg ECNs = "EURUSDecn").
2. There is no error 4066/4073 error handling so you will get false results due to the indicator making calculations on the iMA error return instead of the actual MA.