Help editing variables in mql4

Quoting Nicholishen

Disliked

Hi Reamasesa, I'm not sure if you are familiar with OOP design concepts, but here is an example of something I did that was similar to what you are working on. Perhaps you can reuse this code or find some inspiration I definitely recommend learning OOP if you haven't already - because it keeps your programs clean and super easy understand and debug. This is literally how the EA looks sans class definitions. #property strict #include "ProgramClasses.mqh" input CORNER Corner = UP_RIGHT;//Corner for Placement input int Y_Distance = 30; //+------------------------------------------------------------------+...

Ignored

Quoting Reamasesa

Disliked

{quote} Thank you. I write simple BASH scripts using awk, I taught myself MQL4 from others' simple examples, I know what OOP stands for but it's way way up there for me. I intuitively understood your code as I was able to decipher the words "button" and "close all" but seriously, I don't understand it or why it's been written like that. If you have any pointers (which are not the MQL4 documentation as I've just glimpsed through them and didn't understand most of what's written there regarding OOP) I'll be more than happy to follow through....

Ignored

Quoting Nicholishen

Disliked

{quote} I learned by going through the C++ tutorial on the solo learn app and then practiced making simple classes in MQL; worked my way up to the more complex MQL5 codebase examples. It really is the way to go.

Ignored

Quoting Reamasesa

Disliked

{quote} Thanks, I'll give that site a spin. Why would the OOP approach be better than the straight forward approach with my EA? IT's a simple EA, I think.

Ignored

#include <Arrays\List.mqh>
class SymbolRsi : public CObject
{
   const string m_symbol;
 public:
   SymbolRsi(string symbol): m_symbol(symbol) {}
   double Rsi() const
   {
      double res;
      uint error, ms = GetTickCount();
      do
      {
         ResetLastError();
         res = iRSI(m_symbol, _Period, 14, PRICE_CLOSE, 0);
         error = GetLastError();
      }
      while(error != ERR_NO_ERROR && GetTickCount() - ms < 1000);
      return error == ERR_NO_ERROR ? res : -1.0;
   }
   double Deviation()const
   {
      return fabs(Rsi() - 50.0);
   }
   /**
    * @brief      Compare is a virtual method inherited from the mql base class,
    *  CObject. This is used for sorting and quick searching using the methods
    *  of the collection classes in the standard library.
    * @return     In order to sort in ascending order the method needs to return
    *  +1 when this object is greater than other -and- -1 when this is less than
    *  other.
    */
   virtual int Compare(const CObject * node, const int mode = 0)const override
   {
      const SymbolRsi *other = node;
      if(this.Deviation() > other.Deviation())return -1; // -1 to sort decending when this > other
      if(this.Deviation() < other.Deviation())return  1;
      return 0; //same value
   }
   string ToString()
   {
      return m_symbol + " = " + DoubleToStr(Rsi(), (int)SymbolInfoInteger(m_symbol, SYMBOL_DIGITS));
   }
};
//+------------------------------------------------------------------+
void OnStart()
{
   CList list;
   SymbolRsi *pointer;
   for(int i = SymbolsTotal(true) - 1; i >= 0; i--)
   {
      pointer = new SymbolRsi(SymbolName(i, true));
      if(pointer.Rsi() < 0.0)
         delete pointer;
      else
         list.Add(pointer);
   }
   list.Sort(0);
   for(pointer = list.GetFirstNode(); pointer != NULL; pointer = pointer.Next())
      Print(pointer.ToString());
}

Quoting Nicholishen

Disliked

{quote} Because you can make use of the MQL standard library and make light work out of complex problems. A perfect example is how would use it to sort objects. Let's say you wanted to create a sorted list of trending symbols, prioritized by RSI deviation from the 50 mid-point. Without OOP - holy !@#$ what a task! However with OOP... #include <Arrays\List.mqh> class SymbolAtr : public CObject { const string m_symbol; public: SymbolAtr(string symbol): m_symbol(symbol) {} double Rsi() const { double res; uint error, ms = GetTickCount(); do { ResetLastError();...

Ignored

Quoting Reamasesa

Disliked

{quote} I'll take your words for it, I don't understand the structure at all but I'm guessing it's because of my lack of experience and knowledge in programming. As a side note, I actually took up one semester of programming in C, I flunked I hope it's just knowledge and hard work and not something my brain is missing. But more in particular to my own code, why would an OOP approach be better here? I mean, it's a simple EA trailing profit, nothing fancy about it, I think.

Ignored

#include <ProfitAllDraw.mqh>
void OnTick()
{
   //other code here
   ProfitAllDraw trailing;
   trailing.ProfitAllTrail();
}

Quoting Nicholishen

Disliked

{quote} For starters, you're rewriting a lot of code that's already in the std library. You could cut the lines of code required to manage your chart objects by at least 50%. Second, if you're working with a FIFO broker and you're not checking the sort on your orders before you close them, you're going to be in for a world of hurt. ... a bunch more reasons... and most importantly it would be very difficult to include this code in your other projects down the road! Conversely had you made this program into it's own class then you could easily include...

Ignored