Help editing variables in mql4 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

MQL4 Build 940 Global Variables strange behaviour 0 replies

Problems with coding local vs global variables on mql4 9 replies

Help Needed in Editing Martangle MQL4 Code 2 replies

MQL4 Language Most Recent Version is it updated beyond the tutorial on the mql4 websi 6 replies

Define every MQL4 variables, functions? 4 replies

Attachments: Help editing variables in mql4
Exit Attachments

Help editing variables in mql4

  • #1
  • First Post: Nov 30, 2017 4:21pm Nov 30, 2017 4:21pm
Hi,

I have a question regarding my code, I'm very far from even being considered as a novice programmer but I try.
I have a set of variables set up as user input, however, when I change them from the settings after the EA has been attached to the chart, it seems they don't get updated within the EA, only the settings show the correct input.
If I attach the EA to the chart again with the new settings it works.

I don't know how to proceed from here, tried resetting the parameters on the init, deinit, start, nothing seems to work.

I'm attaching the EA, any help would be greatly appreciated (and if you can think of improving my code, that would be awesome).



Thanks.
Attached File(s)
File Type: mq4 ProfitSymbol.mq4   25 KB | 422 downloads
  • #2
  • Dec 1, 2017 9:43am Dec 1, 2017 9:43am
Anyone?
  • #3
  • Dec 8, 2017 3:05am Dec 8, 2017 3:05am
Hi,

I tried changing the placement of some variables, at first it looked good but now instead of trailing it closes all trades when a jump occurs.


Can some one help me and review my code with me?



Thanks.
  • #4
  • Dec 12, 2017 1:45am Dec 12, 2017 1:45am
Me again.

I tried initializing my variables so when I change the settings (F7) while the EA is loaded so that they will display (and of course, evaluate for further operations) the correct and current values but I'm always stuck with the old variables unless I attach the EA to the chart all over again.

I'm sure this can be done as I've seen it in done in other EAs however, I'm not able to figure out how it's done.



Can some please help me with this?
  • #5
  • Dec 12, 2017 1:55am Dec 12, 2017 1:55am
Can you upload the latest version mate? I'll have a look
  • #6
  • Dec 12, 2017 2:22am Dec 12, 2017 2:22am
You cannot change input variable values in the code.

If you need to modify them in running, create them as extern.
  • #7
  • Dec 12, 2017 2:39am Dec 12, 2017 2:39am
Quoting dietcoke
You cannot change input variable values in the code. If you need to modify them in running, create them as extern.
Thanks, I've discovered that already I should have been clearer.

My input variables are all extern, when I change them (F7), the variables that uses them don't reflect the new values if I don't attach the EA to the chart again.
  • #8
  • Dec 12, 2017 2:41am Dec 12, 2017 2:41am
Quoting BSFilter
Can you upload the latest version mate? I'll have a look
Thanks, I'm attaching the version I'm testing right now, it still doesn't do what I need it to do and it's in a bit of a mess as I tried re-arranging things.
Attached File(s)
File Type: mq4 ProfitSymbol.mq4   26 KB | 396 downloads
  • #9
  • Dec 12, 2017 3:56am Dec 12, 2017 3:56am
Cheers, will try to take a look at it tomorrow
  • #10
  • Dec 12, 2017 2:01pm Dec 12, 2017 2:01pm
Have you tried attaching it to a live chart? Seems to work ok even with ea disabled.
Attached Image (click to enlarge)
Click to Enlarge Name: 2ZzxfKVLRCKiswTFxteqKQ.png Size: 149 KB
  • #11
  • Dec 12, 2017 4:37pm Dec 12, 2017 4:37pm
Quoting sakisf
Have you tried attaching it to a live chart? Seems to work ok even with ea disabled. {image}
Yes, it works well if you attach it to a chart but if you hit F7 and change the user settings, it doesn't work very well.
  • #12
  • Edited 6:01pm Dec 12, 2017 5:23pm | Edited 6:01pm
Quoting Reamasesa
{quote} Yes, it works well if you attach it to a chart but if you hit F7 and change the user settings, it doesn't work very well.
That's what i did there 3 times if you notice the experts output below, hit f7 and made 3 different changes in the EA, all changes were taken in and EA text was updated to the right.

Values seem to be taken properly by the EA. You have 2 double functions which return no value - ProfitAllTrail & DrawProfit - and your start does not return a value. You probably have also some calculation & logic errors in there for the trail.
Attached Image (click to enlarge)
Click to Enlarge Name: CWiXKiOkQdKcH2h1W7eCyQ.png Size: 125 KB
  • #13
  • Dec 13, 2017 3:58am Dec 13, 2017 3:58am
Quoting sakisf
{quote} That's what i did there 3 times if you notice the experts output below, hit f7 and made 3 different changes in the EA, all changes were taken in and EA text was updated to the right. Values seem to be taken properly by the EA. You have 2 double functions which return no value - ProfitAllTrail & DrawProfit - and your start does not return a value. You probably have also some calculation & logic errors in there for the trail. {image}
I take it you used the last version, right? If there is no profit, you can't see that the ProfitLockNext doesn't change as expected, and other such things, when it halogens, changing the user settings is messed up as well.

As for the logic issues, I've discovered some, indeed, and in due the are more that in too stuck in the code to see for myself, that's why I'm asking for help I'm only a pre-beginner at best.
  • #14
  • Dec 13, 2017 4:11am Dec 13, 2017 4:11am
Add "#property strict" right below the other #property
That will give you more errors which you will be able to pin-point and correct.

You learn the most by looking for solutions for any error / problem you may have.

Try to get no errors and no warnings when you compile.

Just to name a few:
Start by replacing "int Start" by "void OnTick"
Any error like "implicit conversion from 'number' to 'string'" --> your can simply put "(string)" in front of the variable to convert to string.
(or any other conversion you want to make like (int) or (double), but they need to be compatible!)
Also, functions like your "double ProfitAllTrail()" need to return a double value or if you don't need a return value, set it to "void" instead of "double".
  • #15
  • Dec 13, 2017 5:40am Dec 13, 2017 5:40am
Quoting Retlaw
Add "#property strict" right below the other #property That will give you more errors which you will be able to pin-point and correct. You learn the most by looking for solutions for any error / problem you may have. Try to get no errors and no warnings when you compile. Just to name a few: Start by replacing "int Start" by "void OnTick" Any error like "implicit conversion from 'number' to 'string'" --> your can simply put "(string)" in front of the variable to convert to string. (or any other conversion you want to make like (int) or (double),...
Thanks.
I'll clean up my code, not sure it will help with the current problem but it sure will make me better at writing code.
  • #16
  • Dec 13, 2017 6:13am Dec 13, 2017 6:13am
Quoting Retlaw
Add "#property strict" right below the other #property That will give you more errors which you will be able to pin-point and correct. You learn the most by looking for solutions for any error / problem you may have. Try to get no errors and no warnings when you compile. Just to name a few: Start by replacing "int Start" by "void OnTick" Any error like "implicit conversion from 'number' to 'string'" --> your can simply put "(string)" in front of the variable to convert to string. (or any other conversion you want to make like (int) or (double),...

Thanks again.
I've added the changes you've suggested, also cleaned up the code a bit.
Still couldn't find the bug(s)/logic issues with my code but thanks to people like you, I am progressing.
Attached File(s)
File Type: mq4 ProfitSymbol.mq4   26 KB | 408 downloads
  • #17
  • Dec 13, 2017 7:17am Dec 13, 2017 7:17am
Inserted Code
long chartID;
int TryAgain=1;
string name, chartSymbol="";
double ProfitLockNextJump=ProfitLockAt*ProfitJump;
double ProfitBELockAt=ProfitLockAt*ProfitBE;
double ProfitLocked=0;
double CurrentProfit=0;
double MaxProfit=0;
double ProfitLockNext=ProfitLockAt;
double ClosedProfit=0;
bool allowEnabled=true;
double HardStopAt;

Declare your globals and then set them in OnInit. The way you have declared and set in one won't work
  • #18
  • Edited 8:21am Dec 13, 2017 8:07am | Edited 8:21am
Quoting dietcoke
long chartID; int TryAgain=1; string name, chartSymbol=""; double ProfitLockNextJump=ProfitLockAt*ProfitJump; double ProfitBELockAt=ProfitLockAt*ProfitBE; double ProfitLocked=0; double CurrentProfit=0; double MaxProfit=0; double ProfitLockNext=ProfitLockAt; double ClosedProfit=0; bool allowEnabled=true; double HardStopAt; Declare your globals and then set them in OnInit. The way you have declared and set in one won't work
Took me a few minutes to understand what you're saying, I though OnInit() was only called when the EA is first placed on a chart not when it "refreshes".

I've changed the location and declarations as you've advised, it seems like this did the trick
Thanks!

Now, if you permit and willing, I have another question, I've tried to NormalizeDouble all my numbers but still, CurrentProfit and MaxProfit, when they change, first show a number with many places after the floating point and then revert back to a two point number.
I've added NormalizeDouble in all their occurrences but I don't seem to catch where it's reverting to that floating number instead of the shorter one.

Do you have any suggestions, maybe?

[EDIT]
After refreshing the EA on my charts, the problem disappeared. I'll keep an eye on it but hopefully it is gone.
Attached File(s)
File Type: mq4 ProfitSymbol.mq4   27 KB | 417 downloads
  • #19
  • Dec 13, 2017 11:01am Dec 13, 2017 11:01am
I thought I had it covered but I guess I'm still missing something.
All the CurrentProfit values are NormalizedDouble to two places after the floating point.
Obviously I'm missing something as after a few price changes it goes back to "regular" two places after the floating point view.
Attached Image (click to enlarge)
Click to Enlarge Name: EURAUDM2.png Size: 63 KB
  • #20
  • Dec 13, 2017 12:01pm Dec 13, 2017 12:01pm
Hi Reamasesa,

I'm not sure if you are familiar with OOP design concepts, but here is an example of something I did that was similar to what you are working on. Perhaps you can reuse this code or find some inspiration

I definitely recommend learning OOP if you haven't already - because it keeps your programs clean and super easy understand and debug. This is literally how the EA looks sans class definitions.
Inserted Code
#property strict
#include "ProgramClasses.mqh"
input CORNER Corner = UP_RIGHT;//Corner for Placement
input int Y_Distance = 30;
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
Program  program;
//+------------------------------------------------------------------+
int OnInit()
{
   if(!program.OnInit(Corner,Y_Distance))
      return INIT_FAILED;
   return(INIT_SUCCEEDED);
}
//+------------------------------------------------------------------+
void OnChartEvent(const int id,
                  const long &lparam,
                  const double &dparam,
                  const string &sparam)
{
   program.OnChartEvent(id, sparam);
}
//+------------------------------------------------------------------+
void OnTimer()
{
   program.OnTimer();
}
//+------------------------------------------------------------------+
void OnTick()
{
   program.OnTick();
}
Attached File(s)
File Type: mqh ProgramClasses.mqh   8 KB | 387 downloads
File Type: mq4 SimpleButtonCloseAllExample.mq4   1 KB | 403 downloads
0 traders viewing now