Help please... aged brain/ cold weather = coding problem | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

brain storming - everyone please join us :) 50 replies

Help with basic coding problem 16 replies

Help with coding this problem - sort buy orders 6 replies

problem, problem, is it MT4 platform or EA, Please help................ 1 reply

please help me in coding 1 reply

Attachments: Help please... aged brain/ cold weather = coding problem
Exit Attachments

Help please... aged brain/ cold weather = coding problem

  • #1
  • First Post: Dec 11, 2017 10:15am Dec 11, 2017 10:15am
Monitoring 34 pairs.
Values stored in array
Trying to count the number of up & down moves from the open within a particular bar.
Each time chart symbol is changed the returned numbers change and cannot work out why.
The routine below is called every tick or on symbol change.

Can you spot my error please?

Inserted Code
void CheckMulti()
 {
   datetime mBtime = iTime(NULL, mTF, 0);
   int mCnt = 0, mCntd = 0, mPipF = 1, i = 0;
   bool   mWait  = true, mWaitd = true;
   double mB1Op  = 0, mMove = 0;
   ArrayInitialize(mUD, 0);

   for(i = 0; i < mPairs; i++)
    { 
      string mName = UniqueID+":symbol:" + IntegerToString(i);
      mBtime = iTime(aSymbols[i], mTF, 0);
      mCnt = 0; mCntd = 0; mPipF = 1;
      mWait  = true; mWaitd = true;
      mB1Op  = iOpen(aSymbols[i], mTF, 0);
      if(MarketInfo(aSymbols[i], MODE_DIGITS) == 3 || MarketInfo(aSymbols[i], MODE_DIGITS) == 5)
        mPipF = 10; 
      mMove  = mCndlMove * Point * mPipF;
      // How many lower TF candles since higher TF open
      int mCndls = (int)(iTime(NULL, mCountTime, 0) - iTime(NULL, mTF, 0)) / mCountTime / 60;
      // Count moves up
      for(int n = 0; n < mCndls; n++)
        {
          if(iLow(aSymbols[i], mCountTime, iBarShift(aSymbols[i], mCountTime, mBtime) -n) <= mB1Op)
            mWait = false;
          if(iHigh(aSymbols[i], mCountTime, iBarShift(aSymbols[i], mCountTime, mBtime) -n) >= mB1Op + mMove && !mWait)
            {
              mCnt ++;
              mWait = true;
            }
        }
       mUD[i][0] = mCnt;
      // Count moves down       
      for(int d = 0; d < mCndls; d++)
        {
          if(iHigh(aSymbols[i], mCountTime, iBarShift(aSymbols[i], mCountTime, mBtime) - d) >= mB1Op)
            mWaitd = false;
          if(iLow(aSymbols[i], mCountTime, iBarShift(aSymbols[i], mCountTime, mBtime) - d) <= mB1Op - mMove && !mWaitd)
            {
              mCntd ++;
              mWaitd = true;
            }
        }
          mUD[i][1] = mCntd;
 
      }  // for i
    
   return;
 }

TIA

M.
If you think I'm mad, I must be mad
  • #2
  • Edited 12:11pm Dec 11, 2017 11:49am | Edited 12:11pm
Hi spec,

I'm looking at your code and here are my thoughts... but before I do I want to preface that I mean you no disrespect, just a little tough love from coder to coder

It's very difficult to understand what's going on here because of the way you named your variables. The typical convention for naming reserves variables starting with "m" to be used only for class member variables. In this instance there are both global and local variables using the class member naming so it's very confusing. Also it's unclear why there are different var names for the timeframe ie. mTF and mCountTime ...? Also, since you haven't encapsulated your code to the function (ie. you have a lot of other stuff going on outside of the function) it is impossible to tell you the source of your bug, however I can tell you that this is one of them
Inserted Code
 int mCndls = (int)(iTime(NULL, mCountTime, 0) - iTime(NULL, mTF, 0)) / mCountTime / 60;
Additionally, you have no logic to handle 4066/4073 errors - this will kill your account!

It just seems like you are trying to do way too much within the scope of this function and/or you're trying to implement something that really needs to make use of OOP. In any regard try to simplify your problem and break it down to smaller and more manageable steps, and also try to make better use of encapsulation and variable naming because it can quickly run away from you and cause you many head-aches down the road. Also, always remember to handle 4066/4073 errors when working outside of the symbol and timeframe on the chart.

Inserted Code
 
bool NetMovesInBar(int      &net_move,
                   string   symbol,
                   int      current_timeframe,
                   int      shift_of_bar_to_compare,
                   int      timeframe_for_inner_bars)
{
   datetime time_start  = iTime(symbol, current_timeframe, shift_of_bar_to_compare);
   datetime time_end    = time_start + PeriodSeconds(current_timeframe) - 1;
   MqlRates rates[];
   ArraySetAsSeries(rates, true);
   int total = -1;
   //<!!!> HANDLE 4066/4073 errors! 1000ms time-out
   long ms = GetTickCount();
   do
   {
      ResetLastError();
      total = CopyRates(symbol, timeframe_for_inner_bars, time_start, time_end, rates);
   }
   while(GetTickCount() - ms < 1000 && GetLastError() != ERR_NO_ERROR && !IsStopped());
   if(total <= 0)
      return false;
   for(int i = 0; i < total - 1; i++)
   {
      if(rates[i].close > rates[i + 1].close)
         net_move++; //bar closed up
      else
         net_move--; //bar closed down
   }
   return true;
}
//+------------------------------------------------------------------+
//| Script program start function                                    |
//+------------------------------------------------------------------+
void OnStart()
{
//---
   for(int i = 0; i < SymbolsTotal(true); i++)
   {
      string symbol = SymbolName(i, true);
      int net_move;
      bool has_data = NetMovesInBar(net_move, symbol, PERIOD_H1, 1, PERIOD_M1);
      if(has_data)
         Print(symbol + " net-moves = ", net_move);
      else
         Print("Data error: ", symbol);
   }
}

Good luck with your project!
  • #3
  • Dec 11, 2017 11:59am Dec 11, 2017 11:59am
Even I missed a potential 4066 error... see if you can spot where my bug was and what I did to correct it...
Inserted Code
bool NetMovesInBar(int      &net_move,
                   string   symbol,
                   int      current_timeframe,
                   int      shift_of_bar_to_compare,
                   int      timeframe_for_inner_bars)
{
   net_move=0;
   long ms = GetTickCount();
   datetime time_start;
   do
   {
      ResetLastError();
      time_start = iTime(symbol, current_timeframe, shift_of_bar_to_compare);
   }
   while(GetTickCount() - ms < 1000 && GetLastError() != ERR_NO_ERROR && !IsStopped());
   if(time_start <= 0)
      return false;
   datetime time_end = time_start + PeriodSeconds(current_timeframe) - 1;
   MqlRates rates[];
   ArraySetAsSeries(rates, true);
   //<!!!> HANDLE 4066/4073 errors! 1000ms time-out
   int total = -1;
   ms = GetTickCount();
   do
   {
      ResetLastError();
      total = CopyRates(symbol, timeframe_for_inner_bars, time_start, time_end, rates);
   }
   while(GetTickCount() - ms < 1000 && GetLastError() != ERR_NO_ERROR && !IsStopped());
   if(total <= 0)
      return false;
   for(int i = 0; i < total - 1; i++)
   {
      if(rates[i].close > rates[i + 1].close)
         net_move++; //bar closed up
      else
         net_move--; //bar closed down
   }
   return true;
}
//+------------------------------------------------------------------+
//| Script program start function                                    |
//+------------------------------------------------------------------+
void OnStart()
{
//---
   for(int i = 0; i < SymbolsTotal(true); i++)
   {
      string symbol = SymbolName(i, true);
      int net_move;
      bool has_data = NetMovesInBar(net_move, symbol, PERIOD_H1, 1, PERIOD_M1);
      if(has_data)
         Print(symbol + " net-moves = ", net_move);
      else
         Print("Data error: ", symbol);
   }
}
//+------------------------------------------------------------------+
  • #4
  • Dec 11, 2017 12:14pm Dec 11, 2017 12:14pm
Hi Nic,

Thanks for the reply and attempt to help.
Will try to get my head around it.

Your highlighted
int mCndls = (int)(iTime(NULL, mCountTime, 0) - iTime(NULL, mTF, 0)) / mCountTime / 60;

works ok I believe and returns the correct value (number of bars on lower TF)

Yes understand that only snippet of code and cannot see errors introduced elsewhere but code too long to put on here.

Thanks again for taking the time, much appreciated.

M.
If you think I'm mad, I must be mad
  • #5
  • Dec 11, 2017 12:23pm Dec 11, 2017 12:23pm
Quoting futurespec
Hi Nic, Thanks for the reply and attempt to help. Will try to get my head around it. Your highlighted int mCndls = (int)(iTime(NULL, mCountTime, 0) - iTime(NULL, mTF, 0)) / mCountTime / 60; works ok I believe and returns the correct value (number of bars on lower TF) Yes understand that only snippet of code and cannot see errors introduced elsewhere but code too long to put on here. Thanks again for taking the time, much appreciated. M.
For various reasons your history data will not always provide you with exactly 60 M1 bars for each hour. This is a bug because if your platform only has, say, 46 bars from 11:00 to 11:59:59 then you're going to be counting bars outside of your time window.
  • #6
  • Dec 11, 2017 12:27pm Dec 11, 2017 12:27pm
Mmm . not come across that before.

Are there really cases when there are not 60 1m bars in the hour???
(I suppose if some data is missing).

One very good lesson here being that need to allow for ALL potential errors

M.
If you think I'm mad, I must be mad
  • #7
  • Dec 11, 2017 12:37pm Dec 11, 2017 12:37pm
Quoting futurespec
Mmm . not come across that before. Are there really cases when there are not 60 1m bars in the hour??? (I suppose if some data is missing). One very good lesson here being that need to allow for ALL potential errors M.
There's only one way to learn... test. Save and run this script and you tell me...
Inserted Code
#property strict
bool NetMovesInBar(int      &net_move,
                   string   symbol,
                   int      current_timeframe,
                   int      shift_of_bar_to_compare,
                   int      timeframe_for_inner_bars)
{
   long ms = GetTickCount();
   datetime time_start;
   do
   {
      ResetLastError();
      time_start = iTime(symbol, current_timeframe, shift_of_bar_to_compare);
   }
   while(GetTickCount() - ms < 1000 && GetLastError() != ERR_NO_ERROR && !IsStopped());
   if(time_start <= 0)
      return false;
   datetime time_end = time_start + PeriodSeconds(current_timeframe) - 1;
   MqlRates rates[];
   ArraySetAsSeries(rates, true);
   //<!!!> HANDLE 4066/4073 errors! 1000ms time-out
   int total = -1;
   ms = GetTickCount();
   do
   {
      ResetLastError();
      total = CopyRates(symbol, timeframe_for_inner_bars, time_start, time_end, rates);
   }
   while(GetTickCount() - ms < 1000 && GetLastError() != ERR_NO_ERROR && !IsStopped());
   if(total <= 0)
      return false;
   if(total!=60)
      Print(symbol," on ",EnumToString((ENUM_TIMEFRAMES)timeframe_for_inner_bars), " has ",total," bars");
   
   for(int i = 0; i < total - 1; i++)
   {
      if(rates[i].close > rates[i + 1].close)
         net_move++; //bar closed up
      else
         net_move--; //bar closed down
   }
   return true;
}

//+------------------------------------------------------------------+
//| Script program start function                                    |
//+------------------------------------------------------------------+
void OnStart()
{
//---
   for(int i = 0; i < SymbolsTotal(false); i++)
   {
      string symbol = SymbolName(i, false);
      int net_move;
      bool has_data = NetMovesInBar(net_move, symbol, PERIOD_H1, 1, PERIOD_M1);
      if(has_data)
         Print(symbol + " net-moves = ", net_move);
      else
         Print("Data error: ", symbol);
   }
}
//+------------------------------------------------------------------+
  • #8
  • Dec 11, 2017 12:47pm Dec 11, 2017 12:47pm
Yes proves the point and taken on board.
Thanks,
M.
If you think I'm mad, I must be mad
  • #9
  • Dec 11, 2017 12:53pm Dec 11, 2017 12:53pm
Quoting Nicholishen
{quote} There's only one way to learn... test. Save and run this script and you tell me... #property strict bool NetMovesInBar(int &net_move, string symbol, int current_timeframe, int shift_of_bar_to_compare, int timeframe_for_inner_bars) { long ms = GetTickCount(); datetime time_start; do { ResetLastError(); time_start = iTime(symbol, current_timeframe, shift_of_bar_to_compare); } while(GetTickCount() - ms < 1000 && GetLastError() != ERR_NO_ERROR && !IsStopped()); if(time_start <= 0) return false; datetime time_end = time_start + PeriodSeconds(current_timeframe)...
@nicolishen:
just for my interest...
what does this script do?
Thanks for an info for a NON-coder.
Reg.Zack
  • #10
  • Dec 11, 2017 1:03pm Dec 11, 2017 1:03pm
Alternatively, instead of making your own 4066/4073 error handling routines every time you call an iTimeseries function, you can use the replacement functions in my included library. The preceding script looks like this instead...
Inserted Code
#include <multi_symbol_timeframe.mqh>
bool NetMovesInBar(int      &net_move,
                   string   symbol,
                   int      current_timeframe,
                   int      shift_of_bar_to_compare,
                   int      timeframe_for_inner_bars)
{
   net_move=0;
   datetime time_start;
   if(!iTime(time_start, symbol, current_timeframe, shift_of_bar_to_compare))
      return false;
   datetime time_end = time_start + PeriodSeconds(current_timeframe) - 1;
   MqlRates rates[];
   ArraySetAsSeries(rates, true);
   int total = CopyRatesArray(symbol, timeframe_for_inner_bars, time_start, time_end, rates);
   if(total < 0)
      return false;
   if(total != 60)
      Print(symbol, " on ", EnumToString((ENUM_TIMEFRAMES)timeframe_for_inner_bars), " has ", total, " bars");
   for(int i = 0; i < total - 1; i++)
   {
      if(rates[i].close > rates[i + 1].close)
         net_move++; //bar closed up
      else
         net_move--; //bar closed down
   }
   return true;
}
Attached File(s)
File Type: mqh multi_symbol_timeframe.mqh   12 KB | 290 downloads
  • #11
  • Dec 11, 2017 1:07pm Dec 11, 2017 1:07pm
Quoting zackery
{quote} @nicolishen: just for my interest... what does this script do? Thanks for an info for a NON-coder. Reg.Zack
This takes a bar (eg. H1 bar) and counts the net moves of the inner (M1 in this example) bars. So for each bar in the hour starting at the first bar - if the next bar closes up then the net count goes up by one and if the bars closes down then the count goes down by one.
  • #12
  • Dec 11, 2017 1:10pm Dec 11, 2017 1:10pm
Quoting Nicholishen
{quote} This takes a bar (eg. H1 bar) and counts the net moves of the inner (M1 in this example) bars. So for each bar in the hour starting at the first bar - if the next bar closes up then the net count goes up by one and if the bars closes down then the count goes down by one.
Thanks a lot for your explanation.
But it freezes my Plattform when using on M1-TF.
Will test it on H1 now.
Reg.Zack
  • #13
  • Dec 11, 2017 1:11pm Dec 11, 2017 1:11pm
Too kind.
Thanks once more

M.

If you think I'm mad, I must be mad
  • #14
  • Last Post: Dec 11, 2017 1:23pm Dec 11, 2017 1:23pm
Quoting zackery
{quote} Thanks a lot for your explanation. But it freezes my Plattform when using on M1-TF. Will test it on H1 now. Reg.Zack
It doesn't matter what timeframe you run it on... that's the point. This is a demonstration of MTF code. It will freeze your platform until all your symbols' data is downloaded from broker and available [OR] the code times-out. Patience young grasshopper.
0 traders viewing now