Attachments: I need help to find a problem in the code

I need help to find a problem in the code

#1
First Post: Edited 10:15am Nov 21, 2017 9:09am | Edited 10:15am

Georgebaker
Joined Nov 2009 | Status: Trader | 953 Posts

I want to check if two previous candles have a range of let's say 10 pips or more, but the strategy tester ignores the check for the range size.

Inserted Code

       double Range1 = ((High[2]-Low[2])/Point)/10;
       double Range2 = ((High[3]-Low[3])/Point)/10;
        
       double CandleHigh = 10;  
      
       if(Range1>=CandleHigh)
         Range_candle1 = true;
            
       if(Range2>=CandleHigh)
         Range_candle2 = true;
      
   if(TotalOpenOrders() == 0 && IsNewBar() == true)
   {
      // Check Sell Entry
      if(Open[3] > Close[3] && Open[2] > Close[2] && Open[1] > Close[1] && High[1] > High[2]+2*Point && Range_candle1 == true && Range_candle2 == true)
      {
         OpenSell();
         Comment("Range_1 : " + DoubleToString(Range1) + " Range_2: " + DoubleToString(Range2));
         Range_candle1 = false;
         Range_candle2 = false;
      }
      else
      // Check Buy Entry
      if(Open[3] < Close[3] && Open[2] < Close[2] && Open[1] < Close[1] && Low[1] < Low[2]-2*Point && Range_candle1 == true && Range_candle2 == true)
      {
         OpenBuy();
         Comment("Range_1 : " + DoubleToString(Range1) + " Range_2: " + DoubleToString(Range2));
         Range_candle1 = false;
         Range_candle2 = false;
      }
   }

Can anyone tell me what is wrong with the code? It works in my brain

but not in the strategy tester.

Sorry! I have cleaned the code up a bit.

Blindly following others will make you blind!

#2
Nov 21, 2017 1:31pm Nov 21, 2017 1:31pm

mladen
Joined Apr 2007 | Status: ... | 817 Posts

Quoting Georgebaker

Disliked

I want to check if two previous candles have a range of let's say 10 pips or more, but the strategy tester ignores the check for the range size. double Range1 = ((High[2]-Low[2])/Point)/10; double Range2 = ((High[3]-Low[3])/Point)/10; double CandleHigh = 10; if(Range1>=CandleHigh) Range_candle1 = true; if(Range2>=CandleHigh) Range_candle2 = true; if(TotalOpenOrders() == 0 && IsNewBar() == true) { // Check Sell Entry if(Open[3] > Close[3] && Open[2] > Close[2] && Open[1] > Close[1] && High[1] > High[2]+2*Point && Range_candle1 == true && Range_candle2...

Ignored

How does the strategy tester "ignores" it?
Used this code for testing the range conditions, and all works as expected :

Inserted Code

#property  indicator_chart_window
#property  indicator_buffers 0
#property  indicator_plots   0
int  OnInit()                   { return(0); }
void OnDeinit(const int reason) {            }
int  OnCalculate (const int rates_total,
                 const int prev_calculated,
                 const datetime& time[],
                 const double& open[],
                 const double& high[],
                 const double& low[],
                 const double& close[],
                 const long& tick_volume[],
                 const long& volume[],
                 const int& spread[])
{
    double Range1 = ((High[2]-Low[2])/Point)/10;
    double Range2 = ((High[3]-Low[3])/Point)/10;
        
    double CandleHigh = 10;  
   
    bool Range_candle1 = (Range1>=CandleHigh) ? true : false;
    bool Range_candle2 = (Range2>=CandleHigh) ? true : false;
    if(Range_candle1 == true && Range_candle2 == true)
    {
         Comment("Range_1 : " + DoubleToString(Range1) + " Range_2: " + DoubleToString(Range2));
   }
   return(rates_total);
}

#3
Nov 21, 2017 1:40pm Nov 21, 2017 1:40pm

Georgebaker
Joined Nov 2009 | Status: Trader | 953 Posts

Quoting mladen

Disliked

{quote} How does the strategy tester "ignores" it? Used this code for testing the range conditions, and all works as expected : #property indicator_chart_window #property indicator_buffers 0 #property indicator_plots 0 int OnInit() { return(0); } void OnDeinit(const int reason) { } int OnCalculate (const int rates_total, const int prev_calculated, const datetime& time[], const double& open[], const double& high[], const double& low[], const double& close[], const long& tick_volume[], const long& volume[], const int& spread[]) { double Range1 = ((High[2]-Low[2])/Point)/10;...

Ignored

In strategy tester it takes the same trades as before, that means if one or two previous candles are 3.9 pips and 6 pips range, the EA still takes the trades and ignore the code that i have added to prevent this.

But let me try the code you have provided here and see how it works.

Blindly following others will make you blind!

#4
Nov 21, 2017 1:51pm Nov 21, 2017 1:51pm

sakisf
Joined Sep 2013 | Status: boreddddd | 3,137 Posts

Quoting Georgebaker

Disliked

{quote} In strategy tester it takes the same trades as before, that means if one or two previous candles are 3.9 pips and 6 pips range, the EA still takes the trades and ignore the code that i have added to prevent this. But let me try the code you have provided here and see how it works.

Ignored

Check your conditions too:

Inserted Code

if( (Open[3] > Close[3]) && (Open[2] > Close[2]) && (Open[1] > Close[1]) && (High[1] > (High[2]+2*Point)) && (Range_candle1 = true) && (Range_candle2 = true) )

#5
Nov 21, 2017 1:57pm Nov 21, 2017 1:57pm

Georgebaker
Joined Nov 2009 | Status: Trader | 953 Posts

Quoting sakisf

Disliked

{quote} Check your conditions too: if( (Open[3] > Close[3]) && (Open[2] > Close[2]) && (Open[1] > Close[1]) && (High[1] > (High[2]+2*Point)) && (Range_candle1 = true) && (Range_candle2 = true) )

Ignored

Blindly following others will make you blind!

#6
Nov 21, 2017 2:24pm Nov 21, 2017 2:24pm

Georgebaker
Joined Nov 2009 | Status: Trader | 953 Posts

I have remove my other logic now so it should only take trades if the range of previous candle 1 and 2 is greater than 10 pips, but it still take the trades even though the are less than 10 pips.

The simplified code looks like this now.

Inserted Code

void OnTick()
  {
    
   double Range1 = ((High[2]-Low[2])/Point)/10;
   double Range2 = ((High[3]-Low[3])/Point)/10;
         
   double CandleHigh = 10;
      
   bool Range_candle1 = (Range1>=CandleHigh) ? true : false;
   bool Range_candle2 = (Range2>=CandleHigh) ? true : false;
      
   if(TotalOpenOrders() == 0 && IsNewBar() == true)
   { 
      // Check Sell Entry
      if( (Range_candle1 = true) && (Range_candle2 = true) )
      {
         OpenSell();
         Comment("Range_1 : " + DoubleToString(Range1) + " Range_2: " + DoubleToString(Range2));
      }
      else
            
      // Check Buy Entry
      if( (Range_candle1 == true) && (Range_candle2 == true) )
      { 
         OpenBuy();
         Comment("Range_1 : " + DoubleToString(Range1) + " Range_2: " + DoubleToString(Range2));
      }
   }   
  }

Attached Image (click to enlarge)

Click to Enlarge

Name: FF_chart1.jpg
Size: 116 KB

Blindly following others will make you blind!

#7
Nov 21, 2017 2:36pm Nov 21, 2017 2:36pm

mladen
Joined Apr 2007 | Status: ... | 817 Posts

Quoting Georgebaker

Disliked

I have remove my other logic now so it should only take trades if the range of previous candle 1 and 2 is greater than 10 pips, but it still take the trades even though the are less than 10 pips. The simplified code looks like this now. void OnTick() { double Range1 = ((High[2]-Low[2])/Point)/10; double Range2 = ((High[3]-Low[3])/Point)/10; double CandleHigh = 10; bool Range_candle1 = (Range1>=CandleHigh) ? true : false; bool Range_candle2 = (Range2>=CandleHigh) ? true : false; if(TotalOpenOrders() == 0 && IsNewBar() == true) { // Check Sell Entry...

Ignored

Checking the sell condition is wrong
You can not use this :

Inserted Code

(Range_candle1 = true) && (Range_candle2 = true)

Since with single "=" is assigning true value to those variables not comparing them to "true" value. Use this instead :

Inserted Code

(Range_candle1 == true) && (Range_candle2 == true)

Also you have exactly the same condition for buy and sell now - that should be changed somehow

#8
Nov 21, 2017 2:40pm Nov 21, 2017 2:40pm

sakisf
Joined Sep 2013 | Status: boreddddd | 3,137 Posts

Quoting Georgebaker

Disliked

I have remove my other logic now so it should only take trades if the range of previous candle 1 and 2 is greater than 10 pips, but it still take the trades even though the are less than 10 pips. The simplified code looks like this now. void OnTick() { double Range1 = ((High[2]-Low[2])/Point)/10; double Range2 = ((High[3]-Low[3])/Point)/10; double CandleHigh = 10; bool Range_candle1 = (Range1>=CandleHigh) ? true : false; bool Range_candle2 = (Range2>=CandleHigh) ? true : false; if(TotalOpenOrders() == 0 && IsNewBar() == true) { // Check Sell Entry...

Ignored

Made a mistake there with the ='s. Should work as mladen said above. Add your additional conditions to discern between sell/buy.
White arrows are where it would have placed a trade in Eur M30.

Attached Image (click to enlarge)

Click to Enlarge

Name: FQLZMOCPTF2OBkvV0s9odw.png
Size: 50 KB

Attached File(s)

Level - Copy.mq4 3 KB | 419 downloads

#9
Nov 21, 2017 2:47pm Nov 21, 2017 2:47pm

Georgebaker
Joined Nov 2009 | Status: Trader | 953 Posts

Yes now with the changes you said mLaden is do it correctly, now back to the original trade conditions. Let me try to add the code from before.

For the Sell condition:

Inserted Code

(Open[3] > Close[3]) && (Open[2] > Close[2]) && (Open[1] > Close[1]) && (High[1] > (High[2]+2*Point)) &&

And for the Buy condition:

Inserted Code

(Open[3] > Close[3]) && (Open[2] > Close[2]) && (Open[1] > Close[1]) && (High[1] > (High[2]+2*Point)) &&

And see how it works.

Blindly following others will make you blind!

#10
Nov 21, 2017 3:00pm Nov 21, 2017 3:00pm

Georgebaker
Joined Nov 2009 | Status: Trader | 953 Posts

Is this the correct way of saying e.g if the low of candle [1] is 2 pips lower than candle [2]?

I mean this -2*Point.

Inserted Code

(Low[1] < (Low[2]-2*Point)

Blindly following others will make you blind!

#11
Nov 21, 2017 3:16pm Nov 21, 2017 3:16pm

Georgebaker
Joined Nov 2009 | Status: Trader | 953 Posts

The code is here, but i need to do something about the logic cause it's not working correctly.

Inserted Code

   double Range1 = ((High[2]-Low[2])/Point)/10;
   double Range2 = ((High[3]-Low[3])/Point)/10;
         
   double CandleHigh = 10;
      
   bool Range_candle1 = (Range1>=CandleHigh) ? true : false;
   bool Range_candle2 = (Range2>=CandleHigh) ? true : false;
      
   if(TotalOpenOrders() == 0 && IsNewBar() == true)
   { 
      // Check Sell Entry
      if((Open[3] > Close[3]) && (Open[2] > Close[2]) && (Open[1] > Close[1]) && (High[1] > (High[2]+2*Point)) )
      {
         OpenSell();
         Comment("Range_1 : " + DoubleToString(Range1) + " Range_2: " + DoubleToString(Range2));
      }
      else
            
      // Check Buy Entry
      if((Open[3] < Close[3]) && (Open[2] < Close[2]) && (Open[1] < Close[1]) && (Low[1] < (Low[2]-2*Point))  )
      { 
         OpenBuy();
         Comment("Range_1 : " + DoubleToString(Range1) + " Range_2: " + DoubleToString(Range2));
      }
   }

Blindly following others will make you blind!

#12
Nov 21, 2017 3:21pm Nov 21, 2017 3:21pm

sakisf
Joined Sep 2013 | Status: boreddddd | 3,137 Posts

Quoting Georgebaker

Disliked

Is this the correct way of saying e.g if the low of candle [1] is 2 pips lower than candle [2]? I mean this -2*Point. (Low[1] < (Low[2]-2*Point)

Ignored

20*Point

In the code above you forgot to add your Range checks.

#13
Nov 21, 2017 4:43pm Nov 21, 2017 4:43pm

mladen
Joined Apr 2007 | Status: ... | 817 Posts

For forex symbols maybe the simplest way to "covert" something to pips is this (just in case if some broker still has 4 digit symbols - and a know a few such brokers

) :

Inserted Code

(desired number of pips)*(_Point*MathPow(10,MathMod(_Digits,2)))

#14
Nov 22, 2017 11:50am Nov 22, 2017 11:50am

Georgebaker
Joined Nov 2009 | Status: Trader | 953 Posts

Quoting sakisf

Disliked

{quote} 20*Point In the code above you forgot to add your Range checks.

Ignored

Yes correct, but it created some error at some point that's the reason i took it out.

Blindly following others will make you blind!

#15
Nov 22, 2017 11:50am Nov 22, 2017 11:50am

Georgebaker
Joined Nov 2009 | Status: Trader | 953 Posts

Quoting mladen

Disliked

For forex symbols maybe the simplest way to "covert" something to pips is this (just in case if some broker still has 4 digit symbols - and a know a few such brokers ) : (desired number of pips)*(_Point*MathPow(10,MathMod(_Digits,2)))

Ignored

Thanks!

Blindly following others will make you blind!

#16
Last Post: Nov 22, 2017 11:53am Nov 22, 2017 11:53am

Georgebaker
Joined Nov 2009 | Status: Trader | 953 Posts

Here is the code, but still need some tweaks here and there.

Inserted Code

   double Range1 = ((High[2]-Low[2])/Point)/10;
   double Range2 = ((High[3]-Low[3])/Point)/10;
        
   double CandleHigh = 10;
      
   bool Range_candle1 = (Range1>=CandleHigh) ? true : false;
   bool Range_candle2 = (Range2>=CandleHigh) ? true : false;
      
   if(TotalOpenOrders() == 0 && IsNewBar() == true)
   {
      // Check Sell Entry
      if((Open[3] > Close[3]) && (Open[2] > Close[2]) && (Open[1] > Close[1]) && (High[1] > (High[2]+20*(_Point*MathPow(10,MathMod(_Digits,2))))) && (Range_candle1 == true) && (Range_candle2 == true) )
      {
         OpenSell();
         Comment("Range_1 : " + DoubleToString(Range1) + " Range_2: " + DoubleToString(Range2));
      }
      else
            
      // Check Buy Entry
      if((Open[3] < Close[3]) && (Open[2] < Close[2]) && (Open[1] < Close[1]) && (Low[1] < (Low[2]-20*(_Point*MathPow(10,MathMod(_Digits,2))))) && (Range_candle1 == true) && (Range_candle2 == true) )
      {
         OpenBuy();
         Comment("Range_1 : " + DoubleToString(Range1) + " Range_2: " + DoubleToString(Range2));
      }
   }

Blindly following others will make you blind!

Platform Tech
/
I need help to find a problem in the code
Reply to Thread

0 traders viewing now

Options

Similar Threads

I need help to find a problem in the code