I have a time problem in my code

extern int iHour1 = 10;
extern int iHour2 = 20;

               if(TimeHour(Time[i])==iHour1 && TimeMinute(Time[i])==0)
               {
                  x++;
                  ObjectCreate("Time" + x,OBJ_VLINE,0,Time[i],High[i]);
                  ObjectSet("Time" + x,OBJPROP_COLOR,Red); // Color value to set/get object color.
                  ObjectSet("Time" + x,OBJPROP_STYLE,STYLE_DOT); // Value is one of STYLE_SOLID, STYLE_DASH, STYLE_DOT, STYLE_DASHDOT, STYLE_DASHDOTDOT constants to set/get object line style.
                  ObjectSet("Time" + x,OBJPROP_WIDTH,1); // Integer value to set/get object line width. Can be from 1 to 5.
                  ObjectSet("Time" + x,OBJPROP_BACK,true); // Boolean value to set/get background drawing flag for object. (for example "true" will hide the value at the bottom of the chart.)
               }
               else
               {        
                  if(TimeHour(Time[i])==iHour2 && TimeMinute(Time[i])==0)
                  {
                     x++;
                     ObjectCreate("Time" + x,OBJ_VLINE,0,Time[i],High[i]);
                     ObjectSet("Time" + x,OBJPROP_COLOR,Yellow); // Color value to set/get object color.
                     ObjectSet("Time" + x,OBJPROP_STYLE,STYLE_DOT); // Value is one of STYLE_SOLID, STYLE_DASH, STYLE_DOT, STYLE_DASHDOT, STYLE_DASHDOTDOT constants to set/get object line style.
                     ObjectSet("Time" + x,OBJPROP_WIDTH,1); // Integer value to set/get object line width. Can be from 1 to 5.
                     ObjectSet("Time" + x,OBJPROP_BACK,true); // Boolean value to set/get background drawing flag for object. (for example "true" will hide the value at the bottom of the chart.)
  
                  }
               }

Quoting Nicholishen

Disliked

You're probably missing the one minute window for drawing the line somehow... Perhaps there were no ticks during that window or another reason... Your code should never be so absolute because you will experience bugs. Instead your algo should be something along the lines of: if line doesn't exist and time is >= draw_time then draw line. Also, don't use "extern" unless you absolutely have a need to change the input parameter in the code (which should be never), use the "input" keyword instead because you want the compiler to complain if you accidentally...

Ignored

Quoting Georgebaker

Disliked

{quote} Forgot to say i'm testing this in the strategy tester, so what is it about this minute? If i set iHour1 to 7 is doesn't work, but if i set iHour1 to 10 it works. Strange isn't it?

Ignored

Quoting Nicholishen

Disliked

{quote} Like I said... you cannot use absolutes. Your code says do this ONLY if the exact time is 7hrs and 00 mins.

Ignored

input int iHour1 = 7;
input int iHour2 = 20;

if(TimeHour(Time[i])==iHour1 && TimeMinute(Time[i])>=0)
               {
                  x++;
                  ObjectCreate("Time" + x,OBJ_VLINE,0,Time[i],High[i]);
                  ObjectSet("Time" + x,OBJPROP_COLOR,Red); // Color value to set/get object color.
                  ObjectSet("Time" + x,OBJPROP_STYLE,STYLE_DOT); // Value is one of STYLE_SOLID, STYLE_DASH, STYLE_DOT, STYLE_DASHDOT, STYLE_DASHDOTDOT constants to set/get object line style.
                  ObjectSet("Time" + x,OBJPROP_WIDTH,1); // Integer value to set/get object line width. Can be from 1 to 5.
                  ObjectSet("Time" + x,OBJPROP_BACK,true); // Boolean value to set/get background drawing flag for object. (for example "true" will hide the value at the bottom of the chart.)
               }
               else
               {        
                  if(TimeHour(Time[i])==iHour2 && TimeMinute(Time[i])>=0)
                  {
                     x++;
                     ObjectCreate("Time" + x,OBJ_VLINE,0,Time[i],High[i]);
                     ObjectSet("Time" + x,OBJPROP_COLOR,Yellow); // Color value to set/get object color.
                     ObjectSet("Time" + x,OBJPROP_STYLE,STYLE_DOT); // Value is one of STYLE_SOLID, STYLE_DASH, STYLE_DOT, STYLE_DASHDOT, STYLE_DASHDOTDOT constants to set/get object line style.
                     ObjectSet("Time" + x,OBJPROP_WIDTH,1); // Integer value to set/get object line width. Can be from 1 to 5.
                     ObjectSet("Time" + x,OBJPROP_BACK,true); // Boolean value to set/get background drawing flag for object. (for example "true" will hide the value at the bottom of the chart.)
  
                  }
               }

Quoting sakisf

Disliked

How do you initialize x? Global or local? If local does it run as int x=0 before the loop? Then each time you will get x=0, each new vertical will delete the previous. And make sure you are switched at 1hr tf and not 4hr because 4hr won't show your line at 7:00. {file}

Ignored