Resetting variables at midnight | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Fibos Midnight 2 midnight 3 replies

Indicator Resetting 15 replies

Midnight to midnight Floor pivots 4 replies

resetting balance 2 replies

Resetting Market Watch to local Time 1 reply

Resetting variables at midnight

  • #1
  • First Post: Oct 24, 2017 9:54am Oct 24, 2017 9:54am
How can i reset var at midnight? I mean if no ticks is coming in for at minute or so then the var will not be reset.

I know this is not the right to do but this is the only way my brain can think of right now. There must be a easier way to do this?

Inserted Code
double DayHigh = 0;
   double Day2ndHigh = 0;
   double DayLow = 0;
   double Day2ndLow = 0;          
   string time_hours = TimeHour(TimeCurrent());
   string time_minutes = TimeMinute(TimeCurrent());
   string time_seconds = TimeSeconds(TimeCurrent());            
  
   if ((time_hours == 00) && (time_minutes == 00) && (time_seconds == 00))
   {
      //Reset Highs/Lows
      double DayHigh = 0;
      double Day2ndHigh = 0;
      double DayLow = 0;
      double Day2ndLow = 0;
   }

Could it be made without relying on ticks?
Blindly following others will make you blind!
  • #2
  • Oct 24, 2017 10:31am Oct 24, 2017 10:31am
Quoting Georgebaker
How can i reset var at midnight? I mean if no ticks is coming in for at minute or so then the var will not be reset. I know this is not the right to do but this is the only way my brain can think of right now. There must be a easier way to do this? double DayHigh = 0; double Day2ndHigh = 0; double DayLow = 0; double Day2ndLow = 0; string time_hours = TimeHour(TimeCurrent()); string time_minutes = TimeMinute(TimeCurrent()); string time_seconds = TimeSeconds(TimeCurrent()); if ((time_hours == 00) && (time_minutes == 00) && (time_seconds == 00)) {...
Yes, you'll need to use the OnTimer() function. Also you will want to avoid absolutes; like if the seconds are equal to zero because you might miss the window where the second is exactly zero and then your code wouldn't work.

Inserted Code
int OnInit()
{
//--- create timer
   EventSetTimer(1);
//---
   return(INIT_SUCCEEDED);
}
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
{
//--- destroy timer
   EventKillTimer();
}
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
{
//---
}
//+------------------------------------------------------------------+
//| Timer function                                                   |
//+------------------------------------------------------------------+
void OnTimer()
{
//---
   ResetVarsAtMidnight();
}
//+------------------------------------------------------------------+
double DayHigh = 0;
double Day2ndHigh = 0;
double DayLow = 0;
double Day2ndLow = 0;
void ResetVarsAtMidnight()
{
   static datetime   last_reset = 0;
   MqlDateTime       last_reset_struct;
   if(last_reset==0 || TimeCurrent() >= last_reset+PeriodSeconds(PERIOD_D1))
   {
      //Reset Highs/Lows
      DayHigh = 0;
      Day2ndHigh = 0;
      DayLow = 0;
      Day2ndLow = 0;
      TimeCurrent(last_reset_struct);
      last_reset_struct.hour = 0;
      last_reset_struct.min = 0;
      last_reset_struct.sec = 0;
      last_reset = StructToTime(last_reset_struct);
      return; 
   }
}
  • #3
  • Edited 1:41pm Oct 24, 2017 12:43pm | Edited 1:41pm
Quoting Nicholishen
{quote} Yes, you'll need to use the OnTimer() function. Also you will want to avoid absolutes; like if the seconds are equal to zero because you might miss the window where the second is exactly zero and then your code wouldn't work. int OnInit() { //--- create timer EventSetTimer(1); //--- return(INIT_SUCCEEDED); } //+------------------------------------------------------------------+ //| Expert deinitialization function | //+------------------------------------------------------------------+ void OnDeinit(const int reason) { //--- destroy timer...
Thank you for the code example!

Should i not be able to test it by set it to:

last_reset_struct.hour = 20;
last_reset_struct.min = 40;
last_reset_struct.sec = 00;

If so, it doesn't set the vars to 0.
Blindly following others will make you blind!
  • #4
  • Oct 24, 2017 7:15pm Oct 24, 2017 7:15pm
That should reset every day @ 20:40
  • #5
  • Oct 24, 2017 11:15pm Oct 24, 2017 11:15pm
Quoting Nicholishen
That should reset every day @ 20:40
Yes, but it does not reset the var's
Blindly following others will make you blind!
  • #6
  • Oct 25, 2017 8:58am Oct 25, 2017 8:58am
Quoting Georgebaker
{quote} Yes, but it does not reset the var's
Because it doesn't reset until the following day after initialization. If you want it to be able to to do you are wanting it to then you need to add some initialization logic and initialize it to the previous day.
Inserted Code
int OnInit()
{
//--- create timer
   EventSetTimer(1);
//---
   return(INIT_SUCCEEDED);
}
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
{
//--- destroy timer
   EventKillTimer();
}
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
{
//---
}
//+------------------------------------------------------------------+
//| Timer function                                                   |
//+------------------------------------------------------------------+
void OnTimer()
{
//---
   ResetVarsAtMidnight();
}
//+------------------------------------------------------------------+
double DayHigh = 0;
double Day2ndHigh = 0;
double DayLow = 0;
double Day2ndLow = 0;
void ResetVarsAtMidnight()
{
   MqlDateTime       last_reset_struct;
   static datetime   last_reset = TimeCurrent();
   static bool       is_init = false;
   int hour=0;
   int min=0;
   int sec=0;
   if(!is_init)
   {
      last_reset-= PeriodSeconds(PERIOD_D1);
      TimeToStruct(last_reset,last_reset_struct);
      last_reset_struct.hour = hour;
      last_reset_struct.min = min;
      last_reset_struct.sec = sec;
      last_reset = StructToTime(last_reset_struct);
      is_init = true;
   }
   if( TimeCurrent() >= last_reset+PeriodSeconds(PERIOD_D1))
   {
      //Reset Highs/Lows
      DayHigh = 0;
      Day2ndHigh = 0;
      DayLow = 0;
      Day2ndLow = 0;
      TimeCurrent(last_reset_struct);
      last_reset_struct.hour = hour;
      last_reset_struct.min = min;
      last_reset_struct.sec = sec;
      last_reset = StructToTime(last_reset_struct);
      return;
   }
}
  • #7
  • Oct 25, 2017 1:14pm Oct 25, 2017 1:14pm
Quoting Nicholishen
{quote} Because it doesn't reset until the following day after initialization. If you want it to be able to to do you are wanting it to then you need to add some initialization logic and initialize it to the previous day. int OnInit() { //--- create timer EventSetTimer(1); //--- return(INIT_SUCCEEDED); } //+------------------------------------------------------------------+ //| Expert deinitialization function | //+------------------------------------------------------------------+ void OnDeinit(const int reason) { //--- destroy timer EventKillTimer();...
I'm trying this to see if it works, but i cannot see the var be set to zero at e.g. 21:10:00, why?

Inserted Code
//+------------------------------------------------------------------+
//|                                                                         Test.mq4 |
//|                       Copyright 2017, MetaQuotes Software Corp. |
//|                                                     https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2017, MetaQuotes Software Corp."
#property link      "https://www.mql5.com"
#property version   "1.00"
#property strict
int OnInit()
{
//--- create timer
   EventSetTimer(1);
//---
   return(INIT_SUCCEEDED);
}
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
{
//--- destroy timer
   EventKillTimer();
}
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
{
DayHigh = High[1];
Day2ndHigh = High[2];
DayLow = Low[1];
Day2ndLow = Low[2];
Comment("High_1 :" + DayHigh + " High_2: " + Day2ndHigh + "  Low_1:" + DayLow + " Low_2:" + Day2ndLow);
}
//+------------------------------------------------------------------+
//| Timer function                                                   |
//+------------------------------------------------------------------+
void OnTimer()
{
//---
   ResetVarsAtMidnight();
}
//+------------------------------------------------------------------+
double DayHigh = 0;
double Day2ndHigh = 0;
double DayLow = 0;
double Day2ndLow = 0;
void ResetVarsAtMidnight()
{
   MqlDateTime       last_reset_struct;
   static datetime   last_reset = TimeCurrent();
   static bool       is_init = false;
   int hour=21;
   int min=10;
   int sec=0;
   if(!is_init)
   {
      last_reset-= PeriodSeconds(PERIOD_D1);
      TimeToStruct(last_reset,last_reset_struct);
      last_reset_struct.hour = hour;
      last_reset_struct.min = min;
      last_reset_struct.sec = sec;
      last_reset = StructToTime(last_reset_struct);
      is_init = true;
   }
   if( TimeCurrent() >= last_reset+PeriodSeconds(PERIOD_D1))
   {
      //Reset Highs/Lows
      DayHigh = 0;
      Day2ndHigh = 0;
      DayLow = 0;
      Day2ndLow = 0;
      TimeCurrent(last_reset_struct);
      last_reset_struct.hour = hour;
      last_reset_struct.min = min;
      last_reset_struct.sec = sec;
      last_reset = StructToTime(last_reset_struct);
      return;
   }
}
Blindly following others will make you blind!
  • #8
  • Oct 25, 2017 1:56pm Oct 25, 2017 1:56pm
Quoting Georgebaker
{quote} I'm trying this to see if it works, but i cannot see the var be set to zero at e.g. 21:10:00, why? //+------------------------------------------------------------------+ //| Test.mq4 | //| Copyright 2017, MetaQuotes Software Corp. | //| https://www.mql5.com | //+------------------------------------------------------------------+ #property copyright "Copyright 2017, MetaQuotes Software Corp." #property link "https://www.mql5.com" #property version "1.00" #property strict int OnInit() { //--- create timer EventSetTimer(1); //--- return(INIT_SUCCEEDED);...
It works. Your code is never going to show you. Try this.
Inserted Code
//+------------------------------------------------------------------+
//|                                                DailyVarReset.mq4 |
//|                                      Copyright 2017, nicholishen |
//|                         https://www.forexfactory.com/nicholishen |
//+------------------------------------------------------------------+
#property copyright "Copyright 2017, nicholishen"
#property link      "https://www.forexfactory.com/nicholishen"
//+------------------------------------------------------------------+
//|                                                                         Test.mq4 |
//|                       Copyright 2017, MetaQuotes Software Corp. |
//|                                                     https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2017, MetaQuotes Software Corp."
#property link      "https://www.mql5.com"
#property version   "1.00"
#property strict
int OnInit()
{
//--- create timer
   EventSetTimer(1);
//---
   return(INIT_SUCCEEDED);
}
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
{
//--- destroy timer
   EventKillTimer();
}
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
{
//DayHigh = High[1];
//Day2ndHigh = High[2];
//DayLow = Low[1];
//Day2ndLow = Low[2];
//Comment("High_1 :" + DayHigh + " High_2: " + Day2ndHigh + "  Low_1:" + DayLow + " Low_2:" + Day2ndLow);
}
//+------------------------------------------------------------------+
//| Timer function                                                   |
//+------------------------------------------------------------------+
void OnTimer()
{
//---
   ResetVarsAtMidnight();
}
//+------------------------------------------------------------------+
double DayHigh = 0;
double Day2ndHigh = 0;
double DayLow = 0;
double Day2ndLow = 0;
void ResetVarsAtMidnight()
{
   MqlDateTime       last_reset_struct;
   static datetime   last_reset = TimeCurrent();
   static bool       is_init = false;
   int hour=18;
   int min=56;
   int sec=0;
   if(!is_init)
   {
      last_reset-= PeriodSeconds(PERIOD_D1);
      TimeToStruct(last_reset,last_reset_struct);
      last_reset_struct.hour = hour;
      last_reset_struct.min = min;
      last_reset_struct.sec = sec;
      last_reset = StructToTime(last_reset_struct);
      is_init = true;
   }
   if( TimeCurrent() >= last_reset+PeriodSeconds(PERIOD_D1))
   {
      //Reset Highs/Lows
      DayHigh = 0;
      Day2ndHigh = 0;
      DayLow = 0;
      Day2ndLow = 0;
      Alert("Resting vars!");/**********/
      TimeCurrent(last_reset_struct);
      last_reset_struct.hour = hour;
      last_reset_struct.min = min;
      last_reset_struct.sec = sec;
      last_reset = StructToTime(last_reset_struct);
      return;
   }
}
  • #9
  • Oct 25, 2017 2:20pm Oct 25, 2017 2:20pm
Quoting Nicholishen
{quote} It works. Your code is never going to show you. Try this. //+------------------------------------------------------------------+ //| DailyVarReset.mq4 | //| Copyright 2017, nicholishen | //| https://www.forexfactory.com/nicholishen | //+------------------------------------------------------------------+ #property copyright "Copyright 2017, nicholishen" #property link "https://www.forexfactory.com/nicholishen" //+------------------------------------------------------------------+ //| Test.mq4 | //| Copyright 2017, MetaQuotes Software Corp....
It works very well

Thank you for the code and your help!

I'm just curious, are you available for hire if i need a good coder?
Blindly following others will make you blind!
  • #10
  • Oct 25, 2017 2:29pm Oct 25, 2017 2:29pm
Quoting Georgebaker
{quote} It works very well Thank you for the code and your help! I'm just curious, are you available for hire if i need a good coder?
Yes
  • #11
  • Last Post: Oct 25, 2017 2:40pm Oct 25, 2017 2:40pm
Quoting Nicholishen
{quote} Yes
Great
Blindly following others will make you blind!
0 traders viewing now