MQL4 - How to find the high of the day | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

How to find barssince() in mql4? 2 replies

Tool to quickly find unmatched parentheses in MQL4 code 7 replies

MQL4 Language Most Recent Version is it updated beyond the tutorial on the mql4 websi 6 replies

Where would I find a MQL4 programmar? 17 replies

Attachments: MQL4 - How to find the high of the day
Exit Attachments

MQL4 - How to find the high of the day

  • #1
  • First Post: Edited 12:57pm Oct 12, 2017 12:45pm | Edited 12:57pm
I Want to compare the high of the day to the previous candle every time the current candle close.

I have this piece of code:

Inserted Code
double TH = iHigh(NULL, PERIOD_D1, 0);    // today's high
if ((High[1] > TH) && (Close[1] < TH)
{
   Some code here...
}

The problem is, that if i use this approach and previous candle by random is the highest of the day it doesn't work correctly.

Attached Image (click to enlarge)
Click to Enlarge Name: FF-CountBackFrom.jpg Size: 75 KB

I'm thinking of counting back to midnight, but how do i do that best?

I actually want to compare to the second highest candle in the chart.
Blindly following others will make you blind!
  • #2
  • Oct 12, 2017 2:18pm Oct 12, 2017 2:18pm
Quoting Georgebaker
I Want to compare the high of the day to the previous candle every time the current candle close. I have this piece of code: double TH = iHigh(NULL, PERIOD_D1, 0); // today's high if ((High[1] > TH) && (Close[1] < TH) { Some code here... } The problem is, that if i use this approach and previous candle by random is the highest of the day it doesn't work correctly. {image} I'm thinking of counting back to midnight, but how do i do that best? I actually want to compare to the second highest candle in the chart.

Well, as brokers are located in different timezones, start and end of a day can be very different.

Wouldn`t it be better to look for the Hi and the Lo of the sessions, which counting for every trader and broker around the world??

In your picture is the first Hi "of the day", the Hi of the asian session, then the Lo "of the day" is the Lo of London and New York session overlapping, where the first candle of NY makes the Lo. Then the new Hi "of the day" is NY sessions Hi.

If a code could work that way, it could be a help to find what you are looking for. Or at least a step closer.
  • #3
  • Oct 12, 2017 3:06pm Oct 12, 2017 3:06pm
if i understand correctly you want compare the high that was already the high of this current date to the current candle close price. But the issue is that when the last candle is higher than the already high of the day it becomes the high and you cant compare. Right ? am i correct ? if that is the issue you can create a contrition which will hold a variable with the high of the day what ever it happens and it will update its value when you say so. Else be more specific.
  • #4
  • Oct 12, 2017 6:10pm Oct 12, 2017 6:10pm
Quoting stoxos
if i understand correctly you want compare the high that was already the high of this current date to the current candle close price. But the issue is that when the last candle is higher than the already high of the day it becomes the high and you cant compare. Right ? am i correct ? if that is the issue you can create a contrition which will hold a variable with the high of the day what ever it happens and it will update its value when you say so. Else be more specific.
The description is not clear enough to provide OP with an answer and unfortunately OP's drawing doesn't help.
  • #5
  • Oct 12, 2017 11:13pm Oct 12, 2017 11:13pm
Quoting stoxos
if i understand correctly you want compare the high that was already the high of this current date to the current candle close price. But the issue is that when the last candle is higher than the already high of the day it becomes the high and you cant compare. Right ? am i correct ? if that is the issue you can create a contrition which will hold a variable with the high of the day what ever it happens and it will update its value when you say so. Else be more specific.
Exactly!

Yeah that's the way to do it, thanks!
Blindly following others will make you blind!
  • #6
  • Oct 13, 2017 12:04am Oct 13, 2017 12:04am
Quoting Georgebaker
{quote} Exactly! Yeah that's the way to do it, thanks!
Inserted Code
void OnStart()
{
   if(CloseAbovePrevHigh())
   {
      ///Do stuff
   }
}
bool CloseAbovePrevHigh()
{
   MqlDateTime today;
   TimeCurrent(today);
   today.hour=0;
   today.min=0;
   today.sec=0;
   int stop_bar = iBarShift(_Symbol,_Period,StructToTime(today),true);
   double prev_high = iHigh(_Symbol,_Period,iHighest(_Symbol,_Period,MODE_HIGH,stop_bar-1,2));
   return Close[1] > prev_high; 
}
  • #7
  • Last Post: Oct 13, 2017 10:05am Oct 13, 2017 10:05am
Quoting Nicholishen
{quote} void OnStart() { if(CloseAbovePrevHigh()) { ///Do stuff } } bool CloseAbovePrevHigh() { MqlDateTime today; TimeCurrent(today); today.hour=0; today.min=0; today.sec=0; int stop_bar = iBarShift(_Symbol,_Period,StructToTime(today),true); double prev_high = iHigh(_Symbol,_Period,iHighest(_Symbol,_Period,MODE_HIGH,stop_bar-1,2)); return Close[1] > prev_high; }
Great Nicolishen - Thanks!
Blindly following others will make you blind!
0 traders viewing now