orderclose() problem - cannot close all trades | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Can I add a comment to an order closed with OrderClose()? 2 replies

OrderClose Error 145 during strategy tester 8 replies

OrderClose() issue on EA 4 replies

OrderClose wont work 2 replies

OrderClose error 4107 1 reply

orderclose() problem - cannot close all trades

  • #1
  • First Post: Sep 13, 2017 11:02am Sep 13, 2017 11:02am
Hi,

Having problems with closing all trades using orderclose(). What am I doing wrong? I know the loop works and it cycles all the way to the end. When I have three trades open only two closes and one is left open.

I test with 3 trades. All are open and all are buy - and same symbol. What am I missing?

if(stop == true)
{
cnt = OrdersTotal();
for (i=0; i < cnt; i++)
{
if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
{
ticket=OrderTicket();
// OrderClose(ticket, 0.01, MarketInfo(OrderSymbol(), MODE_ASK), 5, Red);
OrderClose(ticket, 0.01, MarketInfo(OrderSymbol(), MODE_BID), 5, Red);
// TrendTradingProfit(TrendLineTPSize, EnableTrendLineTrading);

}

}
stop = false;
}

Help me!

L
  • #2
  • Sep 13, 2017 11:08am Sep 13, 2017 11:08am
Quoting kingofspades
Hi, Having problems with closing all trades using orderclose(). What am I doing wrong? I know the loop works and it cycles all the way to the end. When I have three trades open only two closes and one is left open. I test with 3 trades. All are open and all are buy - and same symbol. What am I missing? if(stop == true) { cnt = OrdersTotal(); for (i=0; i < cnt; i++) { if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) { ticket=OrderTicket(); // OrderClose(ticket, 0.01, MarketInfo(OrderSymbol(), MODE_ASK), 5, Red); OrderClose(ticket, 0.01, MarketInfo(OrderSymbol(),...
Reverse the loop ...

Inserted Code
for (int i=OrdersTotal()-1; i >= 0; i--)
MT4/MT5 EAs/Indicators/Alerts coder
  • #3
  • Sep 13, 2017 11:13am Sep 13, 2017 11:13am
Oh wow that works... That's so weird!
  • #4
  • Sep 13, 2017 11:15am Sep 13, 2017 11:15am
Quoting kingofspades
Oh wow that works... That's so weird!
MT4/MT5 EAs/Indicators/Alerts coder
  • #5
  • Sep 13, 2017 11:17am Sep 13, 2017 11:17am
Thanks mate. Got to jigsaw back my code got my EA working! Yippee! Off to make lunch.
  • #6
  • Sep 16, 2017 5:25am Sep 16, 2017 5:25am
Quoting kingofspades
Hi, Having problems with closing all trades using orderclose(). What am I doing wrong? I know the loop works and it cycles all the way to the end. When I have three trades open only two closes and one is left open. I test with 3 trades. All are open and all are buy - and same symbol. What am I missing? if(stop == true) { cnt = OrdersTotal(); for (i=0; i < cnt; i++) { if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) { ticket=OrderTicket(); // OrderClose(ticket, 0.01, MarketInfo(OrderSymbol(), MODE_ASK), 5, Red); OrderClose(ticket, 0.01, MarketInfo(OrderSymbol(),...
I would recommend to not hard code any values as well

OrderClose(ticket, OrderLots(), MarketInfo(OrderSymbol(), MODE_ASK), 5, Red);
  • #7
  • Last Post: Sep 16, 2017 3:41pm Sep 16, 2017 3:41pm
Hi Datatrading,

I had a variable at first. I only put that in just as something to work with.

Cheers,

Spades
0 traders viewing now