Help needed coding EA - OrderSend errors | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

help needed with an expert showing errors 0 replies

Ordersend command help? 13 replies

EA coding issue - 2 errors after decompiling 10 replies

Help for Ordersend - 2 Step Process for ECN 7 replies

Excellent Market Session Indicator - Custom Perimeters - Coding Errors Need Attention 0 replies

Attachments: Help needed coding EA - OrderSend errors
Exit Attachments

Help needed coding EA - OrderSend errors

  • #1
  • First Post: Aug 27, 2017 5:53pm Aug 27, 2017 5:53pm
Hey guys,
I'm trying to code an EA for a particular strategy but I am getting error codes. like OrderSend error 130 and OrderSend error 138 and such.
So I am wondering if any of you guys would be willing to help me out here.

I also get stuff like this where it's not entirely accurate:
Attached Image (click to enlarge)
Click to Enlarge Name: GZ9b1Vfe.jpg Size: 134 KB

and
Attached Image (click to enlarge)
Click to Enlarge Name: uCKYD1Tu.jpg Size: 134 KB


The strategy is as follows:
Engulfing candle had to breach the Bollinger band.
Entry: 5 pips above/below close of Engulfing candle.
Stop: 5 pips above/below high/low of Engulfing candle.
Target: 2-1 Reward to Risk.

Conditions:
Engulfing candle has to close above/below the high/low of previous candle.
If we don't get entered during the next 4 candles the trade gets invalidated.
If candle wick of Engulfing candle is large, use a previous candle to base the Stop loss off of.

Here is the code I am currently using:
https://pastebin.com/jUWGDqdV

Here are some results I got with the code:
Attached Image (click to enlarge)
Click to Enlarge Name: Untitled.png Size: 49 KB



So if anybody would like to try it out and see what the issues are that would appreciated.

Thanks!
AntiVi
  • #2
  • Aug 28, 2017 8:26am Aug 28, 2017 8:26am
Hi Auntie Vi,

This should go some way towards eliminating the errors.
Just play with it and adjust to your needs.

M.
Attached File(s)
File Type: mq4 Engu.mq4   6 KB | 365 downloads
If you think I'm mad, I must be mad
  • #3
  • Aug 28, 2017 3:00pm Aug 28, 2017 3:00pm
Quoting futurespec
Hi Auntie Vi, This should go some way towards eliminating the errors. Just play with it and adjust to your needs. M. {file}
I appreciate the effort but I tested it and it doesn't seem to work.
I would try to fix it but I honestly have no clue what I'm doing or what anything means.
The only thing that I know how to do is change the conditions pretty much.

So in the test I did it opened A LOT of trades and closed them a second later or something which resulted in the test taking a really long time.
In the end results I only had about 10 trades which I know is wrong and I tried making the report which it did after a while however every time I try to open it my browser crashes.

So I'm not sure what the issue is.
I didn't see any errors so that's a good thing.
  • #4
  • Aug 28, 2017 9:35pm Aug 28, 2017 9:35pm
hey antivi, this code works for me......



ticket=OrderSend("USDJPY",OP_BUY,H_Lot,MarketInfo("USDJPY",MODE_ASK),100,O_SL,O_TP,"Auto-Trade",4141,0,Blue);

hope this helps....
Mother of Pips
  • #5
  • Aug 29, 2017 1:30am Aug 29, 2017 1:30am
Sorry did this while I was twiddling my fingers yesterday with an hour to spare.

No time at moment but will come back to it when I can if you do not resolve it.

M.
If you think I'm mad, I must be mad
  • #6
  • Aug 29, 2017 4:09am Aug 29, 2017 4:09am
Quoting pipqueen18
hey antivi, this code works for me...... ticket=OrderSend("USDJPY",OP_BUY,H_Lot,MarketInfo("USDJPY",MODE_ASK),100,O_SL,O_TP,"Auto-Trade",4141,0,Blue); hope this helps....
I appreciate the effort but that is not going to help since I pretty much have something very similar to it.


Quoting futurespec
Sorry did this while I was twiddling my fingers yesterday with an hour to spare. No time at moment but will come back to it when I can if you do not resolve it. M.
I will keep playing around with it and try to resolve it.
If I do I'll make a post here.

I'm not a programmer so the chances of me making it work are slim but I will give it a shot.

Thanks again!
  • #7
  • Aug 29, 2017 5:01am Aug 29, 2017 5:01am
Hi Vi,

Sorry thought you were a programmer as you supplied original code.
Should be a little better now but have not checked or altered the logic of what you were doing.
Cannot replicate your results :-(

Hope it helps.

M.
Attached File(s)
File Type: mq4 Engu.mq4   7 KB | 391 downloads
If you think I'm mad, I must be mad
  • #8
  • Aug 29, 2017 10:12am Aug 29, 2017 10:12am
Quoting futurespec
Hi Vi, Sorry thought you were a programmer as you supplied original code. Should be a little better now but have not checked or altered the logic of what you were doing. Cannot replicate your results :-( Hope it helps. M. {file}
Hehe No problem! I just didn't want to ask people for help until I gave it a shot myself.
The results won't be exactly the same since the code I had wasn't perfect.

I did do a test and every single setup seems to be correct as well as the ones that timed out and the results seem very similar.
The only thing that it does that it shouldn't is not taking setups if a trade is already going on.
Usually when I enter a new position I close the old one but I'm not sure if that's possible in the code.

Another thing I'd like to ask if you want to do is if you can explain what everything exactly does in the code so I can understand it a little better?
If you don't mind of course.
I don't want to ask more than I already have.


Thanks a lot!
AntiVi
  • #9
  • Aug 29, 2017 11:05am Aug 29, 2017 11:05am
Vi,
Try attached. Don't have time to play with this for you so may not work as intended.
You have added new conditions on top of original request which never cheers me up!

No time to explain everything, persevere and you will get there.

Let me know which particular bits you need explaining.

M.
Attached File(s)
File Type: mq4 Engulf2.mq4   7 KB | 433 downloads
If you think I'm mad, I must be mad
  • #10
  • Aug 29, 2017 12:14pm Aug 29, 2017 12:14pm
Quoting futurespec
Vi, Try attached. Don't have time to play with this for you so may not work as intended. You have added new conditions on top of original request which never cheers me up! No time to explain everything, persevere and you will get there. Let me know which particular bits you need explaining. M. {file}
Oh wow that is absolutely perfect!
Thanks so much!

As for results, here is the first result:
Attached Image (click to enlarge)
Click to Enlarge Name: Untitled.png Size: 43 KB


These results look a lot smoother than the other ones however it's not as profitable however the money management I do would really make up for that since I would be able to change my lot size more often.
I will do a big round of optimizing tomorrow and see if any better parameters are available.

As for understanding the code, I will deepen myself into it a bit and see what I can figure out and what I can't since this will take some time.
Also sorry for the inconvenience!


Thanks
AntiVi
  • #11
  • Aug 30, 2017 1:02am Aug 30, 2017 1:02am
AntiVi,

Pleased to help when results are appreciated.
Hope it helps.

M.
If you think I'm mad, I must be mad
  • #12
  • Last Post: Nov 1, 2017 7:55am Nov 1, 2017 7:55am
Quoting futurespec
AntiVi, Pleased to help when results are appreciated. Hope it helps. M.
Could you perhaps explain to me this piece of code and what it does?

int init()
{
mGap = NormalizeDouble((MarketInfo(NULL, MODE_STOPLEVEL) + 30) * Point(), BrokerDigits);
return(0);
}


Thanks
0 traders viewing now