A very good EA and framework example

Quoting reteid2222

Disliked

This ea has not only SL and TP it has several trailing possiblities.... good a starting point 4 beginners 2 learn.... i wish i had found this when I started coding eas... in the kindergarden....just kidding.... Credits to Robert Hill who has done 10 years ago in a non OOP MT4 world this great job! {file}

Ignored

Quoting reteid2222

Disliked

How to code with this effectively....Just simplify all code and put the functions and methods U need in every ea in a file and place it in the include folder....replace the buy sell code with Buy/Sell functions and use them in the main code....so you have only to code there..... I took Roberts code and modified it like my framework(which is much more complicated!) I even test the code but it should give beginners (and maybe advanced if they like) coders an idea so organize their coding..... I anyone like he/she could test modify and upload a better...

Ignored

bool LastTradeClosedToday()
{
  int cnt, total;
  bool Closed;
  
  
  total = HistoryTotal();
  for (cnt = total - 1; cnt >= 0; cnt--)
  {
     res=OrderSelect (cnt, SELECT_BY_POS, MODE_HISTORY);
     
     if(OrderSymbol()!=Symbol()) continue;
     if (OrderMagicNumber() != MagicNumber) continue;
...

Quoting Nicholishen

Disliked

{quote} Some of these are quite dated... For example, this assumes order history is always sorted when it's not. This could potentially be disastrous... bool LastTradeClosedToday() { int cnt, total; bool Closed; total = HistoryTotal(); for (cnt = total - 1; cnt >= 0; cnt--) { res=OrderSelect (cnt, SELECT_BY_POS, MODE_HISTORY); if(OrderSymbol()!=Symbol()) continue; if (OrderMagicNumber() != MagicNumber) continue; ...

Ignored

Quoting reteid2222

Disliked

{quote} Please explain this!

Ignored

bool LastTradeClosedToday()
{
   for(int i = OrdersHistoryTotal()-1; i >= 0; i--)
      if(OrderSelect(i,SELECT_BY_POS, MODE_HISTORY)&&OrderSymbol()==Symbol()&&OrderMagicNumber()==MagicNumber)
         if(OrderType()<2 && TimeDay(OrderCloseTime())==TimeDay(TimeCurrent()))
            return true;
   return false;
}

bool LastTradeClosedToday()
{
   int cnt, total;
   bool Closed;
  
  
   total = HistoryTotal();
   for (cnt = total - 1; cnt >= 0; cnt--)
   {
      res=OrderSelect (cnt, SELECT_BY_POS, MODE_HISTORY);
      
      if(OrderSymbol()!=Symbol()) continue;
      if (OrderMagicNumber() != MagicNumber) continue;
        Closed = false;
        if (OrderType() == OP_BUY)
        {
          if (TimeDay(OrderCloseTime()) == TimeDay(TimeCurrent()))
          {
             Closed = true;
          }
          cnt = 0;
        }
        if (OrderType() == OP_SELL)
        {
          if (TimeDay(OrderCloseTime()) == TimeDay(TimeCurrent()))
          {
             Closed = true;
          }
          cnt = 0;
        }
   }
  
   return (Closed);
}

Quoting reteid2222

Disliked

I see now setting the "running" index cnt in the loop is very bad programming behavior.... But the two files are compiling at my hard disk...

Ignored

Quoting Nicholishen

Disliked

{quote} Have you had a look at the newer libraries available in the MQL5.com's code-base?

Ignored

Quoting Alabarce

Disliked

{quote} Can you comment on quality libraries, do not use structures, and do not use classes?

Ignored

Quoting Nicholishen

Disliked

{quote} This is just MHO and I mean no offense, but I wouldn't put any real money behind legacy code that won't compile under the new MQL compiler standards (#property strict) due to its buggy and unpredictable behavior. I'm sure this lib was the cat's meow at one point in time but there are so many other libs that have cleaner/more readable code and confirm to the new standards, and if I were just beginning to learn MQL - I wouldn't want to learn bad habits by using depreciated and unorganized code... Have you had a look at the newer libraries...

Ignored

Quoting Nicholishen

Disliked

{quote} IMO, the best libraries use structures and classes, but there are plenty of libs that don't. Just have a look here and save the ones you think you'll use frequently. https://www.mql5.com/en/code/mt4/libraries/best

Ignored

Quoting reteid2222

Disliked

{quote} I didnt found any framework there for mq4 only an oop based for mq5....but now I have my own....so no need any longer!

Ignored

Quoting Nicholishen

Disliked

{quote} I'm blown away by the general rejection of OOP by the forexfactory community. Before I learned it I thought it would be useless, but now I can't ever think of how I lived without it. The complexity of my strategies went way up while reducing my overall development time.

Ignored

Quoting Nicholishen

Disliked

{quote} I'm blown away by the general rejection of OOP by the forexfactory community. Before I learned it I thought it would be useless, but now I can't ever think of how I lived without it. The complexity of my strategies went way up while reducing my overall development time.

Ignored

Quoting braintheboss

Disliked

{quote} Rejection by users, not by coders. Because users don't know code and if they need make small modifications will be hard for them. It's the only reason. Evidently coders are not worried about this...

Ignored

Quoting Nicholishen

Disliked

{quote} If that were the case there'd be a much bigger demand for mt5, but there's not. In general, the people who discover mql are traders looking to automate their strategies and don't have a programming background. If I had to guess, I'd say about ten percent of people who dev in mql are "coders". IMO, a coder should't be the slightest bit concerned with publishing dumbed-down code so that a user can make mods to it. Instead, a coder should focus on building a solid framework that can rapidly deploy complex solutions using well designed libraries....

Ignored