Automatic suffix extraction for ECN appended symbols?

string ecn_suffix = AutoSuffixFinder();

string sub = StringSubstr(_Symbol,6,0)

Quoting FerruFx

Disliked

With the below, you are extracting everything after the pair symbol ... Example EURUSDecn ... ecn being the extracted part. string sub = StringSubstr(_Symbol,6,0)

Ignored

#property copyright "nicholishen"
#property link      "www.reddit.com/u/nicholishenFX"
#property version   "1.00"
#property strict
#include <Arrays\ArrayObj.mqh>
class Suffix : public CObject
{
public:
   string   suffix;
   int      count;
   Suffix(string suff):suffix(suff),count(1){}
   int Compare(const CObject *node,const int mode=0)const
   {
      Suffix *that = (Suffix*)node;
      if(this.count > that.count)
         return -1;
      else if( this.count < that.count)
         return 1;
      else 
         return 0;
   }
};
class SuffixList : public CArrayObj
{
public:
   Suffix *operator[](const int i)const{return (Suffix*)At(i);} 
   void Add(string suffix)
   {
      for(int i=0;i<Total();i++)
      {
         if(this[i].suffix == suffix)
         {
            this[i].count++;
            return;
         }
      }
      CArrayObj::Add(new Suffix(suffix));
   }
};
//+------------------------------------------------------------------+
//| Script program start function                                    |
//+------------------------------------------------------------------+
void OnStart()
  {
//---
   string res = AssumedSuffix();
   res = res==NULL?"NULL":res;
   Print("Assumed suffix is ( ",res," )");
  }
//+------------------------------------------------------------------+
string AssumedSuffix()
{
   SuffixList list;
   int total = SymbolsTotal(false);
   for(int i=0;i<total;i++)
   {
      string chart_name = SymbolName(i,false);
      if(StringLen(chart_name) == 7)
      {
         bool con = true;
         for(int j=0;j<6;j++)
         {
            if(!IsChar(StringSubstr(chart_name,j,1)))
            {
               con = false;
               break;
            }
         }
         if(con)
         {
            string sub_string = StringSubstr(chart_name,6,1);
            list.Add(sub_string);
         } 
      }
   }
   if(list.Total() > 0)
   {
      list.Sort();
      return list[0].suffix;
   }
   return NULL;
}
bool IsChar(string c)
{
   string allowed = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
   return StringFind(allowed,c) >= 0;
}

Quoting Master-Mind

Disliked

for example if it was GBPUSDx, it will be changed forcibly to GBPUSD_ Now, even though u r not dropping on the right symbol, ur program will change chart symbol to right symbol. my apologies if i do not get ur point. {image}

Ignored

Quoting Nicholishen

Disliked

{quote} Yes, you missed the point. I don't want to declare a constant char, I want the algo to automatically figure out which symbol to use.

Ignored

Quoting Master-Mind

Disliked

{quote} Is the criterion to find the suffix which is more repeated IN MarketWatch? in this case the program should get pairs name from MarketWATCH, and check one by one. your code, above, solve the problem?

Ignored

Quoting Master-Mind

Disliked

ArrayObj.mqh where one could find this code? you program it or it is a built-in code?

Ignored

Quoting Master-Mind

Disliked

ArrayObj.mqh where one could find this code? you program it or it is a built-in code?

Ignored

Quoting Nicholishen

Disliked

{quote} Also, I would suggest copying the script and then setting a break-point so you can step through the code with the debugger to see how sorting is implemented by overriding the CObject Compare method.

Ignored

Quoting HeroKato

Disliked

Also https://www.mql5.com/en/code/9102 Get the whole list , and do some hardcoded samples like One for Forex One for CFD and etc etc etc

Ignored

#include <suffix_filters.mqh>
string suffix = AssumedSuffix();

SymbolInfoString
Returns the corresponding property of a specified symbol. There are 2 variants of the function.
1. Immediately returns the property value.
string  SymbolInfoString(
   string                   name,        // Symbol
   ENUM_SYMBOL_INFO_STRING  prop_id      // Property identifier
   );
2. Returns true or false, depending on the success of a function. If successful, the value of the property is placed in a placeholder variable passed by reference in the last parameter.
bool  SymbolInfoString(
   string                   name,        // Symbol
   ENUM_SYMBOL_INFO_STRING  prop_id,     // Property identifier
   string&                  string_var   // Here we accept the property value
   );
Parameters
name
[in] Symbol name.
prop_id
[in] Identifier of a symbol property. The value can be one of the values of the [url="mk:@MSITStore:C:\Users\user\AppData\Roaming\MetaQuotes\Terminal\Help\mql4.chm::/marketinfoconstants.htm#enum_symbol_info_string"]ENUM_SYMBOL_INFO_STRING[/url] enumeration.
string_var
[out] Variable of the string type receiving the value of the requested property.
Return Value
The value of string type. In case of execution failure, information about the [url="mk:@MSITStore:C:\Users\user\AppData\Roaming\MetaQuotes\Terminal\Help\mql4.chm::/errorcodes.htm"]error[/url] can be obtained using [url="mk:@MSITStore:C:\Users\user\AppData\Roaming\MetaQuotes\Terminal\Help\mql4.chm::/getlasterror.htm"]GetLastError()[/url] function:[list][*]4106 – symbol is not selected in "Market Watch" (not found in the list of available ones),[*]4051 – invalid identifier of a symbol property,[*]4024 – internal error.[/list]

#include <Arrays\ArrayString.mqh>
string AccountSuffix()
{
   static string suffix = "NULL";
   static int    account_number = 0;
   int acc = (int)AccountInfoInteger(ACCOUNT_LOGIN);
   if(suffix != "NULL" && acc == account_number)
      return suffix;
   account_number = acc;
   CArrayString list;
   int total = SymbolsTotal(false);
   for(int i = total-1; i>=0; i--)
      list.Add(StringSubstr(SymbolName(i,false),6));
   list.Sort();
   string   last     = "NULL";
   int      max      = -1;
   int      cnt      = 0;
   for(int i=list.Total()-1; i>=0; i--)
   {
      if(list[i] != last)
      {
         cnt  = 0;
         last = list[i];
      }
      cnt++;
      if(cnt > max)
      {
         max    = cnt;
         suffix = list[i];
         if(cnt > total / 2)
            break;
      }
   }
   suffix = suffix == "NULL" ? "" : suffix;
   return suffix;
}

Quoting Master-Mind

Disliked

can be improved o automatically distinguish Forex from CDF ENUM_SYMBOL_INFO_STRING SYMBOL_PATH ?? SymbolInfoString Returns the corresponding property of a specified symbol. There are 2 variants of the function. 1. Immediately returns the property value. string SymbolInfoString( string name, // Symbol ENUM_SYMBOL_INFO_STRING prop_id // Property identifier ); 2. Returns true or false, depending on the success of a function. If successful, the value of the property is placed in a placeholder variable passed by reference in the last parameter. bool...

Ignored

enum SYMBOL_TYPE{TYPE_FOREX,TYPE_CFD};
SYMBOL_TYPE SymbolType(const string symbol)
{
   if(SymbolInfoInteger(symbol,SYMBOL_TRADE_CALC_MODE) != 0)
      return TYPE_CFD;
   return TYPE_FOREX;
}

Quoting FerruFx

Disliked

With the below, you are extracting everything after the pair symbol ... Example EURUSDecn ... ecn being the extracted part. string sub = StringSubstr(_Symbol,6,0)

Ignored

string subSuffix = StringSubstr(_Symbol,0,6);
 
string subPrefix = StringSubstr(_Symbol,??,??);

Quoting chimoong

Disliked

{quote} Hi FerruFx, I think to extract the symbol for suffix symbols should be :- string subSuffix = StringSubstr(_Symbol,0,6); string subPrefix = StringSubstr(_Symbol,??,??); how about symbols with prefix such as xxxEURUSD ? What is the correct StringSubstr formulas ? Thanks

Ignored