Help for one entry per candle

Hello,
I'm trying to build EAs through free builders who are on the web.
I have a problem, sometimes on the single candle there are more entries. I searched for the code, I found different material, but I can not get it to work. Here is the code of a simple EA on the cross of two moving everages, you can indicate the appropriate functions and where to place them, so that there may be only one entry on a candle.
Thanks in advance

extern int MagicNumber=10001;
extern double Lots =0.1;
extern double StopLoss=5;
extern double TakeProfit=10;
extern int TrailingStop=0;
extern int Slippage=3;
extern int ma_fast_period=13;
extern int ma_slow_period=89;
extern int shift=0;
//+------------------------------------------------------------------+
// expert start function
//+------------------------------------------------------------------+
int start()
{
double MyPoint=Point;
if(Digits==3 || Digits==5) MyPoint=Point*10;

double TheStopLoss=0;
double TheTakeProfit=0;
if( TotalOrdersCount()==0 )
{
int result=0;
if((iMA(NULL,0,ma_fast_period,shift,MODE_SMA,PRICE_CLOSE,1)<iMA(NULL,0,ma_slow_period,shift,MODE_SMA,PRICE_CLOSE,1))&&(iMA(NULL,0,ma_fast_period,shift,MODE_SMA,PRICE_CLOSE,0)>iMA(NULL,0,ma_slow_period,shift,MODE_SMA,PRICE_CLOSE,0))) // Here is your open buy rule
{
result=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,0,0,"comment",MagicNumber,0,Blue);
if(result>0)
{
TheStopLoss=0;
TheTakeProfit=0;
if(TakeProfit>0) TheTakeProfit=Ask+TakeProfit*MyPoint;
if(StopLoss>0) TheStopLoss=Ask-StopLoss*MyPoint;
OrderSelect(result,SELECT_BY_TICKET);
OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green);
}
return(0);
}
if((iMA(NULL,0,ma_fast_period,shift,MODE_SMA,PRICE_CLOSE,1)>iMA(NULL,0,ma_slow_period,shift,MODE_SMA,PRICE_CLOSE,1))&&(iMA(NULL,0,ma_fast_period,shift,MODE_SMA,PRICE_CLOSE,0)<iMA(NULL,0,ma_slow_period,shift,MODE_SMA,PRICE_CLOSE,0))) // Here is your open Sell rule
{
result=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,0,0,"comment",MagicNumber,0,Red);
if(result>0)
{
TheStopLoss=0;
TheTakeProfit=0;
if(TakeProfit>0) TheTakeProfit=Bid-TakeProfit*MyPoint;
if(StopLoss>0) TheStopLoss=Bid+StopLoss*MyPoint;
OrderSelect(result,SELECT_BY_TICKET);
OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green);
}
return(0);
}
}

for(int cnt=0;cnt<OrdersTotal();cnt++)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if(OrderType()<=OP_SELL &&
OrderSymbol()==Symbol() &&
OrderMagicNumber()==MagicNumber
)
{
if(OrderType()==OP_BUY)
{
if(TrailingStop>0)
{
if(Bid-OrderOpenPrice()>MyPoint*TrailingStop)
{
if(OrderStopLoss()<Bid-MyPoint*TrailingStop)
{
OrderModify(OrderTicket(),OrderOpenPrice(),Bid-TrailingStop*MyPoint,OrderTakeProfit(),0,Green);
return(0);
}
}
}
}
else
{
if(TrailingStop>0)
{
if((OrderOpenPrice()-Ask)>(MyPoint*TrailingStop))
{
if((OrderStopLoss()>(Ask+MyPoint*TrailingStop)) || (OrderStopLoss()==0))
{
OrderModify(OrderTicket(),OrderOpenPrice(),Ask+MyPoint*TrailingStop,OrderTakeProfit(),0,Red);
return(0);
}
}
}
}
}
}
return(0);
}
int TotalOrdersCount()
{
int result=0;
for(int i=0;i<OrdersTotal();i++)
{
OrderSelect(i,SELECT_BY_POS ,MODE_TRADES);
if (OrderMagicNumber()==MagicNumber) result++;
}
return (result);
}

try this:

extern int MagicNumber=10001;
extern double Lots =0.1;
extern double StopLoss=5;
extern double TakeProfit=10;
extern int TrailingStop=0;
extern int Slippage=3;
extern int ma_fast_period=13;
extern int ma_slow_period=89;
extern int shift=0;
//+------------------------------------------------------------------+
// expert start function
//+------------------------------------------------------------------+
int start()
{
double MyPoint=Point;
if(Digits==3 || Digits==5) MyPoint=Point*10;
double TheStopLoss=0;
double TheTakeProfit=0;
if( TotalOrdersCount()==0 )
{
int result=0;
if((iMA(NULL,0,ma_fast_period,shift,MODE_SMA,PRICE_CLOSE,1)<iMA(NULL,0,ma_slow_period,shift,MODE_SMA,PRICE_CLOSE,1))&&(iMA(NULL,0,ma_fast_period,shift,MODE_SMA,PRICE_CLOSE,0)>iMA(NULL,0,ma_slow_period,shift,MODE_SMA,PRICE_CLOSE,0))) // Here is your open buy rule
{
if(getOrdersThisBar(MagicNumber) == 0)
result=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,0,0,"comment",MagicNumber,0,Blue);
if(result>0)
{
TheStopLoss=0;
TheTakeProfit=0;
if(TakeProfit>0) TheTakeProfit=Ask+TakeProfit*MyPoint;
if(StopLoss>0) TheStopLoss=Ask-StopLoss*MyPoint;
OrderSelect(result,SELECT_BY_TICKET);
OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green);
}
return(0);
}
if((iMA(NULL,0,ma_fast_period,shift,MODE_SMA,PRICE_CLOSE,1)>iMA(NULL,0,ma_slow_period,shift,MODE_SMA,PRICE_CLOSE,1))&&(iMA(NULL,0,ma_fast_period,shift,MODE_SMA,PRICE_CLOSE,0)<iMA(NULL,0,ma_slow_period,shift,MODE_SMA,PRICE_CLOSE,0))) // Here is your open Sell rule
{
if(getOrdersThisBar(MagicNumber) == 0)
result=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,0,0,"comment",MagicNumber,0,Red);
if(result>0)
{
TheStopLoss=0;
TheTakeProfit=0;
if(TakeProfit>0) TheTakeProfit=Bid-TakeProfit*MyPoint;
if(StopLoss>0) TheStopLoss=Bid+StopLoss*MyPoint;
OrderSelect(result,SELECT_BY_TICKET);
OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green);
}
return(0);
}
}
for(int cnt=0;cnt<OrdersTotal();cnt++)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if(OrderType()<=OP_SELL &&
OrderSymbol()==Symbol() &&
OrderMagicNumber()==MagicNumber
)
{
if(OrderType()==OP_BUY)
{
if(TrailingStop>0)
{
if(Bid-OrderOpenPrice()>MyPoint*TrailingStop)
{
if(OrderStopLoss()<Bid-MyPoint*TrailingStop)
{
OrderModify(OrderTicket(),OrderOpenPrice(),Bid-TrailingStop*MyPoint,OrderTakeProfit(),0,Green);
return(0);
}
}
}
}
else
{
if(TrailingStop>0)
{
if((OrderOpenPrice()-Ask)>(MyPoint*TrailingStop))
{
if((OrderStopLoss()>(Ask+MyPoint*TrailingStop)) || (OrderStopLoss()==0))
{
OrderModify(OrderTicket(),OrderOpenPrice(),Ask+MyPoint*TrailingStop,OrderTakeProfit(),0,Red);
return(0);
}
}
}
}
}
}
return(0);
}
int TotalOrdersCount()
{
int result=0;
for(int i=0;i<OrdersTotal();i++)
{
OrderSelect(i,SELECT_BY_POS ,MODE_TRADES);
if (OrderMagicNumber()==MagicNumber) result++;
}
return (result);
}

int getOrdersThisBar(int magic)
{
int cnt;
int orders = 0;
int total = OrdersTotal();
for (cnt = 0; cnt <= total; cnt++)
{
if (OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES))
{
if (OrderMagicNumber() == magic)
{
if(iBarShift(OrderSymbol(),0,OrderOpenTime(),true) == 0)
{
orders = orders +1;
}
}
}
}
return (orders);
}

Thank you for the reply.
I did copy and paste your edit, but it does not work.
Then I found this on the web and it seems to work:
int BarsCount = 0; int start()
{

if (Bars > BarsCount)
{
//your code to be executed only once per bar goes here

BarsCount = Bars; }

return(0); }
What do you think about it?

I use this in my EA , it is simple and easy

1- declare global variable :
datetime Bartime


then after the sell or buy conditions add ( ------ && Bartime != Time[0])


last thing after OrderSend :
OrderSend (Symbol(), ---------------------------------------------------------);
Bartime=Time[0];


So the EA will make only one deal in the candle

Hi Dani,

first of all, i think you are not running an Expert Advisor. Your code uses the int start() {} function therefore i guess you are running a script. A script is only run once and it can't trade.
An expert Advisor has at least three functions:
int OnInit() {}
void OnDeinit(const int reason) {}
void OnTick() {}

The OnTick function is where most of the EA's stuff happens.

To check for a new Bar and only have the EA execute trades on the first tick of this new Bar i use this function:

bool newBar()
{

static bool firstCall = true;

static datetime lastbar;

datetime curbar = Time[0];

if(lastbar!=curbar)

{

lastbar=curbar;

if(firstCall == true)

{

firstCall = false;

return(false);

}

else { return (true); }

}

else

{

return(false);

}

}

Now in the OnTick() function i call the newBar() function:

void OnTick() {

if(newBar == true) {

//Check if we have a new Bar and if true we check if we have a buy or sell signal due to our rules

if(TotalOpenOrders() < 1) {

//Check if there is already an order opened by this EA with this particular Magic number

//If NO TRADE IS ALREADY OPENED and we have a valid trade signal open trade ELSE do nothing

}//End TotalOpenOrders

} //End newBar

} // End OnTick

The TotalOpenOrders() function looks like this:

//Get Total Trades opened by this EA
int TotalOpenOrders()
{
int total_orders = 0;
for(int order = 0; order < OrdersTotal(); order++)
{
if(OrderSelect(order,SELECT_BY_POS,MODE_TRADES)==false) break;
if(OrderMagicNumber() == Magic && OrderSymbol() == _Symbol)
{
total_orders++;
}
}
return(total_orders);
}

The TotalOpenOrders() checks if this EA has already an order opened. You can even control how many orders the EA is allowed to open simultaneously.
(I.e. if(TotalOpenOrders() < 2) would allow 2 simultaneous orders.

Please note that the newBar() function and the TotalOpenOrders() function are declared at the end of the EA outside the OnInit(), OnDeinit() and OnTick() function.

I hope this helps a little.

P.S.: your extern int MagicNumber is extern int Magic on my code. Imported because otherwise the TotalOpenOrders() won't work
Attached is a simple EA template that is use.

Thank you very much, it works very well

I'm not a programmer, I created it with an EA buil on the web.
I really appreciate your work in answering me, and I promise you to study it.
Thank you very much.