Please help with custom function code

void close(bool accumulation, double target){
   if (accumulation == true){
      double orderProfit = 0;
      for (int i=0; i<OrdersTotal(); i++){
         if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES) == true){
            orderProfit += OrderProfit();
            if (orderProfit >= target){
               for (int ic=0; ic<OrdersTotal(); ic++){
                  if (OrderSelect(ic, SELECT_BY_POS) == true){
                    if (OrderType() == 0){
                        bool tutup = OrderClose(OrderTicket(), OrderLots(), Bid, 0, clrGreen);
                        komen("Close ALL karena TARGET", "255, 255, 255");
                     }
                     if (OrderType() == 1){
                        bool tutup = OrderClose(OrderTicket(), OrderLots(), Ask, 0, clrGreen);
                        komen("Close ALL karena TARGET", "255, 255, 255");
                     }
                  }
               }
            }
         }
      }  
   }  
}

Quoting dragonregure

Disliked

Hi guys, anyone can tell me where my code is wrong. So i want make a function to close all open orders(regardless of order type) after reach target profit, but somehow, the EA only close buy or only close sell after reaching target profit. Here's the code: void close(bool accumulation, double target){ if (accumulation == true){ double orderProfit = 0; for (int i=0; i<OrdersTotal(); i++){ if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES) == true){ orderProfit += OrderProfit(); if (orderProfit >= target){ for (int ic=0; ic<OrdersTotal(); ic++){ if (OrderSelect(ic,...

Ignored

Quoting FerruFx

Disliked

{quote} Don't put a 2nd loop calling OrdersTotal() inside the 1st one. Run a 1st loop for the P/L sum ... Then if the P/L is at your target or greater, run a 2nd loop closing all your orders.

Ignored

void close(bool accumulation, double target){
   if (accumulation == true){
      double orderProfit = 0;
      for (int i=0; i<OrdersTotal(); i++){
         if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES) == true){
            orderProfit += OrderProfit();   
         }
      }
      if (orderProfit >= target){
         for (int ic=0; ic<OrdersTotal(); ic++){
            if (OrderSelect(ic, SELECT_BY_POS) == true){     
               if (OrderType() == 0){
                  bool tutup = OrderClose(OrderTicket(), OrderLots(), Bid, 0, clrGreen);
                  komen("Close ALL karena TARGET", "255, 255, 255");
               }
               if (OrderType() == 1){
                  bool tutup = OrderClose(OrderTicket(), OrderLots(), Ask, 0, clrGreen);
                  komen("Close ALL karena TARGET", "255, 255, 255");
               }
            }
         }
      }
   }
}

Quoting dragonregure

Disliked

{quote} You mean like this right? This is my first version of my code, originally it looks like this: void close(bool accumulation, double target){ if (accumulation == true){ double orderProfit = 0; for (int i=0; i<OrdersTotal(); i++){ if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES) == true){ orderProfit += OrderProfit(); } } if (orderProfit >= target){ for (int ic=0; ic<OrdersTotal(); ic++){ if (OrderSelect(ic, SELECT_BY_POS) == true){ if (OrderType() == 0){ bool tutup = OrderClose(OrderTicket(), OrderLots(), Bid, 0, clrGreen); komen("Close ALL...

Ignored

for(int ic= OrdersTotal()-1; ic>= 0; ic--)

Quoting dragonregure

Disliked

... if (OrderSelect(ic, SELECT_BY_POS) == true)

Ignored

Quoting FerruFx

Disliked

{quote} When closing orders, you must either: 1/ Run your loop in the opposite order ... for(int ic= OrdersTotal()-1; ic>= 0; ic--) or 2/ Verify after your loop that all your related orders were closed Because in the loop ic++, when an order is closed, the orderstotal pool becomes wrong and the latest order(s) in the pool won't be found Not sure if my english explanation is fine ... but that's it!

Ignored

Quoting dragonregure

Disliked

{quote} You are right! The problem is the loop order, because if using the ic++ logic, it will make OrdersTotal messed up. I try opposite loop and it worked! Thanks a lot! I will close this thread asap.

Ignored