Help Please with Indicator Alert Code

Help Please with Indicator Alert Code

I have added alert code to this indicator, so it with alert when color/signal changes, yet not working correctly,

I have placed the words "// added" beside the code I added,

Simple indicator, yet my coding skills are not good

You Require the HP indicator in your indicators folder for the HP_DIFF_Alerts indicator to work,

All help greatly appreciated

quick look.. and it seem your variable is not matching.

in this line,
for (int li_0 = Bars - IndicatorCounted() - 1; li_0 >= 0; li_0--)
you are using li_0 as your variable to iterate all.

But, in the body, you are using just "i"

if ( i <= AlertBar && Alerts) // added

i think you should change this to li_0.

there was another line

Basically, if you change this
if ( li_0 <= AlertBar && Alerts) , it should work.. ( You might want to change all li_0 to something else like "counter" as this was randomly generated code.



if ( i <= AlertBar && Alerts) // added

In addition, it is better to write this way for easier reading.

if ( ( i <= AlertBar) && Alerts )




FYI, I didn't test out..

I have feeling this code was generated by reverse engineering from ex4 file.

Hello BlueRain, thank you for your helpful reply,

I made your suggested code changes, yet the Alert continues constantly...non stop alerts...lol

extern bool Alerts = TRUE;
extern int AlertBar = 1;

for (int li_0 = Bars - IndicatorCounted() - 1; li_0 >= 0; li_0--) {

if ( li_0 <= AlertBar && Alerts)
Alert(WindowExpertName(), ": ", _Symbol, " ", _Period, "SELL");
g_ibuf_80[li_0] = -1;
g_ibuf_84[li_0] = 1;
}
}

Reason it alert constantly is that it has to go all the bars every time there is new tick.
Whenever there is new tick, whole loop will rerun again and generate whole lot of alerts.

I looked into your code and you don't have any mean to store and check if alert happened before on that new bar.

You will need to set some variable to record what was last time it alerted and record whenever there is new bar.
like

static datetime previousAlertTime;
previousAlertTime = Time[0]; //this is latest bar open time


Now, check if time[0] is newer than last time.




if(Time[0]>previousAlertTime)
{
//new bar time, save this.
previousAlertTime=Time[0];

//your checking code for alert
if (condition == true) Alert( );


}


Time[0] shows open time of each bar. So, basically, you only check and alert 1 time per each bar.
Otherwise, it will generate alert on all bars.. endlessly.

datetime Time[]
Series array that contains open time of each bar of the current chart. Data like datetime represent time, in seconds, that has passed since 00:00 a.m. of 1 January, 1970.







Typically, you should check if there is new bar, if new bar...then check and alert.
Once you did alert, you have to record time so it won't do alert anymore until next bar.

There are a lot of MT4 indicator with alert - take those as sample and adjust your code a bit.

Steps are same:


<Update>: I made quick code change and it should work .. added those new logic to check new bar time.

I assume you want alert when there is color of bar change - which is trend changed.

Typically for this kind of alert, you should have some logic if color of bar is changed to another color like green bar changed to red bar.
As is now, Code just alert when new bar shows up.. ( you just added alert before this happens and no logic to detect trend changed )

Hello BlueRain, yes wanting an alert when bar color changes, thank you for your replies, and help, I will continue code changing today, best wishes

I had some free time this morning to fix your code as I won't do any more trading until new year.

It now checks if trend is changed ( basically compare two buffer value of previous two bars ) and alerts.
Plus, I have renamed few variable for easier reading.

I am sure you can figure it out.

Please test out

Hello BlueRain, very kind of you, many thank yous, yes seems to be working perfectly

I added a sound file to the alerts

Thank you again for your generosity, best wishes

Hello BlueRain, oh! ok yes I will make that change and test when the market is open on Monday, thank you

fix like -

if (UpTrend[AlertBar] > UpTrend[AlertBar + 1]) //trend up
{ Alert(WindowExpertName(), ": ", _Symbol, " ", _Period, " UPTREND ", " BUY");
if (AlertsSound) PlaySound(SoundFile); //"stops.wav" //"news.wav" //"alert2.wav" //"expert.wav"
}
else if ( UpTrend[AlertBar] < UpTrend[AlertBar + 1] )
{ Alert(WindowExpertName(), ": ", _Symbol, " ", _Period, " DOWNTREND "," SELL");
if (AlertsSound) PlaySound(SoundFile); //"stops.wav" //"news.wav" //"alert2.wav" //"expert.wav"
}

Hello BlueRain, thank you for that sound coding fix,

You may have noticed that this HP line is similar, not the same, yet similar to the (T_S_R)-Signal Line.mq4 indicator you posted,

best wishes

Here are the complete set of mq4 indicator files for those interested

I agree that HP and TSR has similar approach... using some kind of filter to smooth out MAs and provide trend changes.
Where TSR is using ZigZag style to show Up/Down Peaks and HP is using more of middle line.
TSR stands for Trend/Support/Resistance so it is trying to give max points. When Trend ends, it either becomes R or S.

After quick check, it seems HP has more smoother line which gives better longer /stronger trend indication and TSR has more accurate on shorter term reversal lines with more up/down. combined together, it might work together nicely.

I have attached indicator which should give bar style for TSR signal.

if you don't like TSR's thick vertical line, change to 1 so it should match with HP vertical line style like

SetIndexStyle(0,DRAW_HISTOGRAM,STYLE_SOLID,1,Green);
SetIndexStyle(1,DRAW_HISTOGRAM,STYLE_SOLID,1,Red);

Hello BlueRain, thank you for the Bar converter indicator, yes an interesting combo to play with

best wishes

Updae 2:
Found some bug.. fixed now.
Try new attached HP.

Update:

This is HP.mq4 with added features as requested by Ray.

//+------------------------------------------------------------------+
//| HP.mq4 |
//| Ver: V2 |
//| Date: 12/29/2019 |
//| By: BlueRain |
//| Added colored Uptrend/Downtrend |
//| Added Arrows, Alerts, Email |
//| No Change to HP line function itself made |
//| See details on
//| https://www.forexfactory.com/showthr...&reply=1#reply |
//+------------------------------------------------------------------+

Some of features code are borrowed from HalftTrend3.mq4 (alerts,emails etc) which has identical requirement as HP v2 requirement.

HP_DIFF_Alerts.mq4 should work without any change as it is still calling HP.mq4 arryindexed 0 which is hpf values.

Happy New Year..

Thank you BlueRain for your generous coding, Happy New Year

Found a minor bug - and fixed.
Try a new one.

this part is rolled back to original
for(int n=0;n<nobs;n++) xn[n]=Close[n];
HPF(nobs,lambda,xn,hpf);

2nd Bug fix:
some arrow was redrawn as it was trying to draw from last point.
fixed by completely go over all data every thick.

- In need of looking a bit more on arrow repainting while still in same trend.
this one has improved but I will update later I feel it needs some change.
Not a big functional blocker but still some eye sore.

Updated one more time.

Great thank you BlueRain

Can you try this one and let me know?
I have moved arrow handling block to its own block.
It seems to be working but if you find any issue, please let me know.