Quick script help... | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Basic Alt Key/Entry Script - Simplest Script Ever 1 reply

Quick Script Help 0 replies

i like to add an indicator script into my own script. what would be the best idea? 3 replies

Hedging Question - Quick Question Looking for A Quick Answer 1 reply

Quick script help 0 replies

Quick script help...

  • #1
  • First Post: Edited 8:12pm Oct 18, 2006 8:00pm | Edited 8:12pm
Your if statement is kinda strange and you have missed a parameter on the second RSI statement .. here is how I would write it:

Inserted Code
int start() {

   if (iRSI(NULL,0,21,PRICE_CLOSE,0) > 49 && iRSI(NULL,0,21,PRICE_CLOSE,0) < 51) {
  PlaySound("sirenhilo.wav");
   }
   return (0);
}

Quote
What's wrong with the following?

//+------------------------------------------------------------------+
//| RSIAlert.mq4 |
//| Palmer |
//| http://www |
//+------------------------------------------------------------------+
#property copyright "Palmer"

//+------------------------------------------------------------------+
//| script program start function |
//+------------------------------------------------------------------+
int start()
{
//----
if(iRSI(NULL,0,21,PRICE_CLOSE,0) > 49 && if(iRSI(NULL,0,21,PRICE_CLOSE,) < 51;
{
PlaySound("sirenhilo.wav");
}
return (0);
}
//+------------------------------------------------------------------+
  • #2
  • Oct 18, 2006 11:43pm Oct 18, 2006 11:43pm
I haven't got a platform with me right now to test it for sure, but I think this code will do a sound alert with every tick while the RSI criteria are being met, rather than to do a single alert when the "magic cross" occurs (ie the when the criteria begin to be met)........
"The market will rally from this or lower levels"
  • #3
  • Edited 12:52am Oct 19, 2006 12:29am | Edited 12:52am
You are right LightKeeper, I was just straight translating his code ... if you just want it when it makes the initial cross and not after then something like this might work:

Inserted Code
int start() {
   double rsiNow = iRSI(NULL,0,21,PRICE_CLOSE,0);
   double rsiBefore = iRSI(NULL,0,21,PRICE_CLOSE,1);
   if ((rsiNow > 49 && rsiNow < 51 && rsiBefore <= 49) || (rsiNow < 51 && rsiNow>49 && rsiBefore >= 51)) {
  PlaySound("sirenhilo.wav");
   }
   return (0);
}

Like you I don't have a terminal in front of me to test it, but give it a go anyway. If you are only looking for rsi to equal 50 .. then it is simpler:


Inserted Code
int start() {
   double rsiNow = iRSI(NULL,0,21,PRICE_CLOSE,0);
   double rsiBefore = iRSI(NULL,0,21,PRICE_CLOSE,1);
if ((rsiNow == 50 && rsiBefore != 50) {
  PlaySound("sirenhilo.wav");
   }
   return (0);
}
You can quit and they won't care, but you will always know.
  • #4
  • Oct 19, 2006 2:07am Oct 19, 2006 2:07am
Quoting Akuma99
You are right LightKeeper, I was just straight translating his code ... if you just want it when it makes the initial cross and not after then something like this might work:

Inserted Code
 
int start() {
double rsiNow = iRSI(NULL,0,21,PRICE_CLOSE,0);
double rsiBefore = iRSI(NULL,0,21,PRICE_CLOSE,1);
if ((rsiNow > 49 && rsiNow < 51 && rsiBefore <= 49) || (rsiNow < 51 && rsiNow>49 && rsiBefore >= 51)) {
 PlaySound("sirenhilo.wav");
}
return (0);
}

Like you I don't have a terminal in front of me to test it, but give it a go anyway. If you are only looking for rsi to equal 50 .. then it is simpler:


Inserted Code
 
int start() {
double rsiNow = iRSI(NULL,0,21,PRICE_CLOSE,0);
double rsiBefore = iRSI(NULL,0,21,PRICE_CLOSE,1);
if ((rsiNow == 50 && rsiBefore != 50) {
 PlaySound("sirenhilo.wav");
}
return (0);
}
Yup, that should work
I wasn't being critical, in fact didnt even know that code was posted by you. Just made an observation because I imagine that will be the next question.
"The market will rally from this or lower levels"
  • #5
  • Oct 19, 2006 7:57am Oct 19, 2006 7:57am
Thanks guys! I'm at the normal job thing right now and won't actually be able to check this out until this weekend. I'll let ya know....
  • #6
  • Oct 21, 2006 10:01am Oct 21, 2006 10:01am
Works like a champ, thanks guys..
  • #7
  • Dec 1, 2006 3:43am Dec 1, 2006 3:43am
Hi Palmer,

I know absolutely nothing about scripting...

Could you please post the full script as I am very interested to try this out.

Thanks,
Sage
  • #8
  • Last Post: Dec 1, 2006 6:31am Dec 1, 2006 6:31am
You might want to put a time constraint on that code (ie end of bar only), otherwise I believe it will play over and over and over and over and over and over......


andersenws
"Youth is the trustee of prosperity." - Benjamin Disraeli
0 traders viewing now