EA to buy/sell previous days high/low

Can u do this function

Pending Buy or Sell- Daily open Candlestick yesterday
Pending Buy or Sell - Daily close Candlestick yesterday

Lock profit 1pip when profit 10 pip or 20pip then trailing

I think it much more safety then high n low yesterday

yes guys your right, there are quite a few problems with this ea. I am new to this. I hope there is someone more experienced who doesnt mind looking at it. Been working 12 hour days recently including saturdays so very hard to work on this. But i will press on to try and sort problems out.
Is anyone else not getting results in the strategy tester? maybe I have given out a different/editited version of the ea?

It works in the strategy tester for me as long as the ENDHH and ENDMM are set after the StartHH and StartMM, for some reason it doesnt switch to the next day or something

I think this was my problem.... thanks durden

Fry, would it be possible to set it to buy 5 pips BELOW the previous days high or sell 5 pips above the previous days low, instead of AT the previous high/low as it is now? I want to see if I can get rid of the few loses in the tester.

hey fire,

nice to see ur playing arround with this, looking to find a way making it smooth...

just an idea... if u buy 5 pips below last days high or 5 pips above last days low... sure u can code that in mql4, but what do u do if u have a marubozu candle? ...one without shadow...? imagine price is moving from 1.5510 down to 1.5500 where is the end of the day, and the low of the day... u place an order at 1.5505, but price continues to fall straigh and nicely from 1.5500 to 1.5480 and so on... u have a pending order, great, but it would never get triggered...

i hope i understood correct what u want, so i try to put it in the following condition...
if the price is higher(at least by ur 5 pips distance and the stoplevel = MarketInfo(symbol, MODE_STOPLEVEL) what is the minimum required distance between current price and pending order)...so if the price is higher than the days low... then u want a pending order 5 pips above the low...
if it is lower than the days high u want an order 5 pips below days high...
and just in case price does not meet that criteria and is either at days high/low or to close to fullfill ur pending order request... then u should buy it at the spot....

so far... hope u know what i mean....

Hey Fry, this seems to be one of my problems. I want to start it at 1700 local time and end it at 1659 the next day. But like Durden said, it doesnt seem to want to go to the next day. It will only work if the end time is between 1700 and 2400.

ok. Well you want the pending orders to open around 17:00 and close same time next day yes? You basically want the pending order to close the next day if it has not been triggered am I correct?
If so then you need not do anything. sorry i havnt really explained too well. For the START HH and START MM, END HH and END MM, you want to leave it the same as it is. That will give the EA 2 or 3 hours to make the pending order, but the pending orders are set to close the next day automatically at the time you gave me. If you want me to change these times then I will have to hack the code again, easy to do.
Although it sounds like there are some other coders here that are making the neccesary changes? if so great im open to any help with this!
Fireslayer when you say you want the EA to start 17:00 and end 16:59 next day do you mean the pending orders or the actual EA? If it is the pending orders just keep the same times that where given with EA. if however it is for the entire EA please let me know why you want it to do this and ill see what I can do.
The Highest high and Lowest low is already calculated for the times you gave me ONLY if you keep the start hour and end hour the same . You could keep START HH and START MM to 17:00 but change the END times to 18:00 if you like and it will still calculate the HH and LL for 17:00 previous day to 17:00 today.
However if you change the START HH and MM to say 18:00 then the HH and LL will actually be calculated for 18:00 previous day to 18:00 today. Effectivly the START TIMES are the Times for the HH and LL to be calculated. They will go 24 Hours back in time from the start time. You could even make it 05:00 in the morning.
I hope this isnt too much of a problem. if it is then let me no what needs to be changed and Ill take a look at it, unless som1 else already making neccessary changes.


p.s. is it ABSOLUTLY CRUCIAL that the HH and LL is calculated from 17:00 to 16:59? it would be fairly simple for me to change if it is important, however I think it would be better for smoother running or the EA to calculate in HOUR, rather than Minuite.

Looking back at your original post you want the HH and LL to be calculated from 5:00 pm est to 5:00pm est currennt day. EA already doing that.
Can I just clarify with you the specific time you would ENTER your trades?
when you said 5-10 do you mean 9:50pm or do you mean anywhere in between 5:00pm to 10:00pm? Basically the EA will enter the trades at the START TIME untill it reached the END time. So realistically you only need to allow it 1 HOUR say the best time that you would normally trade. Whether it be 5:00pm to 6:00pm, OR 9:00pm to 10:00pm.
In the START HH and END HH just put 05 for START and 06 for END. if though you need it to make the trades at 9:00pm to 10:00pm I will need to re-do the code, as currently the HH and LL is also set to calculate from the START TIME given. This is a major flaw really, but then I am stupid at this coding malarky.

Hope now things are a little clearer.

I would say that it would most definately be worth being able to change the Start and end times independantly with this EA. I have gone in and messed with it a little bit and am doing things on a 4 hour chart with a different start time. Fry, would it be possible to go in and comment the code a little better? If I could tell what everything did I could probobly figure out how to change the times correctly....

Thanks guys

Hey Fry,

I think we keep confusing each other. LOL Anyway, this is how I was looking for the EA to be set up. I want it to run indefinately but be able to reset come 5pm. I want it to be able to enter a trade at any time in that 24 hour period. I only want it to make 1 trade per day, that being either a Buy at the previous days high or a Sell at the previous days low with a T/P set for 10 pips. At the end of the 24 hour period (ie-5pm) I want it to cancel any PENDING orders (if there is an open order that hasnt hit the T/P yet, it can stay open) and then starts the process over again for the next 24 hours.

It can either wait to place an order until it reaches the High or Low, or at 5pm it can go ahead and place 2 pending orders. One at the previous High and one at the previous Low. Preferably the latter, since this is how I've been doing it manually.

Everyday at 5pm I would look at the previous days High and Low, I would place a pending Buy order at the High with a Take Profit set for 10 pips and Sell order at the Low with a Take Profit for 10 pips. 90% of the time one or the other will be hit. Occassionaly the pair will stay in a tight range and not hit either one. Come 5pm if neither were hit or one was leaving one pending order I would cancel the pending order(s) and set 2 new pending orders for that days previous High and Low.

On a very RARE occassion the order would be hit but never reach the T/P in this case you would just have to Cost Average.

Hope this makes things clear as mud!!!

Well this EA runs exactly how you want it to, except for the trailing stop and cancelation of the opposite pending order that hasnt been hit yet.
The EA doesnt need to run constantly as it will calculate the HH and LL for those time you gave me. It effectivly will work exactly as you have described your day of trading.
So at 5pm you look at yesterdays HH and LL back to 5PM yesterday. correct so far?
Then you cancel your previous pending orders and put new pending orders in for yesterdays HH and LL. If one has been hit cancel the other. if neither has been hit by 5pm the next day it will close both pending orders.

This EA will do exactly that except for the closing of the opposite pending order. It WILL close boths orders at 5pm the next day. Try putting in at the START HH and END HH 17 for start and 18 for end. see what happens with your trades.

I dont think there is confusions, its just i have made the EA a weird way, but it gets the job done how you first explained.

Durden for this EA it is not important for the start time and end time to work independantly of the calculation of HH and LL. It is only important if you want to use a different strategy to what fireslayer wants which seems to be your case.
So you have changed it to work with H4 chart. The times do not need to be corrected, the only reason I made it so that the EA will only run at 17:00 to 21:00 is because that is around the time when fireslayer put in his pending orders.
Its easy to change this, all you need to do is delete the custom function in tradewindow and its associated parts. Effectivly you would have to change the EA into a different one al together. you mite aswell start a fresh then at least you will get exactly what you want.

Ok, thanks for the reply Fry. I will start testing it leaving your original settings in place!

Oh, and I also have a new challenge for you. I dont know if its possible, let me know. Here it is: its kinda like the last EA you made. Its for the GBP/JPY. It looks at the previous days high and low like the last one. But this one would enter a trade 100 pips past the high or low. If it went 100 pips above the previous high, it would place a sell order with a T/P of 100 pips (adjustable ofcourse). Same if it went 100 pips below the previous low, it would place a buy order with a T/P of 100 pips. Cancelling any open trades at the end of the trade period just like the last EA.

Thanks for the great work!

No problem buddy.
For that new ea you want shouldnt take too long, actually should be very easy to do. just need to make 2 small changes.
Will post when its done. Also this weekend I will look at trying to sort out that damn canceling of order. I still cant believe I had it a few days ago. driving me NUTS!

What is the stop loss you want?

no stop loss set, but have the option of using one.

Also, want to know if you can code it to Cost Average too. Just in case your not sure of what I'm talking about:

Ok, for Cost Averaging, say I buy 1 Lot of Eur/Usd @ 1.5500 and the price goes down against me to 1.5400, I would buy another Lot at 1.5400 bringing the average of my 2 Lots to 1.5450. So the price would only need to get back to 1.5450 to break even instead of 1.5500. Say it continued to drop to 1.5300. I would buy another Lot there bringing my average of the 3 Lots to 1.5400. Then as soon as the price got to 1.5400 I would be at break even.

For example, if using this EA the previous high of the GBP/JPY was 210.50 and I wanted it to Sell @ 211.50, if the price contiued past 211.50, I would want to to sell again every 100 pips past the original Sell of 211.50. So it would sell again @ 212.50 and 213.50. At which point I would close it manually whenever I broke even or started to make profit.

Thanks!

Hey Fry, I found this. Maybe you can work it into the EA for the pending order cancellations?

Cool. will look into that see if it helps with pending orders. also is the first ea working as you wanted apart from pending orders and trailing stop?

I like the idea of cost averaging. I will try to work that into the ea. Do you want it on both?

Sure both would be great! Cant wait to see how it turns out.

*bump*

sry fireslayer, have been caught up with different things. I did try to get the cost avergaing but was having problems with price quotes for jpy pairs.
Is the orgininal EA working as you had expected? it would be good to get that running exactly how you want then I can develop it further with this new ea.