Help in coding a function in MetaEditor

Hello

I'm trying to code a function, that will return the highest candle range from the last 9 candles.

than, I would like to plot it as an indicator.

Here's where I got so far -

Function:

double Last9 (int x)
{

int count, highest;
double range[9];

for (count=(x+1) ; count<(x+10) ; count++) { //bar range assigmant
range[count]=(High[count]-Low[count]);
range[count]=MathAbs(range[count]); //verifying positive
}
highest=ArrayMaximum(range,9,(x+1));

return(range[highest]);
}


here's the indicator I coded for this. If you'll use it on a charts, you will see that from a certain point it plot 0 for some reason.

Help very much appreciated!!!

Cheers,
Nati


The entire indicator:

//+------------------------------------------------------------------+
//| NatiTest.mq4 |
//| Copyright 2008, MetaQuotes Software Corp. |
//| http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright 2008, MetaQuotes Software Corp."
#property link "http://www.metaquotes.net"

#property indicator_separate_window
#property indicator_buffers 2
#property indicator_color1 Red
#property indicator_color2 Lime
//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];

//+------------------------------------+
//|Highest in last 9 function |
//+------------------------------------+
double Last9 (int x)
{

int count, highest;
double range[9];

for (count=(x+1) ; count<(x+10) ; count++) { //bar range assigmant
range[count]=(High[count]-Low[count]);
range[count]=MathAbs(range[count]); //verifying positive
}
highest=ArrayMaximum(range,9,(x+1));

return(range[highest]);
}



//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
SetIndexStyle(0,DRAW_LINE);
SetIndexBuffer(0,ExtMapBuffer1);


SetIndexStyle(1,DRAW_LINE);
SetIndexBuffer(1,ExtMapBuffer2);
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{

//------------------------------+
//Calling Last9 function |
//------------------------------+
int j;
for (j=0 ; j<Bars ; j++)
ExtMapBuffer1[j]=Last9(j);





return(0);
}
//+------------------------------------------------------------------+

The functions needed are built in...

You can use last9High = High[ iHighest() ];

supplying the needed parameters in the iHighest part.

Hi Nati,

I looked over the code and think I understand what you are trying to do. Rewriting the code as you started would have been harder for me than just writing the code from scratch...



I added some commenting in an attempt to aid you in understanding the code and what is actually happening. I realize that actually writing the code goes a step further than helping, may do worse than good, but if you really are willing to learn, the code should be benificial in helping you.

Let me know if this is the indicator you had in mind and if you need any clarification about anything and I will help to my best.

Regards,
lucidlamp

Hi
Thank you very very much for your help!!!
unfortunatlly, since I'm a newbie I had a hard time understanding most of the code...:-( I'll give it another shot soon

anyway, I've manage to get to pretty much what I was aiming for (the result it identical to yours) , but for some reason the indicator loads up really slow and some times MT4 gets stuck

I'll appreciate if you could take a look at it (Sorry for the pretty much dumb coding ideas

Thanks again,
Nati

Hi again,

The slow loading and getting stuck is due to the use of Bars in the for loop in the high9() function coupled with the large size of the array range[]. Every time a tick comes in from your feed the loop calculates every bar on the chart and stores the findings in the array range[], which takes time and consumes computer memory. So the size of the array range[] should only be the size of the bars you are looking back. Then the 'for' loop should only look back the number of bars being checked for largest range, so in:

for (i=0 ; i<Bars ; i++){

the 'Bars' should be replaced with a number representing how many bars you want to compare for largest range.

This will make the code for high9() function run as fast as it possibly can.

Also you included this: 'int counted_bars=IndicatorCounted();' in the high9() function, which is not being used and can be removed.

Also you are assigning a value to ExtMapBuffer1[] within the high9() function and then re-assigning the value of ExtMapBuffer1[] in int start(). This should be rechecked.

Regards,
lucidlamp

Hi Guys,

anyone from you can add option to "disable" sunday's data on the pivot points indicator that im using? drop me a PM if you can do it!

Thank you.

Hi belekas,

Point your avatar at the indicator, perhaps the indicator just needs some persuasion to resolve your Sunday bar problem.

Regards,
lucidlamp

Hey lucidlamp thanks a lot I'll try it

Nati