Code for email alert not working | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

4H Stochs Email Alert Code Help Please 20 replies

how to email alert for trade alert? 3 replies

Email function not working. Code posted. 0 replies

still looking for working ema cross email alert 2 replies

Please help add email alert to code 1 reply

Code for email alert not working

  • #1
  • First Post: Nov 23, 2017 4:09pm Nov 23, 2017 4:09pm
Hey guys,

So I have been playing around and I know stuff can reach my email and give me an alert however I need it to do it at the right time which I'm having issues with.
I need it to check for the conditions after a candle close and if the conditions are met it sends an email.

This is what I came up with but it's not working at the moment so if someone could tell me what's wrong I'd appreciate it.

Here is the code:
https://pastebin.com/1BcDX5Ys


Thanks!
  • #2
  • Nov 23, 2017 5:17pm Nov 23, 2017 5:17pm
You might try something like this
Inserted Code
void OnTick()
  {
//---
   if(AlertsOnTheHour())
      if(true) //condition
         SendMail("Test","Mail");
  }
//+------------------------------------------------------------------+
bool AlertsOnTheHour() //true when new H1 bar is formed
{
   static datetime last_time = SeriesInfoInteger(_Symbol,PERIOD_H1,SERIES_LASTBAR_DATE);
   datetime time = SeriesInfoInteger(_Symbol,PERIOD_H1,SERIES_LASTBAR_DATE);
   if(last_time!=time)
   {
      last_time=time;
      return true;
   }
   return false;
}
  • #3
  • Nov 24, 2017 6:31am Nov 24, 2017 6:31am
Quoting Nicholishen
You might try something like this void OnTick() { //--- if(AlertsOnTheHour()) if(true) //condition SendMail("Test","Mail"); } //+------------------------------------------------------------------+ bool AlertsOnTheHour() //true when new H1 bar is formed { static datetime last_time = SeriesInfoInteger(_Symbol,PERIOD_H1,SERIES_LASTBAR_DATE); datetime time = SeriesInfoInteger(_Symbol,PERIOD_H1,SERIES_LASTBAR_DATE); if(last_time!=time) { last_time=time; return true; } return false; }

Alright so I ended up with something like this and it works however could someone explain why what I did didn't work because to be honest in my brain it worked perfectly hehe.

Thanks a lot for the help!

Inserted Code
//+------------------------------------------------------------------+
//|                                                        ALERT.mq4 |
//|                                                           AntiVi |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "AntiVi"
#property link      "https://www.mql5.com"
#property version   "1.00"
#property strict
 
bool AlertsOnTheHour() //true when new H1 bar is formed
         {
            static datetime last_time = SeriesInfoInteger(_Symbol,PERIOD_H1,SERIES_LASTBAR_DATE);
            datetime time = SeriesInfoInteger(_Symbol,PERIOD_H1,SERIES_LASTBAR_DATE);
               if(last_time!=time)
               {
                  last_time=time;
                  return true;
               }
            return false;
         }
//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit()
  {
//---
      
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
//---
  
  }
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
  {
           if(AlertsOnTheHour())
               {
                    if(Close[1] > High[2])
                    {
                        SendMail("MT4 Alert", "Test");
                    }  
                  
                    else if(Close[1] < Low[2])
                    {
                        SendMail("MT4 Alert", "Test");
                    }  
 
               }  
    
  }
//+------------------------------------------------------------------+
  • #4
  • Nov 24, 2017 6:51am Nov 24, 2017 6:51am
Quoting AntiVi
{quote} Alright so I ended up with something like this and it works however could someone explain why what I did didn't work because to be honest in my brain it worked perfectly hehe. Thanks a lot for the help! //+------------------------------------------------------------------+ //| ALERT.mq4 | //| AntiVi | //| https://www.mql5.com | //+------------------------------------------------------------------+ #property copyright "AntiVi" #property link "https://www.mql5.com" #property version "1.00" #property strict bool AlertsOnTheHour() //true when...
Inserted Code
 if(time < Hour() || ((time == 23) &&(time > Hour())))
Hour() Returns the hour (0,1,2,..23) of the last known server time by the moment of the program start.
so if time == 23, it will stuck there forever
  • #5
  • Last Post: Nov 24, 2017 7:02am Nov 24, 2017 7:02am
Quoting extraw
{quote} if(time < Hour() || ((time == 23) &&(time > Hour()))) Hour() Returns the hour (0,1,2,..23) of the last known server time by the moment of the program start. so if time == 23, it will stuck there forever
Aaah I see, it doesn't keep checking. That makes sense!

Thanks for explaining!
0 traders viewing now