Code for "if ADX (-1) < ADX (-2)"

 if(use_macd && use_adx)
  {
     if(adx>adx_level &&  macd>overbought) return(sell);
     if(adx>adx_level &&  macd<oversold)   return(buy);
  }

Quoting mntemel

Disliked

Hi All, Need some help with coding. I have an assistant EA that I use in my trading. At the moment the signal is like below; if(use_macd && use_adx) { if(adx>adx_level && macd>overbought) return(sell); if(adx>adx_level && macd<oversold) return(buy); } so if MACD is at overbought/sold and ADX is greater than the defined level then it opens a position. Is it possible to add one more rule and say once candle closes check if ADX is less than previous ADX level. So basically I want it to open the position when ADX starts going down. I guess it should...

Ignored

double adx_1 = iADX(Symbol(),0,ADXperiod,0,MODE_MAIN,1); //---- That's the last candle closed
double adx_2 = iADX(Symbol(),0,ADXperiod,0,MODE_MAIN,2); //---- That's the candle before the last candle closed

if(adx_1 < adx_2) ... etc ...

Quoting mntemel

Disliked

did the trick, many thanks!

Ignored

  double macd_1 = iMACD(Symbol(),0,MACD_FastEma,MACD_SlowEma,MACD_SignalPeriod,0,MODE_MAIN,1);
  double macd_2 = iMACD(Symbol(),0,MACD_FastEma,MACD_SlowEma,MACD_SignalPeriod,0,MODE_MAIN,5);

if(macd>overbought && macd_1<macd_2) return(sell);
if(macd<oversold && macd_1>macd_2)   return(buy);

Quoting mntemel

Disliked

do you see anything wrong here?

Ignored

Quoting FerruFx

Disliked

{quote} If your need is to know (ie. SELL) if the last candle closed of the MACD histogram is below of the MACD histogram few candles earlier, it should be fine. Vice versa for BUY.

Ignored

 if(use_macd && use_adx)
  {
     if(adx>30 && adx_2<adx_1 &&  macd>overbought && macd_1<macd_2) return(sell);
     if(adx>30 && adx_2<adx_1 &&  macd<oversold && macd_1>macd_2)   return(buy);
  }

Quoting cja

Disliked

It could be because the BUY / SELL conditions may never occur? if you have something like adx>30 then that is a signal as long as the adx is above 30 however if you have an adx_2<adx_1 that can only signal at that point and your BUY / SELL condition has 2 of those specific signals ( all be it that the macd is 5 bars apart ), so how often do the adx and macd signal conditions occur based on your code? Just throwing this in to the mix and hopefully it helps.

Ignored

Result = 0; 
if(use_macd && use_adx)
  {
     if(adx > 30.0)        Result += 1000;
     if(adx_2 < adx_1)     Result += 100; 
     if(macd > overbought) Result += 10;
     if(macd_1 < macd_2)   Result += 1;
     Print("Result = ", Result);
  }

Quoting fxdaytrader_

Disliked

if(use_macd && use_adx) -> and what if both are = FALSE? Does some errorchecking take place then, or will it open position after position ...? if(adx>30 && adx_2<adx_1 && macd<oversold && macd_1>macd_2) return(buy);: should it not be "adx_2>adx_1"? you could work with bools also, example (scheme): if (adxLong && macdLong) OrderSend(BUY ... bool adxLong() { if (adx1>adx2) return(true); return(false); } or if (adxdirection==OP_BUY) OrderSend(BUY ... int adxdirection() { if (adx1>adx2) return(OP_BUY); if (adx1<adx29 return(OP_SELL); return(99);//just...

Ignored

Quoting FerruFx

Disliked

{quote} It seems that you don't know how to use ADX. The main line should be up regardless the trade direction (adx1 > adx2). That's the +DI/-DI which set the direction.

Ignored

double adx_1 = iADX(Symbol(),0,adx_period,0,MODE_MAIN,1);
double adx_2 = iADX(Symbol(),0,adx_period,0,MODE_MAIN,2);

Quoting mntemel

Disliked

{quote} Well I look at the main ADX line and the moment it starts decreasing I'm taking that as the reversal point. I thought these two lines below would give me the past two values of the main ADX line. As Fxdaytrader mentioned I'm not interested in +di/-di lines. double adx_1 = iADX(Symbol(),0,adx_period,0,MODE_MAIN,1); double adx_2 = iADX(Symbol(),0,adx_period,0,MODE_MAIN,2); Is this where I'm going wrong then?

Ignored

Quoting FerruFx

Disliked

{quote} The MAIN adx line is absolutely not for directional. Line slopping up means that the price is "trending" (up or down). Line slopping down means price is "resting" (no momentum).

Ignored

Quoting mntemel

Disliked

I'm looking at points where ADX is greater than 30 lets say for instance and starts descending (means exhaustion to me)

Ignored

Quoting fxdaytrader_

Disliked

{quote} And that is the point - Because that is not the way the ADX is used (see FerruFX's posts above or read one of the adx-documentations around). It is possible that you better should use +di/-di? If you'd like to use the adx 30 level as filter I suggest the following (without macd now for better understanding): LONG ENTRY: +di crosses above -di AND adx is > 30 SHORT ENTRY: -di crosses above +di AND adx is > 30

Ignored