Menu
Sister Sites

Options

Bookmark Thread

First Page First Unread Last Page Last Post

Print Thread

Similar Threads

virus or something else: smile symbol becomes a crying symbol 4 replies

Trailing Entries & Trailing Stops? 26 replies

Broker with a pip by pip trailing stop 24 replies

To Trailing Stop or Not To Trailing Stop.... 36 replies

Price-based Vs. Pip-based 5 replies

Help: Turning pip-based trailing into something else

  • Post #1
  • Quote
  • First Post: Jul 31, 2012 11:50pm Jul 31, 2012 11:50pm
Hi There,
I've been playing around with forex generator, just getting into coding. For some reason I can't make a trailing stop work with their inbult trailing stop flex block. So I'd like some help changing this code.

Quote
void TrailingStop18()
{
for (int i=OrdersTotal()-1; i >= 0; i--)
if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
{
if (OrderSymbol() == Symbol() && OrderMagicNumber() == 1)
{
double takeprofit = OrderTakeProfit();

if (OrderType() == OP_BUY && Ask - OrderOpenPrice() > TrailingStop18*PipValue*Point)
{
if (OrderStopLoss() < Ask-(TrailingStop18+TrailingGap18)*PipValue*Point)
{
if (NewTakeProfit18 != 0) takeprofit = Ask+(NewTakeProfit18 + TrailingStop18)*PipValue*Point;
bool ret1 = OrderModify(OrderTicket(), OrderOpenPrice(), Ask-TrailingStop18*PipValue*Point, takeprofit, OrderExpiration(), White);
if (ret1 == false)
Print("OrderModify() error - ", ErrorDescription(GetLastError()));
}
}
if (OrderType() == OP_SELL && OrderOpenPrice() - Bid > TrailingStop18*PipValue*Point)
{
if (OrderStopLoss() > Bid+(TrailingStop18+TrailingGap18)*PipValue*Point)
{
if (NewTakeProfit18 != 0) takeprofit = Bid-(NewTakeProfit18 + TrailingStop18)*PipValue*Point;
bool ret2 = OrderModify(OrderTicket(), OrderOpenPrice(), Bid+TrailingStop18*PipValue*Point, takeprofit, OrderExpiration(), White);
if (ret2 == false)
Print("OrderModify() error - ", ErrorDescription(GetLastError()));
}
}
}
}
else
Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
I'd like to change this to move the trailing stop to the Low[1] or High[1] respectivly.... Can someone please advise me if it's possible to change this simply, and possibly what code would need to be changed. I'm just a beginner at this

Thanks in advance!
Try .....

Inserted Code
void TrailingStop18()
{
  double mHighStop = NormalizeDouble(High[1], Digits);
  double mLowStop = NormalizeDouble(Low[1], Digits);
for (int i=OrdersTotal()-1; i >= 0; i--)
if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
{
if (OrderSymbol() == Symbol() && OrderMagicNumber() == 1)
{
double takeprofit = OrderTakeProfit();

if (OrderType() == OP_BUY && Ask - OrderOpenPrice() > TrailingStop18*PipValue*Point)
{
if (OrderStopLoss() < Ask-(TrailingStop18+TrailingGap18)*PipV alue*Point)
{
if (NewTakeProfit18 != 0) takeprofit = Ask+(NewTakeProfit18 + TrailingStop18)*PipValue*Point;
bool ret1 = OrderModify(OrderTicket(), OrderOpenPrice(), mLowStop , takeprofit, OrderExpiration(), White);
if (ret1 == false)
Print("OrderModify() error - ", ErrorDescription(GetLastError()));
}
}
if (OrderType() == OP_SELL && OrderOpenPrice() - Bid > TrailingStop18*PipValue*Point)
{
if (OrderStopLoss() > Bid+(TrailingStop18+TrailingGap18)* PipValue*Point)
{
if (NewTakeProfit18 != 0) takeprofit = Bid-(NewTakeProfit18 + TrailingStop18)*PipValue*Point;
bool ret2 = OrderModify(OrderTicket(), OrderOpenPrice(), mHighStop , takeprofit, OrderExpiration(), White);
if (ret2 == false)
Print("OrderModify() error - ", ErrorDescription(GetLastError()));
}
}
}
}
else
Print("OrderSelect() error - ", ErrorDescription(GetLastError()));


You would need to make sure that the H/L are not too close too current price or the order may not be accepted.

M.
If you think I'm mad, I must be mad
  • Post #3
  • Quote
  • Last Post: Aug 1, 2012 10:58am Aug 1, 2012 10:58am
I'll give it a try. Thank you M.
0 traders viewing now