Help improve this open/close Order Alerts (Email/Sound/Alert) indicator | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Help adding sound & email alert 8 replies

Need Trade Open & Close Sound Alert Indicator 0 replies

Order Open/Close Mobile or Email Alert Indicator - Solved 0 replies

Need help with email and sound alert... 3 replies

sound and email indicator alerts - help! 12 replies

Attachments: Help improve this open/close Order Alerts (Email/Sound/Alert) indicator
Exit Attachments

Help improve this open/close Order Alerts (Email/Sound/Alert) indicator

  • #1
  • First Post: Edited 7:23am May 8, 2012 7:08am | Edited 7:23am
Hi,

I have made an indicator (see attachment) based on a bunch of current indicators to Alert/Email/Sound when orders are opened and closed.
When an order is closed the Alert/Email will detail the ticket, pair, lots, profit/loss, commission, ect. This works without problems.

When an order is opened the Alert/Email will detail the ticket, pair, Lots, ect... This works fine when placing a market order.

But when a pending orders get filled the Alert/Email info (ticket, pair, Lots, ect...) will not state the info from the filled order but instead the info of the last added pending order, one that is not filled yet.

Can somebody help me, or give tips to make this work so the right info gets send by Alert/Email when a pending order is executed. I'm not a (good) coder, in fact I do my coding with a copy/paste strategy ;-)
Thanks so much for the help.
Attached File(s)
File Type: mq4 Order Alerts.mq4   4 KB | 1,010 downloads
File Type: rar sounds.rar   250 KB | 840 downloads
  • #2
  • May 15, 2012 12:55pm May 15, 2012 12:55pm
Anybody?
  • #3
  • May 15, 2012 2:59pm May 15, 2012 2:59pm
Quoting Liquid007
Anybody?
Just at first glance you have this line:

if ((OrderType() == OP_BUY) || (OrderType() == OP_SELL))
number++;

Try commenting out or add:
OP_BUYSTOP
OP_BUYLIMIT
OP_SELLSTOP
OP_SELLLIMIT
  • #4
  • May 15, 2012 4:26pm May 15, 2012 4:26pm
Thanks for your help.
I just tried to add them but then I receive the Alert directly when placing the pending order and when the order gets eventually executed/filled it mixes the info up again.
When closing the order the information is right because the following lines in the code:
----
total = OrdersHistoryTotal();
OrderSelect(total -1,SELECT_BY_POS,MODE_HISTORY);
----
It takes/selects the information from the last closed order out of the order history.

For for the opening I do not know what code to use to select the last executed/filled active order.
  • #5
  • May 15, 2012 4:42pm May 15, 2012 4:42pm
Quoting Liquid007
[font=Verdana]Thanks for your help.
I just tried to add them but then I receive the Alert directly when placing the pending order and when the order gets eventually executed/filled it mixes the info up again.
When closing the order the information is right because the following lines in the code:
----
total = OrdersHistoryTotal();
OrderSelect(total -1,SELECT_BY_POS,MODE_HISTORY);
----
It takes/selects the information from the last closed order out of the order history.

For the opening I do not know what code to use to...
I'm not aware of any way to alert when a pending order gets filled directly.

I'm going to post some code and maybe you can find a way to make it work for your situation.

Inserted Code
for(int i=0;i<OrdersTotal();i++){
 if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
 if(OrderSymbol()==Symbol() && OrderMagicNumber()==MagicNumber){
 BarsCnt=iBarShift(NULL,0,OrderOpenTime());
 openorders+=1;
 if(OrderType()==OP_BUY) buys++;
 if(OrderType()==OP_SELL) sells++;
 }  
}

Use Symbol() and OrderMagicNumber() on that Symbol to see when the last order was opened along with iBarShift().
  • #6
  • May 16, 2012 12:39pm May 16, 2012 12:39pm
I'm going to study a bit more coding to do this successfully...
Thanks again for your help/tips.
  • #7
  • Last Post: Jan 21, 2016 8:22am Jan 21, 2016 8:22am
Quoting Liquid007
I'm going to study a bit more coding to do this successfully... Thanks again for your help/tips.
Hey,

have you finished coding the indicator and solved the problem with the pending orders? I am asking because I am searching for an indicator that alerts you when a pending order has been triggered and I can't seem to find one.

All the best.
0 traders viewing now