OrderModify error 130? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

OrderModify - Error code 1 9 replies

Why ordermodify error 1? 9 replies

OrderModify error 1 HELP PLEASE 5 replies

OrderModify() problem (NOT error code 1) 3 replies

OrderModify error 1 ?? 0 replies

OrderModify error 130?

  • #1
  • First Post: Feb 22, 2012 5:23pm Feb 22, 2012 5:23pm
Inserted Code
if(HideSL==false&&StopLoss>0){SL=Bid+StopLoss*Point;/*OPP=Ask+StopLoss*Point;SLP=Ask;*/}else {SL=0;/*SLP=0;*/}
if(HideTP==false&&TakeProfit>0){TP=Bid-TakeProfit*Point;/*TPP=Ask+(TakeProfit*2)*Point;*/}else {TP=0;/*TPP=0;*/}
if(HideSL==false&&HedgeSL>0)SLH=Ask-HedgeSL*Point;else SLH=0;
if(HideTP==false&&HedgeTP>0)TPH=Ask+HedgeTP*Point;else TPH=0;

Ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,0,0,EAName,Magic,0,Red);
if(Hedge)TicketH=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,0,0,EAName,Magic,0,Blue);
OrderModify(Ticket,0,SL,TP,0,CLR_NONE);
if (Hedge) OrderModify(TicketH,0,SLH,TPH,0,CLR_NONE);

Ehm, any idea? MBT won't accept market orders with TP/SL and modifying them afterwards just gives the same error.
  • #2
  • Feb 22, 2012 11:04pm Feb 22, 2012 11:04pm
bool OrderModify( int ticket, double price, double stoploss, double takeprofit, datetime expiration, color arrow_color=CLR_NONE)
Parameters:
ticket - Unique number of the order ticket. price - New open price of the pending order. stoploss - New StopLoss level. takeprofit - New TakeProfit level. expiration - Pending order expiration time. arrow_color - Arrow color for StopLoss/TakeProfit modifications in the chart. If the parameter is missing or has CLR_NONE value, the arrows will not be shown in the chart.
Now look at your OrderModify command:
OrderModify(Ticket,0,SL,TP,0,CLR_NONE);

Do you think there is a price of "0" ?
Since it does not exist, there must be an error.

The correct command is:
OrderModify(Ticket,OrderOpenPrice(),SL,TP,0,CLR_NONE);
  • #3
  • Feb 23, 2012 7:23am Feb 23, 2012 7:23am
Hey, thanks for the answer.

Do you think that apart from the silly mistake with the price this method of changing the ticket afterwards is correct? Or is a loop to search for the ticket better?
  • #4
  • Feb 23, 2012 8:21am Feb 23, 2012 8:21am
Searching for a ticket with a loop is not necessary because there is
a command for this:

OrderSelect(TicketNumber,SELECT_BY_TICKET);

But for the OrderModify command you donīt need this OrderSelect because it finds the order via the TicketNumber.

Quote
Do you think that apart from the silly mistake with the price this method of changing the ticket afterwards is correct?
Correct, yes, but not good enough if you ask me.
Because you have no error routine.

An EA or indicator or script should always detect errors and communicate those errors.

I recommend that you search for the member 7bit here and find his website where he lets you download some stuff for free.
I use his common_functions module in my EAs and it is just fantastic.
Because he has many routines coded professionally for you, all the
trading commands like OrderSend and much more with all the error-routines built in.
Instead of inventing the wheel again, you can just learn from him and use
the commands.
  • #5
  • Feb 23, 2012 12:18pm Feb 23, 2012 12:18pm
Yea, I understand. In the stuff I made myself I have like else Alert blah blah so that I know exactly what went wrong and where (I still screw up alot, hey it's how I learn ).

This was an EA coded by someone else and it's pretty much error-proof. The only problem is that it was meant for brokers that allow SL/TP setting at marketorders and I guess he didn't know that existed (The EA does modify for 5/3 digit brokers and stoplevels, lots, etc etc).
  • #6
  • Feb 26, 2012 12:32pm Feb 26, 2012 12:32pm
Quoting fxtr51
I recommend that you search for the member 7bit here and find his website where he lets you download some stuff for free.
I use his common_functions module in my EAs and it is just fantastic.
Because he has many routines coded professionally for you, all the
trading commands like OrderSend and much more with all the error-routines built in.
Instead of inventing the wheel again, you can just learn from him and use
the commands.
I'm interested to this functions but I don't find 7bit website, can you help me with a link?
  • #7
  • Feb 26, 2012 4:57pm Feb 26, 2012 4:57pm
I typed "7bit" into google search and on page 2 this link
appeared:

http://www.forexfactory.com/7bit

From there you will find his website, I am sure.
  • #8
  • Feb 26, 2012 5:28pm Feb 26, 2012 5:28pm
Quoting fxtr51
I typed "7bit" into google search and on page 2 this link
appeared:

http://www.forexfactory.com/7bit

From there you will find his website, I am sure.
i've seen that page before, and searched in for www... no website inside... :-(
  • #9
  • Last Post: Feb 26, 2012 9:48pm Feb 26, 2012 9:48pm
Quoting prototipo
i've seen that page before, and searched in for www... no website inside... :-(
Come on. Be a bit creative. You will find a link on every post he has made in his sig. That is 1236 links and counting.
0 traders viewing now