Need a little help on coding about closing trades | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Closing all trades coding 3 replies

little help wanted with coding arrows 0 replies

Little coding help needed.. 1 reply

Need your opinion on trades not closing 4 replies

A little help with coding 3 replies

Need a little help on coding about closing trades

  • #1
  • First Post: Feb 15, 2012 8:34pm Feb 15, 2012 8:34pm
I am trying to add a modification to an EA to close close trades when Nonlagma_V7 changes colour. I can get it to work in a small test EA but for some reason I can't get it to work where I need it.

Buffer 3 = 1 for trend up and -1 for trend down.
nTrdL & nTrdS add 1 with each addition trade opened as price goes up/down.
If I can change to if (nTrdL>=2)y=ExitTrades..... the trades close with no problem.
PHP Code
bool CloseNhedgeL=false;
bool CloseNhedgeS=false;
PHP Code
double Nontrend=iCustom(Symbol(),0,"NonLagMA_v7",Price,Length,Displace,PctFilter,Color,ColorBarBack,Deviation,SoundAlertMode,3,1);    
    
if (nTrdL>0&&Nontrend<0)CloseNhedgeL=true;
               if(y==0)
            {
               if ((CloseNhedgeL==true)&&nTrdL>=2)y=ExitTrades(H,DarkViolet,"NHedge Profit Lock Activated",ThO); //Madness
               nTrdS=0;
         }
if (nTrdS>0&&Nontrend>0)CloseNhedgeS=true;
          if(y==0)
         {
            if ((CloseNhedgeS==true)&&nTrdS>=2)y=ExitTrades(H,DarkViolet,"NHedge Profit Lock Activated",ThO); //Madness
            nTrdL=0;
        }
I am sure it something simple but I am a new beginner to coding EA's so any pointers would be appreciated. I have tried paying people to do this for me but keep ending up with quick and dirty short cuts.

Thanks Fourxxxx
  • #2
  • Feb 15, 2012 11:40pm Feb 15, 2012 11:40pm
Quoting nubcake
no it makes it your problem. no more help for you. it's no skin off my nose.
Doesn't matter I got it working and your suggestion made no difference what so ever.

Here is some code from MQL4.com documentation.

"if (Bid > MA && Fact_Up == true)"

So much for "ALWAYS use brackets"
  • #3
  • Feb 16, 2012 2:08am Feb 16, 2012 2:08am
Try indenting your code properly. That would entice more people to offer you help and possibly make the code logic clearer for yourself.

http://en.wikipedia.org/wiki/Indent_style
  • #4
  • Last Post: Feb 16, 2012 3:10am Feb 16, 2012 3:10am
Quoting Xaphod
Try indenting your code properly. That would entice more people to offer you help and possibly make the code logic clearer for yourself.

http://en.wikipedia.org/wiki/Indent_style
Thanks for the suggestion, I have worked it out now anyway.
0 traders viewing now