MT4 multicurrency EA data problem | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

multicurrency datas with OnChartEvent() and EventChartCustom() 24 replies

MultiCurrency Candles 3 replies

Chamunda's MultiCurrency Strategy 237 replies

Multicurrency ea for demo testing 1 reply

Backtesting multicurrency strategies? 18 replies

MT4 multicurrency EA data problem

  • #1
  • First Post: Oct 11, 2011 5:20am Oct 11, 2011 5:20am
Hi,

I am trying to code multitimeframe, multicurrency EA. The issue I am struggling with is that when I try to get some data for currency different than the other that EA runs on, data is only available for the first currency. It will be better to illustrate this with example:

I am running the EA on USDLFX, aand I try to calculate some values with RSI. The code goes like this:

Inserted Code
for(int i = 0; i < NoOfPeriods; i++) {
     rsiDelta = iRSI(pairName, TradePeriod[i], 3, PRICE_CLOSE, 0) -
iRSI(pairName, TradePeriod[i], 3, PRICE_CLOSE, 1);
     if (rsiDelta >= RSITrendSensitivity2) score += RSITrendScore;
     else if (rsiDelta >= RSITrendSensitivity1) score += RSITrendScore / 2;
     else if (rsiDelta <= RSITrendSensitivity2) score -= RSITrendScore;
     else if (rsiDelta <= RSITrendSensitivity1) score -= RSITrendScore / 2;
    }

pairNames is a list of pairs:
EURUSD, GBPUSD, AUDUSD, NZDUSD, USDCAD, USDCHF, USDJPY

So it calculates ok for EURUSD, but then all the other pairs get only 0 from iRSI, and I get 4054 error code when I ask for last error.
When I change the sequence and for example GBPUSD will be first, then G/U will calculate and E/U and all other pairs will get only 0 from iRSI.

I have been sitting on this till late night yesterday with no results. Couldn't google anything helpful. If someone had similar problem and resolved it, I really would be greatful for some clue.
“I made most of my money sitting on my hands.”
  • #2
  • Oct 11, 2011 7:55am Oct 11, 2011 7:55am
Quoting ride.inc
Inserted Code
for(int i = 0; i < NoOfPeriods; i++) {
     rsiDelta = iRSI(pairName, TradePeriod[i], 3, PRICE_CLOSE, 0) -
iRSI(pairName, TradePeriod[i], 3, PRICE_CLOSE, 1);
     if (rsiDelta >= RSITrendSensitivity2) score += RSITrendScore;
     else if (rsiDelta >= RSITrendSensitivity1) score += RSITrendScore / 2;
     else if (rsiDelta <= RSITrendSensitivity2) score -= RSITrendScore;
     else if (rsiDelta <= RSITrendSensitivity1) score -= RSITrendScore / 2;
    }

pairNames is a list of pairs:
EURUSD, GBPUSD, AUDUSD, NZDUSD, USDCAD, USDCHF, USDJPY...
By "list of pairs", I'm guessing you mean that "pairNames" is a string array of pair names. If that is the case, then you may want to look at your usage of "pairNames" (missing index).
  • #3
  • Oct 11, 2011 8:03am Oct 11, 2011 8:03am
Quoting zznbrm
By "list of pairs", I'm guessing you mean that "pairNames" is a string array of pair names. If that is the case, then you may want to look at your usage of "pairNames" (missing index).
Initially it is string, but in init() I split it, using ',' as a separator, into table of strings. Debug prints me pair names one by one, like USDCAD, EURUSD, etc. so they split correctly. Plus the first pair is always counting correctly. Only second, third and so on gives me zeros. I can paste the whole EA code in a few hours. I will post it later on FF anyway.

Thanks for your reply zznbrm
“I made most of my money sitting on my hands.”
  • #4
  • Oct 11, 2011 8:46am Oct 11, 2011 8:46am
Actually I might have an idea where is the problem, now when I think about. Hours spent at night in front of computer can really damage your brain pairNames looks like this EURUSD, GBPUSD, AUDUSD, NZDUSD, USDCAD, USDCHF, USDJPY. When splitting it on ',' it leaves space in front of each pair but first. That would explain why only the first pair got good data. I will try this when I get home.

If that is the case, this thread is trash When you code at night, at least drink a lot of coffee
“I made most of my money sitting on my hands.”
  • #5
  • Oct 11, 2011 12:16pm Oct 11, 2011 12:16pm
Think that zznbrm gave you a good clue.
How are you arriving at pairName ??
Is it a string array ??
Are using an index of that array to get the pairName ??
If you think I'm mad, I must be mad
  • #6
  • Last Post: Oct 11, 2011 1:22pm Oct 11, 2011 1:22pm
Quoting futurespec
Think that zznbrm gave you a good clue.
How are you arriving at pairName ??
Is it a string array ??
Are using an index of that array to get the pairName ??
Yes zznbrm gave me some clue and I started thinking about those pair names. I fixed the problem about an hour ago. It was just as I suspected Those spaces were difficult to notice in the log. It was just that simple and I searched whole interweb about it..

Anyway thank you guys for the interest and for your help, I appreciate it.
“I made most of my money sitting on my hands.”
0 traders viewing now